Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-11-18 Thread Keith Packard
Emil Velikov writes: > On 18/11/13 01:08, Keith Packard wrote: >> libudev doesn't have a stable API/ABI, and if the application wants to use >> one >> version, we'd best not load another into libGL. >> >> Signed-off-by: Keith Packard >> --- >> > Hi Keith, > > Did you had the chance to look at

Re: [Mesa-dev] [PATCH 27/27] i965: Enable the AMD_performance_monitor extension on Gen5+.

2013-11-18 Thread Kenneth Graunke
On 11/18/2013 05:22 PM, Eric Anholt wrote: > Kenneth Graunke writes: > >> On 11/18/2013 10:33 AM, Eric Anholt wrote: >>> Kenneth Graunke writes: >>> XXX: Gen6+ needs to be predicated on register writes. our register write checking function doesn't work on Gen6. >>> >>> Even if you

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Michel Dänzer
On Mon, 2013-11-18 at 17:27 -0800, Eric Anholt wrote: > i965 passed piglit, but swrast and gallium both segfaulted without this. > i965 happened to work because it never ran _mesa_load_state_parameters() > on the new program before the test called glProgramLocalParameter(), which > was allocating a

Re: [Mesa-dev] sampler arrays indexed with non-constant expressions

2013-11-18 Thread Victor Luchitz
Hello Paul, thank you for the explanation. I thought that relaxing the spec conformance in this particular harmless case would be beneficial both to programmers and users. I understand and accept your reasoning even though deep in my heart I feel that by-the-book conformance is overly dogmatic. G

[Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Eric Anholt
i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter(), which was allocating a LocalParams array for the fallback path. Bugzilla: https://b

Re: [Mesa-dev] [PATCH 27/27] i965: Enable the AMD_performance_monitor extension on Gen5+.

2013-11-18 Thread Eric Anholt
Kenneth Graunke writes: > On 11/18/2013 10:33 AM, Eric Anholt wrote: >> Kenneth Graunke writes: >> >>> XXX: Gen6+ needs to be predicated on register writes. >>> >>> our register write checking function doesn't work on Gen6. >> >> Even if you can just enable it on gen7, this series is: >> >> R

Re: [Mesa-dev] [PATCH 1/2] i965: Link -ldl after libmesa.la

2013-11-18 Thread Eric Anholt
Matt Turner writes: > DLOPEN_LIBS is part of DRI_LIB_DEPS. > --- > src/mesa/drivers/dri/i965/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/Makefile.am > b/src/mesa/drivers/dri/i965/Makefile.am > index 8c0f9a3..3b46af8 100644 > ---

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Eric Anholt
Brian Paul writes: > On 11/18/2013 04:25 PM, Brian Paul wrote: >> On 11/18/2013 11:07 AM, Eric Anholt wrote: >>> i965 passed piglit, but swrast and gallium both segfaulted without this. >>> i965 happened to work because it never ran _mesa_load_state_parameters() >>> on the new program before the

Re: [Mesa-dev] [PATCH 27/27] i965: Enable the AMD_performance_monitor extension on Gen5+.

2013-11-18 Thread Kenneth Graunke
On 11/18/2013 10:33 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> XXX: Gen6+ needs to be predicated on register writes. >> >> our register write checking function doesn't work on Gen6. > > Even if you can just enable it on gen7, this series is: > > Reviewed-by: Eric Anholt Now I'm con

Re: [Mesa-dev] [PATCH 09/15] i965: Add a new representation for Broadwell shader instructions.

2013-11-18 Thread Kenneth Graunke
On 11/18/2013 03:22 PM, Kenneth Graunke wrote: > On 11/18/2013 12:27 PM, Eric Anholt wrote: >> Kenneth Graunke writes: >> >>> Broadwell significantly changes the EU instruction encoding. Many of >>> the fields got moved to different bit positions; some even got split >>> in two. >>> >>> With so m

Re: [Mesa-dev] [PATCH 09/15] i965: Add a new representation for Broadwell shader instructions.

2013-11-18 Thread Kenneth Graunke
On 11/18/2013 03:22 PM, Kenneth Graunke wrote: > On 11/18/2013 12:27 PM, Eric Anholt wrote: [snip] >> I think the old structs worked OK, and there are >> some minor downsides to access-everything-through-methods, like being >> unable to just print the instruction in gdb and see fields all at once,

[Mesa-dev] [PATCH] glxinfo: handle no fbconfigs case better

2013-11-18 Thread Dave Airlie
From: Dave Airlie If we get a server that has only GLX1.2 and no SGIX_fbconfig, we can print stuff we shouldn't. If we have no fbconfigs then we don't have core profile, so don't bother trying visual path when doing core profile. Signed-off-by: Dave Airlie --- src/xdemos/glxinfo.c | 7 ---

[Mesa-dev] [PATCH] glx: don't fail out when no configs if we have visuals

2013-11-18 Thread Dave Airlie
From: Dave Airlie GLX 1.2 servers with no SGIX_fbconfigs exist (some citrix thing), and we fail glxinfo completely in those cases. Signed-off-by: Dave Airlie --- src/glx/glxcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 3b

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Brian Paul
On 11/18/2013 04:25 PM, Brian Paul wrote: On 11/18/2013 11:07 AM, Eric Anholt wrote: i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter

Re: [Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Brian Paul
On 11/18/2013 11:07 AM, Eric Anholt wrote: i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter(), which was allocating a LocalParams arra

[Mesa-dev] [PATCH 2/2] i965/test: Use unreachable() to silence warning.

2013-11-18 Thread Matt Turner
--- src/mesa/drivers/dri/i965/test_vec4_register_coalesce.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/test_vec4_register_coalesce.cpp b/src/mesa/drivers/dri/i965/test_vec4_register_coalesce.cpp index c5a3cfc..83d931c 100644 --- a/src/mesa/drivers/dri/i965/tes

Re: [Mesa-dev] [PATCH 09/15] i965: Add a new representation for Broadwell shader instructions.

2013-11-18 Thread Kenneth Graunke
On 11/18/2013 12:27 PM, Eric Anholt wrote: > Kenneth Graunke writes: > >> Broadwell significantly changes the EU instruction encoding. Many of >> the fields got moved to different bit positions; some even got split >> in two. >> >> With so many changes, it was infeasible to continue using struct

[Mesa-dev] [PATCH 1/2] i965: Link -ldl after libmesa.la

2013-11-18 Thread Matt Turner
DLOPEN_LIBS is part of DRI_LIB_DEPS. --- src/mesa/drivers/dri/i965/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index 8c0f9a3..3b46af8 100644 --- a/src/mesa/drivers/dri/i965/Makefile.a

Re: [Mesa-dev] [PATCH 1/2] st/mesa: pass correct pipe_texture_target to st_choose_format()

2013-11-18 Thread Jakob Bornecrantz
Good catch, both patches in the series are Reviewed-by: Jakob Bornecrantz Cheers, Jakob. On Mon, Nov 18, 2013 at 11:55 PM, Brian Paul wrote: > We were always passing PIPE_TEXTURE_2D, but not all formats are > supported for all types of textures. In particular, the driver may > not supported te

[Mesa-dev] [PATCH 2/2] svga: we don't supported 3D compressed textures

2013-11-18 Thread Brian Paul
--- src/gallium/drivers/svga/svga_screen.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 3c013ea..ebcad2c 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/drivers/svga/svga_sc

[Mesa-dev] [PATCH 1/2] st/mesa: pass correct pipe_texture_target to st_choose_format()

2013-11-18 Thread Brian Paul
We were always passing PIPE_TEXTURE_2D, but not all formats are supported for all types of textures. In particular, the driver may not supported texture compression for all types of textures. --- src/mesa/state_tracker/st_format.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) di

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-11-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/17/2013 06:43 PM, Keith Packard wrote: > Emil Velikov writes: > >> On 18/11/13 01:08, Keith Packard wrote: >>> libudev doesn't have a stable API/ABI, and if the application >>> wants to use one version, we'd best not load another into >>> libGL

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-11-18 Thread Emil Velikov
On 18/11/13 01:08, Keith Packard wrote: > libudev doesn't have a stable API/ABI, and if the application wants to use one > version, we'd best not load another into libGL. > > Signed-off-by: Keith Packard > --- > Hi Keith, Did you had the chance to look at src/gallium/targets/egl-static/egl.c? I

[Mesa-dev] Mesa 10.0 release candidate 1

2013-11-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mesa 10.0 release candidate 1 is now available for testing. The current plan of record is to have release candidate 2 on Friday, November 22nd, and the 10.0 release on Wedensday, November 27th. The tag in the GIT repository for Mesa 10.0-rc1 is 'mesa

Re: [Mesa-dev] [PATCH 09/15] i965: Add a new representation for Broadwell shader instructions.

2013-11-18 Thread Eric Anholt
Kenneth Graunke writes: > Broadwell significantly changes the EU instruction encoding. Many of > the fields got moved to different bit positions; some even got split > in two. > > With so many changes, it was infeasible to continue using struct > brw_instruction. We needed a new representation.

Re: [Mesa-dev] sampler arrays indexed with non-constant expressions

2013-11-18 Thread Paul Berry
On 17 November 2013 00:24, Victor Luchitz wrote: > Hello, > > in my opinion GLSL compiler in mesa is too restrictive when it comes to > sampler arrays. The following code can not be compiled due to the "sampler > arrays indexed with non-constant expressions is forbidden in GLSL 1.30 and > later":

Re: [Mesa-dev] glext.h and glcorearb.h?

2013-11-18 Thread Fredrik Höglund
On Monday 18 November 2013, Dave Airlie wrote: > On Mon, Nov 18, 2013 at 7:58 PM, Dave Airlie wrote: > > Hey, > > > > so I'm not really uptodate on latest Khronos stuff, but the glext.h > > from the webpage is out of date and I can't seem to svn checkout the > > xml files as i'm not a member. > >

[Mesa-dev] i965 uniform upload question

2013-11-18 Thread Rogovin, Kevin
Hello all, Yet another questions related to i965. I was taking a gander through the code base hunting down where and how uniforms are uploaded to the GPU; what I do see is that pointers are set directly to the a backing store that holds the uniform values: brw_vec4_prog_data::param array of

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Jerome Glisse
On Mon, Nov 18, 2013 at 05:41:50PM +0100, Thierry Reding wrote: > On Mon, Nov 18, 2013 at 11:21:36AM -0500, Rob Clark wrote: > > On Mon, Nov 18, 2013 at 10:23 AM, Thierry Reding > > wrote: > > > On Mon, Nov 18, 2013 at 10:17:47AM -0500, Rob Clark wrote: > > >> On Mon, Nov 18, 2013 at 8:29 AM, Thie

Re: [Mesa-dev] [PATCH 27/27] i965: Enable the AMD_performance_monitor extension on Gen5+.

2013-11-18 Thread Eric Anholt
Kenneth Graunke writes: > XXX: Gen6+ needs to be predicated on register writes. > > our register write checking function doesn't work on Gen6. Even if you can just enable it on gen7, this series is: Reviewed-by: Eric Anholt pgpu618mL0Xbn.pgp Description: PGP signature __

[Mesa-dev] [Bug 71734] Commit to "Dynamically allocate the storage for program local parameters." causes KSP to abort on start up.

2013-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71734 Eric Anholt changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@lists

[Mesa-dev] [PATCH] mesa: Fix setup of LocalParams array.

2013-11-18 Thread Eric Anholt
i965 passed piglit, but swrast and gallium both segfaulted without this. i965 happened to work because it never ran _mesa_load_state_parameters() on the new program before the test called glProgramLocalParameter(), which was allocating a LocalParams array for the fallback path. Bugzilla: https://b

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Thierry Reding
On Mon, Nov 18, 2013 at 11:21:36AM -0500, Rob Clark wrote: > On Mon, Nov 18, 2013 at 10:23 AM, Thierry Reding > wrote: > > On Mon, Nov 18, 2013 at 10:17:47AM -0500, Rob Clark wrote: > >> On Mon, Nov 18, 2013 at 8:29 AM, Thierry Reding > >> wrote: > >> > On Sat, Nov 09, 2013 at 01:26:24PM -0800, I

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Thierry Reding
On Mon, Nov 18, 2013 at 05:30:34PM +0100, Maarten Lankhorst wrote: > op 09-11-13 22:26, Ian Romanick schreef: > > On 11/09/2013 12:11 AM, Dave Airlie wrote: > How does this interact with the rule that kernel interfaces require an > open source userspace? Is "here are the mesa/libdrm patch

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Maarten Lankhorst
op 09-11-13 22:26, Ian Romanick schreef: > On 11/09/2013 12:11 AM, Dave Airlie wrote: How does this interact with the rule that kernel interfaces require an open source userspace? Is "here are the mesa/libdrm patches that use it" sufficient to get the kernel interface merged? >>> Tha

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Rob Clark
On Mon, Nov 18, 2013 at 10:23 AM, Thierry Reding wrote: > On Mon, Nov 18, 2013 at 10:17:47AM -0500, Rob Clark wrote: >> On Mon, Nov 18, 2013 at 8:29 AM, Thierry Reding >> wrote: >> > On Sat, Nov 09, 2013 at 01:26:24PM -0800, Ian Romanick wrote: >> >> On 11/09/2013 12:11 AM, Dave Airlie wrote: >>

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Thierry Reding
On Mon, Nov 18, 2013 at 10:17:47AM -0500, Rob Clark wrote: > On Mon, Nov 18, 2013 at 8:29 AM, Thierry Reding > wrote: > > On Sat, Nov 09, 2013 at 01:26:24PM -0800, Ian Romanick wrote: > >> On 11/09/2013 12:11 AM, Dave Airlie wrote: > >> >>> How does this interact with the rule that kernel interfac

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Rob Clark
On Mon, Nov 18, 2013 at 8:29 AM, Thierry Reding wrote: > On Sat, Nov 09, 2013 at 01:26:24PM -0800, Ian Romanick wrote: >> On 11/09/2013 12:11 AM, Dave Airlie wrote: >> >>> How does this interact with the rule that kernel interfaces require an >> >>> open source userspace? Is "here are the mesa/lib

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-18 Thread Thierry Reding
On Sat, Nov 09, 2013 at 01:26:24PM -0800, Ian Romanick wrote: > On 11/09/2013 12:11 AM, Dave Airlie wrote: > >>> How does this interact with the rule that kernel interfaces require an > >>> open source userspace? Is "here are the mesa/libdrm patches that use > >>> it" sufficient to get the kernel i

[Mesa-dev] [Bug 71734] Commit to "Dynamically allocate the storage for program local parameters." causes KSP to abort on start up.

2013-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71734 Alex Deucher changed: What|Removed |Added CC||e...@anholt.net -- You are receiving thi

[Mesa-dev] [Bug 71734] New: Commit to "Dynamically allocate the storage for program local parameters." causes KSP to abort on start up.

2013-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71734 Priority: medium Bug ID: 71734 Assignee: mesa-dev@lists.freedesktop.org Summary: Commit to "Dynamically allocate the storage for program local parameters." causes KSP to abort on

[Mesa-dev] [Bug 71591] Second Life shaders fail to compile

2013-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71591 --- Comment #5 from MirceaKitsune --- Although I'm not a driver developer and have little technical expertise here, I've gotten a better understanding of the issue. I can see why Mesa deems such shaders as invalid, given the statement is not pla

Re: [Mesa-dev] glext.h and glcorearb.h?

2013-11-18 Thread Dave Airlie
On Mon, Nov 18, 2013 at 7:58 PM, Dave Airlie wrote: > Hey, > > so I'm not really uptodate on latest Khronos stuff, but the glext.h > from the webpage is out of date and I can't seem to svn checkout the > xml files as i'm not a member. > > So does glext.h contain the 4.4 ARB extensions like ARB_mul

[Mesa-dev] glext.h and glcorearb.h?

2013-11-18 Thread Dave Airlie
Hey, so I'm not really uptodate on latest Khronos stuff, but the glext.h from the webpage is out of date and I can't seem to svn checkout the xml files as i'm not a member. So does glext.h contain the 4.4 ARB extensions like ARB_multi_bind or do we need to start distributing glcorearb.h? Dave. _

[Mesa-dev] [Bug 71591] Second Life shaders fail to compile

2013-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71591 Eero Tamminen changed: What|Removed |Added CC||eero.t.tammi...@intel.com --- Comment #4

[Mesa-dev] [Bug 71591] Second Life shaders fail to compile

2013-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71591 Petri Latvala changed: What|Removed |Added CC||petri.latv...@intel.com -- You are rece