Re: [Mesa-dev] [PATCH] i965: convert brw_lower_offset_array_visitor to ir_rvalue_visitor

2013-11-09 Thread Kenneth Graunke
On 11/09/2013 01:06 PM, Chris Forbes wrote: > Previously, we would bogusly replace the entire statement containing the > ir_texture node with an ir_dereference_variable. > > Correct this to just replace the ir_texture node itself as intended. > > Signed-off-by: Chris Forbes > --- > src/mesa/dri

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-09 Thread Ian Romanick
On 11/09/2013 12:11 AM, Dave Airlie wrote: >>> How does this interact with the rule that kernel interfaces require an >>> open source userspace? Is "here are the mesa/libdrm patches that use >>> it" sufficient to get the kernel interface merged? >> >> That's my understanding: open source userspace

Re: [Mesa-dev] [PATCH] i965: Make the driver compile until a proper libdrm can be released.

2013-11-09 Thread Kristian Høgsberg
On Fri, Nov 8, 2013 at 2:25 PM, Ian Romanick wrote: > > On 11/08/2013 10:49 AM, Eric Anholt wrote: >> No depending on unreleased code. >> --- >> src/mesa/drivers/dri/i965/brw_context.c | 8 +++- >> src/mesa/drivers/dri/i965/brw_reset.c | 7 +++ >> 2 files changed, 10 insertions(+), 5 de

[Mesa-dev] [PATCH] i965: convert brw_lower_offset_array_visitor to ir_rvalue_visitor

2013-11-09 Thread Chris Forbes
Previously, we would bogusly replace the entire statement containing the ir_texture node with an ir_dereference_variable. Correct this to just replace the ir_texture node itself as intended. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_lower_offset_array.cpp | 18 +++---

Re: [Mesa-dev] [PATCH] glsl/opt_algebraic: recognize lrp pattern

2013-11-09 Thread Matt Turner
On Sat, Nov 9, 2013 at 11:39 AM, Jordan Justen wrote: > This algebraic optimization recognizes an series of adds and > multiplies with a particular pattern within the ir which is > equivalent to a lrp. > > shader-db results: > total instructions in shared programs: 1729161 -> 1718321 (-0.63%) > in

[Mesa-dev] [PATCH] glsl/opt_algebraic: recognize lrp pattern

2013-11-09 Thread Jordan Justen
This algebraic optimization recognizes an series of adds and multiplies with a particular pattern within the ir which is equivalent to a lrp. shader-db results: total instructions in shared programs: 1729161 -> 1718321 (-0.63%) instructions in affected programs: 743700 -> 732860 (-1.46%) GAINE

[Mesa-dev] [PATCH 1/2] nouveau/video: don't try on nv3x

2013-11-09 Thread Ilia Mirkin
It doesn't work, I don't know why, but no point in hanging people's displays until it gets figured out. Signed-off-by: Ilia Mirkin Cc: "10.0" --- I tried a bunch of stuff, but in the end, I was unsuccessful. On the bright side, nv3x cards have a hw overlay, which can be combined with the mpeg d

[Mesa-dev] [PATCH 2/2] nouveau/video: mark bitstream-level acceleration as unsupported

2013-11-09 Thread Ilia Mirkin
Adding a vl_mpeg-based helper didn't seem to work, as it produced data that the card couldn't handle. (And I didn't investigate further.) This makes the decoding functionality only accessible via XvMC and avoids crashes when attempting to use VDPAU. Signed-off-by: Ilia Mirkin Cc: "10.0" --- The

[Mesa-dev] [Bug 71397] [llvmpipe] configure: error: Package requirements (dri3proto >= 1.0) were not met

2013-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71397 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 71397] [llvmpipe] configure: error: Package requirements (dri3proto >= 1.0) were not met

2013-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71397 --- Comment #3 from Chris Rankin --- I've just tested this with the following command line: $ autogen.sh --prefix=/usr/local --libdir=/usr/local/lib64 --with-gallium-drivers=r600 --with-llvm-shared-libs --with-dri-drivers= --enable-texture-float

Re: [Mesa-dev] [PATCH] i965/fs: New peephole optimization to flatten IF/BREAK/ENDIF.

2013-11-09 Thread Kenneth Graunke
On 11/05/2013 02:58 PM, Paul Berry wrote: [snip] > Instead of this special-purpose peephole optimization, I'm wondering if > it would be more useful to create a more general optimization pass that > just converts the entire IF block to predicated instructions, assuming > certain conditions hold. T

Re: [Mesa-dev] CACHED_BATCH questions

2013-11-09 Thread Kenneth Graunke
On 11/08/2013 12:45 AM, Rogovin, Kevin wrote: > Hi all, > > I am trying to get my head around CACHED_BATCH() which is just a > macro for intel_batchbuffer_cached_advance(), and when I dig into > that code it leaves me some head scratching. I am guessing it checks > if the current contents of the

Re: [Mesa-dev] [PATCH] glsl: fix missing breaks in equals(ir_texture, ..)

2013-11-09 Thread Kenneth Graunke
On 11/09/2013 01:29 AM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > Cc: "10.0" > --- > src/glsl/opt_cse.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/opt_cse.cpp b/src/glsl/opt_cse.cpp > index c0fdb23..c53b4c6 100644 > --- a/src/glsl/opt_cse.cpp > +++ b/src/gls

Re: [Mesa-dev] [PATCH 1/2] mesa: Add a streaming load memcpy implementation.

2013-11-09 Thread Matt Turner
On Sat, Nov 9, 2013 at 3:54 AM, Steven Newbury wrote: > On Wed, 2013-11-06 at 17:06 -0800, Chad Versace wrote: >> On 11/06/2013 02:44 PM, Eric Anholt wrote: >> > Matt Turner writes: >> > >> >> Uses SSE 4.1's MOVNTDQA instruction (streaming load) to read from >> >> uncached memory without pollutin

Re: [Mesa-dev] [PATCH 1/2] mesa: Add a streaming load memcpy implementation.

2013-11-09 Thread Steven Newbury
On Wed, 2013-11-06 at 17:06 -0800, Chad Versace wrote: > On 11/06/2013 02:44 PM, Eric Anholt wrote: > > Matt Turner writes: > > > >> Uses SSE 4.1's MOVNTDQA instruction (streaming load) to read from > >> uncached memory without polluting the cache. > >> --- > >> We should add runtime detection sup

Re: [Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader (v3)

2013-11-09 Thread Armin K.
On 11/09/2013 01:00 AM, Matt Turner wrote: > On Fri, Nov 8, 2013 at 3:06 PM, Armin K wrote: >> This patch makes it possible to disable DRI3 if desired. > > Reviewed-by: Matt Turner > > Unless non-Linux users still need to be able to disable DRI3, by the > time Mesa 10.0 is released I think we w

Re: [Mesa-dev] [PATCH 07/18] i915: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-09 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 03:10:14PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i915/intel_screen.c | 79 > > 1 file changed, 79 insertions(+) > > diff --git a/src/mesa/drivers/dri/i915/intel_scre

[Mesa-dev] [PATCH] glsl: fix missing breaks in equals(ir_texture, ..)

2013-11-09 Thread Chris Forbes
Signed-off-by: Chris Forbes Cc: "10.0" --- src/glsl/opt_cse.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/opt_cse.cpp b/src/glsl/opt_cse.cpp index c0fdb23..c53b4c6 100644 --- a/src/glsl/opt_cse.cpp +++ b/src/glsl/opt_cse.cpp @@ -352,6 +352,7 @@ equals(ir_texture *a, ir_textu

[Mesa-dev] [PATCH V3 07/13] mesa: add is_indirect to _mesa_prim

2013-11-09 Thread Chris Forbes
V3: Add missing cases Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_api.c | 1 + src/mesa/vbo/vbo_exec_array.c | 9 + src/mesa/vbo/vbo_save_api.c | 2 ++ 4 files changed, 14 insertions(+), 1 deletion(-) diff --g

[Mesa-dev] [PATCH V3 10/13] i965: pass indirect buffer to primitive restart check

2013-11-09 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_draw.c | 7 --- src/mesa/drivers/dri/i965/brw_draw.h | 3 ++- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH V3 09/13] i965: implement indirect drawing for Gen7

2013-11-09 Thread Chris Forbes
Just prior to emitting the 3DPRIMITIVE command, we load each of the indirect registers. The values loaded are either from offsets into the current indirect BO, or constant zero if the parameter is not used for this draw. Enabling use of the indirect registers is done by turning on a bit in the fir

[Mesa-dev] [PATCH V3 00/13] ARB_draw_indirect for i965

2013-11-09 Thread Chris Forbes
This series adds support for ARB_draw_indirect and ARB_multi_draw_indirect on Gen7+. Big changes: - Get rid of overcomplicated state tracking for the indirect bo in i965. - Make primcount==0 produce GL_INVALID_VALUE in MultiDraw*Indirect - Small tidyups for clarity __

[Mesa-dev] [PATCH V3 02/13] glapi: add plumbing for GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-11-09 Thread Chris Forbes
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mapi/glapi/gen/ARB_draw_indirect.xml | 45 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml| 4 ++- src/mesa/

[Mesa-dev] [PATCH V3 04/13] mesa: Add binding point for indirect buffer

2013-11-09 Thread Chris Forbes
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/main/bufferobj.c| 14 ++ src/mesa/main/get.c | 4 src/mesa/main/get_hash_params.py | 2 ++ src/mesa/main/mtypes.h | 2 ++ 4 files

[Mesa-dev] [PATCH V3 11/13] mesa: pass indirect buffer to sw primitive restart

2013-11-09 Thread Chris Forbes
--- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 2 +- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c | 2 +- src/mesa/vbo/vbo_primitive_restart.c | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH V3 12/13] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-09 Thread Chris Forbes
V2: Check for mapping failure (thanks Brian) V3: - Change error on mapping failure to OUT_OF_MEMORY (Brian) - Unconst; remove casting away of const. Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_primitive_restart.c | 33 + 1 file changed, 33 insertions(+)

[Mesa-dev] [PATCH V3 13/13] i965: Enable ARB_draw_indirect (and ARB_multi_draw_indirect) on Gen7+

2013-11-09 Thread Chris Forbes
.. and mark them off on the extensions list as done. V2: Enable only if pipelined register writes work. V3: Also update relnotes Signed-off-by: Chris Forbes Reviewed-by: Ian Romanick --- docs/GL3.txt | 4 ++-- docs/relnotes/10.0.html | 1 +

[Mesa-dev] [PATCH V3 07/13] mesa: add is_indirect to _mesa_prim

2013-11-09 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index e1914c8..f58fa0b 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@

[Mesa-dev] [PATCH V3 01/13] mesa: add indirect drawing buffer parameter to draw functions

2013-11-09 Thread Chris Forbes
From: Christoph Bumiller Split from patch implementing ARB_draw_indirect. v2: Const-qualify the struct gl_buffer_object *indirect argument. v3: Fix up some more draw calls for new argument. v4: Fix up rebase conflicts in i965. v5: Undo const-qualification --- src/mesa/drivers/dri/i965/brw_draw.

[Mesa-dev] [PATCH V3 03/13] mesa: Add extension scaffolding for ARB_draw_indirect

2013-11-09 Thread Chris Forbes
We will reuse the same extension flag for ARB_multi_draw_indirect since it can always be supported by looping. Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/main/extensions.c | 2 ++ src/mesa/main/get.c| 1 + src/mesa

[Mesa-dev] [PATCH V3 08/13] i965: Add new defines for indirect draws

2013-11-09 Thread Chris Forbes
- MMIO registers for draw parameters - New bit in 3DPRIMITIVE command to enable indirection Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/intel_reg.h | 8 2 files changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH V3 06/13] vbo: Flesh out implementation of indirect draws

2013-11-09 Thread Chris Forbes
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_exec_array.c | 216 ++ 1 file changed, 216 insertions(+) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c

[Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-09 Thread Chris Forbes
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec contradicts itself on this, but the GL4.3 spec disallows it. - Make it clear that the caller has dealt with stride==0 Signed-off-by: Chris F

Re: [Mesa-dev] [PATCH V2 05/15] mesa: Add validation helpers for new indirect draws

2013-11-09 Thread Chris Forbes
>Other BO usage in the draw path doesn't check that buffers aren't >mapped. What makes this path special? Apparently nothing -- this is weirdness inherited from the original patches. I'll drop it. -- Chris ___ mesa-dev mailing list mesa-dev@lists.freed

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-09 Thread Dave Airlie
>> How does this interact with the rule that kernel interfaces require an >> open source userspace? Is "here are the mesa/libdrm patches that use >> it" sufficient to get the kernel interface merged? > > That's my understanding: open source userspace needs to exist, but it > doesn't need to be merg