Re: [Mesa-dev] [PATCH 3/7] i965/fs: Add is_null() method to fs_reg.

2013-10-22 Thread Matt Turner
On Tue, Oct 22, 2013 at 4:30 PM, Matt Turner wrote: > With 6/7 dead, this patch has no users, so drop it for now. I'm now using is_null() is the new "[PATCH 5/7] i965/fs: Don't emit null MOVs in CSE." so this patch is back on. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 7/7] i965/fs: Perform CSE on CMP(N) instructions.

2013-10-22 Thread Matt Turner
Optimizes cmp.ge.f0(8) null g45<8,8,1>F 0F (+f0) sel(8)g50<1>F g40<8,8,1>F g10<8,8,1>F cmp.ge.f0(8) null g45<8,8,1>F 0F (+f0) sel(8)g51<1>F g41<8,8,1>F g11<8,8,1>F cmp.ge.f0(8) null g45<8,8,1>F 0F (+f0) sel(8)g52<1>F g42<8,8,1>F g12

[Mesa-dev] [PATCH 6/7] i965/fs: Don't dead code eliminate CMP(N).

2013-10-22 Thread Matt Turner
Since compare instructions write the flag register, they should not be considered dead even if their destination is never read. Instead of removing them if found to be dead, set their destination to null to free a register. --- v2: New commit message. This is now patch 6/7. src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 5/7] i965/fs: Don't emit null MOVs in CSE.

2013-10-22 Thread Matt Turner
We'd like to CSE some instructions, like CMP, that often have null destinations. Instead of replacing them with MOVs to null, just don't emit the MOV. --- This patch replaces "[PATCH 6/7] i965/fs: Dead code eliminate MOV null." but is now number 5/7 in the series. src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH 4.5/7] i965/fs: Use reads_flag and writes_flag methods in the scheduler.

2013-10-22 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp index 84b74ff..9cc752e 100644 --- a/s

[Mesa-dev] [PATCH 4/7] i965/fs: Add reads_flag() and writes_flag() to fs_inst.

2013-10-22 Thread Matt Turner
--- v2: Clean up style (Ian) and check for FS_OPCODE_MOV_DISPATCH_TO_FLAGS (Eric). src/mesa/drivers/dri/i965/brw_fs.cpp | 12 src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ 2 files changed, 15 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH] i965: Make fs gl_PrimitiveID input work even when there's no gs.

2013-10-22 Thread Paul Berry
When a geometry shader is present, the fragment shader gl_PrimitiveID input acts like an ordinary varying, receiving data from the gs gl_PrimitiveID output. When there's no geometry shader, we have to ask the fixed function SF hardware to provide the primitive ID to the fragment shader instead. P

Re: [Mesa-dev] [PATCH] i965/gs: Set force_writemask_all when setting up g0.

2013-10-22 Thread Kenneth Graunke
On 10/22/2013 07:32 PM, Paul Berry wrote: > All geometry shaders begin this instruction: > > mov(1) g0.2<1>:ud 0x0:ud { align1 } > > which sets up GRF0 properly for scratch reads and writes. Since this > instruction has a SIMD size of 1, it will only have an effect if the > first channel is

Re: [Mesa-dev] [PATCH] R600/SI: fix MIMG writemask adjustement

2013-10-22 Thread Tom Stellard
Pushed, thanks. -Tom On Tue, Oct 22, 2013 at 02:15:01AM +0200, Marek Olk wrote: > From: Marek Olk > > This fixes piglit: > - shaders/glsl-fs-texture2d-masked > - shaders/glsl-fs-texture2d-masked-4 > > Signed-off-by: Marek Olk > Reviewed-by: Tom Stellard > --- > lib/Target/R600/S

[Mesa-dev] [PATCH] i965/gs: Set force_writemask_all when setting up g0.

2013-10-22 Thread Paul Berry
All geometry shaders begin this instruction: mov(1) g0.2<1>:ud 0x0:ud { align1 } which sets up GRF0 properly for scratch reads and writes. Since this instruction has a SIMD size of 1, it will only have an effect if the first channel is enabled. In practice, the hardware seems to always disp

[Mesa-dev] [PATCH] R600/SI: Add compute support for CI

2013-10-22 Thread Tom Stellard
From: Tom Stellard --- lib/Target/R600/AMDGPU.td| 2 ++ lib/Target/R600/AMDGPUAsmPrinter.cpp | 16 ++-- lib/Target/R600/AMDGPUCallingConv.td | 4 ++-- lib/Target/R600/AMDGPUSubtarget.h| 3 ++- lib/Target/R600/Processors.td| 6 +++--- lib/Target/R600/SIInst

[Mesa-dev] [PATCH] radeonsi/compute: Add Sea Islands support

2013-10-22 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index d3f5a23..f047d5d 100644 --- a/src/g

Re: [Mesa-dev] [PATCH 3/7] i965/fs: Add is_null() method to fs_reg.

2013-10-22 Thread Matt Turner
With 6/7 dead, this patch has no users, so drop it for now. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: silence unused 'var' variable warning

2013-10-22 Thread Brian Paul
--- src/glsl/builtin_variables.cpp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index fc1115b..1f62fcf 100644 --- a/src/glsl/builtin_variables.cpp +++ b/src/glsl/builtin_variables.cpp @@ -888,8 +888,8 @@

[Mesa-dev] [PATCH] svga: remove user-space vertex/index buffer code

2013-10-22 Thread Brian Paul
The gallium vbuf module, which we've been using for some time now, takes care of uploading user-space vertex/index data into real buffers. The upload code in the svga driver was unused. --- src/gallium/drivers/svga/svga_context.c | 34 + src/gallium/drivers/svga/svga_context.h |

[Mesa-dev] [PATCH 4/4] glsl: Keep track of centroid/interpolation mode for interface block members.

2013-10-22 Thread Paul Berry
Fixes piglit tests: - interface-block-interpolation-{array,named,unnamed} - glsl-1.50-interface-block-centroid {array,named,unnamed} --- src/glsl/ast_to_hir.cpp | 9 + src/glsl/builtin_variables.cpp| 4 src/glsl/glsl_types.cpp | 10 +++

[Mesa-dev] [PATCH 3/4] glsl: Pass variable mode into ast_process_structure_or_interface_block().

2013-10-22 Thread Paul Berry
Later patches will use this information to do proper error checking of interpolation qualifiers that appear inside of interface blocks. --- src/glsl/ast_to_hir.cpp | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 2/4] glsl: Extract interpretation of interpolation to its own function.

2013-10-22 Thread Paul Berry
In future patches, we will need this in order to interpret interpolation qualifiers that appear inside interface blocks. --- src/glsl/ast_to_hir.cpp | 70 + 1 file changed, 42 insertions(+), 28 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src

[Mesa-dev] [PATCH 1/4] glsl: Pull interpolation_string() out of ir_variable.

2013-10-22 Thread Paul Berry
Future patches will need to call this function when there isn't an ir_varible present to refer to. --- src/glsl/ast_to_hir.cpp| 4 ++-- src/glsl/ir.cpp| 4 ++-- src/glsl/ir.h | 30 -- src/glsl/link_varyings.cpp | 4 ++-- 4 files changed,

Re: [Mesa-dev] [PATCH] egl: refcount wl_egl_window objects. fix memory corruption

2013-10-22 Thread Kristian Høgsberg
On Mon, Oct 07, 2013 at 10:09:17PM +0200, Giulio Camuffo wrote: > Suppose we create a wl_egl_window and an EGLSurface. Then we call > eglMakeCurrent(dpy,surf,surf,ctx) with that surface, render and swap. > Later we destroy the surface and the window, and we make current > another surface. That resu

Re: [Mesa-dev] [PATCH] wayland: Don't leak wl_drm global when unbinding display

2013-10-22 Thread Kristian Høgsberg
On Wed, Oct 16, 2013 at 03:04:03PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > --- > src/egl/wayland/wayland-drm/wayland-drm.c |7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Thanks, applied. Kristian > diff --git a/src/egl/wayland/wayla

Re: [Mesa-dev] [PATCH 5/6] glsl/tests: Unit test vertex shader in / out with link_invalidate_variable_locations

2013-10-22 Thread Paul Berry
On 22 October 2013 13:22, Ian Romanick wrote: > On 10/18/2013 01:31 PM, Paul Berry wrote: > > On 11 October 2013 11:18, Ian Romanick > > wrote: > > > > From: Ian Romanick > > > > > > This required fixing the out-of-date p

Re: [Mesa-dev] [PATCH 07/14] glsl: Fix the function inlining pass to deal with general opaque arguments.

2013-10-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 10/01/2013 07:15 PM, Francisco Jerez wrote: > Almost a trivial change, it boils down to renaming a few identifiers > so their names still make sense for opaque types other than sampler. > --- > src/glsl/opt_function_inlining.cpp | 66 > +++---

Re: [Mesa-dev] [PATCH 05/14] glsl: Add IR builder support for function calls.

2013-10-22 Thread Ian Romanick
On 10/01/2013 07:15 PM, Francisco Jerez wrote: > --- > src/glsl/ir_builder.cpp | 25 + > src/glsl/ir_builder.h | 8 > 2 files changed, 33 insertions(+) > > diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp > index 98b4322..1913c72 100644 > --- a/sr

Re: [Mesa-dev] [PATCH 04/14] glsl: Basic support for built-in intrinsics.

2013-10-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 10/01/2013 07:15 PM, Francisco Jerez wrote: > Fix the linker to deal with intrinsic functions which are undefined > all the way down to the driver back-end, and introduce intrinsic > definition helpers in the built-in generator. > > We still need to figure out what k

Re: [Mesa-dev] [PATCH v2 03/14] glsl: Implement parser support for atomic counters.

2013-10-22 Thread Ian Romanick
On 10/01/2013 07:15 PM, Francisco Jerez wrote: > v2: Mark atomic counters as read-only variables. Move offset overlap > code to the linker. Use the contains_atomic() convenience method. > --- > src/glsl/ast.h| 15 > src/glsl/ast_to_hir.cpp | 57 > +

Re: [Mesa-dev] [PATCH v2 01/14] glsl: Add new atomic_uint built-in GLSL type.

2013-10-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 10/01/2013 07:15 PM, Francisco Jerez wrote: > v2: Fix GLSL version in which the type became available. Add > contains_atomic() convenience method. Split off atomic counter > comparison error checking to a separate patch that will handle all > opaque type

Re: [Mesa-dev] [PATCH] R600: Make sure OQAP defs and uses happen in the same clause

2013-10-22 Thread Tom Stellard
Hi Vincent, Here is an updated patch. I wasn't sure where to put the assertion to check that UnscheduledNoLiveOut{Defs,Uses} is empty when switching to a new clause. I tried adding it to R600SchedStartegy::schedNode() behind the if (NextInstKind != CurInstKind) condition, but it always failed. A

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Match commutative expressions with reversed arguments.

2013-10-22 Thread Eric Anholt
Matt Turner writes: > total instructions in shared programs: 1645011 -> 1644938 (-0.00%) > instructions in affected programs: 17543 -> 17470 (-0.42%) > --- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Add reads_reg() and writes_flag() to fs_inst.

2013-10-22 Thread Eric Anholt
Matt Turner writes: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 16 > src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ > 2 files changed, 19 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index 77b898b..9b56764 10

Re: [Mesa-dev] [PATCH 5/7] i965/fs: Don't dead code eliminate CMP(N).

2013-10-22 Thread Matt Turner
On Tue, Oct 22, 2013 at 1:56 PM, Eric Anholt wrote: > Matt Turner writes: > >> An future commit will enable CSE for CMP instructions. It operates on >> the following code >> >> cmp.ge.f0(8) null g45<8,8,1>F 0F >> (+f0) sel(8)g50<1>F g40<8,8,1>F g10<8,8,1>F >> cmp.ge.f0

Re: [Mesa-dev] [PATCH 5/7] i965/fs: Don't dead code eliminate CMP(N).

2013-10-22 Thread Eric Anholt
Matt Turner writes: > An future commit will enable CSE for CMP instructions. It operates on > the following code > > cmp.ge.f0(8) null g45<8,8,1>F 0F > (+f0) sel(8)g50<1>F g40<8,8,1>F g10<8,8,1>F > cmp.ge.f0(8) null g45<8,8,1>F 0F > (+f0) sel(8)g51<1>F g

Re: [Mesa-dev] [PATCH 07/24] glsl: Add extension enables for ARB_shader_atomic_counters.

2013-10-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 09/15/2013 12:10 AM, Francisco Jerez wrote: > --- > src/glsl/glsl_parser_extras.cpp | 1 + > src/glsl/glsl_parser_extras.h | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp > index 772933f

Re: [Mesa-dev] [PATCH 06/24] mesa: Add support for ARB_shader_atomic_counters.

2013-10-22 Thread Ian Romanick
On 09/15/2013 12:10 AM, Francisco Jerez wrote: > This patch implements the common support code required for the > ARB_shader_atomic_counters extension. It defines the necessary data > structures for tracking atomic counter buffer objects (from now on > "ABOs") associated with some specific context

Re: [Mesa-dev] [PATCH 05/24] glapi: Add support for ARB_shader_atomic_counters.

2013-10-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 09/15/2013 12:10 AM, Francisco Jerez wrote: > Add XML file for the dispatch code generator, update the > dispatch_sanity test and add stub definition for the new entry point. > --- > src/mapi/glapi/gen/ARB_shader_atomic_counters.xml | 47 > +++ >

[Mesa-dev] [PATCH 1/2] i965: Try not to reverse-schedule things when doing LIFO scheduling.

2013-10-22 Thread Eric Anholt
The LIFO plan was simple: Take the most recently made available instructions, and pick those first. But because of the order we were pushing things onto our list of available-to-schedule instructions, it meant that when a set of instructions was made available at the same time (for example, everyt

[Mesa-dev] [PATCH 2/2] i965/fs: Stop trying to hack around weird MRF chains on gen7+ LIFO scheduling.

2013-10-22 Thread Eric Anholt
This was a hack to avoid choosing to schedule all texturing before consumption of any texture results due to the way dependency chains worked out in the presence of MRFs. On gen7, we don't have MRFs, so the problem doesn't apply, and this was just badly constraining our scheduling. total instruct

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Add reads_reg() and writes_flag() to fs_inst.

2013-10-22 Thread Matt Turner
On Tue, Oct 22, 2013 at 1:30 PM, Ian Romanick wrote: > On 10/22/2013 01:07 PM, Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 16 >> src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH] clover: Refuse to create context with invalid properties

2013-10-22 Thread Francisco Jerez
Jan Vesely writes: > On Mon, 2013-10-21 at 22:20 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > the specs say that clCreateContext reutrns error >> > "if platform value specified in properties is not a valid platform" >> > >> > The orignal approach fials if invalid valu other than

Re: [Mesa-dev] [PATCH] glsl/gs: Prevent illegal input/output primitive types.

2013-10-22 Thread Ian Romanick
On 10/22/2013 10:41 AM, Paul Berry wrote: > From the GLSL 1.50 spec, section 4.3.8.1 (Input Layout Qualifiers): > > The layout qualifier identifiers for geometry shader inputs are > > layout-qualifier-id > points > lines > lines_adjacency >

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Add reads_reg() and writes_flag() to fs_inst.

2013-10-22 Thread Ian Romanick
On 10/22/2013 01:07 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 16 > src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ > 2 files changed, 19 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > ind

Re: [Mesa-dev] [PATCH 5/6] glsl/tests: Unit test vertex shader in / out with link_invalidate_variable_locations

2013-10-22 Thread Ian Romanick
On 10/18/2013 01:31 PM, Paul Berry wrote: > On 11 October 2013 11:18, Ian Romanick > wrote: > > From: Ian Romanick > > > This required fixing the out-of-date prototype in linker.h. While > making that change, further

Re: [Mesa-dev] [PATCH] egl_dri2: Don't use gbm_dri_device when its not there

2013-10-22 Thread Chad Versace
I'm unsure if it makes sense to build EGL with Wayland support but without GBM support. That is, to configure Mesa with --with-egl-platforms=wayland # no drm Also, the patch is corrupt. `git am` is unable to apply it. Did you copy-paste the patch into your email client? Instead, use `git send

Re: [Mesa-dev] [PATCH 2/6] glsl/tests: Verify vertex shader built-ins generated by _mesa_glsl_initialize_variables

2013-10-22 Thread Paul Berry
On 22 October 2013 13:00, Ian Romanick wrote: > On 10/18/2013 01:14 PM, Paul Berry wrote: > > On 11 October 2013 11:18, Ian Romanick > > wrote: > > > > From: Ian Romanick > > > > > > Checks that the variables generated me

[Mesa-dev] [PATCH 7/7] i965/fs: Perform CSE on CMP(N) instructions.

2013-10-22 Thread Matt Turner
The example code's final state after the last three changes is cmp.ge.f0(8) g30<1>F g45<8,8,1>F 0F (+f0) sel(8)g50<1>F g40<8,8,1>F g10<8,8,1>F (+f0) sel(8)g51<1>F g41<8,8,1>F g11<8,8,1>F (+f0) sel(8)g52<1>F g42<8,8,1>F g12<8,8,1>F (+f0) sel(8)g53<1>F

[Mesa-dev] [PATCH 6/7] i965/fs: Dead code eliminate MOV null.

2013-10-22 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 5336851..a03acae 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@

[Mesa-dev] [PATCH 5/7] i965/fs: Don't dead code eliminate CMP(N).

2013-10-22 Thread Matt Turner
An future commit will enable CSE for CMP instructions. It operates on the following code cmp.ge.f0(8) null g45<8,8,1>F 0F (+f0) sel(8)g50<1>F g40<8,8,1>F g10<8,8,1>F cmp.ge.f0(8) null g45<8,8,1>F 0F (+f0) sel(8)g51<1>F g41<8,8,1>F g11<8,8,1>F cmp.g

[Mesa-dev] [PATCH 4/7] i965/fs: Add reads_reg() and writes_flag() to fs_inst.

2013-10-22 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 16 src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 77b898b..9b56764 100644 --- a/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 3/7] i965/fs: Add is_null() method to fs_reg.

2013-10-22 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 src/mesa/drivers/dri/i965/brw_fs.h | 1 + 2 files changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 65a4b66..77b898b 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp ++

[Mesa-dev] [PATCH 2/7] i965/fs: Match commutative expressions with reversed arguments.

2013-10-22 Thread Matt Turner
total instructions in shared programs: 1645011 -> 1644938 (-0.00%) instructions in affected programs: 17543 -> 17470 (-0.42%) --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 1/7] i965: s/Muchnik/Muchnick/.

2013-10-22 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(

Re: [Mesa-dev] [PATCH 2/6] glsl/tests: Verify vertex shader built-ins generated by _mesa_glsl_initialize_variables

2013-10-22 Thread Ian Romanick
On 10/18/2013 01:14 PM, Paul Berry wrote: > On 11 October 2013 11:18, Ian Romanick > wrote: > > From: Ian Romanick > > > Checks that the variables generated meet certain criteria. > > - Vertex shader inputs have an

Re: [Mesa-dev] [PATCH] i965/fs: Only unroll high-accuracy dFdy() from SIMD16 to SIMD8 on gen4 and IVB.

2013-10-22 Thread Eric Anholt
Paul Berry writes: > In commit 800610f (i965/fs: Improve accuracy of dFdy() to match > dFdx()) I unrolled the high-accuracy dFdy() computation from a single > SIMD16 instruction to two SIMD8 instructions because of text I found > in the i965 (gen4) PRM saying that instruction compression could no

Re: [Mesa-dev] [PATCH 5/8] i965/gs: Fix up gl_PointSize input swizzling for DUAL_INSTANCED gs.

2013-10-22 Thread Eric Anholt
Paul Berry writes: > On 21 October 2013 18:34, Eric Anholt wrote: >> Another option: How about instead of that assert in brw_eu_emit.c, we >> just smash the vstride to be width * hstride? We know the vstride >> doesn't matter, because you're only using execsize components, so let's >> just not

Re: [Mesa-dev] Core Profile and extension strings question

2013-10-22 Thread Courtney Goeltzenleuchter
On Tue, Oct 22, 2013 at 11:01 AM, Ian Romanick wrote: > On 10/22/2013 09:00 AM, Courtney Goeltzenleuchter wrote: > > I'm curious about what the proper behavior should be for extensions that > > have been integrated into core. In particular I'm looking at > > ARB_texture_cube_map as we are using t

[Mesa-dev] [PATCH] glsl/gs: Prevent illegal input/output primitive types.

2013-10-22 Thread Paul Berry
>From the GLSL 1.50 spec, section 4.3.8.1 (Input Layout Qualifiers): The layout qualifier identifiers for geometry shader inputs are layout-qualifier-id points lines lines_adjacency triangles triangles_adjacency And from sec

Re: [Mesa-dev] Ivybridge support for ARB_transform_feedback2

2013-10-22 Thread Paul Berry
On 22 October 2013 10:07, Ian Romanick wrote: > On 10/21/2013 11:48 AM, Kenneth Graunke wrote: > > On 10/21/2013 08:40 AM, Ian Romanick wrote: > >> On 10/17/2013 11:09 PM, Kenneth Graunke wrote: > >>> Here's my implementation of ARB_transform_feedback2. I believe it's > >>> complete; it passes a

Re: [Mesa-dev] Ivybridge support for ARB_transform_feedback2

2013-10-22 Thread Ian Romanick
On 10/21/2013 11:48 AM, Kenneth Graunke wrote: > On 10/21/2013 08:40 AM, Ian Romanick wrote: >> On 10/17/2013 11:09 PM, Kenneth Graunke wrote: >>> Here's my implementation of ARB_transform_feedback2. I believe it's >>> complete; it passes all of our Piglit tests and a lot of Intel's >>> oglconform

Re: [Mesa-dev] Core Profile and extension strings question

2013-10-22 Thread Ian Romanick
On 10/22/2013 09:00 AM, Courtney Goeltzenleuchter wrote: > I'm curious about what the proper behavior should be for extensions that > have been integrated into core. In particular I'm looking at > ARB_texture_cube_map as we are using that in one of the ARB_texture_view > piglit tests and when run o

[Mesa-dev] [PATCH] radeon/llvm: Specify the DataLayout when running optimizations

2013-10-22 Thread Tom Stellard
From: Tom Stellard Without DataLayout, a lot of optimization passes aren't run and the ones that are don't work as well. --- src/gallium/drivers/radeon/radeon_llvm_util.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_util.c b/src/gallium/drivers/

Re: [Mesa-dev] [PATCH] i965/fs: Only unroll high-accuracy dFdy() from SIMD16 to SIMD8 on gen4 and IVB.

2013-10-22 Thread Matt Turner
On Tue, Oct 22, 2013 at 6:37 AM, Paul Berry wrote: > In commit 800610f (i965/fs: Improve accuracy of dFdy() to match > dFdx()) I unrolled the high-accuracy dFdy() computation from a single > SIMD16 instruction to two SIMD8 instructions because of text I found > in the i965 (gen4) PRM saying that i

[Mesa-dev] Core Profile and extension strings question

2013-10-22 Thread Courtney Goeltzenleuchter
I'm curious about what the proper behavior should be for extensions that have been integrated into core. In particular I'm looking at ARB_texture_cube_map as we are using that in one of the ARB_texture_view piglit tests and when run on the Mesa driver the piglit function piglit_require_extension("G

Re: [Mesa-dev] [PATCH] clover: Refuse to create context with invalid properties

2013-10-22 Thread Jan Vesely
On Mon, 2013-10-21 at 22:20 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > the specs say that clCreateContext reutrns error > > "if platform value specified in properties is not a valid platform" > > > > The orignal approach fials if invalid valu other than NULL pointer is > > provided

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-22 Thread Ian Romanick
On 10/22/2013 07:48 AM, Ian Romanick wrote: > On 10/16/2013 10:40 AM, Ian Romanick wrote: >> On 10/15/2013 07:50 PM, Kenneth Graunke wrote: >>> On 10/15/2013 01:58 PM, Ian Romanick wrote: On 10/15/2013 01:50 PM, Anuj Phogat wrote: > On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick > wr

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-22 Thread Ian Romanick
On 10/16/2013 10:40 AM, Ian Romanick wrote: > On 10/15/2013 07:50 PM, Kenneth Graunke wrote: >> On 10/15/2013 01:58 PM, Ian Romanick wrote: >>> On 10/15/2013 01:50 PM, Anuj Phogat wrote: On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote: > On 10/14/2013 10:12 AM, Anuj Phogat wrot

[Mesa-dev] [Bug 70766] New: Run-time link error in swrast_dri.so

2013-10-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70766 Priority: medium Bug ID: 70766 Assignee: mesa-dev@lists.freedesktop.org Summary: Run-time link error in swrast_dri.so Severity: major Classification: Unclassified OS: Linux (

[Mesa-dev] [Bug 70743] Compilation on VS2013

2013-10-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70743 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] st/mesa: respect higher GLSL levels. (v2)

2013-10-22 Thread Brian Paul
On 10/22/2013 02:06 AM, Dave Airlie wrote: From: Dave Airlie Limit the max glsl version level to what the state tracker supports. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/st

Re: [Mesa-dev] [PATCH 5/8] i965/gs: Fix up gl_PointSize input swizzling for DUAL_INSTANCED gs.

2013-10-22 Thread Paul Berry
On 21 October 2013 18:34, Eric Anholt wrote: > Paul Berry writes: > > > On 18 October 2013 17:04, Eric Anholt wrote: > >> Putting these fixups for a couple of weird cases in just MOV and ADD > >> feels wrong to me, but maybe when I understand better what's going on > >> it'll seem more natural.

Re: [Mesa-dev] [PATCH] mesa: fix a couple issues with U_FIXED, I_FIXED macros

2013-10-22 Thread Jose Fonseca
- Original Message - > Silence a bunch of MSVC type conversion warnings. > > Changed return type of S_FIXED to int32_t (signed). The result > is the same. It just seems more intuitive that a signed conversion > function should return a signed value. > --- > src/mesa/main/macros.h |

[Mesa-dev] [PATCH] i965/fs: Only unroll high-accuracy dFdy() from SIMD16 to SIMD8 on gen4 and IVB.

2013-10-22 Thread Paul Berry
In commit 800610f (i965/fs: Improve accuracy of dFdy() to match dFdx()) I unrolled the high-accuracy dFdy() computation from a single SIMD16 instruction to two SIMD8 instructions because of text I found in the i965 (gen4) PRM saying that instruction compression could not be used in align16 mode. I

[Mesa-dev] [PATCH 2/2] glsl: Add check for unsized arrays to glsl types

2013-10-22 Thread Timothy Arceri
The main purpose of this patch is to increase readability of the array code. A redundent is_array() check is also removed. The introduction of is_unsized_array() should also make the ARB_arrays_of_arrays code simpler and more readable when it arrives. Signed-off-by: Timothy Arceri --- src/glsl/

[Mesa-dev] [PATCH 1/2] glsl: Fix comment

2013-10-22 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- src/glsl/ast_array_index.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index b457ec8..107c29e 100644 --- a/src/glsl/ast_array_index.cpp +++ b/src/glsl/ast_array_index.cpp @@ -14

Re: [Mesa-dev] [PATCH 6/9] mesa: Add a new GetTransformFeedbackVertexCount() driver hook.

2013-10-22 Thread Marek Olšák
On Fri, Oct 18, 2013 at 8:09 AM, Kenneth Graunke wrote: > DrawTransformFeedback() needs to obtain the number of vertices written > to a particular stream during the last Begin/EndTransformFeedback block. > The new driver hook returns exactly that information. > > Gallium drivers already implement

[Mesa-dev] [PATCH] egl_dri2: Don't use gbm_dri_device when its not there

2013-10-22 Thread jorgen.lind
From: =?UTF-8?q?J=C3=B8rgen=20Lind?= Date: Tue, 22 Oct 2013 09:21:05 +0200 Subject: [PATCH] Don't use gbm_dri_device when its not there --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c inde

[Mesa-dev] [PATCH] st/mesa: respect higher GLSL levels. (v2)

2013-10-22 Thread Dave Airlie
From: Dave Airlie Limit the max glsl version level to what the state tracker supports. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_t

Re: [Mesa-dev] Bug with glBlitFramebufferEXT(), and a piglit test for it

2013-10-22 Thread Timothy Arceri
Hi Federico, Just FYI you should send the piglit test to the piglit mailing list: http://lists.freedesktop.org/mailman/listinfo/piglit Also to allow easy review you should use git send-email rather than attaching it to the email. Timothy Arceri On Mon, 2013-10-21 at 17:37 -0500, Federico Mena Q