On Thu, Aug 15, 2013 at 1:26 PM, Chia-I Wu wrote:
> On Sat, Aug 10, 2013 at 2:56 AM, Marek Olšák wrote:
>> Most importantly, this hides all LLVM symbols. They shouldn't clash
>> with a different LLVM version used by apps (at least in theory).
>>
>> $ nm -g --defined-only radeonsi_dri.so
>> 01148f
On Sat, Aug 10, 2013 at 2:56 AM, Marek Olšák wrote:
> Most importantly, this hides all LLVM symbols. They shouldn't clash
> with a different LLVM version used by apps (at least in theory).
>
> $ nm -g --defined-only radeonsi_dri.so
> 01148f30 D __driDriverExtensions
I am not familiar with issues r
On Thu, Aug 15, 2013 at 10:03 AM, Kenneth Graunke wrote:
> On 08/08/2013 03:13 PM, Chad Versace wrote:
> [snip]
>>
>> By the way, I talked to krh today, and he suggested that we delete egl_glx
>> rather than allow it to bitrot.
>
>
> I'm in favor, but I don't know who uses that.
>
> GLX on EGL wou
For some reason, we didn't use this information even though the VS
backend has computed it (albeit poorly) for ages.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vs_surface_state.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri
Unlike the FS, the VS backend already computed the binding table size.
However, it did so poorly: after compilation, it looked to see if any
pull constants/textures/UBOs were in use, and set num_surfaces to the
maximum surface index for that category. If the VS only used a single
texture or UBO, t
This will be useful for the next commit.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_vec4.h| 3 +++
src/mesa/drivers/dri/i965/brw_vec4_emit.cpp | 5 +++--
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git
Computing the minimum size was easy, and done at compile-time for no
extra overhead here. Making the binding table smaller wastes less batch
space.
Adding the CACHE_NEW_WM_PROG dirty bit isn't strictly necessary, since
other atoms depend on it and flag BRW_NEW_SURFACES. However, it's best
to add
This allows us to determine how small we can make the binding table.
Since it depends entirely on the shader program, we can just compute
it once at compile time, rather than at binding table emit time (which
happens during drawing).
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/
SURF_INDEX_DRAW is the identity function, and it's unlikely that it will
change, but we may as well use it for documentation's sake.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs_emit.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/d
(This should be applied before MSAA, which will need to be rebased.)
It moves all sampler view descriptors to a buffer.
It supports partial resource updates and it can also unbind resources
(required for FMASK texturing).
The buffer contains all sampler view descriptors for one shader stage,
repr
On 08/08/2013 03:13 PM, Chad Versace wrote:
[snip]
By the way, I talked to krh today, and he suggested that we delete egl_glx
rather than allow it to bitrot.
I'm in favor, but I don't know who uses that.
GLX on EGL would be an interesting experiment. EGL on GLX is not
useful, IMHO.
--Ken
_
This allows us to avoid uploading the VS sampler state table if only the
fragment program changes.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_state.h| 3 ++-
src/mesa/drivers/dri/i965/brw_state_upload.c | 9 ++---
src/mesa/drivers/dri/i965/brw_wm_sampl
This allows us to coalesce the brw_samplers and gen7_samplers atoms.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_context.h | 6 ++
src/mesa/drivers/dri/i965/brw_state.h| 5 -
src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +-
src/mesa/dr
Now that we have the number of samplers available, we don't need to
iterate over all 16. This should be particularly helpful for vertex
shaders.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_vs.c | 2 +-
2 files changed, 2 insert
Now, each shader stage has a sampler state table that only refers to the
samplers actually used by that problem. This should make the VS table
non-existant or very small.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_context.h | 1 +
src/mesa/drivers/dri/i965/brw_wm
Previously, we computed sampler counts when generating the SAMPLER_STATE
table. By computing it earlier, we should be able to shorten a bunch of
loops.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_context.h | 2 +-
src/mesa/drivers/dri/i965/brw_draw.c |
Now that we have the number of samplers available, we don't need to
iterate over all 16. This should be particularly helpful for vertex
shaders.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_program.h | 1 +
src/mesa/drivers/dri/i965/brw_vs.c | 3 ++-
src/mesa/drivers/dr
Currently, we only have a single sampler state table shared among all
stages, so we just copy wm.sampler_count into vs.sampler_count.
In the future, each shader stage will have its own SAMPLER_STATE table,
at which point we'll need these separate sampler counts.
Signed-off-by: Kenneth Graunke
--
Also upload separate sampler default/texture border color entries.
At the moment, this is completely idiotic: both tables contain exactly
the same contents, so we're simply wasting batch space and CPU time.
However, soon we'll only upload data for textures actually /used/ in
a particular stage, w
Currently, i965 uploads a single SAMPLER_STATE table shared across all
shader stages (VS, FS). This series splits it out, uploading a unique
table for each stage.
I think this may actually fix some bugs with vertex texturing:
Piglit's fragment-and-vertex-texturing uses two textures (unit 0 and
un
Like the previous patch, this simply pushes direct access to brw->wm up
one level in the call chain. Rather than passing the whole array, we
just pass a pointer to the correct spot in the array, similar to what we
do for the actual sampler state structure.
Signed-off-by: Kenneth Graunke
---
src
When we begin uploading separate sampler state tables for VS and FS,
we won't be able to use &brw->wm.sdc_offset[ss_index]. By passing it in
as a parameter, we push the problem up to the caller.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_state.h| 3 ++-
src/me
Currently single sample scaled blits with GL_LINEAR filter falls
back to meta path. Patch removes this limitation in BLORP engine
and implements single sample scaled blit with bilinear filter.
No piglit, gles3 regressions are observed with this patch on Ivybridge.
V2: Use "sample" message to utili
On Wed, Aug 14, 2013 at 1:46 PM, Paul Berry wrote:
> On 5 August 2013 15:00, Anuj Phogat wrote:
>>
>> This patch fixes a case of framebuffer blitting with renderbuffer
>> as color attachment and GL_LINEAR filter. Meta implementation of
>> glBlitFrambuffer() converts source color buffer to a textu
Fix a typo introduced with commit d1ba1055d9 -
vl: Add support for max level query v2
Cc: Rico Schüller
Cc: Christian König
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68126
Signed-off-by: Emil Velikov
---
FWIW the original patch could have introduced default params for all profiles
Previously, INTEL_DEBUG=bat would dump messages like:
intel_mipmap_tree.c:1643: Batchbuffer flush with 456b used
This only reported the space used for command packets, and didn't
report any information on the space used for indirect state.
Now it dumps:
intel_context.c:366: Batchbuffer flush wi
Am 15.08.2013 00:54, schrieb Zack Rusin:
> > - lp_build_sample_compare(&bld, newcoords[4], texel_out);
>> + if (0)
>> + lp_build_sample_compare(&bld, newcoords[4], texel_out);
>> }
>
> What does this do?
> The rest looks good to me!
>
> Reviewed-by: Zack Rusin
>
Yeah t
> - lp_build_sample_compare(&bld, newcoords[4], texel_out);
> + if (0)
> + lp_build_sample_compare(&bld, newcoords[4], texel_out);
> }
What does this do?
The rest looks good to me!
Reviewed-by: Zack Rusin
___
mesa-dev mailing l
From: Roland Scheidegger
Doing the comparisons pre-filter is highly recommended by OpenGL (and d3d9)
and definitely required by d3d10.
This actually doesn't do it pre-filter but more "in-filter" as otherwise
need to push the comparisons even further down into fetch code and this
also trivially al
On 14 August 2013 11:46, Anuj Phogat wrote:
> On Wed, Aug 14, 2013 at 10:25 AM, Paul Berry
> wrote:
> > On 9 August 2013 19:01, Anuj Phogat wrote:
> >> - src.brw_surfaceformat = dst.brw_surfaceformat;
> >> + if (src.num_samples > 1)
> >> + src.brw_surfaceformat = dst.brw_surfaceformat;
On 5 August 2013 15:00, Anuj Phogat wrote:
> This patch fixes a case of framebuffer blitting with renderbuffer
> as color attachment and GL_LINEAR filter. Meta implementation of
> glBlitFrambuffer() converts source color buffer to a texture and
> uses it to do the scaled blitting in to destinatio
I have to admit that I don't know the sampling code, but the patches look good
to me.
z
- Original Message -
> From: Roland Scheidegger
>
> This makes things a bit nicer, and more importantly it fixes an issue
> where a "downgraded" array texture (due to view reduced to 1 layer and
> a
Consistently using a "The ___ driver hook." line at the the top of each
function's comment block makes it easy to see at a glance what function
is being implemented.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/intel_buffer_objects.c | 68 ++--
1 file changed,
This code upload performs batched uploads via a BO. By moving it out to
a separate file, intel_buffer_objects.c only provides the core buffer
object functionality.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/Makefile.sources | 1 +
src/mesa/drivers/dri/i965/intel_buffer
GL_APPLE_object_purgeable creates a mechanism for marking OpenGL objects
as "purgeable" so they can be thrown away when system resources become
scarce. It specifically applies to buffer objects, textures, and
renderbuffers.
The intel_buffer_objects.c file provides core functionality for GL
buffer
On Wed, Aug 14, 2013 at 10:25 AM, Paul Berry wrote:
> On 9 August 2013 19:01, Anuj Phogat wrote:
>>
>> Currently single sample scaled blits with GL_LINEAR filter falls
>> back to meta path. Patch removes this limitation in BLORP engine
>> and implements single sample scaled blit with bilinear fil
On 9 August 2013 19:01, Anuj Phogat wrote:
> Currently single sample scaled blits with GL_LINEAR filter falls
> back to meta path. Patch removes this limitation in BLORP engine
> and implements single sample scaled blit with bilinear filter.
> No piglit, gles3 regressions are obeserved with this
On Wed, Aug 14, 2013 at 09:08:55AM +0200, Maarten Lankhorst wrote:
> Op 14-08-13 04:37, Tom Stellard schreef:
> > On Tue, Aug 13, 2013 at 05:53:52PM +0200, Maarten Lankhorst wrote:
> >> Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not
> >> present in /usr/lib/llvm-3.2/lib.
> >
From: Roland Scheidegger
This makes things a bit nicer, and more importantly it fixes an issue
where a "downgraded" array texture (due to view reduced to 1 layer and
addressed with (non-array) samplec instruction) would use the wrong
coord as shadow reference value. (This could also be fixed by p
On 9 August 2013 17:14, Chris Forbes wrote:
> This series adds support for GLSL-1.30 clip distances on Gen4/5, and
> extends max clip planes to match the 1.30 requirement on Cantiga and later.
>
> Passes 2000/2004 glsl-1.30 piglits on Ironlake. The missing 4 tests here
> are
> bugs in handling un
On 9 August 2013 17:14, Chris Forbes wrote:
> V2: - Use the new VS_OPCODE_UNPACK_FLAGS_SIMD4X2 to correctly split the
> flags for the two vertices being processed together.
> - Don't apply bogus masking of clip flags. The set of plane enables
> aren't included in the shader key, a
On 9 August 2013 17:14, Chris Forbes wrote:
> Splits the bottom 8 bits of f0.0 for further wrangling
> in a SIMD4x2 program. The 4 bits corresponding to the channels in each
> program flow are copied to the LSBs of dst.x visible to each flow.
>
> This is useful for working with clipping flags in
From: Roland Scheidegger
This makes things a bit nicer, and more importantly it fixes an issue
where a "downgraded" array texture (due to view reduced to 1 layer and
addressed with (non-array) samplec instruction) would use the wrong
coord as shadow reference value. (This could also be fixed by p
From: Roland Scheidegger
Instead of passing s,t,r coordinates pass a coord array - the reason is that
I need to pass more coords (in particular for shadow "coord", future will also
need another one for cube map arrays) so just pass them as an array.
Also, to simplify things, use fixed location fo
Signed-off-by: Jonathan Gray
---
src/gallium/include/pipe/p_config.h | 10 ++
1 file changed, 10 insertions(+)
diff --git src/gallium/include/pipe/p_config.h
src/gallium/include/pipe/p_config.h
index 1588a92..9af5df7 100644
--- src/gallium/include/pipe/p_config.h
+++ src/gallium/include
Am 14.08.2013 07:40, schrieb Zack Rusin:
> If the fragment shader is null then pixel shader invocations have
> to be equal to zero. And if we're running a null ps then clipper
> invocations and primitives should be equal to zero but only
> if both stancil and depth testing are disabled.
>
> Signed
Am 14.08.2013 13:04, schrieb Rico Schüller:
On 14.08.2013 12:47, Christian König wrote:
Am 14.08.2013 08:13, schrieb Rico Schüller:
Hi,
this patch adds the level query support to the video decoders. This
uses some more reasonable defaults.
This improves the situation in bug 67530 .
The patc
On 14.08.2013 12:47, Christian König wrote:
Am 14.08.2013 08:13, schrieb Rico Schüller:
Hi,
this patch adds the level query support to the video decoders. This
uses some more reasonable defaults.
This improves the situation in bug 67530 .
The patch is:
Reviewed-by: Christian König
I assum
Am 14.08.2013 08:13, schrieb Rico Schüller:
Hi,
this patch adds the level query support to the video decoders. This
uses some more reasonable defaults.
This improves the situation in bug 67530 .
The patch is:
Reviewed-by: Christian König
I assume you don't have commit access, right?
Che
On Die, 2013-08-13 at 19:39 -0700, Tom Stellard wrote:
> On Tue, Aug 13, 2013 at 07:04:56PM +0200, srol...@vmware.com wrote:
> > From: Roland Scheidegger
> >
> > Also use ordered comparisons for old cmp instructions. Untested.
>
> This patch looks good to me, but I would like to do a piglit run
>I was planning to change platform_wayland.c not to use _DRI_IMAGE_USE_SHARE
>when self sharing. But after looking more closely, it seems that
>PIPE_BIND_SHARED
>would be necessary for gallium drivers for self-sharing too.
>
>Since we want to enable tiling when we use self-sharing, my patch isn
On Wed, Aug 14, 2013 at 10:45:23AM +0300, Ville Syrjälä wrote:
> On Tue, Aug 13, 2013 at 05:46:55PM -0700, Chad Versace wrote:
> > On 08/13/2013 03:31 PM, Vedran Rodic wrote:
> > > On Mon, Aug 12, 2013 at 3:07 PM, wrote:
> > >> From: Ville Syrjälä
> > >>
> > >> IVB/BYT also has the same L3 cache
On Tue, Aug 13, 2013 at 05:46:55PM -0700, Chad Versace wrote:
> On 08/13/2013 03:31 PM, Vedran Rodic wrote:
> > On Mon, Aug 12, 2013 at 3:07 PM, wrote:
> >> From: Ville Syrjälä
> >>
> >> IVB/BYT also has the same L3 cacheability control in MOCS as HSW,
> >> so let's make use of it.
> >
> > Accor
Op 14-08-13 04:37, Tom Stellard schreef:
> On Tue, Aug 13, 2013 at 05:53:52PM +0200, Maarten Lankhorst wrote:
>> Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not
>> present in /usr/lib/llvm-3.2/lib.
>>
> I'm trying to understand the problem here, could you give a little more
>
Hi,
this patch adds the level query support to the video decoders. This uses
some more reasonable defaults.
This improves the situation in bug 67530 .
Cheers
Rico
---
src/gallium/auxiliary/vl/vl_decoder.c| 15 +++
src/gallium/auxiliary/vl/vl_decoder.h| 6 +
If the fragment shader is null then pixel shader invocations have
to be equal to zero. And if we're running a null ps then clipper
invocations and primitives should be equal to zero but only
if both stancil and depth testing are disabled.
Signed-off-by: Zack Rusin
---
src/gallium/drivers/llvmpip
On Wed, Aug 14, 2013 at 1:04 AM, wrote:
> From: Roland Scheidegger
>
> untested.
Looks good to me.
> ---
> src/gallium/drivers/ilo/shader/toy_tgsi.c | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/src/gallium/drivers/ilo/shader/toy_tgsi.c
> b/sr
> On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák wrote:
>> On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin
>> wrote:
Other than hybrid systems (of which
there are none with i915 graphics), is there any case where
__DRI_IMAGE_USE_SHARE can occur?
>>>
>>> You could do interesti
On 08/13/2013 01:35 PM, Ian Romanick wrote:
From: Ian Romanick
Previously we would emit a warning for empty declarations like
float;
We would also emit the same warning for things like
highp float;
However, this second case is most likely the application trying to set
the default precision.
Hi,
this patch adds the level query support to the video decoders. This uses
some more reasonable defaults.
This improves the situation in bug 67530 .
Cheers
Rico
---
src/gallium/auxiliary/vl/vl_decoder.c| 15 +++
src/gallium/auxiliary/vl/vl_decoder.h| 6 ++
60 matches
Mail list logo
