Re: [Mesa-dev] [i965][V2] i965/draw: Move constant formation outside of for loop and use an enum.

2013-08-08 Thread Mark Mueller
On Thu, Aug 8, 2013 at 2:19 PM, Eric Anholt wrote: > Mark Mueller writes: > > Signed-off-by: Mark Mueller > > --- > > src/mesa/drivers/dri/i965/brw_draw.c | 16 ++-- > > 1 file changed, 6 insertions(+), 10 deletions(-) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c > b/s

[Mesa-dev] [PATCH] r600g: disable GPUVM by default

2013-08-08 Thread Alex Deucher
Cayman and trinity systems still seem to suffer from stability problems with GPUVM. This also fixes compute on these asics. It can still be enabled for testing by setting env var RADEON_VA=true. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=65958 Signed-off-by: Alex Deucher CC: "9.2" CC

Re: [Mesa-dev] [PATCH] glsl: Don't allow const on out or inout function parameters

2013-08-08 Thread Matt Turner
On Thu, Aug 8, 2013 at 4:54 PM, Ian Romanick wrote: > From: Ian Romanick > > Fixes piglit tests const-inout-parameter.frag and > const-out-parameter.frag. > > Signed-off-by: Ian Romanick > Cc: "9.2" mesa-sta...@lists.freedesktop.org > Cc: Matt Turner > --- > This currently causes a regression i

[Mesa-dev] [Bug 67928] New: [softpipe] piglit tesselation quads wireframe regression

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67928 Priority: medium Bug ID: 67928 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit tesselation quads wireframe

Re: [Mesa-dev] [PATCH 3/3] draw: rewrite primitive assembler

2013-08-08 Thread Zack Rusin
> Am 09.08.2013 00:40, schrieb Zack Rusin: > > > Series looks good though I'm unsure why the pipeline stage doesn't work. > >> Where does that decomposition happen? Is that something like GS > >> outputting multiple prims in the same topology which all need the same id? > > > > No, it's because t

[Mesa-dev] [Bug 67925] ARB_vertex_array_bgra api-errors test fails when normalized is false

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67925 --- Comment #1 from Fredrik Höglund --- I have yet a third version in my arb-vertex-attrib-binding branch: http://cgit.freedesktop.org/~fredrik/mesa/commit/?h=arb-vertex-attrib-binding&id=df98f9f8 -- You are receiving this mail because: You ar

[Mesa-dev] [PATCH] glsl: Don't allow const on out or inout function parameters

2013-08-08 Thread Ian Romanick
From: Ian Romanick Fixes piglit tests const-inout-parameter.frag and const-out-parameter.frag. Signed-off-by: Ian Romanick Cc: "9.2" mesa-sta...@lists.freedesktop.org Cc: Matt Turner --- This currently causes a regression in relaxed-parameter-qualifier-ordering.vert. I believe that test is in

[Mesa-dev] [Bug 67926] New: [softpipe] piglit tesselation polygon wireframe regression

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67926 Priority: medium Bug ID: 67926 Keywords: have-backtrace, regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit tesselation polygon w

[Mesa-dev] [Bug 67921] [bisected commit 883987] crosscompiling fails with util/u_cpu_detect.c:247:4: error: 'asm' undeclared (first use in this function)

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67921 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 67925] New: ARB_vertex_array_bgra api-errors test fails when normalized is false

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67925 Priority: medium Bug ID: 67925 CC: co...@octayn.net, fred...@kde.org, i...@freedesktop.org, kenn...@whitecape.org Assignee: mesa-dev@lists.freedesktop.org Blocks: 6722

Re: [Mesa-dev] Mesa CVS: compilation fails in u_cpu_detect.c

2013-08-08 Thread Roland Scheidegger
Am 09.08.2013 01:05, schrieb Dieter Nützel: > After git pull 8. Aug 19:18 compilation fails in > src/gallium/auxiliary/util/u_cpu_detect.c > > gmake[3]: Entering directory `/opt/mesa/src/gallium/auxiliary' > CC util/u_cpu_detect.lo > util/u_cpu_detect.c: In function 'sse2_has_daz': > util/

[Mesa-dev] [PATCH 3/3] mesa: Use _mesa_detach_renderbuffer when deleting a texture

2013-08-08 Thread Ian Romanick
From: Ian Romanick The functional change is that now invalidate_framebuffer is called if the texture is actually detached from one of the currently bound FBOs. Previously this was only done for renderbuffers. The remaining changes make the texture delete path look more similar to the renderbuffe

[Mesa-dev] [PATCH 2/3] mesa: Make detach_renderbuffer available outside fbobject.c

2013-08-08 Thread Ian Romanick
From: Ian Romanick Also add a return value indicating whether any work was done. This will be used by the next patch. Signed-off-by: Ian Romanick Cc: "9.2" mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 42 +- src/mesa/main/fbobject.h

[Mesa-dev] [PATCH 1/3] meta: Don't call _mesa_Ortho with width or height of 0

2013-08-08 Thread Ian Romanick
From: Ian Romanick Fixes failures in oglconform fbo mipmap.manual.color, mipmap.manual.colorAndDepth, mipmap.automatic, and mipmap.manualIterateTexTargets subtests. Signed-off-by: Ian Romanick Cc: "9.2" mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/common/meta.c | 11 --- 1 fi

[Mesa-dev] [Bug 67924] New: [softpipe] piglit tesselation quad_strip wireframe regression

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67924 Priority: medium Bug ID: 67924 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit tesselation quad_strip wireframe

Re: [Mesa-dev] OpenGL ES only configuration (without "desktop" OpenGL support)

2013-08-08 Thread Ian Romanick
On 08/06/2013 02:13 PM, Siarhei Siamashka wrote: Hello, Some months ago, the commit "configure.ac: Allow OpenGL ES1 and ES2 only with enabled OpenGL" dropped support for the OpenGL-free configuration. http://lists.freedesktop.org/archives/mesa-dev/2013-February/033909.html http://list

Re: [Mesa-dev] [PATCH] mesa: Reject VertexAttribPointer() with GL_BGRA and !normalized.

2013-08-08 Thread Ian Romanick
On 07/30/2013 09:57 AM, Ian Romanick wrote: On 07/23/2013 03:50 PM, Matt Turner wrote: On Mon, Jul 15, 2013 at 6:37 AM, Fredrik Höglund wrote: On Monday 15 July 2013, Kenneth Graunke wrote: Fixes Piglit's ARB_vertex_attrib_bgra/api-errors test. Signed-off-by: Kenneth Graunke --- src/mesa/

Re: [Mesa-dev] [PATCH 3/3] draw: rewrite primitive assembler

2013-08-08 Thread Roland Scheidegger
Am 09.08.2013 00:40, schrieb Zack Rusin: > > Series looks good though I'm unsure why the pipeline stage doesn't work. >> Where does that decomposition happen? Is that something like GS >> outputting multiple prims in the same topology which all need the same id? > > No, it's because the pipeline

Re: [Mesa-dev] [PATCH 3/3] draw: rewrite primitive assembler

2013-08-08 Thread Zack Rusin
> Series looks good though I'm unsure why the pipeline stage doesn't work. > Where does that decomposition happen? Is that something like GS > outputting multiple prims in the same topology which all need the same id? No, it's because the pipeline stage is ran on the decomposed primitives. The i

Re: [Mesa-dev] [PATCH 3/3] draw: rewrite primitive assembler

2013-08-08 Thread Roland Scheidegger
Am 08.08.2013 21:46, schrieb Zack Rusin: > We can't be injecting the primitive id's in the pipeline because > by that time the primitives have already been decomposed. To > properly number the primitives we need to handle the adjacency > primitives by hand. This patch moves the prim id injection in

[Mesa-dev] [Bug 67921] [bisected commit 883987] crosscompiling fails with util/u_cpu_detect.c:247:4: error: 'asm' undeclared (first use in this function)

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67921 Alexandre Demers changed: What|Removed |Added CC||srol...@vmware.com -- You are receiv

[Mesa-dev] [Bug 67921] New: [bisected commit 883987] crosscompiling fails with util/u_cpu_detect.c:247:4: error: 'asm' undeclared (first use in this function)

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67921 Priority: medium Bug ID: 67921 Assignee: mesa-dev@lists.freedesktop.org Summary: [bisected commit 883987] crosscompiling fails with util/u_cpu_detect.c:247:4: error: 'asm' undeclared

Re: [Mesa-dev] [PATCH] egl: Do not export private symbols

2013-08-08 Thread Chad Versace
On 08/06/2013 05:30 PM, Jakob Bornecrantz wrote: On Wed, Aug 7, 2013 at 2:00 AM, Chad Versace wrote: On 08/06/2013 03:02 PM, Jakob Bornecrantz wrote: On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz wrote: On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace < chad.vers...@linux.intel.com w

Re: [Mesa-dev] [i965][V2] i965/draw: Move constant formation outside of for loop and use an enum.

2013-08-08 Thread Eric Anholt
Mark Mueller writes: > Signed-off-by: Mark Mueller > --- > src/mesa/drivers/dri/i965/brw_draw.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c > b/src/mesa/drivers/dri/i965/brw_draw.c > index 6170d07..1b5ed55 10064

Re: [Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Kenneth Graunke
On 08/08/2013 03:59 AM, Eric Anholt wrote: Previously, we were asserting that each driver specified an NConfigOptions exactly equal to the number of options they supplied, leading to frequent bugs when people would forget to adjust the value when adjusting driver options. Instead, just overalloc

[Mesa-dev] [PATCH] mesa: Enable LTO by default on i965/libdricore release builds.

2013-08-08 Thread Eric Anholt
We can't just smash it on globally due to (probably resolvable) issues with the asm in glapi. And we don't want to penalize developers with longer build times for their normal debug environment. Due to libdricore making almost all of our symbols public, the effect is very small -- cairo-gl with I

[Mesa-dev] [i965][V2] i965/draw: Move constant formation outside of for loop and use an enum.

2013-08-08 Thread Mark Mueller
Signed-off-by: Mark Mueller --- src/mesa/drivers/dri/i965/brw_draw.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 6170d07..1b5ed55 100644 --- a/src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH] gallivm: set non-existing values really to zero in size queries for d3d10

2013-08-08 Thread Zack Rusin
Looks good. Reviewed-by: Zack Rusin - Original Message - > From: Roland Scheidegger > > My previous attempt at doing so double-failed miserably (minification of > zero still gives one, and even if it would not the value was never written > anyway). > While here also rename the confusin

Re: [Mesa-dev] [PATCH 2/2] gallivm: use texture target from shader instead of static state for size query

2013-08-08 Thread Zack Rusin
Series looks good to me. Reviewed-by: Zack Rusin - Original Message - > From: Roland Scheidegger > > d3d10 has no notion of distinct array resources neither at the resource nor > sampler view level. However, shader dcl of resources certainly has, and > d3d10 expects resinfo to return t

Re: [Mesa-dev] [PATCH 2/3] draw: reset the vertex id when injecting new primitive id

2013-08-08 Thread Zack Rusin
Don't worry about this one too much. The next patch removes draw_pipe_ia.c anyway... - Original Message - > Without reseting the vertex id, with primitives where the same > vertex is used with different primitives (e.g. tri/lines strips) > our vbuf module won't re-emit those vertices with

[Mesa-dev] [PATCH 3/3] draw: rewrite primitive assembler

2013-08-08 Thread Zack Rusin
We can't be injecting the primitive id's in the pipeline because by that time the primitives have already been decomposed. To properly number the primitives we need to handle the adjacency primitives by hand. This patch moves the prim id injection into the original primitive assembler and completel

[Mesa-dev] [PATCH 2/3] draw: reset the vertex id when injecting new primitive id

2013-08-08 Thread Zack Rusin
Without reseting the vertex id, with primitives where the same vertex is used with different primitives (e.g. tri/lines strips) our vbuf module won't re-emit those vertices with the changed primitive id. So lets reset the vertex id whenever injecting new primitive id to make sure that the vertex da

[Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

2013-08-08 Thread Zack Rusin
Before inserting new front face and prim id outputs cleanup the old extra outputs, otherwise our cache will use previous output slots which will break as soon as outputs of the current shader don't match the last. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_context.c |1 +

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Alex Deucher
On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: > On Thu, Aug 8, 2013 at 6:57 PM, Christian König > wrote: >> Am 08.08.2013 16:33, schrieb Marek Olšák: >>> >>> On Thu, Aug 8, 2013 at 3:09 PM, Christian König >>> wrote: Am 08.08.2013 14:38, schrieb Marek Olšák: > .On Thu, A

Re: [Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Eric Anholt
Ian Romanick writes: > On 08/08/2013 03:59 AM, Eric Anholt wrote: >> Previously, we were asserting that each driver specified an NConfigOptions >> exactly equal to the number of options they supplied, leading to frequent >> bugs when people would forget to adjust the value when adjusting driver >

Re: [Mesa-dev] [i965] i965/draw: Move constant formation outside of for loop and use an enum.

2013-08-08 Thread Mark Mueller
On Tue, Aug 6, 2013 at 12:31 PM, Ian Romanick wrote: > On 08/06/2013 12:10 PM, mmueller wrote:Signed-off-by: mmueller < > markkmuel...@gmail.com> > >> --- >> src/mesa/drivers/dri/i965/brw_**draw.c | 18 +- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/sr

Re: [Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Ian Romanick
On 08/08/2013 03:59 AM, Eric Anholt wrote: Previously, we were asserting that each driver specified an NConfigOptions exactly equal to the number of options they supplied, leading to frequent bugs when people would forget to adjust the value when adjusting driver options. Instead, just overalloc

[Mesa-dev] [Bug 67740] render2.c: In function '__indirect_glMap1d'

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67740 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO CC|

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Tom Stellard
On Thu, Aug 08, 2013 at 05:36:09PM +0200, Michel Dänzer wrote: > On Don, 2013-08-08 at 08:00 -0700, Tom Stellard wrote: > > On Thu, Aug 08, 2013 at 02:20:54AM +0200, Marek Olšák wrote: > > > > > > diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c > > > b/src/gallium/drivers/radeonsi/si_st

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Remember to call intel_prepare_render() before blitting.

2013-08-08 Thread Chad Versace
On 08/06/2013 02:36 PM, Kenneth Graunke wrote: Otherwise, blits to the window system buffer may cause crashes, since dst_irb->mt may be NULL. This code is lifted straight out of brw_blorp_framebuffer()'s try_blorp_blit() helper. Fixes crashes in Piglit's fbo-sys-blit on systems without BLORP.

Re: [Mesa-dev] [PATCH] i965: Remember to call intel_prepare_render() before blitting.

2013-08-08 Thread Ian Romanick
On 08/06/2013 02:36 PM, Kenneth Graunke wrote: Otherwise, blits to the window system buffer may cause crashes, since dst_irb->mt may be NULL. This code is lifted straight out of brw_blorp_framebuffer()'s try_blorp_blit() helper. Fixes crashes in Piglit's fbo-sys-blit on systems without BLORP.

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67672 Roland Scheidegger changed: What|Removed |Added CC||lordhea...@gmail.com --- Comment #1

[Mesa-dev] [Bug 67910] make check fail on lp_test_arit test

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67910 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Marek Olšák
On Thu, Aug 8, 2013 at 6:57 PM, Christian König wrote: > Am 08.08.2013 16:33, schrieb Marek Olšák: >> >> On Thu, Aug 8, 2013 at 3:09 PM, Christian König >> wrote: >>> >>> Am 08.08.2013 14:38, schrieb Marek Olšák: >>> .On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: > > A

[Mesa-dev] [Bug 67910] New: make check fail on lp_test_arit test

2013-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67910 Priority: medium Bug ID: 67910 Assignee: mesa-dev@lists.freedesktop.org Summary: make check fail on lp_test_arit test Severity: normal Classification: Unclassified OS: Linux

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Christian König
Am 08.08.2013 16:33, schrieb Marek Olšák: On Thu, Aug 8, 2013 at 3:09 PM, Christian König wrote: Am 08.08.2013 14:38, schrieb Marek Olšák: .On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: Am 08.08.2013 02:20, schrieb Marek Olšák: FMASK is bound as a separate texture. For every text

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Michel Dänzer
On Don, 2013-08-08 at 08:00 -0700, Tom Stellard wrote: > On Thu, Aug 08, 2013 at 02:20:54AM +0200, Marek Olšák wrote: > > > > diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c > > b/src/gallium/drivers/radeonsi/si_state_draw.c > > index 746ace6..4208fa7 100644 > > --- a/src/gallium/driver

[Mesa-dev] [PATCH] gallivm: set non-existing values really to zero in size queries for d3d10

2013-08-08 Thread sroland
From: Roland Scheidegger My previous attempt at doing so double-failed miserably (minification of zero still gives one, and even if it would not the value was never written anyway). While here also rename the confusingly named int_vec bld as we have int vecs of different sizes, and rename need_nr

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Michel Dänzer
On Don, 2013-08-08 at 08:02 -0700, Tom Stellard wrote: > On Thu, Aug 08, 2013 at 01:51:39PM +0200, Marek Olšák wrote: > > Interleaving might not be a good idea, but they could be in the same > > array, like this: > > > > 0..15: textures > > 16..31: FMASK textures > > > > I'll test LLVM master, bu

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Tom Stellard
On Thu, Aug 08, 2013 at 02:20:54AM +0200, Marek Olšák wrote: > --- > src/gallium/drivers/radeonsi/radeonsi_shader.c | 7 ++-- > src/gallium/drivers/radeonsi/radeonsi_shader.h | 58 > ++ > src/gallium/drivers/radeonsi/si_state_draw.c | 1 + > 3 files changed, 36 inserti

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Tom Stellard
On Thu, Aug 08, 2013 at 02:20:54AM +0200, Marek Olšák wrote: > --- > src/gallium/drivers/radeonsi/radeonsi_shader.c | 7 ++-- > src/gallium/drivers/radeonsi/radeonsi_shader.h | 58 > ++ > src/gallium/drivers/radeonsi/si_state_draw.c | 1 + > 3 files changed, 36 inserti

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Tom Stellard
On Thu, Aug 08, 2013 at 01:51:39PM +0200, Marek Olšák wrote: > Interleaving might not be a good idea, but they could be in the same > array, like this: > > 0..15: textures > 16..31: FMASK textures > > I'll test LLVM master, but we should probably bump the LLVM version > requirement in configure.a

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Marek Olšák
On Thu, Aug 8, 2013 at 3:09 PM, Christian König wrote: > Am 08.08.2013 14:38, schrieb Marek Olšák: > >> .On Thu, Aug 8, 2013 at 9:47 AM, Christian König >> wrote: >>> >>> Am 08.08.2013 02:20, schrieb Marek Olšák: >>> FMASK is bound as a separate texture. For every texture, there can be

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Michel Dänzer
On Don, 2013-08-08 at 13:51 +0200, Marek Olšák wrote: > I'll test LLVM master, but we should probably bump the LLVM version > requirement in configure.ac to prevent users from using LLVM 3.3. That might be a good idea for the Mesa release after 9.2 anyway, but another possibility might be to only

Re: [Mesa-dev] [PATCH 12/20] radeonsi: implement MSAA colorbuffer compression for rendering

2013-08-08 Thread Michel Dänzer
On Don, 2013-08-08 at 13:44 +0200, Marek Olšák wrote: > Do you mean the surface_sync pm4 or the one in si_state? I mean this: diff --git a/src/gallium/drivers/radeonsi/r600_hw_context.c b/src/gallium/drivers/radeonsi/r600_hw_context.c index 25c972b..d9fc151 100644 --- a/src/gallium/drivers/radeo

Re: [Mesa-dev] [PATCH 15/20] radeonsi: add basic infrastructure for atom-based states

2013-08-08 Thread Marek Olšák
On Thu, Aug 8, 2013 at 2:55 PM, Christian König wrote: > Am 08.08.2013 14:02, schrieb Marek Olšák: > >> Why is the order so important? Note that cache flushes shouldn't be >> treated like states and neither should the draw packets and any state >> that comes from pipe_draw_info. The only things le

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Christian König
Am 08.08.2013 14:38, schrieb Marek Olšák: .On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: Am 08.08.2013 02:20, schrieb Marek Olšák: FMASK is bound as a separate texture. For every texture, there can be an FMASK. Therefore a separate array of resource slots has to be added. This adds

Re: [Mesa-dev] [PATCH 15/20] radeonsi: add basic infrastructure for atom-based states

2013-08-08 Thread Christian König
Am 08.08.2013 14:02, schrieb Marek Olšák: Why is the order so important? Note that cache flushes shouldn't be treated like states and neither should the draw packets and any state that comes from pipe_draw_info. The only things left are the register updates and resource updates where the order do

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Marek Olšák
.On Thu, Aug 8, 2013 at 9:47 AM, Christian König wrote: > Am 08.08.2013 02:20, schrieb Marek Olšák: > >> FMASK is bound as a separate texture. For every texture, there can be >> an FMASK. Therefore a separate array of resource slots has to be added. >> >> This adds a new mechanism for emitting res

Re: [Mesa-dev] [PATCH 15/20] radeonsi: add basic infrastructure for atom-based states

2013-08-08 Thread Marek Olšák
Why is the order so important? Note that cache flushes shouldn't be treated like states and neither should the draw packets and any state that comes from pipe_draw_info. The only things left are the register updates and resource updates where the order doesn't matter, does it? Anyway, the order is

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Marek Olšák
Interleaving might not be a good idea, but they could be in the same array, like this: 0..15: textures 16..31: FMASK textures I'll test LLVM master, but we should probably bump the LLVM version requirement in configure.ac to prevent users from using LLVM 3.3. Marek On Thu, Aug 8, 2013 at 10:37

Re: [Mesa-dev] [PATCH 12/20] radeonsi: implement MSAA colorbuffer compression for rendering

2013-08-08 Thread Marek Olšák
Do you mean the surface_sync pm4 or the one in si_state? Marek On Thu, Aug 8, 2013 at 10:31 AM, Michel Dänzer wrote: > On Don, 2013-08-08 at 02:20 +0200, Marek Olšák wrote: >> >> diff --git a/src/gallium/drivers/radeonsi/r600_hw_context.c >> b/src/gallium/drivers/radeonsi/r600_hw_context.c >> i

[Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Eric Anholt
Previously, we were asserting that each driver specified an NConfigOptions exactly equal to the number of options they supplied, leading to frequent bugs when people would forget to adjust the value when adjusting driver options. Instead, just overallocate the table by a bit and leave sanity check

Re: [Mesa-dev] [PATCH 00/20] MSAA support for Radeon SI and more

2013-08-08 Thread Michel Dänzer
On Don, 2013-08-08 at 02:21 +0200, Marek Olšák wrote: > > This is MSAA support for the radeonsi driver. It implements MSAA > rendering, texturing, and colorbuffer compression. The only missing > feature is the MSAA fast color clear; other than that, it operates at > maximum performance the hardwar

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Christian König
Am 08.08.2013 10:30, schrieb Michel Dänzer: On Don, 2013-08-08 at 02:20 +0200, Marek Olšák wrote: diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 746ace6..4208fa7 100644 --- a/src/gallium/drivers/radeonsi/si_state_draw.c +++ b/src/g

Re: [Mesa-dev] [PATCH 15/20] radeonsi: add basic infrastructure for atom-based states

2013-08-08 Thread Christian König
Am 08.08.2013 02:20, schrieb Marek Olšák: It's the same as in r600g. Look how simple it is. That concept has the problem that we don't necessary know in which order the state is emitted. Why not just add an "emit" callback to si_pm4_state for the short term instead? For the long term we s

Re: [Mesa-dev] [PATCH 12/20] radeonsi: implement MSAA colorbuffer compression for rendering

2013-08-08 Thread Michel Dänzer
On Don, 2013-08-08 at 02:20 +0200, Marek Olšák wrote: > > diff --git a/src/gallium/drivers/radeonsi/r600_hw_context.c > b/src/gallium/drivers/radeonsi/r600_hw_context.c > index 25c972b..382382b 100644 > --- a/src/gallium/drivers/radeonsi/r600_hw_context.c > +++ b/src/gallium/drivers/radeonsi/r600

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-08 Thread Michel Dänzer
On Don, 2013-08-08 at 02:20 +0200, Marek Olšák wrote: > > diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c > b/src/gallium/drivers/radeonsi/si_state_draw.c > index 746ace6..4208fa7 100644 > --- a/src/gallium/drivers/radeonsi/si_state_draw.c > +++ b/src/gallium/drivers/radeonsi/si_state_d

Re: [Mesa-dev] [PATCH 18/20] radeonsi: port texture improvements from r600g

2013-08-08 Thread Christian König
Am 08.08.2013 02:20, schrieb Marek Olšák: This started as an attempt to add support for MSAA texture transfers and MSAA depth-stencil decompression for the DB->CB copy path. It has gotten a bit out of control, but it's for the greater good. Some changes do not make much sense, they are there jus

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-08 Thread Christian König
Am 08.08.2013 02:20, schrieb Marek Olšák: FMASK is bound as a separate texture. For every texture, there can be an FMASK. Therefore a separate array of resource slots has to be added. This adds a new mechanism for emitting resource descriptors, its features are: - resource descriptors are stored