Re: [Mesa-dev] [PATCH] st/dri/sw: Fix pitch calculation in drisw_update_tex_buffer

2013-06-19 Thread Stéphane Marchesin
On Tue, Jun 18, 2013 at 8:41 AM, Richard Sandiford wrote: > swrastGetImage rounds the pitch up to 4 bytes for compatibility reasons > that are explained in drisw_glx.c:bytes_per_line, so drisw_update_tex_buffer > must do the same. > > Fixes window skew seen while running firefox over vnc on a 16-b

[Mesa-dev] [PATCH V3 2/2] i965: Enable ext_framebuffer_multisample_blit_scaled on intel h/w

2013-06-19 Thread Anuj Phogat
This patch enables ext_framebuffer_multisample_blit_scaled extension on intel h/w >= gen6. Note: Patches for piglit tests to verify this functionality are out for review on piglit mailing list. Comment history: Paul Berry on v1 of my implementation: "I have some concerns about the image quality o

[Mesa-dev] [PATCH V3 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-19 Thread Anuj Phogat
Current implementation of ext_framebuffer_multisample_blit_scaled in i965/blorp uses nearest filtering for multisample scaled blits. Using nearest filtering produces blocky artifacts and negates the benefits of MSAA. That is the reason why extension was not enabled on i965. This patch implements t

Re: [Mesa-dev] [PATCH] i965: Remove interleaved user array upload optimization

2013-06-19 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > The checks to determine when the data can be uploaded in an interleaved > fashion can be tricked by certain data layouts. For example, > > float data[...]; > > glVertexAttribPointer(0, 4, GL_FLOAT, GL_FALSE, 16, &data[0]); > glVertexAttr

[Mesa-dev] [PATCH 1/2] mesa: Move shader compiler API code to shaderapi.c

2013-06-19 Thread Eric Anholt
There was nothing ir_to_mesa-specific about this code, but it's not exactly part of the compiler's core turning-source-into-IR job either. v2: Split from the ir_to_mesa to glsl/ commit, avoid renaming the sh variable. Acked-by: Paul Berry (v1) --- src/mesa/main/shaderapi.c | 42 ++

[Mesa-dev] [PATCH 2/2] mesa: Move the common _mesa_glsl_compile_shader() code to glsl/.

2013-06-19 Thread Eric Anholt
This code had no relation to ir_to_mesa.cpp, since it was also used by intel and state_tracker, and most of it was duplicated with the standalone compiler (which has periodically drifted from the Mesa copy). v2: Split from the ir_to_mesa to shaderapi.c changes. Acked-by: Paul Berry (v1) --- src

Re: [Mesa-dev] [PATCH 5/6] mesa: Fix missing setting of shader->IsES.

2013-06-19 Thread Eric Anholt
Kenneth Graunke writes: > On 06/17/2013 04:10 PM, Eric Anholt wrote: >> I noticed this while trying to merge code with the builtin compiler, which >> does set it. >> >> Note that this causes two regressions in piglit in >> default-precision-sampler.* which try to link without a vertex or fragment

Re: [Mesa-dev] [PATCH 6/6] mesa: Move the common _mesa_glsl_compile_shader() code to glsl/.

2013-06-19 Thread Eric Anholt
Kenneth Graunke writes: > On 06/17/2013 04:10 PM, Eric Anholt wrote: >> ... and move the mesa-core-specific code into Mesa core. This code had no >> relation to ir_to_mesa.cpp, since it was also used by intel and >> state_tracker, and most of it was duplicated with the standalone compiler >> (wh

Re: [Mesa-dev] [PATCH 1/4] glsl: Add simple vector type accessor helpers.

2013-06-19 Thread Eric Anholt
Kenneth Graunke writes: > On 06/18/2013 06:47 AM, Ian Romanick wrote: >> On 06/18/2013 04:22 AM, Kenneth Graunke wrote: >>> This patch introduces new functions to quickly grab a pointer to a >>> vector type. For example: >>> >>> glsl_type::bvec(4) returns glsl_type::bvec4_type >>> gl

Re: [Mesa-dev] [PATCH 7/8] indices: add some comments

2013-06-19 Thread Roland Scheidegger
Am 19.06.2013 18:39, schrieb Brian Paul: > This is pretty complicated code with few/any comments. Here's a first stab. > --- > src/gallium/auxiliary/indices/u_indices.c | 23 > +--- > src/gallium/auxiliary/indices/u_unfilled_indices.c |9 +++- > 2 files changed

Re: [Mesa-dev] [PATCH 6/8] svga: reindent svga_tgsi.c

2013-06-19 Thread Roland Scheidegger
Am 19.06.2013 18:39, schrieb Brian Paul: > --- > src/gallium/drivers/svga/svga_tgsi.c | 128 > +- > 1 file changed, 65 insertions(+), 63 deletions(-) > > diff --git a/src/gallium/drivers/svga/svga_tgsi.c > b/src/gallium/drivers/svga/svga_tgsi.c > index 8bea7f8..

Re: [Mesa-dev] [PATCH 04/14] gallium: Document packed formats

2013-06-19 Thread Jose Fonseca
Series looks good to me too. Jose - Original Message - > Signed-off-by: Adam Jackson > --- > src/gallium/docs/format.rst | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/docs/format.rst b/src/gallium/docs/format.rst > index 2514656..e270d93 1

Re: [Mesa-dev] [PATCH 0/8] util: big-endian fixes for format generator

2013-06-19 Thread Jose Fonseca
- Original Message - > This series is a replacement for the util part of: > > http://lists.freedesktop.org/archives/mesa-dev/2013-May/039419.html > > It doesn't include any of the controversial format name parts of > those patches (although of course they're still needed in some form

Re: [Mesa-dev] [PATCH 03/13] gallium: Introduce 32-bit bytewise format names

2013-06-19 Thread Jose Fonseca
- Original Message - > Jose Fonseca writes: > > - Original Message - > >> On Sun, 2013-06-16 at 10:22 -0700, Jose Fonseca wrote: > >> > >> > Ok. I think this patch series is sound from an implementation POV. I > >> > see no point in delaying further. We can tweak things afterwar

[Mesa-dev] [PATCH 8/8] svga: add some comments about primitive conversion

2013-06-19 Thread Brian Paul
And clean up the svga_translate_prim() function with better variable names. --- src/gallium/drivers/svga/svga_draw_arrays.c |5 src/gallium/drivers/svga/svga_draw_private.h | 32 +- 2 files changed, 26 insertions(+), 11 deletions(-) diff --git a/src/gallium/dri

[Mesa-dev] [PATCH 5/8] svga: whitespace, comment, formatting fixes in svga_tgsi_emit.h

2013-06-19 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi_emit.h | 98 - 1 file changed, 56 insertions(+), 42 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_emit.h b/src/gallium/drivers/svga/svga_tgsi_emit.h index 949c39d..e36a955 100644 --- a/src/gallium/drivers/svga/sv

[Mesa-dev] [PATCH 7/8] indices: add some comments

2013-06-19 Thread Brian Paul
This is pretty complicated code with few/any comments. Here's a first stab. --- src/gallium/auxiliary/indices/u_indices.c | 23 +--- src/gallium/auxiliary/indices/u_unfilled_indices.c |9 +++- 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 6/8] svga: reindent svga_tgsi.c

2013-06-19 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi.c | 128 +- 1 file changed, 65 insertions(+), 63 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi.c b/src/gallium/drivers/svga/svga_tgsi.c index 8bea7f8..56529c6 100644 --- a/src/gallium/drivers/svga/svga_tgsi.c

[Mesa-dev] [PATCH 4/8] svga: move some svga/tgsi functions

2013-06-19 Thread Brian Paul
Move some functions from the svga_tgsi_insn.h header into the svga_tgsi_insn.c file since they're only used there. Plus, add comments and fix formatting. --- src/gallium/drivers/svga/svga_tgsi_decl_sm30.c | 20 src/gallium/drivers/svga/svga_tgsi_emit.h | 125 ---

[Mesa-dev] [PATCH 3/8] svga: formatting fixes in svga_tgsi_insn.c

2013-06-19 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi_insn.c | 655 + 1 file changed, 395 insertions(+), 260 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/drivers/svga/svga_tgsi_insn.c index f94f3b2..1e0579d 100644 --- a/src/gallium/drivers/svga/

[Mesa-dev] [PATCH 2/8] mesa: wrap comments, code to 78 columns in multisample.c

2013-06-19 Thread Brian Paul
--- src/mesa/main/multisample.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c index f4116ca..8b974c1 100644 --- a/src/mesa/main/multisample.c +++ b/src/mesa/main/multisample.c @@ -120,7 +120,8 @@ _

[Mesa-dev] [PATCH 1/8] mesa: remove unused BITSET64 macros

2013-06-19 Thread Brian Paul
--- src/mesa/main/bitset.h | 61 1 file changed, 61 deletions(-) diff --git a/src/mesa/main/bitset.h b/src/mesa/main/bitset.h index c3b060b..601fd0e 100644 --- a/src/mesa/main/bitset.h +++ b/src/mesa/main/bitset.h @@ -96,65 +96,4 @@ __bitset_ffs(

[Mesa-dev] [PATCH 2/2] radeonsi: Handle TGSI_OPCODE_DDX/Y using local memory

2013-06-19 Thread Michel Dänzer
From: Michel Dänzer 16 more little piglits. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 2 +- src/gallium/drivers/radeonsi/radeonsi_shader.c | 101 +++- src/gallium/drivers/radeonsi/radeonsi_shader.h | 1 + src/gallium/drivers/ra

[Mesa-dev] [PATCH v2 1/2] radeonsi: Handle TGSI_OPCODE_TXD

2013-06-19 Thread Michel Dänzer
From: Michel Dänzer One more little piglit. Signed-off-by: Michel Dänzer --- v2: Only use the new functionality as of LLVM 3.4. src/gallium/drivers/radeonsi/radeonsi_shader.c | 27 -- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r

[Mesa-dev] R600/SI: Support for local memory and derivatives

2013-06-19 Thread Michel Dänzer
These patches implement enough of local memory support to allow radeonsi to use that for computing derivatives, as suggested by Tom. They also almost allow test/CodeGen/R600/local-memory.ll to generate code for SI. Right now it still fails because it tries to copy a VGPR to an SGPR, which is not

[Mesa-dev] [PATCH] st/dri/sw: Fix pitch calculation in drisw_update_tex_buffer

2013-06-19 Thread Richard Sandiford
swrastGetImage rounds the pitch up to 4 bytes for compatibility reasons that are explained in drisw_glx.c:bytes_per_line, so drisw_update_tex_buffer must do the same. Fixes window skew seen while running firefox over vnc on a 16-bit screen. Signed-off-by: Richard Sandiford --- src/gallium/state

Re: [Mesa-dev] [PATCH 3/3] R600/SI: Expand sub for v2i32 and v4i32 for SI

2013-06-19 Thread Tom Stellard
On Mon, Jun 17, 2013 at 04:11:40PM -0500, Aaron Watry wrote: > Also add a v2i32 test to the existing v4i32 test. > > Note: v2i32 for EG seems slightly out of order based on the normal > ordering. i.e. "SUB_INT * T..." comes before the "SUB_INT T..." > I am not sure if this is correct, but it's how

Re: [Mesa-dev] [PATCH 2/3] R600/SI: Expand add for v2i32 and v4i32

2013-06-19 Thread Tom Stellard
On Mon, Jun 17, 2013 at 04:11:39PM -0500, Aaron Watry wrote: > Also add SI tests to existing file and a v2i32 test for both > R600 and SI. > Reviewed-by: Tom Stellard > Signed-off-by: Aaron Watry > --- > lib/Target/R600/SIISelLowering.cpp | 2 ++ > test/CodeGen/R600/add.ll | 37 +

Re: [Mesa-dev] [PATCH 1/3] R600: Expand v2i32 load/store instead of custom lowering

2013-06-19 Thread Tom Stellard
On Mon, Jun 17, 2013 at 04:11:38PM -0500, Aaron Watry wrote: > The custom lowering causes llc to crash with a segfault. > > Ideally, the custom lowering can be fixed, but this allows > programs which load/store v2i32 to work without crashing. > > Signed-off-by: Aaron Watry > --- > lib/Target/R60

Re: [Mesa-dev] [PATCH] R600/SI: Add support for v4i32 and v4f32 kernel args

2013-06-19 Thread Tom Stellard
On Tue, Jun 18, 2013 at 08:26:53PM -0500, Aaron Watry wrote: > Tested on Pitcairn by: Aaron Watry > Thanks. > Follow-up question: Would it be as easy as it looks to add v2i32 right away? > I think so. -Tom > On Tue, Jun 18, 2013 at 6:21 PM, Tom Stellard wrote: > > From: Tom Stellard > > > >

Re: [Mesa-dev] [PATCH 1/2] gallium: fix PIPE_QUERY_TIMESTAMP_DISJOINT

2013-06-19 Thread Jose Fonseca
- Original Message - > > > - Original Message - > > From: Roland Scheidegger > > > > The semantics didn't really make sense, not really matching neither d3d9 > > (though the docs are all broken there) nor d3d10. So make it match d3d10 > > semantics, which actually gives meanin

Re: [Mesa-dev] [PATCH 2/2] softpipe: handle all queries, and change for the new disjoint semantics

2013-06-19 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > From: Roland Scheidegger > > The driver can do render_condition but wasn't handling the occlusion > and so_overflow predicates (though the latter might not work yet due > to gs support). > --- > src/gallium/drivers/softpipe/sp_query.c | 3

Re: [Mesa-dev] [PATCH 1/2] gallium: fix PIPE_QUERY_TIMESTAMP_DISJOINT

2013-06-19 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > The semantics didn't really make sense, not really matching neither d3d9 > (though the docs are all broken there) nor d3d10. So make it match d3d10 > semantics, which actually gives meaning to the "disjoint" part. > Drivers are fixed u

Re: [Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-06-19 Thread Marek Olšák
Could somebody please review this series? Marek On Thu, Jun 13, 2013 at 2:25 PM, Marek Olšák wrote: > Hi everyone, > > this series adds a new GLSL compiler optimization pass which eliminates > unused and set-but-unused built-in varyings and adds a few improvements to > the GLSL linker in the p

[Mesa-dev] [PATCH] i965: Remove interleaved user array upload optimization

2013-06-19 Thread Ian Romanick
From: Ian Romanick The checks to determine when the data can be uploaded in an interleaved fashion can be tricked by certain data layouts. For example, float data[...]; glVertexAttribPointer(0, 4, GL_FLOAT, GL_FALSE, 16, &data[0]); glVertexAttribPointer(1, 4, GL_FLOAT, GL_FALSE, 16

Re: [Mesa-dev] [PATCH] prog_parameter.c ASAN Patch

2013-06-19 Thread Myles C. Maxfield
Any word on this? Thanks, Myles On Mon, Jun 17, 2013 at 12:09 PM, Myles C. Maxfield < myles.maxfi...@gmail.com> wrote: > Sure. I was under the impression that |size| couldn't be both greater than > 4 and a non-multiple of 4, but I've reworked the patch to incorporate this > and to be a little m