Re: [Mesa-dev] [PATCH 2/2] radeon/llvm: add store.vertex.{position, param} intrinsics

2012-12-16 Thread Vadim Girlin
I think it would be more efficient and correct to set EOP and change EXPORT to EXPORT_DONE in some separate pass that will handle all exports at once instead of iterating through instructions for every export, probably later it will be done by the instruction scheduler (when we'll have one). Also,

Re: [Mesa-dev] [PATCH 1/2] radeon/llvm: add an intrinsic converting clipvertex to clipdistance

2012-12-16 Thread Vadim Girlin
I think the clipvertex emulation via clipdistance is rather a driver's job and compiler shouldn't be aware of that, driver should simply emit all corresponding DOT's and exports. As for the kcache regs, in your patch it looks like you are going to hardcode some logic to access another const buffer

[Mesa-dev] [PATCH] mesa osmesa/x11: fix build error introduced in 4bea4cb9

2012-12-16 Thread Jordan Justen
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=58380 Signed-off-by: Jordan Justen Cc: Vinson Lee --- src/mesa/drivers/osmesa/osmesa.c | 10 +- src/mesa/drivers/x11/xm_api.c|6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/osmesa/osm

[Mesa-dev] [Bug 58380] osmesa.c:794: error: ‘ctx’ undeclared

2012-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58380 Jordan Justen changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |jljus...@gmail.com |or

[Mesa-dev] [Bug 58380] New: osmesa.c:794: error: ‘ctx’ undeclared

2012-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58380 Priority: medium Bug ID: 58380 Keywords: regression CC: jljus...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: osmesa.c:794: error: ‘ctx’ undeclared Sever

[Mesa-dev] [PATCH 2/2] r600g: tgsi to llvm emits vertex export

2012-12-16 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_llvm.c | 119 --- src/gallium/drivers/r600/r600_shader.c | 11 ++- src/gallium/drivers/radeon/radeon_llvm.h | 1 + 3 files changed, 120 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/ga

[Mesa-dev] [PATCH 1/2] r600g: tgsi to llvm emits stream output intrinsics.

2012-12-16 Thread Vincent Lejeune
--- src/gallium/drivers/r600/eg_asm.c| 2 ++ src/gallium/drivers/r600/r600_asm.c | 2 ++ src/gallium/drivers/r600/r600_llvm.c | 20 src/gallium/drivers/r600/r600_shader.c | 3 ++- src/gallium/drivers/radeon/radeon_llvm.h | 1 + 5 files changed, 27 insert

[Mesa-dev] [PATCH 2/2] radeon/llvm: add store.vertex.{position, param} intrinsics

2012-12-16 Thread Vincent Lejeune
--- lib/Target/AMDGPU/R600ISelLowering.cpp| 51 +++ lib/Target/AMDGPU/R600Instructions.td | 5 +++ lib/Target/AMDGPU/R600Intrinsics.td | 4 +++ lib/Target/AMDGPU/R600MachineFunctionInfo.cpp | 1 + lib/Target/AMDGPU/R600MachineFunctionInfo.h |

[Mesa-dev] [PATCH 1/2] radeon/llvm: add an intrinsic converting clipvertex to clipdistance

2012-12-16 Thread Vincent Lejeune
--- lib/Target/AMDGPU/R600ISelLowering.cpp | 21 - lib/Target/AMDGPU/R600Instructions.td | 12 lib/Target/AMDGPU/R600Intrinsics.td| 2 ++ lib/Target/AMDGPU/R600RegisterInfo.td | 21 - 4 files changed, 54 insertions(+), 2 deletions(-) dif

Re: [Mesa-dev] [PATCH 1/3] mesa: implement GL_ARB_texture_buffer_range

2012-12-16 Thread Christoph Bumiller
On 16.12.2012 18:10, Brian Paul wrote: > On Sun, Dec 16, 2012 at 9:50 AM, Christoph Bumiller > wrote: >> --- >> src/mapi/glapi/gen/ARB_texture_buffer_range.xml | 22 ++ >> src/mapi/glapi/gen/Makefile.am |1 + >> src/mapi/glapi/gen/gl_API.xml |2 + >

Re: [Mesa-dev] [PATCH 1/3] mesa: implement GL_ARB_texture_buffer_range

2012-12-16 Thread Marek Olšák
On Sun, Dec 16, 2012 at 6:11 PM, Marek Olšák wrote: > On Sun, Dec 16, 2012 at 5:50 PM, Christoph Bumiller > wrote: >> --- >> src/mapi/glapi/gen/ARB_texture_buffer_range.xml | 22 ++ >> src/mapi/glapi/gen/Makefile.am |1 + >> src/mapi/glapi/gen/gl_API.xml

Re: [Mesa-dev] [PATCH 3/3] st/mesa: add support for GL_ARB_texture_buffer_range

2012-12-16 Thread Brian Paul
On Sun, Dec 16, 2012 at 9:50 AM, Christoph Bumiller wrote: > --- > src/mesa/state_tracker/st_atom_texture.c | 15 ++- > src/mesa/state_tracker/st_extensions.c |6 ++ > 2 files changed, 20 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/state_tracker/st_atom_texture

Re: [Mesa-dev] [PATCH 2/3] gallium: add PIPE_CAP_TEXTURE_BUFFER_OFFSET_ALIGNMENT

2012-12-16 Thread Brian Paul
On Sun, Dec 16, 2012 at 9:50 AM, Christoph Bumiller wrote: > --- > src/gallium/docs/source/screen.rst |3 +++ > src/gallium/include/pipe/p_defines.h |3 ++- > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/src/gallium/docs/source/screen.rst > b/src/gallium/docs/sourc

Re: [Mesa-dev] [PATCH 1/3] mesa: implement GL_ARB_texture_buffer_range

2012-12-16 Thread Marek Olšák
On Sun, Dec 16, 2012 at 5:50 PM, Christoph Bumiller wrote: > --- > src/mapi/glapi/gen/ARB_texture_buffer_range.xml | 22 ++ > src/mapi/glapi/gen/Makefile.am |1 + > src/mapi/glapi/gen/gl_API.xml |2 + > src/mesa/main/context.c

Re: [Mesa-dev] [PATCH 1/3] mesa: implement GL_ARB_texture_buffer_range

2012-12-16 Thread Brian Paul
On Sun, Dec 16, 2012 at 9:50 AM, Christoph Bumiller wrote: > --- > src/mapi/glapi/gen/ARB_texture_buffer_range.xml | 22 ++ > src/mapi/glapi/gen/Makefile.am |1 + > src/mapi/glapi/gen/gl_API.xml |2 + > src/mesa/main/context.c

[Mesa-dev] [PATCH 3/3] st/mesa: add support for GL_ARB_texture_buffer_range

2012-12-16 Thread Christoph Bumiller
--- src/mesa/state_tracker/st_atom_texture.c | 15 ++- src/mesa/state_tracker/st_extensions.c |6 ++ 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/st_atom_texture.c index dba1d82..bd2135f 1

[Mesa-dev] [PATCH 2/3] gallium: add PIPE_CAP_TEXTURE_BUFFER_OFFSET_ALIGNMENT

2012-12-16 Thread Christoph Bumiller
--- src/gallium/docs/source/screen.rst |3 +++ src/gallium/include/pipe/p_defines.h |3 ++- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst index 6c89171..f520704 100644 --- a/src/gallium/docs/source/

[Mesa-dev] [PATCH 1/3] mesa: implement GL_ARB_texture_buffer_range

2012-12-16 Thread Christoph Bumiller
--- src/mapi/glapi/gen/ARB_texture_buffer_range.xml | 22 ++ src/mapi/glapi/gen/Makefile.am |1 + src/mapi/glapi/gen/gl_API.xml |2 + src/mesa/main/context.c |1 + src/mesa/main/extensions.c |1 +

Re: [Mesa-dev] [PATCH v2 6/6] mesa: Make a function is_transform_feedback_active_and_unpaused.

2012-12-16 Thread Paul Berry
On 16 December 2012 07:49, Brian Paul wrote: > On Sat, Dec 15, 2012 at 11:09 PM, Paul Berry > wrote: > > The rather unweildy logic for determining this condition was repeated > > in a large number of places. This patch consolidates it to a single > > inline function. > > > > > > @@ -111,4 +113,

Re: [Mesa-dev] [PATCH v2 2/6] mesa: refactor _mesa_compute_max_transform_feedback_vertices from i965.

2012-12-16 Thread Paul Berry
On 16 December 2012 07:43, Brian Paul wrote: > On Sat, Dec 15, 2012 at 11:09 PM, Paul Berry > wrote: > > Previously, the i965 driver contained code to compute the maximum > > number of vertices that could be written without overflowing any > > transform feedback buffers. This code wasn't driver

Re: [Mesa-dev] [PATCH 2/2] r600g: add htile support v14

2012-12-16 Thread Marek Olšák
The patch looks good mostly. There are some comments below. > diff --git a/src/gallium/drivers/r600/evergreen_state.c > b/src/gallium/drivers/r600/evergreen_state.c > index 58964c4..39de55b 100644 > --- a/src/gallium/drivers/r600/evergreen_state.c > +++ b/src/gallium/drivers/r600/evergreen_state.

Re: [Mesa-dev] [PATCH] vega: fix for object handle leak

2012-12-16 Thread Brian Paul
On Sat, Dec 15, 2012 at 3:48 PM, Andreas Pokorny wrote: > Hello, > I have been chasing a leak with OpenVG mesa-8.0.5. > > Massif gave me the following stack: > ->09.66% (3,471,568B) 0xB706B80: util_hash_table_set (u_hash_table.c:163) > | ->09.66% (3,471,568B) 0xB4E106F: create_handle (handle.c:83)

Re: [Mesa-dev] [PATCH v2 1/6] mesa: Change args to vbo_count_tessellated_primitives.

2012-12-16 Thread Brian Paul
On Sat, Dec 15, 2012 at 11:09 PM, Paul Berry wrote: > No functional change--this simply paves the way to allow futures > patches to call vbo_count_tessellated_primitives() during error > checking, before the _mesa_prim struct has been constructed. > > This will be needed for GLES3, which requires

Re: [Mesa-dev] [PATCH v2 6/6] mesa: Make a function is_transform_feedback_active_and_unpaused.

2012-12-16 Thread Brian Paul
On Sat, Dec 15, 2012 at 11:09 PM, Paul Berry wrote: > The rather unweildy logic for determining this condition was repeated > in a large number of places. This patch consolidates it to a single > inline function. > > @@ -111,4 +113,11 @@ _mesa_PauseTransformFeedback(void); > extern void GLAPIE

Re: [Mesa-dev] [PATCH v2 2/6] mesa: refactor _mesa_compute_max_transform_feedback_vertices from i965.

2012-12-16 Thread Brian Paul
On Sat, Dec 15, 2012 at 11:09 PM, Paul Berry wrote: > Previously, the i965 driver contained code to compute the maximum > number of vertices that could be written without overflowing any > transform feedback buffers. This code wasn't driver-specific, and for > GLES3 support we're going to need to

Re: [Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-16 Thread Marek Olšák
ctx->Const.UniformBufferOffsetAlignment should be set to PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT. I added the cap exactly for that purpose. The default value for UniformBufferOffsetAlignment is 1, but R600 requires the alignment to be 256 bytes. The other 3 UBO limits in Const could also be set

Re: [Mesa-dev] [PATCH 1/2] r600g: rework flusing and synchronization pattern v5

2012-12-16 Thread Marek Olšák
Please see the inline comments below. On Fri, Dec 14, 2012 at 12:13 AM, wrote: > From: Jerome Glisse > > This bring r600g allmost inline with closed source driver when > it comes to flushing and synchronization pattern. > > v2-v4: history lost somewhere in outer space > v5: Fix compute size of

Re: [Mesa-dev] [PATCH 2/2] r600g: texture buffer object + glsl 1.40 enable support

2012-12-16 Thread Dave Airlie
On Sun, Dec 16, 2012 at 8:33 PM, Dave Airlie wrote: > From: Dave Airlie > > This adds TBO support to r600g, and with GLSL 1.40 enabled, > we now get 3.1 core profiles advertised for r600g. > > This code is evergreen only so far, but I don't think there is > much to make it work on r600/700/cayman

[Mesa-dev] [PATCH 2/2] r600g: texture buffer object + glsl 1.40 enable support

2012-12-16 Thread Dave Airlie
From: Dave Airlie This adds TBO support to r600g, and with GLSL 1.40 enabled, we now get 3.1 core profiles advertised for r600g. This code is evergreen only so far, but I don't think there is much to make it work on r600/700/cayman other than testing. a) buffer txq is broken like cube map txq,

[Mesa-dev] [PATCH 1/2] r600g: uniform buffer object support

2012-12-16 Thread Dave Airlie
From: Dave Airlie This adds 12 more constant buffers for use as UBOs, along with adding relative constant fetching for 2D indices. This with GLSL 1.40 enabled passes all the same tests as softpipe on my evergreen system. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.h |

[Mesa-dev] [rfc] r600g evergreen tbo/ubo/glsl140 = GL 3.1 core profiles

2012-12-16 Thread Dave Airlie
These two patches implement UBO and TBO for evergreen GPUs, Once I get some time to swap around some GPUs I hope to test and implement on the full range from r600->cayman. Also enabling GLSL 1.40 has the side effect of piglit dying in a tf-no-position test which I'd also like to track down before

Re: [Mesa-dev] [PATCH v2 0/6] GLES3 transform feedback fixes.

2012-12-16 Thread Jordan Justen
Reviewed-by: Jordan Justen On Sat, Dec 15, 2012 at 10:09 PM, Paul Berry wrote: > Here's an update on my patch series from yesterday. I've made the > following changes: > > - In patch 2, I had accidentaly included some C++-style variable > declarations. These don't work with MSVC, so I change