Re: [Mesa-dev] [PATCH 4/6] Bitwise conversion operator support in ir_constant_expression.

2012-05-19 Thread Olivier Galibert
On Sat, May 19, 2012 at 11:59:24AM -0700, Jose Fonseca wrote: > > > - Original Message - > > +/* This method is the only one supported by gcc. Unions in > > particular > > + * are iffy, and read-through-converted-pointer is killed by strict > > + * aliasing. OTOH, the compiler sees thro

Re: [Mesa-dev] [PATCH 4/6] Bitwise conversion operator support in ir_constant_expression.

2012-05-19 Thread Jose Fonseca
- Original Message - > This patch expects to be applied after the "Constants through > builtins > evaluation rewrite" for two reasons: > - a line of that patch appears in the context > - the ir_function side changes that the old method would need are not > present (and they would confli

Re: [Mesa-dev] [PATCH 5/6] Bitwise conversion operator support in the software renderers.

2012-05-19 Thread Jose Fonseca
- Original Message - > TGSI doesn't need an opcode, since registers are untyped (but beware > once doubles come into the scene). That's correct. This patch looks good. Doubles will likely be handled similarly, with the difference that will. BTW, I believe there were some patches for d

[Mesa-dev] [PATCH] glsl/constant propagation: kill whole var if LHS involves array indexing.

2012-05-19 Thread Paul Berry
When considering which components of a variable were killed by an assignment, constant propagation would previously just use the write mask of the assignment. This worked if the LHS of the assignment was simple, e.g.: v.xy = ...; // (assign (xy) (var_ref v) ...) But it did the wrong thing if the

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release() in st_destroy_context_priv()

2012-05-19 Thread Jose Fonseca
Sounds good. Jose - Original Message - > Fixes another case of sampler views being created by one context, > shared by another, then deleted by the first, leaving a dangling > pipe context pointer. > --- > src/mesa/state_tracker/st_context.c |2 +- > 1 files changed, 1 insertions(+),

Re: [Mesa-dev] [PATCH 2/2] mesa: use F_TO_I() instead of IROUND()

2012-05-19 Thread Jose Fonseca
The IROUND implementation fix looks good. Concerning this F_TO_I thought, I wonder if rounding to nearest was the true intention below, and we just happened to be lucky so far. Anyway, easy to revert to IROUND as needed, and not terribly important. Jose - Original Message - > Use it w

Re: [Mesa-dev] [PATCH 1/2] mesa: Keep a computed value for dual source blend func with each buffer.

2012-05-19 Thread Kenneth Graunke
On 05/18/2012 08:00 PM, Eric Anholt wrote: The i965 driver needed this as well for hardware setup, so instead of duplicating the logic, just save it off. --- src/mesa/main/blend.c | 20 src/mesa/main/context.c | 24 +++- src/mesa/main/mtypes.h |

Re: [Mesa-dev] [PATCH] mesa: fix Z32_FLOAT -> uint conversion functions

2012-05-19 Thread Jose Fonseca
Looks good. Jose - Original Message - > The IROUND converted all arguments to 0 or 1. That's not what we > wanted. > > NOTE: This is a candidate for the 8.0 branch. > --- > src/mesa/main/format_unpack.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/s