https://bugs.freedesktop.org/show_bug.cgi?id=33758
--- Comment #3 from nobled 2011-06-24 18:29:49 PDT ---
This patch by ajax back in May seems relevant, BTW. I'll test it (and Chad's
patches) when I get a chance.
http://lists.freedesktop.org/archives/mesa-dev/2011-May/007353.html
--
Configure
If CreateDRIDrawable fails, then return 0 as the GLXDrawable.
Cc: nob...@dreamwidth.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=33758
Note: This is candidate for the stable branch.
Signed-off-by: Chad Versace
---
src/glx/glx_pbuffer.c | 17 +++--
1 files changed, 11
If a calleé returns null, then free local memory and return false.
Cc: nob...@dreamwidth.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=33758
Note: This is a candidate for the stable branch.
Signed-off-by: Chad Versace
---
src/glx/drisw_glx.c | 19 ++-
1 files chang
nobled, try these patches and let us know if they fix the problem.
Chad Versace (2):
drisw: Do error checking in XCreateDrawable
glx: Do error checking in CreateDrawable
src/glx/drisw_glx.c | 19 ++-
src/glx/glx_pbuffer.c | 17 +++--
2 files changed, 29 inse
On Fri, 24 Jun 2011 17:35:10 -0700, "Ian Romanick" wrote:
> From: Ian Romanick
>
> And don't delete them. Let ralloc clean them up. Deleting the
> temporary IR leaves dangling references in the prog_instruction. That
> results in a bad dererfernce when printing the IR with MESA_GLSL=dump.
de
On Fri, 24 Jun 2011 12:42:50 -0700, Ben Widawsky wrote:
> Upload the system routine as part of the invariant state if debugging.
>
> Remove SIP setting if not debugging to make it more friendly for others
> that may be debugging shaders or media kernels.
Instructions are from an offset of the br
On Fri, 24 Jun 2011 12:42:48 -0700, Ben Widawsky wrote:
> The debugger shared memory needs to be a fixed size. Since this is
> scratch memory that is already used by register spilling, add
> appropriate hooks to do the right thing when debugging.
>
> Also copy in a binary blob system routine base
From: Ian Romanick
NOTE: This is a candidate for the 7.10 branch.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38584
---
src/glsl/ir_print_visitor.cpp |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visit
From: Ian Romanick
And don't delete them. Let ralloc clean them up. Deleting the
temporary IR leaves dangling references in the prog_instruction. That
results in a bad dererfernce when printing the IR with MESA_GLSL=dump.
NOTE: This is a candidate for the 7.10 branch.
Bugzilla: https://bugs.
On Fri, 24 Jun 2011 12:42:47 -0700, Ben Widawsky wrote:
> The system routine requires m0 be reserved. for saving off architectural
> state. Moved the allocation to start at 2 instead of 0.
>
> Signed-off-by: Ben Widawsky
Reviewed-by: Eric Anholt
pgpfodX6AC5FB.pgp
Description: PGP signature
_
On 06/24/2011 01:17 PM, Dan McCabe wrote:
On 06/20/2011 03:50 PM, Ian Romanick wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/17/2011 05:43 PM, Dan McCabe wrote:
Beware! Here be dragons!
I think this will generate the wrong code for:
for (i = 0; i< 10; i++) {
switc
If we happened to allocate a texture result (or other vector) to the
highest hardware register slot, and we were in 16-wide, we would
under-count the registers used and potentially wrap around to g0 if
that allocation crossed a 16-register block boundary.
Noticed in looking into a shader from idr
On 06/24/2011 11:38 PM, Jerome Glisse wrote:
On Fri, Jun 24, 2011 at 12:29 PM, Vadim Girlin wrote:
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=38440
Signed-off-by: Vadim Girlin
As discussed previously, there is better to handle this. I think best
solution is to always add the instruct
Improves firefox-talos-gfx around 5%.
---
This patch regresses glean/fbo and these two ARB_cbf runs:
./bin/arb_color_buffer_float-render GL_RGBA8 fog
./bin/arb_color_buffer_float-render GL_RGBA8 sanity fog
I'd love if anyone else could take a look at it and figure out what's
going on here. Unfo
We almost never want to specify a condition, and when we do we're
already thinking about it (because we're writing a lowering pass
generating the condition), so a default argument should make the code
more pleasant to read.
---
src/glsl/ir.h |2 +-
1 files changed, 1 insertions(+), 1 deletions
---
src/glsl/lower_mat_op_to_vec.cpp | 32
1 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/src/glsl/lower_mat_op_to_vec.cpp b/src/glsl/lower_mat_op_to_vec.cpp
index 9d593f9..a371afc 100644
--- a/src/glsl/lower_mat_op_to_vec.cpp
+++ b/src/glsl/lowe
We were constrained to using temporaries because we were assuming
variables all over. This simplifies things a bit.
---
src/glsl/lower_mat_op_to_vec.cpp | 127 +-
1 files changed, 56 insertions(+), 71 deletions(-)
diff --git a/src/glsl/lower_mat_op_to_vec.cpp
Our copy propagation tends to be bad at handling the later array
accesses of the matrix argument we moved to a temporary. Generally we
don't need to move it to a temporary, though, so this avoids needing
more copy propagation complexity.
Reduces instruction count of some Unigine Tropics and Sanct
This awkward typing was to avoid shadowing the function argument (the
matrix) with the temporary deref (the column) before the
get_column()/get_element()s were moved into the expression/assignment
constructors. They're about to become not-variables, so the current
names had to go. This change is
I think this makes the code more obvious by moving the declarations to
their single usage (now that we aren't using them to get at the ->type
field for expression constructors).
---
src/glsl/lower_mat_op_to_vec.cpp | 65 +-
1 files changed, 22 insertions(+), 4
The constructor can figure it out for us these days.
---
src/glsl/lower_mat_op_to_vec.cpp | 33 ++---
1 files changed, 6 insertions(+), 27 deletions(-)
diff --git a/src/glsl/lower_mat_op_to_vec.cpp b/src/glsl/lower_mat_op_to_vec.cpp
index 8cbbfa7..bf3915e 100644
---
On Fri, Jun 24, 2011 at 12:29 PM, Vadim Girlin wrote:
> #1 fixes slots order for x & y writes in the LIT implementation.
> Without this patch "fp-lit-mask" piglit test fails after patch 3. It seems
> wrong order causes wrong PV.* values for the next instruction.
>
> #2 reduces unneeded calls to r6
On 06/20/2011 03:50 PM, Ian Romanick wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/17/2011 05:43 PM, Dan McCabe wrote:
Beware! Here be dragons!
I think this will generate the wrong code for:
for (i = 0; i< 10; i++) {
switch (i) {
https://bugs.freedesktop.org/show_bug.cgi?id=38622
Kristian Høgsberg changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
On 06/20/2011 03:34 PM, Ian Romanick wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/17/2011 05:43 PM, Dan McCabe wrote:
We now tie the grammar to the ctors of the ASTs they reference.
This requires that we actually have definitions of the ctors.
In addition, we also need to define
On 06/20/2011 03:31 PM, Ian Romanick wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/17/2011 05:43 PM, Dan McCabe wrote:
+
+ exec_list cases;
What types are in this list? If this is a list of ast_case_statements,
there should be a comment to that effect. We've been really sloppy
On 06/20/2011 03:39 PM, Ian Romanick wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/17/2011 05:43 PM, Dan McCabe wrote:
The grammar is modified to support switch statements. Rather than follow the
grammar in the appendix, which allows case labels to be placed ANYWHERE
as a regular s
Use unix domain sockets to connect to a debugger and send the
information the debugger will use to properly handle debug events.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_wm_debug.c | 66 -
1 files changed, 63 insertions(+), 3 deletions(-)
diff
Provide a function to allow emitting breakpoints in the instruction
oword. Use breakpoints when debugging.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_eu.c |6 ++
src/mesa/drivers/dri/i965/brw_eu.h |1 +
src/mesa/drivers/dri/i965/brw_wm.c |3 +++
3 files changed
Upload the system routine as part of the invariant state if debugging.
Remove SIP setting if not debugging to make it more friendly for others
that may be debugging shaders or media kernels.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_misc_state.c | 24 +++---
Since the debug system routine will share scratch space with threads
doing register spilling, we must offset the registers to accomodate.
This is more easily accomplished (and less bug prone) in Mesa, so there
you go...
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_fs_emit.cpp |
The debugger shared memory needs to be a fixed size. Since this is
scratch memory that is already used by register spilling, add
appropriate hooks to do the right thing when debugging.
Also copy in a binary blob system routine based on an environment
variable. This blob will need to be relocated,
The system routine requires m0 be reserved. for saving off architectural
state. Moved the allocation to start at 2 instead of 0.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/mesa
On Fri, Jun 24, 2011 at 12:29 PM, Vadim Girlin wrote:
> #1 fixes slots order for x & y writes in the LIT implementation.
> Without this patch "fp-lit-mask" piglit test fails after patch 3. It seems
> wrong order causes wrong PV.* values for the next instruction.
>
> #2 reduces unneeded calls to r6
On Fri, Jun 24, 2011 at 12:29 PM, Vadim Girlin wrote:
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=38440
>
> Signed-off-by: Vadim Girlin
As discussed previously, there is better to handle this. I think best
solution is to always add the instruction and to conditionally execute
them thank
https://bugs.freedesktop.org/show_bug.cgi?id=38622
Ian Romanick changed:
What|Removed |Added
Severity|major |normal
Priority|highest
https://bugs.freedesktop.org/show_bug.cgi?id=38622
--- Comment #2 from Ian Romanick 2011-06-24 11:09:26 PDT
---
(In reply to comment #1)
> I can't reproduce this with the egl x11 demos from mesa/demos.
> Also I dont see what could effect that in the bisected commit.
>
> Anyway, would give more
On 06/24/2011 11:27 AM, Eric Anholt wrote:
On Thu, 23 Jun 2011 19:08:51 -0600, Brian Paul wrote:
I'd like to overhaul the part of Mesa related to texture memory
reading/writing.
The basic idea would be to add two new driver functions:
/**
* Map a 2D slice of a texture image into user spac
On Thu, 23 Jun 2011 19:08:51 -0600, Brian Paul wrote:
>
> I'd like to overhaul the part of Mesa related to texture memory
> reading/writing.
>
> The basic idea would be to add two new driver functions:
>
> /**
> * Map a 2D slice of a texture image into user space.
> * (x,y,w,h) defines a r
https://bugs.freedesktop.org/show_bug.cgi?id=33203
Sven Arvidsson changed:
What|Removed |Added
CC||s...@whiz.se
--- Comment #4 from Sven A
https://bugs.freedesktop.org/show_bug.cgi?id=33204
Sven Arvidsson changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugs.freedesktop.org/show_bug.cgi?id=38626
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=38440
Signed-off-by: Vadim Girlin
---
src/gallium/drivers/r600/evergreen_state.c |2 +
src/gallium/drivers/r600/r600_pipe.c |2 +-
src/gallium/drivers/r600/r600_pipe.h |7 +++-
src/gallium/drivers/r600/r600_shader.c
Signed-off-by: Vadim Girlin
---
src/gallium/drivers/r600/r600_pipe.h |1 +
src/gallium/drivers/r600/r600_state_common.c | 10 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_pipe.h
b/src/gallium/drivers/r600/r600_pipe.h
index
Signed-off-by: Vadim Girlin
---
src/gallium/drivers/r600/r600_shader.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_shader.c
b/src/gallium/drivers/r600/r600_shader.c
index 86fdfbc..904cc69 100644
--- a/src/gallium/d
#1 fixes slots order for x & y writes in the LIT implementation.
Without this patch "fp-lit-mask" piglit test fails after patch 3. It seems
wrong order causes wrong PV.* values for the next instruction.
#2 reduces unneeded calls to r600_spi_update.
#3 implements color clamping in shaders by addin
https://bugs.freedesktop.org/show_bug.cgi?id=37253
--- Comment #8 from Sven Arvidsson 2011-06-24 09:19:19 PDT ---
I have tried the conformance test with Firefox 7.0a1 and Mesa
c0c0bb6cb140825f5bab3c40c0c9c0ec575fbc76
r600g on a HD5670:
Results: (5665 of 5785 passed, 2 timed out)
r300g on a RV57
On 06/24/2011 09:58 AM, Marek Olšák wrote:
On Fri, Jun 24, 2011 at 3:15 PM, Brian Paul wrote:
On 06/23/2011 08:39 PM, Marek Olšák wrote:
NOTE: This is a candidate for the 7.10 branch.
---
src/mesa/main/texstore.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --gi
On Fri, Jun 24, 2011 at 3:15 PM, Brian Paul wrote:
> On 06/23/2011 08:39 PM, Marek Olšák wrote:
>>
>> NOTE: This is a candidate for the 7.10 branch.
>> ---
>> src/mesa/main/texstore.c | 9 ++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/mesa/main/texstore.c
On 06/24/2011 07:19 AM, Marc Pignat wrote:
This patch add the support for 24bpp in the dri/swrast implementation.
Signed-off-by: Marc Pignat
Pushed. Thanks. Can you close the relevant bugs if they check out?
-Brian
___
mesa-dev mailing list
mesa-
On 06/22/2011 06:31 AM, Alon Levy wrote:
Signed-off-by: Alon Levy
---
src/gallium/tests/trivial/Makefile |9 +++--
src/gallium/tests/trivial/quad-tex.c |4 ++--
src/gallium/tests/trivial/tri.c |4 ++--
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/src
This patch add the support for 24bpp in the dri/swrast implementation.
Signed-off-by: Marc Pignat
---
Hi all!
I think it is important because users of KVM or QEMU use this mode as
the default.
Here is a small list of bugs that should be fixed by this patch:
* https://bugs.freedesktop.org/show
BTW, the same treatment could probably be given to a few other
object types, like texture objects and buffer objects.
-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 06/23/2011 11:22 PM, Dave Airlie wrote:
From: Dave Airlie
inline the hotpath of the reference remaining the same, this shouldn't
penalise the slow path at all but improve the hot path so we don't have
to jump to the function.
It also moves some assert checks under an #ifndef NDEBUG.
Signed-
On 06/23/2011 08:39 PM, Marek Olšák wrote:
NOTE: This is a candidate for the 7.10 branch.
---
src/mesa/main/pack.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c
index d6470e3..7d541dc 100644
--- a/src/mesa/main/pack.c
+++ b
On 06/23/2011 08:39 PM, Marek Olšák wrote:
NOTE: This is a candidate for the 7.10 branch.
---
src/mesa/main/texstore.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
index 6da3e4e..5c925a3 100644
--- a/src/me
On 06/23/2011 08:39 PM, Marek Olšák wrote:
---
src/mesa/main/pack.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c
index 7d541dc..a232a51 100644
--- a/src/mesa/main/pack.c
+++ b/src/mesa/main/pack.c
@@ -4683,7 +
On 06/23/2011 08:39 PM, Marek Olšák wrote:
---
src/mesa/main/pack.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c
index 7d541dc..a232a51 100644
--- a/src/mesa/main/pack.c
+++ b/src/mesa/main/pack.c
@@ -4683,7 +
On 06/23/2011 08:39 PM, Marek Olšák wrote:
---
src/mesa/main/renderbuffer.c | 23 ---
src/mesa/main/renderbuffer.h |3 ---
2 files changed, 0 insertions(+), 26 deletions(-)
diff --git a/src/mesa/main/renderbuffer.c b/src/mesa/main/renderbuffer.c
index fa884c0..c3617
2011/6/24 Chia-I Wu :
> On Fri, Jun 24, 2011 at 3:34 PM, Benjamin Franzke
> wrote:
>> 2011/6/24 Chia-I Wu :
>>> On Fri, Jun 24, 2011 at 8:38 AM, Chia-I Wu wrote:
On Thu, Jun 23, 2011 at 8:07 PM, Benjamin Franzke
wrote:
> 2011/6/23 Chia-I Wu :
>> On Thu, Jun 23, 2011 at 7:46 PM,
On Fri, Jun 24, 2011 at 3:34 PM, Benjamin Franzke
wrote:
> 2011/6/24 Chia-I Wu :
>> On Fri, Jun 24, 2011 at 8:38 AM, Chia-I Wu wrote:
>>> On Thu, Jun 23, 2011 at 8:07 PM, Benjamin Franzke
>>> wrote:
2011/6/23 Chia-I Wu :
> On Thu, Jun 23, 2011 at 7:46 PM, Benjamin Franzke
> wrote:
61 matches
Mail list logo