At file:///home/tsk/mprog/src/5.3/
revno: 2801
revision-id: tim...@askmonty.org-20100715135910-y1gvcc3d63sod6xt
parent: sa...@askmonty.org-20100710103730-ayy6a61pdibspf4o
committer: tim...@askmonty.org
branch nick: 5.3
timestamp: Thu 201
*tmp_columns)
+bool subselect_hash_sj_engine::init(List *tmp_columns)
{
+ select_union *result_sink;
/* Options to create_tmp_table. */
ulonglong tmp_create_options= thd->options | TMP_TABLE_ALL_COLUMNS;
/* | TMP_TABLE_FORCE_MYISAM; TIMOUR: force MYISAM
*/
- DBUG_ENTER("subselect_hash_sj_engi
#At file:///home/tsk/mprog/src/5.3/ based on
revid:pser...@askmonty.org-20100716090711-5ijpspzyvmoi5mix
2805 tim...@askmonty.org 2010-07-16
Fixed a problem where the temp table of a materialized subquery
was not cleaned up between PS re-executions. The reason was two-fold:
#At file:///home/tsk/mprog/src/5.3-mwl89/ based on
revid:tim...@askmonty.org-20100716121055-6pesx07gvsmivwm3
2803 tim...@askmonty.org 2010-07-18
MWL#89: Cost-based choice between Materialization and IN->EXISTS
transformation
Step1 in the separation of the creation of IN
#At file:///home/tsk/mprog/src/5.3-mwl89/ based on
revid:tim...@askmonty.org-20100718114608-wiz9ji9z80pzjw2k
2804 tim...@askmonty.org 2010-07-18
MWL#89: Cost-based choice between Materialization and IN->EXISTS
transformation
Step2 in the separation of the creation of
#At file:///home/tsk/mprog/src/5.3/ based on
revid:tim...@askmonty.org-20100716110215-toh8erf6p93d1n6i
2806 tim...@askmonty.org 2010-07-23
Removed dead code that was made obsolete by the introduction of
check_join_cache_usage() by the change:
Revno: 2793
Revi
#At file:///home/tsk/mprog/src/mysql-6.0-mwl68/ based on
revid:tim...@sun.com-20100122161805-8lgrisqabrlvc3nc
3769 tim...@askmonty.org 2010-02-01
MWL#68 Subquery optimization: Efficient NOT IN execution with NULLs
Completed main coding of partial matching. The code compi
At file:///home/tsk/mprog/src/mysql-6.0-mwl68/
revno: 3769
revision-id: tim...@askmonty.org-20100201120948-mdt7gtwcz50q1dzp
parent: tim...@sun.com-20100122161805-8lgrisqabrlvc3nc
committer: tim...@askmonty.org
branch nick: mysql-6.0-mwl6
#At file:///etc/ based on revid:r...@lamia-20100203064317-whagbeui3pyl1bck
157 tim...@askmonty.org 2010-02-04
saving uncommitted changes in /etc prior to apt run
modified:
cups/subscriptions.conf
cups/subscriptions.conf.O
resolv.conf
=== modified file 'cups/sub
At file:///etc/
revno: 157
revision-id: tim...@askmonty.org-20100204112537-3a6fyd3ibqzi73wc
parent: r...@lamia-20100203064317-whagbeui3pyl1bck
committer: tim...@askmonty.org
branch nick: lamia /etc repository
timestamp: Thu 2010-02-04 13
At file:///home/tsk/mprog/src/mysql-6.0-mwl68/
revno: 3770
revision-id: tim...@askmonty.org-20100212143343-l0pjascssuqedfk6
parent: tim...@askmonty.org-20100201120948-mdt7gtwcz50q1dzp
committer: tim...@askmonty.org
branch nick: mysql-6.0
At file:///home/tsk/mprog/src/5.3-mwl68/
revno: 2762
revision-id: tim...@askmonty.org-20100219215557-g1uohrur8bopfv7n
parent: pser...@askmonty.org-20100217215941-5uxponk64p55xg4a
committer: tim...@askmonty.org
branch nick: 5.3-mwl68
time
*) result;
- uint cur_key= 0;
+ uint cur_keyid= 0;
Item_in_subselect *item_in= (Item_in_subselect*) item;
int error;
@@ -4346,16 +4392,16 @@ subselect_rowid_merge_engine::init(MY_BI
/* Create the only non-NULL key if there is any. */
if (non_null_key_parts)
{
-non_null_key= new Or
#At file:///home/tsk/mprog/src/5.3-mwl68-unmerged/ based on
revid:tim...@askmonty.org-20100219215557-g1uohrur8bopfv7n
2763 tim...@askmonty.org 2010-02-22 [merge]
Automerge with 5.3-subqueries
modified:
mysql-test/r/subselect_no_mat.result
mysql-test/r/subselect_no_op
NULL key if there is any. */
if (non_null_key_parts)
{
-non_null_key= new Ordered_key(cur_key, tmp_table, item_in->left_expr,
+non_null_key= new Ordered_key(cur_keyid, tmp_table, item_in->left_expr,
0, 0, 0, row_num_to_rowid);
if (non_null_ke
At file:///home/tsk/mprog/src/5.3-mwl68-unmerged/
revno: 2763 [merge]
revision-id: tim...@askmonty.org-20100222135709-3568ya6z76hkwfzs
parent: tim...@askmonty.org-20100219215557-g1uohrur8bopfv7n
parent: pser...@askmonty.org-2010022107531
At file:///home/tsk/mprog/src/5.3-mwl68-merge.base-mwl68/
revno: 2766 [merge]
revision-id: tim...@askmonty.org-20100309103615-dzmm6xt7ye5xfs25
parent: tim...@askmonty.org-20100309101406-xygkt2sgftvjvevg
parent: pser...@askmonty.org-20100
#At file:///home/tsk/mprog/src/5.3-mwl68-merge.base-mwl68/ based on
revid:tim...@askmonty.org-20100309101406-xygkt2sgftvjvevg
2766 tim...@askmonty.org 2010-03-09 [merge]
MWL#68 Subquery optimization: Efficient NOT IN execution with NULLs
Automerge with 5.3-subqueries
#At file:///home/tsk/mprog/src/5.3-mwl68/ based on
revid:tim...@askmonty.org-20100309103615-dzmm6xt7ye5xfs25
2767 tim...@askmonty.org 2010-03-11
MWL#68 Subquery optimization: Efficient NOT IN execution with NULLs
This patch does three things:
- It adds the possibil
At file:///home/tsk/mprog/src/5.3-mwl68/
revno: 2767
revision-id: tim...@askmonty.org-20100311214331-kw8ng8aiy6h60vai
parent: tim...@askmonty.org-20100309103615-dzmm6xt7ye5xfs25
committer: tim...@askmonty.org
branch nick: 5.3-mwl68
times
#At file:///home/tsk/mprog/src/5.3-subqueries/ based on
revid:tim...@askmonty.org-20100315195258-nhomb3anbb1tv3mi
2780 tim...@askmonty.org 2010-03-16
MWL#68: Subquery optimization: Efficient NOT IN execution with NULLs
Fix for the PBXT copy of subselect.test.
modifi
At file:///home/tsk/mprog/src/5.3-subqueries/
revno: 2780
revision-id: tim...@askmonty.org-20100315224130-321rym1lsuwz2j5z
parent: tim...@askmonty.org-20100315195258-nhomb3anbb1tv3mi
committer: tim...@askmonty.org
branch nick: 5.3-subque
#At file:///home/tsk/mprog/src/5.3-subqueries/ based on
revid:pser...@askmonty.org-20100329200940-9ikx6gpww0gtsx00
2788 tim...@askmonty.org 2010-04-02
MWL#68: Subquery optimization: Efficient NOT IN execution with NULLs
Fixed an error where the priority queue for the ind
#At file:///home/tsk/mprog/src/5.3-subqueries/ based on
revid:tim...@askmonty.org-20100402142706-klcgi39tjzhvy22z
2789 tim...@askmonty.org 2010-04-06
Fixed a problem where the temp table of a materialized subquery
was not cleaned up between PS re-executions. The reason was two-
#At file:///home/tsk/mprog/src/5.3-subqueries/ based on
revid:tim...@askmonty.org-20100405211515-istsgehaz7zafg0l
2790 tim...@askmonty.org 2010-04-06
Fixed an error in the creation of REF access method for materialized
semi-join, where the the REF buffer format was mistaken to
reate_tmp_table. */
ulonglong tmp_create_options= thd->options | TMP_TABLE_ALL_COLUMNS;
/* | TMP_TABLE_FORCE_MYISAM; TIMOUR: force MYISAM
*/
@@ -3706,15 +3716,16 @@ bool subselect_hash_sj_engine::init_perm
DBUG_RETURN(TRUE);
}
*/
- if (!(result= new select_materialize_with_stats))
+ if (!(result_sink=
therwise
*/
-bool subselect_hash_sj_engine::init_permanent(List *tmp_columns)
+bool subselect_hash_sj_engine::init(List *tmp_columns)
{
select_union *result_sink;
/* Options to create_tmp_table. */
ulonglong tmp_create_options= thd->options | TMP_TABLE_ALL_COLUMNS;
changes in the docs, rather than having a possibly outdated
documentation, with a link to the up-to-date docs.
If we take this manual approach to copy/paste docs for a dozen storage
engines, we will end up in a big mess.
timour: would
http://code.google.com/feeds/p/sphinxsearch/svnchanges/basic
Igor,
Why not take the opportunity to change the format of all comments to
Doxygen format. It doesn't make sense to have two formats for comments,
and I've seen you adding new comments in new code in Doxygen format.
Timour
On 10/06/10 14:08, Sergey Petrunya wrote:
Hello Igor,
P
Sergey,
I noticed these while building my recent bug fixes, but I
wanted to fix them in a separate patch. Patch will follow
very soon.
Timour
Hi Timour,
When one compiles 5.3, it produces the following warnings which I believe fall
into your turf. Could you please fix them
const_cond,
which is evaluated once in the beginning of JOIN::exec.
"
Timour
=== modified file 'mysql-test/r/subselect4.result'
--- mysql-test/r/subselect4.result 2010-10-28 17:04:23 +
+++ mysql-test/r/subselect4.result 2010-11-11 16:42:55 +
@@ -397,3 +397,42 @@
# Re
e above wrong result for sure.
If this is not the problem, then please post a reproducible example.
Timour
-Zardosht
On Wed, Dec 8, 2010 at 2:42 PM, Kristian Nielsen
wrote:
Zardosht Kasheff writes:
We have been working on testing our storage engine, TokuDB, against
MariaDB 5.2.3, and we
Igor,
While merging 5.3-mwl89 with 5.3 I noticed that when you extracted
a block of code from add_key_part() into the new function
add_keyuse(), you skipped the initialization:
keyuse.ref_table_rows= 0;
was it intentional, and if so, why?
Timour
At file:///home/igor/maria/maria-5.3
Sergey,
I only suggest to change the comment so that it says that
loose scan can process only range conditions, not that it
cannot process SEL_TREEs with type=SEL_ARG::MAYBE_KEY.
Ok to push.
Timour
Hi Timour,
Could you please review the below? (Asking you because the fix is in the loose
inconsistency in JOIN::keyuse in 5.3.
Please look at the last bug comment - it contains
a very small test case.
I will ping you tonight after putting kids to sleep
around 21:30.
Timour
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria
Hi Sergey,
Hi Timour,
While merging, I also got the following questions:
== exclude_expensive_cond ==
make_cond_for_table()'s exclude_expensive_cond parameter is not used anymore.
Was it intentional that you kept it in the code?
(minimizing MWL#89's diff size could not be a reason b
has proven to lead to bugs and harder to maintain code. Therefore
I am *strongly* against pushing such code.
The result of my merge has an issue that conceptually it is not a full merge,
because MWL#90 code is not able yet to take advantage of the possibily of
dynamic choice between IN->EXISTS (
Sergey,
Ok to push. I'd rather add a comment to the block of code
starting with:
" // 1. Store the length "
At least to me it was not obvious why it is the way it is.
Timour
At file:///home/psergey/dev2/5.3-push3/
-
add some general comment to the whole
function how do we compute the field length.
Timour
On 27.06.2011 07:55, Igor Babaev wrote:
At file:///home/igor/maria/maria-5.3-merge-tmp/
revno: 3062
revision-id: i...@askmonty.org-20110627045532
.
I will be back from vacation on Tuesday, so if there
is need for discussion, we can talk on Tuesday evening
or Wednesday any time.
Timour
Original Message
Return-Path:
X-Original-To: tim...@askmonty.org
Delivered-To: tim...@askmonty.org
Received: from localhost
Could you please review ASAP, as this bug blocks
RQG testing of your tree.
Timour
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More
y, we should not use casting, but we should change the type of all
the relevant variables/class members to double.
In addition we should add to get_best_combination() a
DEBUG_ASSERT(join->best_positions[tablenr].records_read > 0)
to verify that we got a reasonable value.
Let me know
absolutely no clue why items should be taken
from the ref-array.
Timour
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help
Igor,
Could you please review my patch for bug LP:809245.
Ttimour
Original Message
Return-Path:
X-Original-To: tim...@askmonty.org
Delivered-To: tim...@askmonty.org
Received: from localhost (localhost.localdomain [127.0.0.1])by
hasky.askmonty.org (Postfix) with ESMTP id
Igor,
Could you please review this fix for bug lp:809266.
Timour
revno: 3104
revision-id: tim...@askmonty.org-20110713211507-j9v80yk2tzae8tq2
parent: tim...@askmonty.org-20110713141146-339e3xwz17hogqsb
fixes bug(s): https
Sergey,
Please review the below patch. As discussed, all other
solutions that try to keep the call to mark_as_null_row()
lead to a chicken-egg-like problem that is tricky to
solve. Since I am not sure it is worth solving, I suggest
the below simple solution.
Timour
ere are few more comments below marked with "timour:".
Timour
=== modified file 'mysql-test/r/subselect_cache.result'
--- a/mysql-test/r/subselect_cache.result 2011-02-03 15:00:28 +
+++ b/mysql-test/r/subselect_cache.result 2011-07-19 09:15:34 +
@@ -3272,6 +
great libraries.
Do you think that it is reasonable that all such projects should follow
the approach you suggest, and internally embed the libraries they use (or parts
thereof)?
Timour
Cheers,
Arjen.
___
Mailing list: https://launchpad.net/~m
on
is needed or not.
My source of information is this page:
http://tinyurl.com/c3e5mh
(original:)
http://www.microsoft.com/downloads/details.aspx?familyid=727BCFB0-B575-47AB-9FD8-4EE067BB3A37&displaylang=en
Timour
[moving the discussion to maria-develop...@]
Timour Katchaounov writes:
Ser
ject to a local host.
Timour
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
Hi,
I was looking today at some optimizer code, and bumped again
into sql_select.cc:find_best(). We have been using the greedy
optimizer for years, and this function has been dead code for
a while, isn't it time to remove it?
The less code, the better.
T
Sergei,
Hi, Timour!
On Jun 02, Timour Katchaounov wrote:
Hi,
I was looking today at some optimizer code, and bumped again
into sql_select.cc:find_best(). We have been using the greedy
optimizer for years, and this function has been dead code for
a while, isn't it time to remove it?
The
efine brestore
source brestore.gdb
end
document brestore
restore breakpoints saved by bsave
end
The credits go to this page:
http://stackoverflow.com/questions/501486/getting-gdb-to-save-a-list-of-breakpoints
Happy debugging,
Timour
___
Mailing list: https
end
The credits go to this page:
http://stackoverflow.com/questions/501486/getting-gdb-to-save-a-list-of-breakpoints
Happy debugging,
Timour
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.
54 matches
Mail list logo
