Re: [Maria-developers] MariaDB and MySQL replication

2013-05-21 Thread Jan Lindström
Hi, > > > Before you say they are fully compatible, I point out at least > > following types at mysql_com.h that do not exist on MariaDB > > mysql_com.h: > > > > MYSQL_TYPE_TIMESTAMP2, > > MYSQL_TYPE_DATETIME2, > > MYSQL_TYPE_TIME2, > > I do not know the details of this particular point (also yo

Re: [Maria-developers] ALTER ONLINE TABLE syntax

2013-07-10 Thread Jan Lindström
Hi, I really do not see why you would want to define both algorithm and lock mode. In my transactional view ALGORITHM=COPY would mean EXCLUSIVE lock and INPLACE would mean SHARED lock. Is there some other lock that protects from concurrent online alter tables ? Lock NONE would mean I do not ca

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-12 Thread Jan Lindström
Hi, On 08/12/2013 02:59 PM, Kristian Nielsen wrote: I took a close look at your patch for MDEV-4820. I think there is a fundamental disconnect. In MariaDB GTID, I do not require or rely on monotonically increasing seqeunce numbers (monoticity is requred per-server-id, but not between different

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-13 Thread Jan Lindström
Hi, On 08/13/2013 09:49 AM, Kristian Nielsen wrote: You can always use the contents of the binlogs to know this. You can search the binlogs for your GTID and determine if it was a) logged in an earlier binlog that was purged, b) found in the binlog, c) a "hole" due to filtering or whatever, or

Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread Jan Lindström
Hi, From experience working on two storage engines on MySQL and being main developer for the second one, and one "storage engine" on big company, I would say MySQL storage engine API has some legacy problems and clearly some missing functionality. e.g. - Some part of the storage engines are

Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread Jan Lindström
On 08/19/2013 07:43 PM, MARK CALLAGHAN wrote: Welcome back to the MySQL community Jan. It is good to see SkySQL/MariaDB get more InnoDB expertise. Thanks, I have really enjoyed back on MySQL community. Many things are changed but many are as they were when I was moved to develop other databa

[Maria-developers] Rollback causes assertion with Galera 10.0

2013-09-09 Thread Jan Lindström
Unfortunately, general log contains so many statements from different connections that they are not really helpful for getting repeatable test case. R: Jan -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstr

Re: [Maria-developers] Rollback causes assertion with Galera 10.0

2013-09-09 Thread Jan Lindström
ddress 0xa5a5a5a5a5a5a5a5 (gdb) p cache_log.pos_in_file $4 = 11936128518282651045 (gdb) p *cache_log.request_pos $5 = 37 '%' (gdb) p cache_log.request_pos $6 = (uchar *) 0x7f214003bb10 "%\374-R\023"' R: Jan Jan L

[Maria-developers] A tale of two MySQL bugs

2013-09-09 Thread Jan Lindström
See:   http://developers.slashdot.org/story/13/09/09/2259206/a-tale-of-two-mysql-bugs Great work! -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com

Re: [Maria-developers] Rollback causes assertion with Galera 10.0

2013-09-10 Thread Jan Lindström
=--general_log_file=/home/jan/mysql/galera-test/stmt.log R: -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com ___ Mailing list: https

[Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-18 Thread Jan Lindström
Query (0x7fcc10005288): ROLLBACK Connection ID (thread ID): 11 Status: NOT_KILLED -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com ___ Mailing l

Re: [Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-19 Thread Jan Lindström
help. Where I should add some output to narrow down the place where the corruption happens. R: Jan -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com

Re: [Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-23 Thread Jan Lindström
_VA_ARGS__) #define WSREP_ERROR(...) WSREP_LOG(sql_print_error,   ##__VA_ARGS__) Thus , it seems that trx_cache and stmt_cache are not initialized, where that should happen ? Jan Lindström writes: Correct log file attached.

[Maria-developers] The Usability of Free/Libre/Open Source Projects, A Review

2013-09-23 Thread Jan Lindström
In http://www.ijcit.com/archives/volume2/issue5/Paper020519.pdf For some reason MySQL/MariaDB is not mentioned. R: -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com

Re: [Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-25 Thread Jan Lindström
ror handling is missing when the binlog code calls reinit_io_cache(), so the error is ignored, and it proceeds to trigger the assertion in reset() as the reinit_io_cache() did not complete. Should I do a bug report to you or can this handled in some other MDEV ? R:

Re: [Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-25 Thread Jan Lindström
a5a5a5a5a5a5a5a5, mdl_savepoint = {m_stmt_ticket = 0xa5a5a5a5a5a5a5a5, m_trans_ticket = 0xa5a5a5a5a5a5a5a5}} Again access to unitialized memory, sv is ok but sv+1 not R: -- Jan Lindström Principal Engineer MariaDB |

Re: [Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-25 Thread Jan Lindström
     at galera/src/replicator_smm.cpp:apply_wscoll():52      at galera/src/replicator_smm.cpp:apply_trx_ws():118 130925 15:10:36 [ERROR] WSREP: Node consistency compromized, aborting... R: -- Jan Lindström Principal Engineer MariaD

Re: [Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-27 Thread Jan Lindström
- Kristian. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp -- -- Jan

Re: [Maria-developers] Galera and aria

2013-09-30 Thread Jan Lindström
a mdev to this task (allow aria engine with galera cluster)?  today it's not a trasational engine, but it's better than myisam with the crash safe feature -- Jan Lindström Principal Engineer

Re: [Maria-developers] Galera and aria

2013-09-30 Thread Jan Lindström
nt development phase Aria tables created with TRANSACTIONAL=1 are crashsafe and atomic but not transactional because changes in Aria tables can't be rolled back with the ROLLBACK command. R: -- Jan Lindström Principal Engineer

Re: [Maria-developers] [Commits] Rev 3886: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10exp/

2013-11-10 Thread Jan Lindström
dictionary. Prior to that it only used the CONSTRAINT name for it. ___ commits mailing list comm...@mariadb.org https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits -- -- Jan

Re: [Maria-developers] [Commits] Rev 3966: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-02 Thread Jan Lindström
-- -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers

Re: [Maria-developers] [Commits] Rev 3966: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-03 Thread Jan Lindström
Hi, Hi, Jan! Good point! On Feb 02, Jan Lindström wrote: Hi, In my opinion the test case is not complete, you are missing e.g. ALTER TABLE t2 ADD FOREIGN KEY IF NOT EXISTS (id) REFERENCES t1(id); -- should fail on warning ALTER TABLE t2 ADD FOREIGN

Re: [Maria-developers] [Commits] Rev 3984: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-05 Thread Jan Lindström
ame for it. ___ commits mailing list comm...@mariadb.org https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits -- -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.

Re: [Maria-developers] [Commits] Rev 3984: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-06 Thread Jan Lindström
ch handles only InnoDB part not XtraDB, these should work similarly, to avoid confusion. Hi, Jan! On Feb 06, Jan Lindström wrote: Hi, Change: Another change is that it uses the index name for the internal dictionary. Not ok. Firstly, that change should a

Re: [Maria-developers] GSOC 2014 participation

2014-02-26 Thread Jan Lindström
Suyash Please have a look of ideas at https://mariadb.com/kb/en/google-summer-of-code-2014/ R: Jan -- -- Jan Lindström Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com

[Maria-developers] InnoDB selected projects (corrected links)

2014-03-12 Thread Jan Lindström
above links. R: -- -- Jan Lindström, Principal Engineer SkySQL - The MariaDB Company MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com ___ Mailing list: https://launchpad.net

Re: [Maria-developers] [Commits] 2c9bb42: MDEV-11432 Change the informational redo log format tag to "MariaDB 10.2.3"

2016-11-30 Thread Jan Lindström
Hi, ok to push. R: Jan On Thu, Dec 1, 2016 at 8:36 AM, wrote: > revision-id: 2c9bb42d901fc4f48f4884e4a85af74eae6d0929 > (mariadb-10.2.2-91-g2c9bb42) > parent(s): dc9f919f27fccfeb0de3ab392f33bc5efdfd59a0 > author: Marko Mäkelä > committer: Marko Mäkelä > timestamp: 2016-12-01 08:28:59 +0200 > m

Re: [Maria-developers] [Commits] 00f5065: MDEV-11422 rpl.rpl_parallel_optimistic_nobinlog failed

2016-12-08 Thread Jan Lindström
Hi, All other looks correct, I'm concerned only following change that is not needed to fix this bug: On Thu, Dec 8, 2016 at 2:35 PM, wrote: > > > - err = lock_trx_handle_wait(trx, > - (lock_mutex_taken || already_have_lock_mutex), > - (t

Re: [Maria-developers] [Commits] 9f863a15b03: MDEV-11602 InnoDB leaks foreign key metadata on DDL operations

2016-12-19 Thread Jan Lindström
ok to push. Most likely the double free was result of some other bug fixed later. R: Jan On Mon, Dec 19, 2016 at 4:00 PM, wrote: > revision-id: 9f863a15b037c0ddffc2d12c1f7d841466f9f345 (mariadb-10.0.28-27- > g9f863a15b03) > parent(s): eb4f2e063c341d9f3644339c68cb01679e782001 > author: Marko Mä

Re: [Maria-developers] [Commits] d158f55659c: MDEV-11679 Remove redundant function fsp_header_get_crypt_offset()

2016-12-28 Thread Jan Lindström
On Wed, Dec 28, 2016 at 5:16 PM, wrote: > > diff --git a/storage/innobase/fil/fil0crypt.cc b/storage/innobase/fil/ > fil0crypt.cc > index 75efcdfdab0..095b9f706c0 100644 > --- a/storage/innobase/fil/fil0crypt.cc > +++ b/storage/innobase/fil/fil0crypt.cc > @@ -1179,10 +1179,11 @@ fil_crypt_start_e

Re: [Maria-developers] InnoDB: Instant ADD COLUMN that works on old data files

2017-01-10 Thread Jan Lindström
Hi, Number of the fields indeed would solve the ADD COLUMN default case but has some limitations ADD COLUMN m default xxx; would be still slow, xxx = NULL maybe possible, in other cases could we store default on SYS_COLUMNS? DROP COLUMN would be still slow Problem naturally is that we do not ha

Re: [Maria-developers] [Commits] 43e2a78f2a0: Remove MYSQL_COMPRESSION.

2017-01-16 Thread Jan Lindström
Hi, On Mon, Jan 16, 2017 at 2:10 PM, wrote: > > diff --git a/storage/innobase/btr/btr0btr.cc b/storage/innobase/btr/ > btr0btr.cc > index d1d9dfe64fe..1fb5cb06949 100644 > --- a/storage/innobase/btr/btr0btr.cc > +++ b/storage/innobase/btr/btr0btr.cc > @@ -215,10 +215,6 @@ btr_root_get( >

Re: [Maria-developers] [Commits] f380e7b5535: MDEV-12072 Do not unnecessarily construct rec_printer objects in debug builds

2017-02-15 Thread Jan Lindström
ok to push. On Wed, Feb 15, 2017 at 4:02 PM, wrote: > revision-id: f380e7b5535358bd3d7caf81d22579ef97f6ca24 (mariadb-10.2.3-271- > gf380e7b5535) > parent(s): 24911cee4e3be988848f6eab4d768849709f5256 > author: Marko Mäkelä > committer: Marko Mäkelä > timestamp: 2017-02-15 16:02:00 +0200 > message

Re: [Maria-developers] [Commits] 01d5d6db4c3: Fix GCC 6.3.0 warnings.

2017-02-16 Thread Jan Lindström
ok to push. On Thu, Feb 16, 2017 at 11:17 AM, wrote: > revision-id: 01d5d6db4c337daae0aa593341e081cc6bfebb8a (mariadb-10.0.29-25- > g01d5d6db4c3) > parent(s): 6011fb6daa5ac9e6cb97a23b877e4d2568c85d94 > author: Marko Mäkelä > committer: Marko Mäkelä > timestamp: 2017-02-16 11:16:27 +0200 > messag

[Maria-developers] Filtered transactions coming through mysql/mariadb replication to Galera cluster

2017-03-13 Thread Jan Lindström
Hi, Galera cluster (https://github.com/codership/mysql-wsrep/commits/5.6) has new feature : commit 14301279075dc2b420f3173cc9c2eb7912db63de Author: sjaakola Date: Fri Nov 18 12:45:42 2016 +0200 Refs: MW-319 * replicating write set containing only GTID event of totally filtered transac

Re: [Maria-developers] cte page

2017-04-27 Thread Jan Lindström
Hi, Very interesting and nice to see that paper is not full of theorems and mathematics, very good paper!. Any ideas how to improve from here ? R: Jan On Thu, Apr 27, 2017 at 7:10 PM, Galina Shalygina wrote: > мои артиклы > > > ___ > Mailing list: ht

Re: [Maria-developers] 1 Transaction and several threads

2017-08-03 Thread Jan Lindström
Hi, If we talk about bulk load I would write directly .ibd file format pages, now as InnoDB has always some order between pages doing this in parallel has challenges, we can read and parse input, sort it, reformat to InnoDB pages, write these pages (maybe you could do this also parallel). To speed

Re: [Maria-developers] commit_checkpoint_request() vs. thd_get_durability_property() (in relation to MDEV-11937)

2017-08-07 Thread Jan Lindström
Hi, On Mon, Aug 7, 2017 at 2:09 PM, Kristian Nielsen wrote: > > The problem is that somehow the thd_get_durability_property() function was > introduced into MariaDB code, but it is completely non-functional. So now > there is code in InnoDB, TokuDB and RocksDB that calls this function and > does

Re: [Maria-developers] [Commits] 8048670: MDEV-10715 Galera: Replicate MariaDB GTID to other nodes in the cluster

2017-12-12 Thread Jan Lindström
On Mon, Dec 11, 2017 at 9:40 AM, sachin wrote: > revision-id: 8048670e25e5cda915ad7ce16dbd66afa6227aa5 > (mariadb-10.1.29-24-g8048670) > parent(s): de76cbdcb0728b80c0f7b453b24b0b81f653e450 > author: Sachin Setiya > committer: Sachin Setiya > timestamp: 2017-12-11 13:05:08 +0530 > message: > > MDE

Re: [Maria-developers] 9bc03294c89: MDEV-15033: Node fails to join mdb cluster with wsrep_sst_mariabackup due to dependency from socat

2018-02-06 Thread Jan Lindström
socat to mariabackup > package aren't much better, as mariabackup users don't really need socat > either. > > May be just a better error message in the script? > > On Feb 06, jan wrote: > > revision-id: 9bc03294c89b16df5f556b7d9fa4cb1eadae451a > (mariadb-10.

Re: [Maria-developers] MDEV-17706 Review server changes introduced by Galera 4 wsrep patch

2018-11-27 Thread Jan Lindström
Hi Alexander and thank you for your review. On Tue, Nov 27, 2018 at 2:18 PM Alexander Barkov wrote: > Hi Jan, > > > I checked changes to the /sql directory so far. > Sorry, I'm completely out of this topic. > So I have only general suggestions. > > > > 1. General code structure. > > There are a

Re: [Maria-developers] 889f90365ef: MDEV-23536 : Race condition between KILL and transaction commit

2020-12-19 Thread Jan Lindström
Hi Sergei, > > > Not exactly. In 10.2 THD::~THD() only has > > mysql_mutex_lock(&LOCK_thd_data); > mysql_mutex_unlock(&LOCK_thd_data); > > it's not what Jan did. So I thought it'd be safer to leave it in place. > But 10.5 has > > if (WSREP_NNULL(this)) mysql_mutex_lock(&LOCK_thd_data); >

Re: [Maria-developers] [Commits] 608b0ee52ef: MDEV-23033: All slaves crash once in ~24 hours and loop restart with signal 11

2021-01-04 Thread Jan Lindström
Hi Sujatha, On Mon, Jan 4, 2021 at 11:45 AM sujatha wrote: > > +for (TABLE_LIST *tables= rgi->tables_to_lock; tables; > + tables= tables->next_global) > +{ > + if (slave_run_triggers_for_rbr) >{ > tables->trg_event_map= new_trg_event_map; > lex->que

Re: [Maria-developers] [Commits] Rev 4153: MDEV-5963: InnoDB: Assertion failure in file row0sel.cc line 2503 ... in file:///home/psergey/dev2/10.0-cp/

2014-04-18 Thread Jan Lindström
le->ha_rnd_init(false))) { DBUG_PRINT("error", ("ROR index_merge rnd_init call failed")); DBUG_RETURN(error); ___ R: -- -- Jan Lindström, Principal Engineer SkySQL - The MariaDB Company Ma

Re: [Maria-developers] innodb holepunch compression vs the filesystem

2015-10-21 Thread Jan Lindström
documentation of feature when punch hole should be used. We have not yet introduced similar do unlink() in a background thread solution as MySQL. R: Jan Lindström On Sat, Oct 17, 2015 at 4:54 PM, MARK CALLAGHAN wrote: > InnoDB punch-hole compression is very bad for a filesystem when done on > eve

Re: [Maria-developers] On the issue of Seconds_behind_master and Parallel Replication

2015-10-21 Thread Jan Lindström
Hi, Is it possible to know how many transactions/operations slave is behind the master ? Assume in above that master is idle for several days, if master then executes a one transaction, does that mean that slave is behind the master also several days ? R: Jan On Thu, Oct 22, 2015 at 9:12 AM, Kri

Re: [Maria-developers] [Commits] 2709165: MDEV-9128 - Compiling on IBM System Z fails

2015-11-18 Thread Jan Lindström
Hi Sergey, Is this true only for innodb_plugin ? R: Jan On Wed, Nov 18, 2015 at 2:07 PM, Sergey Vojtovich wrote: > revision-id: 2709165caed4691d1203f0b91d22d0e7927b > (mariadb-10.1.8-67-g2709165) > parent(s): bff6780806f4afed8faaf4c79b1593964564097e > committer: Sergey Vojtovich > timestam

Re: [Maria-developers] [Commits] be25be4: MDEV-8827 Duplicate key with auto increment

2015-11-30 Thread Jan Lindström
Ok to push. On Mon, Nov 30, 2015 at 6:45 PM, wrote: > revision-id: be25be4b1aaf65593d67498c2f30a99fd254ea15 > (mariadb-10.1.8-71-gbe25be4) > parent(s): cf8cb9ebd810a46154f99a73045b53a6913b6eb6 > committer: Sergei Golubchik > timestamp: 2015-11-30 17:45:23 +0100 > message: > > MDEV-8827 Duplicate

Re: [Maria-developers] Log warnings when upgrading from mysql 5.6 -> mariadb 10.0

2016-01-10 Thread Jan Lindström
Hi, These warnings are printed because some of the system table definitions have been changed, you should run mysql_upgrade and restart should be again more silent. R: Jan On Mon, Jan 11, 2016 at 8:56 AM, Otto Kekäläinen wrote: > Hello! > > When testing mysql 5.6 -> mariadb 10.0 I noticed that

Re: [Maria-developers] Log warnings when upgrading from mysql 5.6 -> mariadb 10.0

2016-01-11 Thread Jan Lindström
for this. R: Jan On Mon, Jan 11, 2016 at 10:39 AM, Otto Kekäläinen wrote: > 2016-01-11 9:25 GMT+02:00 Jan Lindström : > > These warnings are printed because some of the system table definitions > have > > been changed, you should run mysql_upgrade and restart should be again

Re: [Maria-developers] Log warnings when upgrading from mysql 5.6 -> mariadb 10.0

2016-01-11 Thread Jan Lindström
I did not remember to make it totally public, modified version: https://mariadb.atlassian.net/browse/MDEV-9394 On Mon, Jan 11, 2016 at 12:51 PM, Jan Lindström wrote: > Hi, > > I agree with you, I do not fully understand why mysql_upgrade is separate > program, at startup mysqld

Re: [Maria-developers] MDEV-8691 Multiple test failures on mips and mipsel platforms, suites federated and rpl

2016-02-02 Thread Jan Lindström
Where I get mips machine to test and find out the reason, do we even support mips ? On Tue, Feb 2, 2016 at 4:34 PM, Alexander Barkov wrote: > Hello Jan. > > a gentle reminder ;) > > Thanks. > > > On 01/26/2016 04:35 PM, Alexander Barkov wrote: > >> Hi Jan, >> >> can you please have a look into:

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-23 Thread Jan Lindström
question, do you allow blobs to be foreign keys or not. Finally, unique key with NOT NULL can be used as primary key i.e. clustered key on InnoDB, using blobs hash on that might be out of reach on this timetable. R: Jan Lindström Principal Engineer InnoDB On Wed, Mar 23, 2016 at 6:38 PM, Shubham Barai

Re: [Maria-developers] InnoDB blob for primary key

2016-04-12 Thread Jan Lindström
Hi, Sachin, naturally you may continue, this is open source, please read https://mariadb.com/kb/en/mariadb/community-contributing-to-the-mariadb-project/ From InnoDB point of view there is issue if you add a new system generated column to the row. Firstly, existing tables will not have that colum

Re: [Maria-developers] 9058071: MDEV-9362: InnoDB tables using DATA_DIRECTORY created using MySQL 5.6 do not work with MariaDB 10.1

2016-05-01 Thread Jan Lindström
below. Nothing big, nothing that's really > the approach you've taken. In fact, I like where it's going. > > But this is a huge and intrusive patch. I wonder, should we rather do it > in 10.2? See below, you yourself write: > > On Feb 25, Jan Lindström wrote: > >

Re: [Maria-developers] [Commits] a6fb98f: MDEV-6368: assertion xid_seqno > trx_sys_cur_xid_seqno

2016-05-03 Thread Jan Lindström
Hi Nirbhay, I'm not expert on this code area but some questions, comments below. On Tue, May 3, 2016 at 1:26 AM, Nirbhay Choubey wrote: > revision-id: a6fb98fd74ab6f14fab0c1ef4630b010ff28880f > (mariadb-10.1.13-6-ga6fb98f) > parent(s): f8cdb9e7e8fb692f8eb3b9bb4792cd60653e0eb8 > author: Nirbhay

Re: [Maria-developers] GSoC weekly reports (Unique indexes for blobs)

2016-06-22 Thread Jan Lindström
Hi, Please commit and push these changes to your git branch I have not yet seen them, in my opinion as this is only a working branch you can push often. I still fail to see any test cases on InnoDB branch, do you have more than one branch and if you have why ? Depending on extent of these changes

Re: [Maria-developers] Status of InnoDB 5.7 merge to 10.2

2016-08-12 Thread Jan Lindström
Hi, On Fri, Aug 12, 2016 at 12:26 PM, Kristian Nielsen wrote: > > > From a quick look at the patch, this seems to be because of code removed > from innobase_kill_query(). Specifically: > > > @@ -4799,65 +5511,11 @@ innobase_kill_query( > > DBUG_ENTER("innobase_kill_query"); > > DBUG_

Re: [Maria-developers] Problem with parallel replication in 10.2

2016-09-02 Thread Jan Lindström
On Thu, Sep 1, 2016 at 12:31 PM, Kristian Nielsen wrote: > Michael Widenius writes: > > > > This is because of errorneous merge. The original code: > > if (waitee_buf_ptr) { > lock_report_waiters_to_mysql(waitee_buf_ptr, > start_mysql_thd,

Re: [Maria-developers] Problem with parallel replication in 10.2

2016-09-05 Thread Jan Lindström
On Fri, Sep 2, 2016 at 2:17 PM, Kristian Nielsen wrote: > Michael Widenius writes: > > > Ok, so I prepared patches for this: > > http://lists.askmonty.org/pipermail/commits/2016-September/009740.html > http://lists.askmonty.org/pipermail/commits/2016-September/009741.html > http://lists.as

Re: [Maria-developers] [Commits] f2aea43: MDEV-10649: Optimizer sometimes use "index" instead of "range" access for UPDATE

2016-09-07 Thread Jan Lindström
On Tue, Sep 6, 2016 at 8:37 PM, Sergei Petrunia wrote: > revision-id: f2aea435df7e92fcf8f09f8f6c160161168c5bed > parent(s): a14f61ef749ad9f9ab2b0f5badf6754ba7443c9e > committer: Sergei Petrunia > branch nick: 10.0 > timestamp: 2016-09-06 20:37:21 +0300 > message: > > MDEV-10649: Optimizer sometim

Re: [Maria-developers] [Commits] f2aea43: MDEV-10649: Optimizer sometimes use "index" instead of "range" access for UPDATE

2016-09-28 Thread Jan Lindström
I'm fine with this. Ok to push #1. 28.9.2016 15.32 "Sergey Petrunia" kirjoitti: > On Wed, Sep 07, 2016 at 10:36:32AM +0300, Jan Lindström wrote: > > On Tue, Sep 6, 2016 at 8:37 PM, Sergei Petrunia > > wrote: > > > > > revision-id: f2aea435df

Re: [Maria-developers] [Commits] 1c9da8d: MDEV-9312: storage engine not enforced during galera cluster replication

2016-09-28 Thread Jan Lindström
Hi Nirbhay, This looks ok but one question (no need to change now): On Wed, Sep 28, 2016 at 7:36 PM, Nirbhay Choubey wrote: > > +Since some wsrep threads (THDs) are create before plugins are > +initialized, LOCK_plugin mutex needs to be initialized here. > + */ > Is there some fundame

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-03 Thread Jan Lindström
Hi Sergei, On Fri, Oct 1, 2021 at 9:05 PM Sergei Golubchik wrote: > Hi, Seppo, Jan! > > Note, this is 10.2 patch below. > > > > > MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL) > > I think this should say > > MDEV-23328 Server hang due to Galera lock conflict resolution > > Sur

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-06 Thread Jan Lindström
Hi Sergei, Answers below: > > > > > +/* This is wrapper for wsrep_break_lock in thr_lock.c */ > > > > +static int wsrep_thr_abort_thd(void *bf_thd_ptr, void > *victim_thd_ptr, my_bool signal) > > > > +{ > > > > + THD* victim_thd= (THD *) victim_thd_ptr; > > > > + /* We need to lock THD::LOCK_th

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-06 Thread Jan Lindström
Hi Sergei, Answers to your questions below: On Wed, Oct 6, 2021 at 5:03 PM Sergei Golubchik wrote: > Hi, Jan! > > On Oct 06, Jan Lindström wrote: > > > > > > > > > +/* This is wrapper for wsrep_break_lock in thr_lock.c */ > > > > > >

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-10 Thread Jan Lindström
Hi Sergei, > > > if (victim_trx) { > > const trx_id_t victim_trx_id= victim_trx->id; > > const longlong victim_thread= thd_get_thread_id(victim_thd); > > /* This is necessary as correct mutexing order is > > lock_sys -> trx -> THD::LOCK_thd_data and below > > function assume

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-10 Thread Jan Lindström
Hi Sergei, Update on what happens after TOI failure. > What I mean it, what if KILL would ignore WSREP_TO_ISOLATION_BEGIN > failure and will just proceed killing? Perhaps if > WSREP_TO_ISOLATION_BEGIN fails it means that there can be no bf aborts > anyway? Could you try to find it out? > After

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-11 Thread Jan Lindström
Update on disconnect > > > // As trx is now referenced it can't go away > > Hmm. What happens if the thd that owns this transaction is killed or the > user disconnects? THD gets freed. What happens to the referenced trx? > I created new mtr-tests (galera_disconnect_debug) to try disconnecti

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-11 Thread Jan Lindström
sv/linux/x86_64/clone.S:95 R: Jan On Wed, Oct 6, 2021 at 5:03 PM Sergei Golubchik wrote: > Hi, Jan! > > On Oct 06, Jan Lindström wrote: > > > > > > > > > +/* This is wrapper for wsrep_break_lock in thr_lock.c */ > > > > > > +static i

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-11 Thread Jan Lindström
Hi Sergei, > > > > trx_rw_is_active needs to be modified to do that, right? > > > > No this is current behaviour, I did not change anything on > > trx_rw_is_active > > In xtradb trx_rw_is_active returns bool. > I think xtradb is still the default innodb in 10.2. > > In innobase it returns, indeed

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-11 Thread Jan Lindström
Hi Sergei, Update on wsrep_close_connections problem. My suggestion to fix this issue is on https://github.com/MariaDB/server/commit/99cbe03a44cc95e6f548550df51e7201ebea3b9d If you have a better solution, please advise. R: Jan On Mon, Oct 11, 2021 at 12:52 PM Jan Lindström wrote: >

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-14 Thread Jan Lindström
t I > removed too much from wsrep_abort_transaction()). Note it's the patch > for 10.2 at the commit 29bbcac0ee8^ - that is one commit before my fix. > > On Oct 12, Jan Lindström wrote: > > Hi Sergei, > > > > Update on wsrep_close_connections problem. My suggestion t

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-19 Thread Jan Lindström
. R: Jan On Fri, Oct 15, 2021 at 11:36 AM Sergei Golubchik wrote: > Hi, Jan! > > On Oct 15, Jan Lindström wrote: > > Few questions: > > > > (1) Is this review for a full patch or just problems on > > wsrep_abort_transaction ? > > a full patch > > &

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-20 Thread Jan Lindström
t I > removed too much from wsrep_abort_transaction()). Note it's the patch > for 10.2 at the commit 29bbcac0ee8^ - that is one commit before my fix. > > On Oct 12, Jan Lindström wrote: > > Hi Sergei, > > > > Update on wsrep_close_connections problem. My sugg

Re: [Maria-developers] 4b164f176e6: MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

2021-10-21 Thread Jan Lindström
On Thu, Oct 21, 2021 at 7:52 AM Jan Lindström wrote: > Hi Sergei, > > This does not seem to work. Consider following: > > CREATE TABLE t1 (id INT PRIMARY KEY) ENGINE=InnoDB; > INSERT INTO t1 VALUES (1); > connection node_2; > SET AUTOCOMMIT=OFF; > START TRANSACTION; > I

Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-24 Thread Jan Lindström
Hi Sergei, > > > --- a/sql/sql_parse.cc > > +++ b/sql/sql_parse.cc > > @@ -2159,6 +2159,7 @@ bool dispatch_command(enum enum_server_command > command, THD *thd, > > } > > DBUG_PRINT("quit",("Got shutdown command for level %u", level)); > > general_log_print(thd, command, NullS); >

Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-24 Thread Jan Lindström
Hi Marko, > > > I am sad to see that my comment regarding wsrep_is_BF_lock_timeout() > that I made in > https://github.com/MariaDB/server/commit/b74b53f0515b360bb5cddec1a506a2f4d4dc21b3#r52293813 > (June 17) has not been addressed. Do we really need that output? Do we > see that output in our inte