[Maria-developers] Open and close a TABLE_LIST at random place in code

2018-05-30 Thread Eugene Kosov
Hello. I need to see a table structure while executing some query (DELETE in my case, but there will be more query types in future). I have a TABLE_LIST which came from a parser. Now I'm opening it with open_table_only_view_structure(), examine table structure and close it, trying to prevent an

Re: [Maria-developers] Open and close a TABLE_LIST at random place in code

2018-05-31 Thread Eugene Kosov
t are you trying to do in the first place? > > On May 30, Eugene Kosov wrote: >>  Hello. >> >>  I need to see a table structure while executing some query (DELETE in my >> case, but there will be more query types in future). I have a TABLE_LIST >> which came from a p

Re: [Maria-developers] [beginner] how can I assign an existing ticket to myself?

2018-10-11 Thread Eugene Kosov
Hello. I can't help you with Jira because I do not know answers. But I know you just can write some patch and submit it on github. Guide is here https://mariadb.org/get-involved/getting-started-for-developers/ Feel free to ask any question in that mailing list. 11.10.2018, 17:42, "Takashi Sasak

Re: [Maria-developers] Do we support compilers that support C++11 but not thread_local?

2018-11-27 Thread Eugene Kosov
Hi. This page may be useful for you https://en.cppreference.com/w/cpp/compiler_support It says that until gcc 4.8 support is partial. And I can see a buildbot for 10.4 with gcc 4.4.6 http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-centos6-x86/builds/392/steps/compile/logs/stdio 27.1

Re: [Maria-developers] (no subject)

2019-01-12 Thread Eugene Kosov
Hi, Varsha. Here are some links to get started:https://mariadb.org/get-involved/getting-started-for-developers/https://jira.mariadb.org/browse/MXS-2044?jql=labels%20%3D%20beginner-friendly If you have no ideas you can grab some issue from list above and make a PR on github. I hope this this help. F

Re: [Maria-developers] f93af1f93e2: MDEV-12836 Avoid table rebuild when adding or removing of auto_increment settings

2019-02-04 Thread Eugene Kosov
Hi, Sergei! Thanks for you review. 04.02.2019, 21:59, "Sergei Golubchik" : > Hi, Eugene! > > On Feb 04, Eugene Kosov wrote: >>  revision-id: f93af1f93e2 (mariadb-10.3.12-19-gf93af1f93e2) >>  parent(s): d4144c8e010 >>  author: Eugene Kosov >>  committ

Re: [Maria-developers] f93af1f93e2: MDEV-12836 Avoid table rebuild when adding or removing of auto_increment settings

2019-02-05 Thread Eugene Kosov
Hi, Sergei! 04.02.2019, 23:34, "Sergei Golubchik" : > Hi, Eugene! > > On Feb 04, Eugene Kosov wrote: >>  >   create table t1 (a int unique); >>  >   insert t1 values (NULL),(NULL),(NULL); >>  >   alter table t1 modify a int auto_increment; >> &

Re: [Maria-developers] 1581f65be57: MDEV-13301 Optimize DROP INDEX, ADD INDEX into RENAME INDEX

2019-04-02 Thread Eugene Kosov
AME would be also good to have, at least for compatibility reasons. > > On Apr 01, Eugene Kosov wrote: >>  revision-id: 1581f65be57 (mariadb-10.4.3-69-g1581f65be57) >>  parent(s): e012d266807 >>  author: Eugene Kosov >>  committer: Eugene Kosov >>  timestamp: 2

Re: [Maria-developers] 1581f65be57: MDEV-13301 Optimize DROP INDEX, ADD INDEX into RENAME INDEX

2019-04-02 Thread Eugene Kosov
Hi, Sergei! 02.04.2019, 20:55, "Sergei Golubchik" : > Hi, Eugene! > > On Apr 02, Eugene Kosov wrote: >>  Hi, Sergei. >> >>  Thank you for the review. Style fixed. >> >>  01.04.2019, 17:18, "Sergei Golubchik" : >>  > Hi, Eugene! &

Re: [Maria-developers] Please review a patch for MDEV-19284 and MDEV-19285 (instant ALTER)

2019-04-23 Thread Eugene Kosov
Hello, Marko, Alexander. 23.04.2019, 15:37, "Marko Mäkelä" : > Bar, thank you for the revision. > > I ran all tests and found a regression for ROW_FORMAT=REDUNDANT, in > the test innodb.instant_alter_charset,redundant. We should allow any > extension of VARCHAR maximum length (in bytes) for > ROW_

Re: [Maria-developers] Please review a patch for MDEV-19284 and MDEV-19285 (instant ALTER)

2019-04-23 Thread Eugene Kosov
Hi. 23.04.2019, 16:49, "Alexander Barkov" : >    Hi, > > It seems I forgot to record the rdiff file. > > On 4/23/19 4:55 PM, Eugene Kosov wrote: >>  Hello, Marko, Alexander. >> >>  23.04.2019, 15:37, "Marko Mäkelä" : >>>  Bar, th

Re: [Maria-developers] MDEV-19284-19285v3

2019-05-14 Thread Eugene Kosov
Hi, Alexander! Patch looks good to me. 13.05.2019, 17:03, "Alexander Barkov" : > Hi Eugene, > > Please review the next round of the patch. > > Are any changes in tests still needed? > > Thanks! -- Eugene ___ Mailing list: https://launchpad.net/~mari

[Maria-developers] Proposal for automatic code formatting (clang-format)

2019-05-27 Thread Eugene Kosov
Hi. I'm proposing to add some tool that automatically formats source code. Main purpose is overall productivity. It's possible to save time on manual formatting. Also, reading a uniformly formatted code is easier. Some new languages has one correct coding style and code formatters. Examples are