Do we need HAVE_LONG_LONG in item.cc:
#ifdef HAVE_LONG_LONG
case MYSQL_TYPE_LONGLONG:
field= new (mem_root)
Field_longlong((uchar*) 0, max_length, null_ptr, 0, Field::NONE,
name, 0, unsigned_flag);
break;
#endif
?
There is no such check in field.cc:
case MYSQL_
In ha_innobase::info_low() there is following dirty hack:
/*
The MySQL optimizer seems to assume in a left join that n_rows
is an accurate estimate if it is zero. Of course, it is not,
since we do not have any locks on the rows yet at this phase.
Since SHOW TABLE STATUS seems to call this function
Hello!
On Mon, Sep 11, 2017 at 4:37 PM, Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Sep 11, Aleksey Midenkov wrote:
>> In ha_innobase::info_low() there is following dirty hack:
>>
>> if (n_rows == 0 && !(flag & HA_STATUS_TIME)) {
>> n_r
Hello!
Do we have to write test cases for such coding errors? Because this is
developer factor: either he does such errors or not. What are
conditions of getting PR merged?
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-de
Sergei,
On Sat, Oct 14, 2017 at 9:20 PM, Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 13, Aleksey Midenkov wrote:
>> Hello!
>>
>> Do we have to write test cases for such coding errors? Because this is
>> developer factor: either he does such errors or not.
TRING,
MYSQL_CONST_LEX_STRING. Why?
--
All the best,
Aleksey Midenkov
@midenok
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help :
On Sun, Oct 22, 2017 at 10:27 PM, Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 20, Aleksey Midenkov wrote:
>> Recent refactorings of replacing C strings with LEX_CSTRING which is
>> no doubt a good thing raise some questions:
>>
>> 1. Is it still guaranteed t
rt_time`
or it should be explicitly commented that it has nothing to do with
`start_time`. I.e. there is nothing wrong on algorithmic level, but
such data members may (and certainly would) lead developers to misuse
of `start_time_micro`.
--
All the best,
Aleksey Midenk
ke it is now.
--
All the best,
Aleksey Midenkov
@midenok
>
> I shortly discussed this with Vladislav Vaintroub, and he mentioned that the
> microsecond timestamp in THD::start_utime is updated at the start of each
> statement.
> I also looked at his MDEV-12345 performance fix. It look
Hi Alexander!
On Tue, Apr 10, 2018 at 12:15 PM, Alexander Barkov wrote:
> Hi Aleksey,
>
> You added Type_handler_hybrid_field_type::m_vers_trx_id.
>
> Is it really needed? It seems to be always "false".
> So this code in aggregate_for_comparison() seems to be a dead code:
>
> if (m_vers_trx_i
a type later.
>
> this is clearly a bug too.
>
>> I propose
>> 1. Either we fix the code to call resolve_unit() in fixed state.
>> 2. Or, if it's too hard, at least temporary disallow hybrid data type
>> Items to be used in AS OF.
>>
>> Is N1 do
Alexander,
this is leftover after MDEV-15991, so please feel free to fix.
Sorry for the inconvenience!
On Mon, Jun 25, 2018 at 7:50 AM, Alexander Barkov wrote:
> Hi Aleksey,
>
> I found some dead code in sp_head that seem to have appeared
> in your patch for "IB: 0.2 part IV".
>
> If you don't
Hi!
On Tue, Dec 25, 2018 at 1:27 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Dec 23, Aleksey Midenkov wrote:
> > revision-id: 7198e7c71fc (versioning-1.0.6-82-g7198e7c71fc)
> > parent(s): 6be155757b7
> > author: Aleksey Midenkov
> > committer: Aleksey
with this? I propose to duplicate blob buffer when record gets
into m_ordered_rec_buffer.
More details can be found here:
https://github.com/tempesta-tech/mariadb/issues/581
--
All the best,
Aleksey Midenkov
@midenok
___
Mailing list: https
new flag
LOG_EVENT_HAS_SEC_PART_F (for support sending Log_event without fractions).
Do you agree?
On Thu, Jan 31, 2019 at 1:10 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Jan 31, Aleksey Midenkov wrote:
> > revision-id: 14c2f90ad08 (versioning-1.0.7-1-g14c2f90ad08)
> > parent(s): a8efe7ab1f2
Andrei, thanks for explanation!
Agree with you and Sergei on that topic.
Sergei,
On Tue, Mar 12, 2019 at 9:04 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Mar 12, Aleksey Midenkov wrote:
> > Hi, Sergei,
> >
> > Thank you for observations! This task is in
Sergei,
On Wed, Mar 13, 2019 at 9:01 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Mar 13, Aleksey Midenkov wrote:
> > >
> > > Query_log_event() can already store microseconds, see Q_HRNOW flag.
> > > So better to add them to Rows_log_event, if n
Sergey,
On Wed, Mar 13, 2019 at 9:48 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Mar 13, Aleksey Midenkov wrote:
> > On Wed, Mar 13, 2019 at 9:01 PM Sergei Golubchik
> wrote:
> > > On Mar 13, Aleksey Midenkov wrote:
> > > > >
> > > > &
the best,
Aleksey Midenkov
@midenok
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https://help.launchpad.net/ListHelp
test program that invokes regcomp(), clang-8’s
> ASAN did not complain about it. I cannot immediately recognize what
> might be wrong in mysqltest.cc. Maybe there is some macro obfuscation
> at play.
>
> Marko
>
> On Mon, Mar 18, 2019 at 4:59 PM Aleksey Midenkov
> wr
/1234
On Tue, Mar 12, 2019 at 1:42 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Mar 11, Aleksey Midenkov wrote:
> > Hi, Sergei!
> >
> > ha_partition::handle_ordered_index_scan() stores records in
> > m_ordered_rec_buffer. Then TABLE::update_virtual_fields() upda
Hi Sergei,
On Thu, Mar 21, 2019 at 10:24 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Mar 20, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > It turned out that only vcol blobs are affected. They are allocated
> > by update_virtual_fields(), so it was enough
Hi, Sergei!
On Wed, Mar 27, 2019 at 1:04 AM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Mar 26, Aleksey Midenkov wrote:
> > revision-id: 74b2eba1ca6 (mariadb-10.3.12-115-g74b2eba1ca6)
> > parent(s): 2c0901d808b
> > author: Aleksey Midenkov
> > committer: Serg
What if system_time.sec_part == TIME_MAX_SECOND_PART here:
else
{
start_time= t;
start_time_sec_part= ++system_time.sec_part;
}
?
--
All the best,
Aleksey Midenkov
@midenok
___
Mailing list: https://launchpad.net
Hi Sergei!
On Wed, Mar 13, 2019 at 7:16 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Jan 31, Aleksey Midenkov wrote:
> > revision-id: ab6ef429a84 (versioning-1.0.7-2-gab6ef429a84)
> > parent(s): 14c2f90ad08
> > author: Aleksey Midenkov
> > committer: Alek
Hi Sergei!
On Wed, Mar 27, 2019 at 6:08 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Mar 27, Aleksey Midenkov wrote:
> > revision-id: 9976699033c (mariadb-10.3.7-30-g9976699033c)
> > parent(s): c0f97710582
> > author: Aleksey Midenkov
> > committer: Aleksey
UG_EXECUTE("time", print_start_time("Set time 4"););
}
user_time.val= hrtime_from_time(start_time) + start_time_sec_part;
PSI_CALL_set_thread_start_time(start_time);
start_utime= utime_after_lock= microsecond_interval_timer();
}
}
--
All the best,
On Thu, Apr 4, 2019 at 2:43 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Apr 04, Aleksey Midenkov wrote:
> > Hello, Sergei!
> >
> > In unversioned -> versioned scenario in the code below it first gets to
> Set
> > time 4, creates some records (on slave
On Thu, Apr 4, 2019 at 5:08 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Apr 04, Aleksey Midenkov wrote:
> > On Thu, Apr 4, 2019 at 2:43 PM Sergei Golubchik
> wrote:
> > >
> > If there is an installation from unversioned 5.3 to versioned 10.3 we
> >
On Thu, Apr 4, 2019 at 5:54 PM Aleksey Midenkov wrote:
>
> But it can't recover correct statements order anyway. The statements came
> from many master threads to single slave thread in some arbitrary order.
> What is the point in ordering them at slave end?
>
>
This is
Hi Sergei!
On Thu, Apr 4, 2019 at 8:59 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Apr 04, Aleksey Midenkov wrote:
> > On Thu, Apr 4, 2019 at 5:08 PM Sergei Golubchik
> wrote:
> >
> > > > > And I didn't want to force the master to include micr
Hello, Sergei!
On Fri, May 3, 2019 at 8:43 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On May 03, Aleksey Midenkov wrote:
> > revision-id: ef2519fee4e (versioning-1.0.5-17-gef2519fee4e)
> > parent(s): 56145be2951
> > author: Aleksey Midenkov
> > commit
, so
you'll have to find out your own codes via tack utiity. With strong
will and enough patience it is possible to add Ctrl+, Alt+, Shift+ and
their combinations as well.
This works only with MDEV-17609 patch.
--
All the best,
Aleksey Midenkov
@midenok
Hi Sergei!
On Fri, Jun 7, 2019 at 8:45 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> Looks ok, thanks!
> No requests to change anything,
> but still a couple of "why" questions, see below
>
> On Jun 07, Aleksey Midenkov wrote:
> > revision-id: 66f93
please move clear_error() to the caller
> (ha_innodb.cc) and remove the assert.
>
> On Jul 04, Aleksey Midenkov wrote:
> > revision-id: 4670c85a48c (mariadb-10.4.5-47-g4670c85a48c)
> > parent(s): 0f55a9eb73b
> > author: Aleksey Midenkov
> > committer: Aleksey Midenkov
&
Hi Sergei!
Fixed in `bb-10.3-midenok`.
On Fri, Aug 30, 2019 at 8:49 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Aug 30, Aleksey Midenkov wrote:
> > revision-id: c3d2998a038 (versioning-1.0.3-71-gc3d2998a038)
> > parent(s): 611488e3d90
> > author: Aleksey Miden
Hi Sergei,
On Fri, Oct 25, 2019 at 9:44 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 25, Aleksey Midenkov wrote:
> > revision-id: d5352b8154d (mariadb-10.2.25-54-gd5352b8154d)
> > parent(s): 1153950ad0a
> > author: Aleksey Midenkov
> > committer: Alek
Hi Sergei,
On Thu, Sep 26, 2019 at 4:15 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Sep 26, Aleksey Midenkov wrote:
> > revision-id: f6269a85ad7 (mariadb-10.4.7-38-gf6269a85ad7)
> > parent(s): a9ca752f1a9
> > author: Aleksey Midenkov
> > committer: Aleksey
Sergei,
On Thu, Oct 31, 2019 at 2:03 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 30, Aleksey Midenkov wrote:
> > On Fri, Oct 25, 2019 at 9:44 PM Sergei Golubchik
> wrote:
> > > On Oct 25, Aleksey Midenkov wrote:
> > > > revision-id: d5352
Hi Sergei!
On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> Just a question for now
> (and a couple of style comments, I didn't look at the logic yet)
>
> On Dec 04, Aleksey Midenkov wrote:
> > revision-id: c91ec05e01b (mariadb-10.4.4-4
Hi, Sergei!
On Fri, Dec 6, 2019 at 5:34 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 05, Aleksey Midenkov wrote:
> > >
> > > > 3. Invalidate referenced shares on:
> > > >
> > > > - RENAME TABLE
> > > > - DROP TABLE
ins and use class methods instead. We can't use THD directly
though, because we don't want it compiled in plugins. So we compile
non-inline methods in server that are used in plugin.
--
All the best,
Aleksey Midenkov
@midenok
___
Mailing list
Sergei,
On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 18, Aleksey Midenkov wrote:
> > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote:
> >
> > But it's better to be from the other side:
> >
> > bool L
Sergei,
On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 18, Aleksey Midenkov wrote:
> > Sergei,
> >
> > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik
> wrote:
> >
> > > Hi, Aleksey!
> > >
> > >
Hi, Sergei!
On Thu, Dec 19, 2019 at 11:32 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 18, Aleksey Midenkov wrote:
> > On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik
> wrote:
> > > On Dec 18, Aleksey Midenkov wrote:
> > > > On Wed, Dec 18, 20
Hi, Sergei!
On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 22, Aleksey Midenkov wrote:
> > > >
> > > > Particularly to this function I don't like its name, semantics and
> > > > signature.
> > >
&g
Hi, Sergei!
On Wed, Jan 1, 2020 at 4:07 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Jan 01, Aleksey Midenkov wrote:
> > On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote:
> > > On Dec 22, Aleksey Midenkov wrote:
> >
> > My concern is mostly ab
d if we'll want to change it to "pp%u" it should
> be done only in one place.
>
Done.
> 2. don't overload operators, use, say,
>
> bool greater_than(size_t seconds)
>
Done.
> But overall it's pretty good. A nice idea with a separate thread.
&g
Sergei,
On Mon, Feb 17, 2020 at 8:23 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 17, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > On Sat, Nov 9, 2019 at 12:03 AM Sergei Golubchik wrote:
> > >
> > > Hi, Aleksey!
> > >
&g
Sergei,
On Wed, Feb 19, 2020 at 8:27 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 18, Aleksey Midenkov wrote:
> > On Mon, Feb 17, 2020 at 8:23 PM Sergei Golubchik wrote:
> > > On Feb 17, Aleksey Midenkov wrote:
> > > > On Sat, Nov 9, 2019 at 12
Hi, Sergei!
On Tue, Apr 7, 2020 at 3:03 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 07, Aleksey Midenkov wrote:
> > revision-id: 9941c6a3179 (mariadb-10.5.2-164-g9941c6a3179)
> > parent(s): 920c3c6b237
> > author: Aleksey Midenkov
> > committer: A
9:25 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 09, Aleksey Midenkov wrote:
> > > > +#
> > > > +# MDEV-17554 Auto-create new partition for system versioned tables
> > > > with history partitioned by INTERVAL/LIMIT
> > >
er. Disagree?
>
> And for the test - please add the case for a table with no PRIMARY KEY, bug
> with the UNIQUE instead.
>
> Best regards!
> HF
>
--
All the best,
Aleksey Midenkov
@midenok
___
Mailing list: https://launc
d1 the one I was supposed to review?
Yes.
>
> On May 17, Aleksey Midenkov wrote:
> > revision-id: b97e45651d1 (mariadb-10.4.7-33-gb97e45651d1)
> > parent(s): 7587975bf06
> > author: Aleksey Midenkov
> > committer: Aleksey Midenkov
> > timestamp: 2019-08-1
Sergei,
On Tue, May 19, 2020 at 1:52 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On May 19, Aleksey Midenkov wrote:
> > > > diff --git a/mysql-test/suite/versioning/engines.combinations
> > > > b/mysql-test/suite/versioning/engines.combinations
> >
t really see
> how update_virtual_field() can ever get an error. But it's not a
> particularly future-proof approach. And I just might be wrong about
> errors.
>
> On Apr 23, Aleksey Midenkov wrote:
> > revision-id: 7d593466a22 (mariadb-10.2.28-4-g7d593466a22)
>
Hi Sergei!
On Wed, Jul 1, 2020 at 12:26 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 29, Aleksey Midenkov wrote:
> > revision-id: 9bf4b92cbc5 (mariadb-10.5.2-168-g9bf4b92cbc5)
> > parent(s): 478301d9b9a
> > author: Aleksey Midenkov
> > committer: A
Hi Sergei!
On Wed, Oct 21, 2020 at 4:19 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 20, Aleksey Midenkov wrote:
> > revision-id: 0cd5377e9ff (mariadb-10.2.31-357-g0cd5377e9ff)
> > parent(s): dc716da4571
> > author: Aleksey Midenkov
> > committer: Alek
Sergei,
On Sat, Oct 31, 2020 at 12:54 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Oct 25, Aleksey Midenkov wrote:
> > On Wed, Oct 21, 2020 at 4:19 PM Sergei Golubchik
wrote:
> > > On Oct 20, Aleksey Midenkov wrote:
> > > > revision-id: 0cd537
commit, but the diff below includes all three commits that mention
MDEV-18734.
>
> On Nov 02, Aleksey Midenkov wrote:
> > revision-id: 2f9bbf392072 (mariadb-10.2.31-543-g2f9bbf392072)
> > parent(s): 1f4960e3f2ac
> > author: Aleksey Midenkov
> > committer: Aleksey
Hi Sergei!
The updated patches are here:
https://github.com/MariaDB/server/commits/2c2e79487a9189e02fce8f884a9ab2b42b9aa333
On Tue, Nov 3, 2020 at 8:28 PM Aleksey Midenkov wrote:
>
> Sergei,
>
> the updated patches are here:
>
>
https://github.com/Mari
Hi Sergei!
On Tue, Sep 22, 2020 at 8:31 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> Wow, this comes so late, sorry! :(
>
> But it's fixVersion=10.6 and on the top my list, so here you are.
>
> On May 07, Aleksey Midenkov wrote:
> > >
>
Hi Sergei,
On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Nov 03, Aleksey Midenkov wrote:
> >
> > the updated patches are here:
> >
> > https://github.com/MariaDB/server/commits/5f6bcd6cd0145513974b0dfc5b2cefba28b72f1a
>
>
Hi, Sergei!
On Tue, Dec 1, 2020 at 7:54 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Nov 24, Aleksey Midenkov wrote:
> >
> > And mysqldump should take care of setting system_versioning_insert_history
> > sysvar. Right? Is everything else in the task descripti
Sergei,
On Thu, Feb 25, 2021 at 11:09 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 25, Aleksey Midenkov wrote:
> > > On Nov 24, Aleksey Midenkov wrote:
> > > > 1. Add server variable system_versioning_insert_history which will
> > >
ake another look or it's on you now?
>
> I think I've never got a reply to this question.
> Shall I take another look at the bb-10.6-midenok-MDEV-17554 branch or
> not yet?
I've updated the branch on top of the latest 10.6. Please go ahead and
take a look.
>
> &
Hi Sergei,
On Mon, Apr 5, 2021 at 8:04 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 26, Aleksey Midenkov wrote:
> > > > >
> > > > > In other words, if one can create an arbitrary history by
> > > > > manipulating @@timestamp vari
Hi Sergei,
On Sun, Apr 4, 2021 at 2:48 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> Note, it's a review of the `git diff 82e44d60d1e 8175ce8a5f1`
> so it's not only commit c4de76aeff8
>
> On Apr 04, Aleksey Midenkov wrote:
> > revision-id: c4de76a
Hi Sergei,
On Thu, Apr 8, 2021 at 3:30 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 07, Aleksey Midenkov wrote:
> > > > +
> > > > +--echo # INSERT, INSERT .. SELECT don't increment partitions
> > >
> > > it's not reall
Hi Sergei,
On Sat, Apr 10, 2021 at 11:12 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 09, Aleksey Midenkov wrote:
> > > >
> > > > --echo # Increment from 3 to 5
> > > > --echo # Increment from 3 to 6, manual names, LOCK TABLES
> &
Hi Sergei,
On Sun, Apr 11, 2021 at 7:21 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 11, Aleksey Midenkov wrote:
> > On Sat, Apr 10, 2021 at 11:12 PM Sergei Golubchik wrote:
> > > On Apr 09, Aleksey Midenkov wrote:
> > > > > &g
Hi Sergei,
On Mon, Apr 12, 2021 at 3:14 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 11, Aleksey Midenkov wrote:
> >
> > It was a conscious choice. Quantitative characteristic is implied.
>
> This isn't going anywhere.
Of course. And because of that
Hi, Sergei!
On Mon, Apr 12, 2021 at 8:46 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 12, Aleksey Midenkov wrote:
> > On Mon, Apr 12, 2021 at 3:14 PM Sergei Golubchik wrote:
> > >
> > > On Apr 11, Aleksey Midenkov wrote:
> > > >
Hi Sergei!
On Tue, Apr 6, 2021 at 3:29 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 06, Aleksey Midenkov wrote:
> > > > But, since we need to specify implicit system fields we cannot
> > > > avoid adding one more session variable. In
Sergei,
sorry, I forgot to add that implementation with @@force_fields_visible
is cleaner and shorter. Also that helps to deprecate sysvers_show and
MDEV-16587 which I would greatly appreciate.
On Tue, Apr 27, 2021 at 4:07 PM Aleksey Midenkov wrote:
>
> Hi Sergei!
>
> On Tue, Apr
ergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 27, Aleksey Midenkov wrote:
> > > On Apr 06, Aleksey Midenkov wrote:
>
> > > > To be able to specify them in INSERT command they must be at least
> > > > user-invisible. Sys
22158b3c05a,
> so not only commit 38a888da0f1.
>
> The main thing below - I didn't understand a couple of changes and asked
> for clarifications.
>
> On May 30, Aleksey Midenkov wrote:
> > revision-id: 38a888da0f1 (mariadb-10.5.2-653-g38a888da0f1)
> > parent(s): bc
Hi Sergei!
Users could benefit from this fix of MDEV-18734 since the last
changes. Do you really think the open questions left are so important
for this bug to be still not pushed?
On Tue, Jan 26, 2021 at 1:51 AM Aleksey Midenkov wrote:
>
> Hi Sergei,
>
> On Tue, Dec 22, 2020 at 7:
Sergei,
On Wed, Jun 2, 2021 at 12:06 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 01, Aleksey Midenkov wrote:
> > > > +# Don't auto-create new partition on DELETE HISTORY:
> > > > +set timestamp= unix_timestamp('2000-01-01 00:00:00'
Hi Sergei!
I'm sorry, what other I can say apart from commits descriptions? This
code fixes the roots of problems while you suggest to keep bugs
masked.
On Wed, Jun 2, 2021 at 3:23 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > r
Sergei,
On Wed, Jun 2, 2021 at 2:00 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > > > > > diff --git a/mysql-test/suite/versioning/t/partition.test
> > > > > > b/mysql-test/suite/versioning/t/partition.test
Sergei,
On Wed, Jun 2, 2021 at 9:06 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > > > > > > >
> > > > > > > > - if (!(sql_lock= (MYSQL_LOCK*)
> > &
Sergei,
On Wed, Jun 2, 2021 at 11:37 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > On Wed, Jun 2, 2021 at 9:06 PM Sergei Golubchik wrote:
> > >
> > > On Jun 02, Aleksey Midenkov wrote:
> > > > &
Sergei,
On Thu, Jun 3, 2021 at 11:30 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 03, Aleksey Midenkov wrote:
> > On Wed, Jun 2, 2021 at 11:37 PM Sergei Golubchik wrote:
> > > On Jun 02, Aleksey Midenkov wrote:
> > > > On Wed, Jun 2, 2021 at 9
Sergei,
On Thu, Jun 3, 2021 at 12:27 PM Aleksey Midenkov wrote:
>
> Sergei,
>
> On Thu, Jun 3, 2021 at 11:30 AM Sergei Golubchik wrote:
> >
> > Hi, Aleksey!
> >
> > On Jun 03, Aleksey Midenkov wrote:
> > > On Wed, Jun 2, 2021 at 11:37 PM Sergei
t; fix before the next release.
>
> On Jun 01, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > Users could benefit from this fix of MDEV-18734 since the last
> > changes. Do you really think the open questions left are so important
> > for this bug to be still not
Hi Sergei!
On Thu, Jun 3, 2021 at 1:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jan 26, Aleksey Midenkov wrote:
> > On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
> > > On Nov 03, Aleksey Midenkov wrote:
> > >
> > > And please, pre
Hi Sergei!
On Tue, Jun 8, 2021 at 3:04 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 08, Aleksey Midenkov wrote:
> > revision-id: b3844107287 (mariadb-10.5.2-424-gb3844107287)
> > parent(s): 27d66d644cf
> > author: Aleksey Midenkov
> > committer: A
Hi Sergei!
The rebased patches are in
bb-10.7-midenok-MDEV-17554
Do we have open questions on review?
On Thu, Jun 3, 2021 at 1:52 PM Aleksey Midenkov wrote:
>
> Sergei,
>
> On Thu, Jun 3, 2021 at 12:27 PM Aleksey Midenkov wrote:
> >
> > Sergei,
> >
> > On
Hi Sergei!
Now updated the patch to
git diff dfa2d0bc13..9b564832e3
On Wed, Jul 21, 2021 at 11:33 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> As before, despite the email subject, it's
>
> git diff dfa2d0bc13..e533b5fb307
>
> Don't be confused :)
>
Hi Sergei!
On Mon, Jul 26, 2021 at 7:35 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jul 23, Aleksey Midenkov wrote:
> > Now updated the patch to
> >
> > git diff dfa2d0bc13..9b564832e3
>
> Thanks, no new comments about it. Just one question be
sey!
>
> On Aug 23, Aleksey Midenkov wrote:
> > revision-id: f14cfd22115 (mariadb-10.6.1-63-gf14cfd22115)
> > parent(s): 03225474d60
> > author: Aleksey Midenkov
> > committer: Aleksey Midenkov
> > timestamp: 2021-08-17 20:01:48 +0300
> >
the 3-command
> sequence, so non-atomic. But, of course, making it atomic makes perfect
> sense.
>
> See other comments below.
>
> On Aug 23, Aleksey Midenkov wrote:
> > commit 6768e3a2830
> > Author: Aleksey Midenkov
> > Date: Thu Jul 29 22:54:12 20
Hi Sergei!
On Fri, Aug 27, 2021 at 3:23 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Aug 26, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > The updated branch is cabd0530 bb-10.7-midenok-MDEV-22166
>
> Commits
>
> cabd0530426 Parser refacto
Hi Sergei!
Updated bb-10.7-midenok-MDEV-22166 is d4668e7254c6
On Thu, Aug 26, 2021 at 9:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> Some replies.
>
> On Aug 26, Aleksey Midenkov wrote:
> > > > diff --git a/sql/lex.h b/sql/lex.h
> > > > index cbf
Hi Sergei!
On Wed, Sep 1, 2021 at 3:46 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > revision-id: 19fbfab084f (mariadb-10.6.1-67-g19fbfab084f)
> > parent(s): 8009680fbc3
> > author: Aleksey Midenkov
> > committer: Ale
Hi, Sergei!
On Wed, Sep 1, 2021 at 2:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Aug 30, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > Updated bb-10.7-midenok-MDEV-22166 is d4668e7254c6
>
> I'll look right after replying to this e
Sergei,
On Wed, Sep 1, 2021 at 8:21 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > revision-id: dc2ace70f1b (mariadb-10.6.1-68-gdc2ace70f1b)
> > parent(s): 19fbfab084f
> > author: Aleksey Midenkov
> > committer: Alekse
Sergei,
On Wed, Sep 1, 2021 at 9:07 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > >
> > > We have a series of IF_xxx(A,B) macros, IF_PARTITIONING, IF_WIN, etc.
> > > IF_DBUG(A,B) expands to A if dbug is compiled i
Sergei,
On Wed, Sep 1, 2021 at 10:13 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > > >
> > > > +move_out_partition:
> > > > +MIGRATE_SYM PARTITION_SYM
> > > > +| MIGRATE_SYM OU
1 - 100 of 131 matches
Mail list logo
