Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

2017-10-05 Thread Kristian Nielsen
andrei.el...@pp.inet.fi writes: > The patch is ready for review and can be located on bb-10.1-andrei, > https://github.com/MariaDB/server/pull/460 I think the patch is ok, it looks of good quality and well thought out. A few comments/suggestions: 1. In drop_domain(), the use of the condition i

[Maria-developers] MDEV-13972 crash in Item_func_sec_to_time::get_date

2017-10-05 Thread Alexander Barkov
Hello Sergei, Please review a patch for MDEV-13972. The patch is for 5.5, as we agreed in slack. Thanks! commit 003c19c7677e1ce5b18b4081e21b7864700f8250 Author: Alexander Barkov Date: Thu Oct 5 21:07:19 2017 +0400 MDEV-13972 crash in Item_func_sec_to_time::get_date Item_func_sec

Re: [Maria-developers] [Commits] 3f7e619647f: MDEV-13928: Missing symbols building RocksDB on macOS 10.12.6

2017-10-05 Thread Sergei Golubchik
Hi, Varun! Why did it fail only on MacOS X? On Oct 06, Varun wrote: > revision-id: 3f7e619647f7bc1ec31a6118b403da805c48ae51 > (mariadb-10.2.5-653-g3f7e619647f) > parent(s): 08c493c62afae0e81f9da6bb9b86efe99a9a763d > author: Varun Gupta > committer: Varun Gupta > timestamp: 2017-10-06 00:20:08 +0

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

2017-10-05 Thread andrei . elkin
Kristian, salve. Thanks for checking the patch so promptly! > andrei.el...@pp.inet.fi writes: > >> The patch is ready for review and can be located on bb-10.1-andrei, >> https://github.com/MariaDB/server/pull/460 > > I think the patch is ok, it looks of good quality and well thought out. > > A fe