Re: [Maria-developers] MDEV-10598 - bb-10.2-compatibility

2017-03-16 Thread Alexander Barkov
Hello Jerome, On 03/14/2017 06:07 PM, jerome brauge wrote: > Hi Alexander, > Can you review this patch ? > I could add more tests when your others points will be corrected. I have a few suggestions. Let's discuss different topics in separate letters. Here're my suggestions for sql_yacc_ora.yy

Re: [Maria-developers] MDEV-10598 - bb-10.2-compatibility

2017-03-16 Thread Alexander Barkov
Hello Jerome, On 03/14/2017 06:07 PM, jerome brauge wrote: > Hi Alexander, > Can you review this patch ? > I could add more tests when your others points will be corrected. SHOW PROCEDURE CODE is available in debug builds only. I moved the related code from sp-cursor-decl.test to sp-code.test

Re: [Maria-developers] MDEV-10598 - bb-10.2-compatibility

2017-03-16 Thread Alexander Barkov
Hello Jerome, On 03/14/2017 06:07 PM, jerome brauge wrote: > Hi Alexander, > Can you review this patch ? > I could add more tests when your others points will be corrected. I tried to simplify your patch slightly. sp_instr_cpush instructions are now created from the array sp_pcontext::m_cursors

Re: [Maria-developers] MDEV-10598 - bb-10.2-compatibility

2017-03-16 Thread jerome brauge
Hello Alexander. I am out of office until monday. I m ok with all your proposal. I will try to use your coding style for futur work. Many thank. Have a nice evening. Jerome Envoyé depuis mon smartphone Samsung Galaxy. Message d'origine De : Alexander Barkov Date : 16/03/20

Re: [Maria-developers] 9f33288dde9: MDEV-11115 CHECK constraints are not shown in I_S.TABLE_CONSTRAINTS

2017-03-16 Thread Sergei Golubchik
Hi, Jacob! On Mar 16, jacob.mat...@mariadb.com wrote: > revision-id: 9f33288dde950343c46e6c5d6a4f233de191f477 > (mariadb-10.2.3-245-g9f33288dde9) > parent(s): 7c152ac68a7993bca99ef23e073b0a0974b087a1 > author: Jacob Mathew > committer: Jacob Mathew > timestamp: 2017-03-16 14:41:41 -0700 > message