Re: [Maria-developers] [Commits] 00c30e5: MDEV-11645: archive.archive fails in buildbot with valgrind (Use of uninitialised value)

2017-03-01 Thread Sergey Petrunia
Hi Varun, Please * fix the commit comment * add a comment * fix the coding style as indicated below. (and also please conform to the coding style in the future. If its requirements are not clear, lets sit down once and discuss them) On Wed, Mar 01, 2017 at 07:50:01AM +0530, Varun wrote: > rev

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-03-01 Thread Sergei Golubchik
Hi, Alexander! On Feb 28, Alexander Barkov wrote: > commit af8887b86ccbaea8782cf54fe445cf53aaef7c06 > Author: Alexander Barkov > Date: Tue Feb 28 10:28:09 2017 +0400 > > MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT > in subquery > > The bug happens bec

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-03-01 Thread Oleksandr Byelkin
Hi! Am 01.03.2017 um 13:56 schrieb Sergei Golubchik: Hi, Alexander! On Feb 28, Alexander Barkov wrote: commit af8887b86ccbaea8782cf54fe445cf53aaef7c06 Author: Alexander Barkov Date: Tue Feb 28 10:28:09 2017 +0400 MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT

Re: [Maria-developers] [s...@mariadb.org: [Commits] 02d155a: MDEV-11418 - AliSQL: [Feature] Issue#1 KILL IDLE TRANSACTIONS]

2017-03-01 Thread Michael Widenius
Hi! On Tue, Feb 21, 2017 at 2:37 PM, Sergey Vojtovich wrote: > Hi Monty, > > Please review this patch. > > Thanks, > Sergey > > - Forwarded message from Sergey Vojtovich - > > Date: Tue, 21 Feb 2017 16:29:36 +0400 > From: Sergey Vojtovich > To: comm...@mariadb.org > Subject: [Commits]

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-03-01 Thread Sergei Golubchik
Hi, Oleksandr! On Mar 01, Oleksandr Byelkin wrote: > > > > So, I see few possible approaches to this and other similar queries: > > > > 1. We specify that no Item's val method can modify the buffer of the > > arguments. That is, CONCAT will always have to copy. SUBSTR won't > > need to cop

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-03-01 Thread Oleksandr Byelkin
Am 01.03.2017 um 15:04 schrieb Sergei Golubchik: Hi, Oleksandr! On Mar 01, Oleksandr Byelkin wrote: So, I see few possible approaches to this and other similar queries: 1. We specify that no Item's val method can modify the buffer of the arguments. That is, CONCAT will always have to copy

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-03-01 Thread Sergei Golubchik
Hi, Oleksandr! On Mar 01, Oleksandr Byelkin wrote: > > Actually val_str accept buffer and if we ensure that the buffer used > each time is different and value stored in it changing it is not a > problem at all, problem is that some Items do not use it in sake of > the efficiency, so maybe we shou