Re: [Maria-developers] [Commits] ef590fa: MDEV-7409 On RBR, extend the PROCESSLIST info to include at least the name of the recently used table

2017-01-31 Thread Sachin Setiya
Hi Kristian, Daniel, On Thu, Jan 26, 2017 at 2:24 PM, Kristian Nielsen wrote: > Sachin Setiya writes: > >> On Tue, Jan 24, 2017 at 2:32 AM, Daniel Black >> wrote: > >>> On 24/01/17 04:30, SachinSetiya wrote: >>> > revision-id: ef590faa0e21d25a2dc5153f938135612b17ecbc >>> (mariadb-10.1.20-31-gef

Re: [Maria-developers] Mdev-10664 Add statuses about optimistic parallel replication stalls.

2017-01-31 Thread Sachin Setiya
HI Kristian, On Thu, Jan 26, 2017 at 2:05 PM, Kristian Nielsen wrote: > Sachin Setiya writes: > >>> Why did you decide to put this information into a status variable? >>> Normally, >>> slave status is seen in SHOW SLAVE STATUS, which supports showing status >>> for >>> a particular connection wi

Re: [Maria-developers] Please review MDEV-9979 Keywords UNBOUNDED, PRECEDING, FOLLOWING, TIES, OTHERS should be non-reserved

2017-01-31 Thread Vicențiu Ciorbaru
Hi Alexander, OK to push. Please add the version of the standard you used to check these keywords as non-reserved both to the commit message, as well as the keywords themselves. I used 2011 standard draft to check. Vicențiu On Mon, 23 Jan 2017 at 09:28 Alexander Barkov wrote: > Hello Vicențiu,

Re: [Maria-developers] Please review MDEV-11692 Comparison data type aggregation for pluggable data types

2017-01-31 Thread Vicențiu Ciorbaru
Hi Alexander! Comments inline. OK to push otherwise. > diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc > index fc3f81a..6fcfec4 100644 > --- a/sql/item_cmpfunc.cc > +++ b/sql/item_cmpfunc.cc > @@ -118,8 +118,11 @@ static int cmp_row_type(Item* item1, Item* item2) > 0 otherwise > */

Re: [Maria-developers] Please review MDEV-9979 Keywords UNBOUNDED, PRECEDING, FOLLOWING, TIES, OTHERS should be non-reserved

2017-01-31 Thread Alexander Barkov
Hello Vicențiu, On 01/31/2017 05:13 PM, Vicențiu Ciorbaru wrote: > Hi Alexander, > > OK to push. Please add the version of the standard you used to check > these keywords as non-reserved both to the commit message, as well as > the keywords themselves. I used 2011 standard draft to check. Thanks

[Maria-developers] valgrind + SSL

2017-01-31 Thread Alexander Barkov
Hello Elena, You wrote on IRC: On 01/31/2017 08:10 PM, Slack wrote: > bar: hi! We have this in 10.0 valgrind, what do you think about it? > http://buildbot.askmonty.org/buildbot/builders/work-amd64-valgrind/builds/9873/steps/test/logs/stdio > > i'm asking you because you fixed a similar-looking