Re: [Maria-developers] Mdev-10664 Add statuses about optimistic parallel replication stalls.

2017-01-26 Thread Kristian Nielsen
Sachin Setiya writes: >> Why did you decide to put this information into a status variable? >> Normally, >> slave status is seen in SHOW SLAVE STATUS, which supports showing status >> for >> a particular connection without using @@default_master_connection. >> >> Sorry for this , I guess It was a

Re: [Maria-developers] [Commits] ef590fa: MDEV-7409 On RBR, extend the PROCESSLIST info to include at least the name of the recently used table

2017-01-26 Thread Kristian Nielsen
Sachin Setiya writes: > On Tue, Jan 24, 2017 at 2:32 AM, Daniel Black > wrote: >> On 24/01/17 04:30, SachinSetiya wrote: >> > revision-id: ef590faa0e21d25a2dc5153f938135612b17ecbc >> (mariadb-10.1.20-31-gef590fa) >> >> >> >thd_proc_info(thd, message); >> > + DBUG_EXECUTE_IF("should_sleep_f

[Maria-developers] MDEV-11913 Split sp_get_item_value() into methods in Type_handler

2017-01-26 Thread Alexander Barkov
Hello Sanja, Can you please review a patch for MDEV-11913? Thanks! commit 269368e696aa9b03be743e7fbc0a5838ba54f49a Author: Alexander Barkov Date: Thu Jan 26 13:01:52 2017 +0400 MDEV-11913 Split sp_get_item_value() into methods in Type_handler This patch also fixes: MDEV-11815

[Maria-developers] MDEV-11829 - Questions on timezones

2017-01-26 Thread Seth Shelnutt
I am working on a patch for adding datetime parsing support for RFC3339 as reported in MDEV-11829. In examining methods to use the provided offset to convert the parsed datetime to the timezone of mariadb. I have some questions on the my_system_gmt_sec function in sql-common/my_time.c . >From tes

Re: [Maria-developers] MDEV-10142 - bb-10.2-compatibility

2017-01-26 Thread Alexander Barkov
Hello Jerome, On 01/24/2017 07:33 PM, jerome brauge wrote: > Hello Alexander, > This patch works fine. Thanks. Thanks for confirmation. The patch is now in review. I'll push it as soon as it gets reviewed, then will let you know. > But I have a question: why do you want to preserve behavior of

[Maria-developers] MDEV-10142 - / MDEV-10343 - bb-10.2-compatibility

2017-01-26 Thread jerome brauge
Hi, I'm testing datatype compatibility provide by MDEV-10343 and I have some comments: 1) Oracle character datatype (char, varchar, varchar2) doesn't accept a length of 0 char Example : select cast('tt' as char(0)) from dual; ORA-01723: zero-length columns are not allowed MariaDB

Re: [Maria-developers] [Commits] fb49b98: MDEV-10436 non-deterministic vcol does not force rbr

2017-01-26 Thread Daniel Black
On 25/01/17 00:33, sachin wrote: > @@ -5824,6 +5826,16 @@ int THD::decide_logging_format(TABLE_LIST *tables) >table->table->file->ht) > multi_access_engine= TRUE; > > + /* > + Loop through each table field if it is virtual field check if it is > deterministic

Re: [Maria-developers] MDEV-10142 - / MDEV-10343 - bb-10.2-compatibility

2017-01-26 Thread Alexander Barkov
Hello Jerome, On 01/26/2017 11:35 PM, jerome brauge wrote: > Hi, > I'm testing datatype compatibility provide by MDEV-10343 and I have some > comments: > 1) Oracle character datatype (char, varchar, varchar2) doesn't accept a > length of 0 char > Example : > select cast('tt' as char(0)) fr

[Maria-developers] Fwd: [Commits] d1124c9: MDEV-10812 WSREP causes responses being sent to protocol commands that must not send a response

2017-01-26 Thread Sachin Setiya
Hi Nirbhay! On Wed, Jan 25, 2017 at 7:53 PM, Nirbhay Choubey wrote: > Hi Sachin, > > My comments below. > > On Sun, Jan 22, 2017 at 7:18 AM, SachinSetiya > wrote: >> >> revision-id: d1124c98cbede6366e4b4d27a23dcf5b9d207cf0 >> (mariadb-10.1.21-2-gd1124c9) >> parent(s): a14638581b4c8ef175e68dccff