Re: [Maria-developers] new PLUGIN API.

2016-10-25 Thread Sergei Golubchik
Hi, Alexey! On Oct 25, Alexey Botchkov wrote: > To me both approaches are like indistingushable. The 'service' is too > just the set of callback methods. I don't know if we should keep that > 'plugin type' specification or not, the very idea is getting server's > data and sending commands to serv

Re: [Maria-developers] new PLUGIN API.

2016-10-25 Thread Alexey Botchkov
To me both approaches are like indistingushable. The 'service' is too just the set of callback methods. I don't know if we should keep that 'plugin type' specification or not, the very idea is getting server's data and sending commands to server using the callback functions. That way plugins get f

Re: [Maria-developers] new PLUGIN API.

2016-10-23 Thread Sergey Vojtovich
Hi Alexey, Just soem thought from my side... > +const char *ap_get_database(MYSQL_THD thd) > +{ > + if (!thd) > +return ""; > + > + return thd->db; > +} I think this should be benchmarked with perf. Things like this ain't good performance wise (we already fixed a bunch of those). That is wh

Re: [Maria-developers] new PLUGIN API.

2016-10-23 Thread Sergei Golubchik
Hi, Alexey! On Oct 23, Alexey Botchkov wrote: > Hi, Sergei. > > I'd like to draw your attention to this old issue: > https://jira.mariadb.org/browse/MDEV-7389 > > The idea was to make a bigger thing - to modify the plugin API > so it is easier to use and let user to do more. Particularly to > no