Re: [Maria-developers] problem with savepoints in mariadb 5.5.25

2012-07-11 Thread Rich Prohaska
Hello, Thanks. Per Elena's request, i created bug #1023404. Rich Prohaska On Wed, Jul 11, 2012 at 7:27 AM, Michael Widenius wrote: > > Hi! > >> "Rich" == Rich Prohaska writes: > > Rich> Hello, > Rich> I posted our fix at lp:~prohaska7/maria/5.5-savepoint-offset-fix. > Rich> Does it make sen

Re: [Maria-developers] problem with savepoints in mariadb 5.5.25

2012-07-10 Thread Elena Stepanova
Hi Rich, Could you please file a bug at https://bugs.launchpad.net/maria, with the description of the problem and [a link to] your patch? I could do it on your behalf, but I suppose if the report belongs to you, it will be more convenient for you to track the progress and for others to request

Re: [Maria-developers] problem with savepoints in mariadb 5.5.25

2012-07-10 Thread Rich Prohaska
Hello, I posted our fix at lp:~prohaska7/maria/5.5-savepoint-offset-fix. Does it make sense? Thanks Rich Prohaska On Mon, Jul 9, 2012 at 7:17 PM, Rich Prohaska wrote: > Hello, > It turns out the previous explanation was WRONG. > > Here is another stab at the problem. My understanding of the save

Re: [Maria-developers] problem with savepoints in mariadb 5.5.25

2012-07-09 Thread Rich Prohaska
Hello, It turns out the previous explanation was WRONG. Here is another stab at the problem. My understanding of the savepoint initialization process is: 1. the handlerton sets its savepoint_offset to the size of its local savepoint data. 2. the ha_initailize_handlerton function reads it, modifie

[Maria-developers] problem with savepoints in mariadb 5.5.25

2012-07-09 Thread Rich Prohaska
Hello, We observed a problem with savepoints in Mariadb 5.5.25. The problem at the SQL layer is that a "rollback to savepoint" statement would get an error after the savepoint was created. The problem was caused by the savepoint name in the savepoint stack getting overwritten by the handlerton s