Kristian Nielsen writes:
> If a mistake, I can push a correction for this to 5.2.
I now pushed a fix for this to 5.2.
- Kristian.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscrib
Kristian Nielsen wrote:
> "Philip Stoev" writes:
>
>> This code was added as a fix for MySQL bug #38005 and then removed as
>> a fix for bug #46639
>
> Yes.
>
> Turns out that the removal part of Bug#46639 was lost in MariaDB in this
> merge:
>
> revno: 2732 [merge]
> revision-id: i...
Thank you to everybody for the clarification. We will fix our engine
to not set 0 for stats.records unless we are absolutely sure it is
empty.
-Zardosht
On Thu, Dec 9, 2010 at 7:52 AM, Sergei Golubchik wrote:
> Hi, Zardosht!
>
> On Dec 08, Zardosht Kasheff wrote:
>>
>> We always thought that sta
Hi, Zardosht!
On Dec 08, Zardosht Kasheff wrote:
>
> We always thought that stats.records was meant to be an estimate, and
> that an estimate of 0 was ok even if the table was non-empty. We were
> reporting that stats.records was 0 even though the table was
> non-empty. Is this assumption wrong?
"Philip Stoev" writes:
> This code was added as a fix for MySQL bug #38005 and then removed as
> a fix for bug #46639
Yes.
Turns out that the removal part of Bug#46639 was lost in MariaDB in this
merge:
revno: 2732 [merge]
revision-id: i...@askmonty.org-20091112043128-yd6odg8zr5ribjal
patch for bug#38005, since that was a workaround in the
partitioning engine instead of a fix in myisam.
- Original Message -
From: "Zardosht Kasheff"
To: "Kristian Nielsen"
Cc:
Sent: Wednesday, December 08, 2010 9:47 PM
Subject: Re: [Maria-developers] problem with
Zardosht Kasheff writes:
> What I do not understand is this. Why does the following code at line
> 4734 of ha_partition.cc (at the bottom of this message) simply assume
> that if file->stats.records is 0, that it can blindly return
> HA_ERR_END_OF_FILE? I understand if file->ha_table_flags expose
Our storage engine does not lie to the optimizer. We do not set the
HA_STATS_RECORDS_IS_EXACT flag. I do not know this code well enough to
understand how the relevant code in opt_sum.cc results in the
partition code I describe get executed.
What I do not understand is this. Why does the following
Zardosht,
I think we found out the problem. In ha_partition.cc, in the function
ha_partition::handle_ordered_index_scan, this code was added:
case partition_index_last:
/*
MyISAM engine can fail if we call index_last() when indexes disabled
that happens if the table
I think we found out the problem. In ha_partition.cc, in the function
ha_partition::handle_ordered_index_scan, this code was added:
case partition_index_last:
/*
MyISAM engine can fail if we call index_last() when indexes disabled
that happens if the table is empty.
Zardosht Kasheff writes:
> We have been working on testing our storage engine, TokuDB, against
> MariaDB 5.2.3, and we have encountered a problem with partitioning
> that does not exist on MySQL 5.1, MySQL 5.5, and MariaDB 5.1.50. This
> problem also does not exist with any other storage engine t
Hello all,
We have been working on testing our storage engine, TokuDB, against
MariaDB 5.2.3, and we have encountered a problem with partitioning
that does not exist on MySQL 5.1, MySQL 5.5, and MariaDB 5.1.50. This
problem also does not exist with any other storage engine that we have
tried. It O
12 matches
Mail list logo
