Hi, Alexander!
On Dec 03, Alexander Barkov wrote:
>
> Let me try to advertise a different approach :)
> I like more encapsulation. I'd encapsulate every single member
> in every single class, really.
I know :)
I've heard these arguments many times too, and they aren't wrong.
It's about balance,
Hi Sergei,
On 12/03/2014 04:08 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Dec 03, Alexander Barkov wrote:
On 12/03/2014 01:13 AM, Sergei Golubchik wrote:
Hi.
It think the split is good, I liked it.
I didn't like that you've tried to put the refactoring of sql_db.cc and
sql_lang.h in the
Hi, Alexander!
On Dec 03, Alexander Barkov wrote:
> On 12/03/2014 01:13 AM, Sergei Golubchik wrote:
> > Hi.
> >
> > It think the split is good, I liked it.
> >
> > I didn't like that you've tried to put the refactoring of sql_db.cc and
> > sql_lang.h in the same commit, please move it to a separat
Hi Sergei,
Thanks for review. I addressed most of your suggestions.
A fixed version is attached.
See details inline:
On 12/03/2014 01:13 AM, Sergei Golubchik wrote:
Hi.
It think the split is good, I liked it.
I didn't like that you've tried to put the refactoring of sql_db.cc and
sql_lang.h
Hi.
It think the split is good, I liked it.
I didn't like that you've tried to put the refactoring of sql_db.cc and
sql_lang.h in the same commit, please move it to a separate patch.
MDEV-5359 should not depend on that.
Anyway, see all my comments below:
> diff --git a/sql/structs.h b/sql/struc
5 matches
Mail list logo
