Re: [Maria-developers] MWL#36: feedback for post-review fixes

2009-10-31 Thread Michael Widenius
Hi! > "Sergey" == Sergey Petrunya writes: Sergey> On Wed, Oct 28, 2009 at 12:42:20AM +0300, Alexi1952 wrote: >> Hi Sergey, >> >> > Please change to use multiple-strings; >> >"Updates to a database with a different name than the original." >> > "Example: rewrite-db='from->to'.", >>

Re: [Maria-developers] MWL#36: feedback for post-review fixes

2009-10-28 Thread Sergey Petrunya
On Wed, Oct 28, 2009 at 12:42:20AM +0300, Alexi1952 wrote: > Hi Sergey, > > > Please change to use multiple-strings; > >"Updates to a database with a different name than the original." > > "Example: rewrite-db='from->to'.", > > as that is what is done around the codebase. > > Just few li

Re: [Maria-developers] MWL#36: feedback for post-review fixes

2009-10-28 Thread Alexi1952
Hi Sergey, > > Please change to use multiple-strings; > >"Updates to a database with a different name than the original." > > "Example: rewrite-db='from->to'.", > > as that is what is done around the codebase. > Just few lines above there is a sample which I followed: > {"to-last-log",

Re: [Maria-developers] MWL#36: feedback for post-review fixes

2009-10-27 Thread Alexi1952
Hi Sergey, > Please change to use multiple-strings; >"Updates to a database with a different name than the original." > "Example: rewrite-db='from->to'.", > as that is what is done around the codebase. Just few lines above there is a sample which I followed: {"to-last-log", 't', "Requ

[Maria-developers] MWL#36: feedback for post-review fixes

2009-10-27 Thread Sergey Petrunya
Hi Alexander, Please find the feedback for post-review fixes below: > === modified file 'client/mysqlbinlog.cc' > --- client/mysqlbinlog.cc 2009-10-24 19:43:39 + > +++ client/mysqlbinlog.cc 2009-10-27 13:42:47 + > @@ -38,8 +38,8 @@ > /* Needed for Rpl_filter */ > CHARSET_INF