Re: [Maria-developers] MDEV 10754 - Patch for trim functions

2018-03-26 Thread Alexander Barkov
Forgot to mention, To track changes easier, I made a separate MDEV for this: MDEV-15664 sql_mode=ORACLE: Make TRIM return NULL instead of empty string Greetings. On 03/26/2018 04:21 PM, Alexander Barkov wrote: > Hello Jerome, > > > Thank you for the contribution. > > > The patch looks fin

Re: [Maria-developers] MDEV 10754 - Patch for trim functions

2018-03-26 Thread Alexander Barkov
Hello Jerome, Thank you for the contribution. The patch looks fine. I have only some proposals. 1. We don't use bb-10.2-ext any more. Please use 10.3 instead. 2. You mapped "TRIM_ORACLE" to SYM(TRIM). I guess you wanted to avoid grammar duplication for "TRIM" and "TRIM_ORACLE". It's good t

[Maria-developers] MDEV 10754 - Patch for trim functions

2018-03-15 Thread jerome brauge
Hello Alexander, Can you review this patch for trim functions for Oracle ? Regards, Jérôme. patch_trim.diff Description: patch_trim.diff ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubs