Hi Alexey,
Thanks for your review.
On 11/26/2018 12:29 AM, Alexey Botchkov wrote:
> Ok, fine with leaving sql_base_types.h and the MYSQL_TIME_STATUS as it is.
>
> The last comment then:
> Item_func_trt_id::val_int()
> Item_interval_DDhhmmssff_typecast::val_str()
> there you get the 'current_
Hi Alexey,
On 11/25/2018 09:05 AM, Alexander Barkov wrote:
>>
>> What do you think if we do this:
>> - add THD* memver to the MYSQL_TIME_STATUS structure,
>> so we can get rid of the THD * parameter to many functions?
>> - send one MYSQL_TIME_STATUS* to the add_nanoseconds()
>> instead of
Hi Alexey,
On 11/25/2018 03:00 AM, Alexey Botchkov wrote:
> Hi, Alexander.
>
> First question about the sql/sql_basic_types.h.
> To me it looks overcomplicated. Do we really need classes over
> the simple enums?
> I attached my version of this file here. In my opinion it's shorter itself,
> and
3 matches
Mail list logo
