Re: [Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

2018-10-27 Thread Sergei Golubchik
Hi, Vicențiu! On Oct 21, Vicențiu Ciorbaru wrote: > Hi Sergei! > > Here are my review comments, inline. Read them from oldest to newest > commit, that's how I wrote them. :) > > commit df9d95d2a85 > > Author: Sergei Golubchik > > Date: Sat Oct 13 11:30:39 2018 +0200 > > > > cleanup: sql

Re: [Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

2018-10-21 Thread Vicențiu Ciorbaru
Hi Sergei! About the syntax problem, inline: On 17/10/2018 23:40, Sergei Golubchik wrote: Hi, Now, the syntax problem. Old MySQL syntax (for the last ~20 years) was (1) GRANT ... TO user IDENTIFIED BY 'plain-text password' (2) GRANT ... TO user IDENTIFIED BY PASSWORD 'password hash' (3) S

Re: [Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

2018-10-21 Thread Vicențiu Ciorbaru
Hi Sergei! Here are my review comments, inline. Read them from oldest to newest commit, that's how I wrote them. :) On 17/10/2018 23:40, Sergei Golubchik wrote: Hi, Please review commits for MDEV-12321 "authentication plugin: SET PASSWORD support" They're now in the bb-10.4-serg branch,

[Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

2018-10-17 Thread Sergei Golubchik
Hi, Please review commits for MDEV-12321 "authentication plugin: SET PASSWORD support" They're now in the bb-10.4-serg branch, the last seven commits: = commit 62e8340f513 Author: Sergei Golubchik Date: Wed Oct 17 12:48:13 2018 +0200 MDEV-12321 authentication p