Re: [Maria-developers] EXPLAIN in the slow query log

2013-11-12 Thread Sergei Petrunia
Ok, thanks for the input. I'll change the formatting to prefix each line with 'explain:', and remove XML-like tags. On Sat, Oct 19, 2013 at 08:32:51AM -0700, Jeremy Zawodny wrote: > Agreed. Make it easy to grep and don't pretend the log is an XML file. :-) > > Jeremy > > > On Sat, Oct 19, 2013

Re: [Maria-developers] EXPLAIN in the slow query log

2013-10-20 Thread Elena Stepanova
Hi, On 10/19/2013 7:26 PM, Eric Bergen wrote: I don't understand why you need both the xml style tag and the double # to denote an explain entry. I would prefer to see each line prefixed with # explain: to make it similar to the other info lines above and get rid of the . Regardless the tags

Re: [Maria-developers] EXPLAIN in the slow query log

2013-10-19 Thread Sergei Golubchik
Hi, Sergei! On Oct 18, Sergei Golubchik wrote: > On Oct 18, Sergei Petrunia wrote: > > Open questions: > > - Is this syntax OK? > > Yes, assuming you use tabs as column separators, not spaces. Just to make it clear, "yes" above means I'm ok with that, it doesn't mean I particularly prefer that v

Re: [Maria-developers] EXPLAIN in the slow query log

2013-10-19 Thread Jeremy Zawodny
Agreed. Make it easy to grep and don't pretend the log is an XML file. :-) Jeremy On Sat, Oct 19, 2013 at 8:26 AM, Eric Bergen wrote: > I don't understand why you need both the xml style tag and > the double # to denote an explain entry. I would prefer to see each > line prefixed with # expl

Re: [Maria-developers] EXPLAIN in the slow query log

2013-10-19 Thread Eric Bergen
I don't understand why you need both the xml style tag and the double # to denote an explain entry. I would prefer to see each line prefixed with # explain: to make it similar to the other info lines above and get rid of the . By prefixing each line with # explain: it makes grepping explain plans

Re: [Maria-developers] EXPLAIN in the slow query log

2013-10-18 Thread Sergei Golubchik
Hi, Sergei! On Oct 18, Sergei Petrunia wrote: > Hello, > > After recent changes in the [SHOW] EXPLAIN architecture in MariaDB, it became > really easy to add an option to print EXPLAIN(*) output into the slow query > log, > so I went ahead and implemented it. > > @@log_slow_verbosity has got

[Maria-developers] EXPLAIN in the slow query log

2013-10-17 Thread Sergei Petrunia
Hello, After recent changes in the [SHOW] EXPLAIN architecture in MariaDB, it became really easy to add an option to print EXPLAIN(*) output into the slow query log, so I went ahead and implemented it. @@log_slow_verbosity has got a 'explain' flag, and if it is on, the slow query log entries l