Hi Kristian!
On Fri, Jun 3, 2016 at 7:53 AM, Kristian Nielsen
wrote:
> Sergei Golubchik writes:
>
> > On May 26, Nirbhay Choubey wrote:
>
> >> > > + if (wait_for_prior_commit())
>
> Please call this method tmptable_wait_for_prior_commit() or something like
> that. To avoid confusion with THD::
Hi Serg!
On Fri, Jun 3, 2016 at 7:20 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On May 26, Nirbhay Choubey wrote:
>
> > > > +/*
> > > > + Create a temporary table, open it and return the TABLE handle.
> > > > +
> > > > + @param hton [IN]Handlerton
> > > > + @param frm
Sergei Golubchik writes:
> On May 26, Nirbhay Choubey wrote:
>> > > + if (wait_for_prior_commit())
Please call this method tmptable_wait_for_prior_commit() or something like
that. To avoid confusion with THD::wait_for_prior_commit().
>> > you're doing it in almost every method. And when one m
Hi, Nirbhay!
On May 26, Nirbhay Choubey wrote:
> > > +/*
> > > + Create a temporary table, open it and return the TABLE handle.
> > > +
> > > + @param hton [IN]Handlerton
> > > + @param frm [IN]Binary frm image
> > > + @param path [IN]
Hi, Nirbhay!
I like the approach, there were only few comments, but still there were
some :)
See below.
On May 16, Nirbhay Choubey wrote:
> revision-id: c285dbece2881e1d864bb758d77edc899d568c04
> (mariadb-10.1.8-82-gc285dbe)
> parent(s): 222ca736f737e888115c732c8ecad84faf0a2529
> author: Nirbha
5 matches
Mail list logo
