Re: [Maria-developers] Participation in MariaDB Community's Open Source Project

Hi Yingquan! I recommend you start reading this article: https://mariadb.org/get-involved/getting-started-for-developers/ That should guide you in the right direction. Feel free to reach out on zulip https://mariadb.zulipchat.com/ if you have any questions. You can have a look at our beginner fr

Re: [Maria-developers] Google Summer of Code 2022

Hi Sergey! I'm happy to see that you have experience in MariaDB code base already. The MDEV-18827 is definitely up for grabs for GSoC 2022. The project is mostly a part-time project (requiring a commitment of around 175 hours), however depending on your availability we can increase the scope of th

Re: [Maria-developers] [Commits] 6f1628b: MDEV-25565 Crash on 2-nd execution of SP/PS for query calculating window functions

Hi Igor! The patch looks good, however I suggest the following changes to make it smaller and easier to read & maintain. 1. You do not need to have special if statements for save_partition_list and save_order_list when you do the cleanup. 2. You do not need to have special code that saves the par

[Maria-developers] Initial prototype for MDEV-10825 Persist exact view definitions DDL

Hi Sergei! This email is a followup to the brief discussion on Zulip here: https://mariadb.zulipchat.com/#narrow/stream/118759-general/topic/preserve.20original.20formatting.20for.20views You mentioned we store the view's definition (source) inside the FRM. I've used that information to extend t

Re: [Maria-developers] GSOC21: MDEV-16375 & MDEV-23143

Hi Songlin! It's great that you are excited about this project! Here are my thoughts on your proposal and what I think you should focus on: JSON_NORMALIZE seems simple at first, but I believe there are a lot of corner cases. In order to get a proper specification for this function can you have a

Re: [Maria-developers] RFC: incompatible changes to mtr debugging flags

Hi Sergei! Just tested this out. I like the changes and can live with what you proposed. However, I don't see a reason to get rid of "--manual-debug". I like being able to see what command line parameters are needed to start the server with the exact same setup. Sometimes I use it to start the ser

[Maria-developers] Review of MDEV-4851

Hi Daniel! The patch looks good, some comments about the test cases. About the commit message, we have --write-binlog not just --binlog. Also, check for typos in the last commit message and also, I would squash the two test cases commits into just one. > diff --git a/mysql-test/suite/rpl/t/rpl_my

[Maria-developers] Welcome to Google Summer of Code 2020 with MariaDB

Hi! GSoC 2020 accepted proposals have just been announced and you are part of the successful applicants. This year we had a lot of very good proposals and so we have a one of the highest number of students (7) to mentor for GSoC. Congratulations on the effort to learn about the program, get invol

[Maria-developers] MDEV-14296: Moving wsrep_sst_common to /usr/libexec

Hi Otto! I am doing a push towards cleaning up as much as possible from our packaging issues. Starting with the older ones: *Background:* wsrep_sst_common.sh is a script that should never be run standalone, it is rather a helper script used for other wsrep_* scripts. As such, it *does not really

Re: [Maria-developers] [DISCUSS] Don't see ARM release information in MariaDB download page

Hi! Yes, this is in the works, I will come with an update during this week! Vicențiu On Tue, 14 Jan 2020, 03:51 bo zhaobo, wrote: > Hi Team and Sergei, > > I opened a issue about this https://jira.mariadb.org/browse/MDEV-21432 , > and the status of it is confirmed for several days, is there

Re: [Maria-developers] MariaDB for CentOS 8

Should be fixed now! Thanks for letting us know about the problem. On 04.10.2019 00:31, Daniel Bartholomew wrote: On Thu, 3 Oct 2019 22:00:16 +0530 Thomas Stephen Lee wrote: Hi, Please release MariaDB 10.4 for CentOS 8. https://downloads.mariadb.org/mariadb/repositories/ does not show Cen

Re: [Maria-developers] MariaDB for CentOS 8

Hi Thomas, That is a bug in our code which we shall fix as soon as possible. In the meantime, you can replace the instructions on https://downloads.mariadb.org/mariadb/repositories/ with the correct URL from yum.mariadb.org. # MariaDB 10.4 CentOS repository list - created 2019-10-04 06:20 U

[Maria-developers] Congratulations on a successful GSoC!

on to help others! In this sense, I encourage you to keep being active in the community and share what you have learned. :) Thank you for a great summer! Vicențiu Ciorbaru GSoC MariaDB Foundation Admin ___ Mailing list: https://launchpad.net/~maria-devel

[Maria-developers] Coding Style Review INSERT RETURNING

Hi Rucha! This is going to be a very thorough review looking at coding style. I'll nitpick on every line of code where I find something, just be patient and let's clean up everything. You might consider me picking on the coding style a bit pedantic, but it really is important. It is important bec

[Maria-developers] INSERT ... RETURNING intermediate review

Hi Rucha! I've spent quite a bit of time looking at the implementation. It is working and passes almost all test cases, although you forgot to also commit the insert_parser updated result file. Good job so far. I want to give you something to work on and think about for a bit before we do another o

[Maria-developers] INSERT ... RETURNING Initial code review

Hi Rucha! Here is the promised review. I have run the main test suite locally and have noticedthat some tests fail if you run with a debug build. The failure is an assertionfailure on the protocol level. This means you forgot to call a my_ok or my_errorat an appropriate time. I suggest you try and

Re: [Maria-developers] GSoC Introduction

Hi Rucha! Great start. Whenever you have some code ready for the parser part, please share the repository and the branch onto which you are pushing your code. We should discuss implementation details once you have managed to get the grammar to work. Remember to include test cases to show that the

[Maria-developers] Welcome to GSoC 2019

Hi! As you may have noticed a few days ago, you have received an email from Google that you have been accepted as part of Google Summer of Code. Congratulations on the effort to learn about the program, get involved and submit succesful proposals. The fun part begins now! If you have not done so

[Maria-developers] Review for ANALYZE TABLE with Sampling

Hi Sergei! Can you review that you are happy with the storage engine API changes? I'veustructured the commit to be as small as possible to achieve the desired outcome. In my tests, we are now twice as fast as MySQL for a 10 mil row table with 13 columns. Vicențiu Forwarded Message -

[Maria-developers] Review for follow up fix of MDEV-17323: Backport INFORMATION_SCHEMA.CHECK_CONSTRAINTS to 10.2

Hi Anel! This is not a terribly bad patch, however you have forgotten the following things: You removed the misspelled is_check_constraint.test file, but forgot to remove the is_check_constraint.result file. Now we would be left with a dangling result file. Please be more careful next time. Yo

Re: [Maria-developers] 02587f61f40: MDEV-13095 Implement User Account locking

Hi Sergei! I agree with most review comments except one: > > information. > > > > diff --git a/mysql-test/include/switch_to_mysql_user.inc b/mysql- > > test/include/switch_to_mysql_user.inc > > index f5801db6114..eff1d98c2df 100644 > > --- a/mysql-test/include/switch_to_mysql_user.inc > > +++ b

Re: [Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

Hi Sergei! > For the first iteration, after considering your input, I'd go with > > "init function", "get random row", "end function", without imposing an > > index, but somehow passing a (COND or similar) arg to the init > > function. > > For the first iteration I'd go without a condition. You, p

Re: [Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

On Tue, 11 Dec 2018 at 14:33 Sergei Golubchik wrote: > Hi, Vicențiu! > > On Dec 11, Vicențiu Ciorbaru wrote: > > Hi! > > > > Here is my proposal on extending the storage engine API to provide a > > functionality for retrieving random rows from tables (those th

Re: [Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

On Tue, 11 Dec 2018 at 12:43 Sergey Petrunia wrote: > > On Tue, Dec 11, 2018 at 12:34:12AM +0200, Vicențiu Ciorbaru wrote: > > Hi! > > > > Here is my proposal on extending the storage engine API to provide a > > functionality for retrieving random rows from table

[Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

Hi! Here is my proposal on extending the storage engine API to provide a functionality for retrieving random rows from tables (those that have indexes). The storage engines for which I plan to implement this are: MyISAM, Aria, Innodb. Possibly RocksDB, TokuDB. --- a/sql/handler.h +++ b/sql/handle

Re: [Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

Hi Sergei! About the syntax problem, inline: On 17/10/2018 23:40, Sergei Golubchik wrote: Hi, Now, the syntax problem. Old MySQL syntax (for the last ~20 years) was (1) GRANT ... TO user IDENTIFIED BY 'plain-text password' (2) GRANT ... TO user IDENTIFIED BY PASSWORD 'password hash' (3) S

Re: [Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

Hi Sergei! Here are my review comments, inline. Read them from oldest to newest commit, that's how I wrote them. :) On 17/10/2018 23:40, Sergei Golubchik wrote: Hi, Please review commits for MDEV-12321 "authentication plugin: SET PASSWORD support" They're now in the bb-10.4-serg branch,

Re: [Maria-developers] Please review MDEV-16584 SP with a cursor inside a loop wastes THD memory aggressively

Hi Alexander! Can you double check that this same problem doesn't occur with custom aggregate functions? There is a switch involved with cursors and custom aggregate functions here: /* Only pop cursors when we're done with group aggregate running. */ if (m_chistics.agg_type != GROUP_AGGREGATE

Re: [Maria-developers] Please review a patch for MDEV-15758 Split Item_bool_func::get_mm_leaf() into virtual methods in Field and Type_handler

Hi Alexander! (I was doing some experimentation with the code and forgot to send the email properly) So the main things we discussed during the review: We discussed alternative of not adding SEL_ARG_XXX classes and instead have separate constructors within SEL_ARG. I tried to do this myself but

Re: [Maria-developers] [Maria-discuss] MariaDB crashes because of "long semaphore wait" after migrating from 10.1 to 10.3

Hi! I have cc'ed the maria-developers mailing list as this is potentially a dev issue and also the devs responsible for Windows and InnoDB development. There might be some people on vacation right now, but this should get looked into in a week or two at most. Let's find a solution for your proble

Re: [Maria-developers] unbundle RocksDB

Hi Michal, Just so you know, we've been discussing the possibility of adding compression services to the server, which would allow removing some static libraries from the code. This however is probably a bit far on the horizon as we haven't particularly scheduled it for 10.4 (yet). Vicentiu On S

Re: [Maria-developers] Proposal for Negative Grants Project

Hi Sergey! On Tue, 29 May 2018 at 17:54 Sergei Golubchik wrote: > Hi, Vicențiu! As you might've guessed from my comments above, I'd rather prefer to use > REVOKE instead of DENY, if we can make it to work (and to explain how it > works afterwards :). > > So here I suggest a semantics how REVO

Re: [Maria-developers] With_sum_func_cache

Hi Alexander! I was looking through this patch as I am rather familiar with this code. I didn't take time to test this out, but maybe you can explain if this is a possible concern or not: index 4a95189..7d1532c 100644 --- a/sql/item_sum.cc +++ b/sql/item_sum.cc @@ -404,7 +404,7 @@ bool Item_sum::

Re: [Maria-developers] [Commits] 4861977ce76: MDEV-14695: Assertion `n < m_size' failed in Bounds_checked_array::operator

Hi Varun! I will take a second look at this but a first minor comment is to not save two characters by shortening fields to flds, it makes reading unnatural. Vicentiu On Sat, 12 May 2018 at 21:45 Varun wrote: > revision-id: 4861977ce76761fefb9779a774984b6afa818f2e > (mariadb-10.2.5-636-g486197

Re: [Maria-developers] Proposal for Negative Grants Project

Hi Sergei! On Fri, 11 May 2018 at 21:10 Sergei Golubchik wrote: > Hi, Rutuja! > > I think it would've be useful to put your main ideas into MDEV-14443, as > a comment. > > For now I've just added a link to your email. > > On May 09, Rutuja Surve wrote: > > Hello, > > Please find the proposal for

Re: [Maria-developers] [Commits] 326db1a: Mdev-14853 Grant does not work correctly when table contains...

Hi Sachin! Did you run this test on embedded server? Usually grant related tests require some form of not_embedded.inc include. (check roles suite for examples) Vicentiu On Thu, 26 Apr 2018 at 00:20 sachin wrote: > revision-id: 326db1a2aaa9b275a1a21a863e8cd2d9fa1b1d5f > (mariadb-10.3.6-46-g326

Re: [Maria-developers] Regarding bugs (mysqldump)

Hi Rutuja! Great analysis again and lets share this with the maria-developers mailing list as well. I've tested your proposed change and the change for dump_all_tables_in_db seems to not be necessary. If you look at how dump_all_tables_in_db gets called, it's followed by dump_all_views_in_db. The

Re: [Maria-developers] Observation for CHECK_CONSTRAINTS MDEV 14474

Hi Anel! I've reviewed your patch and generally things look good. You do some good analysis usually and I think we should highlight your work to the broader developer scene. I've thus CC'ed this email to the maria-developers mailing list. This gives us a chance to get feedback from outside, partic

Re: [Maria-developers] [Commits] c9ae1234814: MDEV-14592: Custom Aggregates Usage Status Variable

Hi Varun This generally looks good, 2 comments inline. Vicentiu diff --git a/mysql-test/t/custom_aggregate_functions.test b/mysql-test/t/custom_aggregate_functions.test index 20fcc35f39f..a93ec545f01 100644 --- a/mysql-test/t/custom_aggregate_functions.test +++ b/mysql-test/t/custom_aggregate_fu

Re: [Maria-developers] GSoC 2018 - Histograms with equal-width bins

Hi Teodor, In order to get started with the project you need to see how we currently gather statistics from tables. You should first read up on: https://mariadb.com/kb/en/library/engine-independent-table-statistics/ Note we are interested in *engine independent table statistics*, not engine spec

[Maria-developers] Review Custom Aggregate Functions

Hi Varun! Here's a final review for Custom Aggregate Functions * You haven't run the full test suite, there are a few failing tests. Please update those. rpl.rpl_sp funcs_1.is_columns_mysql funcs_1.storedproc * Push your code to a BB branch and rebase it on top of current 10.3. * Fix commits me

[Maria-developers] Review of Percentile Window Functions

Hi Varun, Here's the final review for Percentile Functions. Just 2 minor coding style comments. Rebase on top of current 10.3 and push to a bb-* branch to double check nothing breaks. Make sure that no merge commit happens. Regards, Vicențiu > diff --git a/sql/item_windowfunc.h b/sql/item_window

Re: [Maria-developers] 46b93fc: MDEV-13676: Field "create Procedure" is NULL, even if the the user has role which is the definer. (SHOW CREATE PROCEDURE)

b3 > (mariadb-10.0.32-50-g46b93fc) > > parent(s): dbeffabc83ed01112e09d7e782d44f044cfcb691 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2017-10-09 13:32:40 +0300 > > message: > > > > MDEV-13676: Field "create Proce

Re: [Maria-developers] [Commits] dccebdf862d: Rdb_io_watchdog doesn't support osx so disabling it

Hi Varun! Please change the CMakeLists.txt to be like so: diff --git a/storage/rocksdb/CMakeLists.txt b/storage/rocksdb/CMakeLists.txt index 5db6d88..6db8211 100644 --- a/storage/rocksdb/CMakeLists.txt +++ b/storage/rocksdb/CMakeLists.txt @@ -146,7 +146,10 @@ ADD_CONVENIENCE_LIBRARY(rocksdb_aux_l

[Maria-developers] Review: MDEV-12985: Support percentile and media window functions

Hi Varun! Here is the in-detail review for the percentile functions. Please add a grammar definition for median too and test it. All in all, not many changes, but please address my comments. If you disagree with some of them, let's discuss them. > diff --git a/mysql-test/r/win_percentile_cont.re

[Maria-developers] Review of PERCENTILE_CONT && PERCENTILE_DISC

Hi Varun, Here's the review for your patch. > diff --git a/mysql-test/t/percentile.test b/mysql-test/t/percentile.test > new file mode 100644 > index 000..0958fc05e7d > --- /dev/null > +++ b/mysql-test/t/percentile.test > @@ -0,0 +1,41 @@ Whenever you are adding a test case, please add th

[Maria-developers] Fwd: ecbad0a07a8: MDEV-13189: Window functions crash when using INTERVAL

: revision-id: ecbad0a07a848c1f9f474c4c749c87b6bfe7986c (mariadb-10.2.6-74-gecbad0a07a8) parent(s): 31ba0fa48d27715e82258b1e74401093e0ee17a2 author: Vicențiu Ciorbaru committer: Vicențiu Ciorbaru timestamp: 2017-06-28 21:07:55 +0300 message: MDEV-13189: Window functions crash when using INTERVAL Interval

Re: [Maria-developers] Cannot push branch to github

r explanations, yesterday I have submitted pull request > https://github.com/MariaDB/server/pull/398 It does not have assignee or > reviewers and I am not sure if somebody will be able to see it. Please have > a look. > > Thank you, > Valentin > > > On Thu, May 25, 201

Re: [Maria-developers] Cannot push branch to github

Hi Valentin! The correct way to do a pull request is to create your own fork of the server repository. You don't need any special permissions for that. Afterwards, push your changes to your fork. Finally, click on New pull request button in *your* repository. Select the appropriate branch for the

Re: [Maria-developers] cte page

Hi Jocelyn! There have been quite a few requests to benchmark this. Although CTE merging conflicts with reusing, it would be interesting to get some results in. The best person to do this is a third party, as any one from MySQL or MariaDB may be biased in choosing workloads. Nonetheless it is some

Re: [Maria-developers] cte page

Very good! Congratulations on finishing the paper! Thank you for all the great work. :) Vicențiu On Thu, 27 Apr 2017 at 09:11 Galina Shalygina wrote: > мои артиклы > ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-develo

Re: [Maria-developers] Please review MDEV-12426 Add Field::type_handler()

Hi Alexander, Comments inline. Please provide feedback on why that Field_enum::can_optimize_range is needed. Ok to push otherwise. Feel free to address stylistic comments if you agree with them. Vicențiu > commit 1d9f9b8d93fd0d1aad56b77694fb3c2b5a55514d > Author: Alexander Barkov > Date: Mon

Re: [Maria-developers] Refactoring in LEX_STRING and LEX_CSTRING

Hi! I would like to add a few more arguments in favour of using const references and not const pointers. I do not endorse non-const references, that makes the code silly and confusing a lot of the times. When we need output or input-output parameters we should keep using pointers. For strictly man

Re: [Maria-developers] Please review patch for 12017 and 12018.

Hi Sachin! I'll review the patch. If Monty wants to chip in he can do so. 1. Indentation is wrong for the patch, you have an extra step of indentation. 2. I would use only one return true statement, after the if/else statement. 3. For singular subject sentence use does instead of do. So: 'Flashba

Re: [Maria-developers] Errors in building debs

Latest push ought to fix this. Waiting for buildbot to confirm. On Fri, 31 Mar 2017 at 23:05, Sergey Petrunia wrote: Hi Vicențiu, I'm looking at the last build in bb-10.2-mariarocks http://buildbot.askmonty.org/buildbot/builders/kvm-deb-trusty-x86/builds/3558/steps/compile/logs/stdio and I se

Re: [Maria-developers] Gsoc project

Hi! Yes, Table Functions are at the moment not a GSoC Project. We will need to probably restructure the project (scoping and such), so in order to not have you write proposals for an uncertain one, we have removed the gsoc2017 label from the MDEV. Regards, Vicențiu On Sun, 26 Mar 2017 at 21:24 V

Re: [Maria-developers] GSoC 2016 Student Introduction. [ MDEV-4989 ]

Hi Mike! For debugging on OS X I suggest you use lldb instead of gdb, if you're having troubles with gdb. At the same time you can get gdb to work but sometimes it doesn't work as you expect it to, so lldb might be your best alternative. Using mysql-test-run with lldb will also be somewhat tricky.

[Maria-developers] Fwd: 41f885f64fe: MDEV-10859: Wrong result of aggregate window function in query with HAVING and no ORDER BY

: MDEV-10859: Wrong result of aggregate window function in query with HAVING and no ORDER BY To: revision-id: 41f885f64fe4c02e03ec655f225b1dc01e9d5376 (mariadb-10.2.3-252-g41f885f64fe) parent(s): d731ce21a7bc25a49958789d24b3f0eec5845aea author: Vicențiu Ciorbaru committer: Vicențiu Ciorbaru timestamp

Re: [Maria-developers] [Commits] 822aa21672b: MDEV-11170: MariaDB 10.2 cannot start on MySQL 5.7 datadir

iu wrote: > > revision-id: 822aa21672ba6650a31a3ec05ab5c1bce7a80c1e > (mariadb-10.2.3-198-g822aa21672b) > > parent(s): b745ea489f0698c328383d9b8ec20d2f9777b1b8 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2017-02-13 14:44:00 +0200 > > message: > > > >

Re: [Maria-developers] Please review MDEV-11692 Comparison data type aggregation for pluggable data types

Hi Alexander! Comments inline. OK to push otherwise. > diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc > index fc3f81a..6fcfec4 100644 > --- a/sql/item_cmpfunc.cc > +++ b/sql/item_cmpfunc.cc > @@ -118,8 +118,11 @@ static int cmp_row_type(Item* item1, Item* item2) > 0 otherwise > */

Re: [Maria-developers] Please review MDEV-9979 Keywords UNBOUNDED, PRECEDING, FOLLOWING, TIES, OTHERS should be non-reserved

Hi Alexander, OK to push. Please add the version of the standard you used to check these keywords as non-reserved both to the commit message, as well as the keywords themselves. I used 2011 standard draft to check. Vicențiu On Mon, 23 Jan 2017 at 09:28 Alexander Barkov wrote: > Hello Vicențiu,

Re: [Maria-developers] Please review MDEV-9522 Split sql_select.cc:can_change_cond_ref_to_const into virtual methods in Type_handler

Hi Alexander! Ok to push this one. I really like how this splits the function. Please put a comment that collation does not make sense (and thus is no concern) for numerical type handlers in the function where you compare them by pointer address. Also, Item_get_cache should be on a separate line

Re: [Maria-developers] Fwd: mixing of user-defined data types with other data types

Hi Alexander, I've reviewed your second patch. Comments inline. >> +} > >> > >> > >> /* > >> diff --git a/sql/field.h b/sql/field.h > >> index 541da5a..fa84e7d 100644 > >> --- a/sql/field.h > >> +++ b/sql/field.h > >> @@ -835,7 +835,6 @@ class Field: public Value_source > >>virtual Item_resu

[Maria-developers] Fwd: mixing of user-defined data types with other data types

Hi Alexander! Comments inline. Most are stylistic comments. I think the patch is great. The Item_type_holder is really bugging me though. It feels poorly designed in the current place. > diff --git a/sql/field.cc b/sql/field.cc > index 6f273e6..7876a6f 100644 > --- a/sql/field.cc > +++ b/sql/fiel

Re: [Maria-developers] [Commits] 02e74a5: MDEV-11700: MariaDB 10.2 cannot start on MySQL 5.7 datadir:

Hi Daniel! On Mon, 12 Dec 2016 at 04:08 Daniel Black wrote: > nit - its really MDEV-11170 > Argh, thanks. That's always annoying to get right :) > On 12/12/16 12:57, Vicențiu Ciorbaru wrote: > > Hi Sergei! > > > > Can you please review this patch for MDEV-117

Re: [Maria-developers] 02e74a5: MDEV-11700: MariaDB 10.2 cannot start on MySQL 5.7 datadir:

ce we're planning on doing some authentication changes, we can implement a variant of B. Thoughts? On Mon, 12 Dec 2016 at 03:50 vicentiu wrote: > revision-id: 02e74a5614b08cfce505002abc26d4634648308e > (mariadb-10.2.2-138-g02e74a5) > parent(s): 9320d8ae30c18420bef659618175836221

Re: [Maria-developers] [Commits] 27af988: MDEV-11479 Improved wsrep_dirty_reads

Hi Sachin! Comments inline: On Sun, 4 Dec 2016 at 08:36 wrote: > revision-id: 27af98805c27c8e0c41dc8c19bf80aefff4c6d3d > (mariadb-galera-5.5.53-3-g27af988) > parent(s): 72fd15f7c31aa3e3705ae1b005a3247a985c5bb3 > author: SachinSetiya > committer: SachinSetiya > NIT: To get these to display corr

Re: [Maria-developers] MDEV-11330 Split Item_func_hybrid_field_type::val_xxx() into methods in Type_handler

Hi Alexander! I find this version much cleaner! Looks good to me. What I'd really like to see later is if we can write some unit tests for these conversions. Not mtr linked tests but actual unit tests specifically using these Items. I am up for chipping in and writing some myself. One thing I'd l

Re: [Maria-developers] Deleting unused branches on github

On Mon, 7 Nov 2016 at 19:40 Elena Stepanova wrote: > Hi, > > On 11/07/2016 08:59 PM, Vicențiu Ciorbaru wrote: > > Hi! > > > > I'm wondering if it makes sense to have an automatic cleanup process for > > branches older than X months? > > Please don

Re: [Maria-developers] Deleting unused branches on github

Hi! I'm wondering if it makes sense to have an automatic cleanup process for branches older than X months? We can potentially add some exceptions for work that needs to stay. Regards, Vicențiu On Mon, 7 Nov 2016 at 18:54 Sergey Vojtovich wrote: > Hi! > > ALL BRANCH OWNERS: PLEASE REVIEW AND C

[Maria-developers] Community Involvement - GSoC Mentor Summit impressions

Hi everyone! Since MariaDB has completed another Google Summer of Code program this year, with some great projects as well, the MariaDB Foundation was able to send 2 mentors to the summit in California this year. I was one of the people that had the privilege to go. There were a lot of talks ther

Re: [Maria-developers] [Commits] aa9bd40: MDEV-10824 - Crash in CREATE OR REPLACE TABLE t1 AS SELECT spfunc()

Hi Sergey! I think you commited the AAA.test file by mystake. Regards, Vicentiu On Mon, 24 Oct 2016 at 13:47 Sergey Vojtovich wrote: > revision-id: aa9bd40f8067e1421ad71d2ada367544a6db78ca > (mariadb-10.0.27-8-gaa9bd40) > parent(s): 4dfb6a3f54cfb26535636197cc5fa70fe5bacc2e > committer: Sergey

[Maria-developers] Article on git rebasing - follow up from Developer Meetup

Hi everyone! During the Developer Meetup in Amsterdam, we've had quite some productive discussions. One of these was on how to make use of git rebase to clean up our history before pushing final changes. The presentation on it was a bit rushed and perhaps some did not get the full gist out of it.

Re: [Maria-developers] Error building mariadb-10.0 with Clang 3.8: Unqualified lookup in templates

Hi Luke! This is a know problem that will be fixed in the upcoming release. https://jira.mariadb.org/browse/MDEV-5944 Regards, Vicențiu On Thu, 13 Oct 2016 at 09:16 Luke Benes wrote: > Building mariadb-10.0 with Clang results in: > > graph_concepts.hpp:93:17: error: call to function 'out_edge

Re: [Maria-developers] Sachin weekly report

th you but defining > #define HA_HASH_STR_LEN 4 > or > const int HA_HASH_STR_LEN = 4; > > make it independent of length of "hash". Although we rarely gone > change "hash", so I think it > is a good idea. What do you think , Sergei? > Regards

Re: [Maria-developers] Sachin weekly report

Hi Sachim, Sergei! One quick thing I wanted to point out. I did not specifically look at how things get called, but, when defining constants, I don't agree with: > +#define HA_HASH_STR_LEN strlen(HA_HASH_STR) > Or: > > +#define HA_HASH_STR_INDEX_LEN strlen(HA_HASH_STR_I

Re: [Maria-developers] c56c966: MDEV-10563 Crash during shutdown in Master_info_index::any_slave_sql_running

Hi Kristian, Thanks for the quick and thorough reply. As to the patch, you're basically moving the check for NULL into all the > callers. I'm not sure if the check is even needed for all callers, but > then, > I also do not think it's worth it to try and determine where it is needed > and where n

Re: [Maria-developers] [Commits] 5486f34: MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func

vicentiu wrote: > > revision-id: 5486f3458859fa4bd161150b9ac0e9c0f633a0e3 > (mariadb-10.2.1-9-g5486f34) > > parent(s): 08683a726773f8cdf16a4a3dfb3920e5f7842481 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2016-08-01 14:43:41 +0300 > > m

Re: [Maria-developers] Aggregate Stored Functions

>>>>>>>> On Fri, Jun 3, 2016 at 1:01 PM, Varun Gupta < >>>>>>>>>>> varungupta1...@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> For non aggregate function , show output is co

[Maria-developers] Please review MDEV-9497 oqgraph fails to build with boost 1.60

Hi Sergei! Can you please review the following patch for MariaDB 10.0. It fixes a compilation failure in Debian/Ubuntu when boost 1.60 or later is installed. I've looked into the code and checked if the #ifdef'ed code is used anywhere. There is absolutely no reference to it. I doubt it affect any

Re: [Maria-developers] Aggregate Stored Functions

to make sure it could >> be used for stored procedures too in the future. >> I have committed the changes on GitHub :) >> >> On Mon, May 23, 2016 at 4:21 PM, Vicențiu Ciorbaru >> wrote: >> >>> Hi Varun, >>> >>> Getting the parser to a

Re: [Maria-developers] Aggregate Stored Functions

Hi Varun, Getting the parser to accept the syntax is a good first step. Writing tests is the correct way to go also. Now we need to have a way to pass this extra information to the part of the code that stores / executes this procedure. When we encounter this AGGREGATE_SYM syntax we have to recor

Re: [Maria-developers] Aggregate Stored Functions

Hi Sanja, Since we have not officially started the coding period, I figured that an exercise in adding a parser syntax would be a good first step. We can do automatic detection by looking at the cursor without to much extra work. Vicentiu On Fri, 20 May 2016 at 08:29, Sanja wrote: > Hi! > > H

Re: [Maria-developers] [Commits] b1ddc7d: MDEV-9487: Server crashes in Time_and_counter_tracker::incr_loops with UNION in ALL subquery

Hi Sanja, Sergey, I think Sergey might have mean the same thing but it is not clear to me. in_optimize never gets set to true. By mentioning that it is redundant that means that it can be removed from the current code right? Also, I would put the "return true" conditions after the "return false"

Re: [Maria-developers] [GSOC Students] Allow to contribute

Hi Daniil! The nice thing about git and Github is that you can do all the coding on your own repository. You don't actually need any specific access for the MariaDB repository. My suggestion is to create your own fork of MariaDB (by clicking the fork button on github). Here is a very short tutoria

Re: [Maria-developers] [Commits] a0c06ba: Preliminary implementation for the aggregate sum function as a window function

Vicentiu Ciorbaru wrote: > > revision-id: a0c06ba1edb54c8c4705189c0455137a85658297 > (mariadb-10.1.8-154-ga0c06ba) > > parent(s): ce8a0d8e19e7bf1486a2c80ff6b7a30ef35bf99f > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2016-03-14 15:42:00

[Maria-developers] MTR related community contribution

Hi Vlad, I'm looking at the community pull request https://github.com/grooverdan/mariadb-server/commit/a9dfee63bad7393002621f92c15f1debd535ee1a I have a question regarding your commit: 2943d2b7e99b4221ef481890fc9a56ad569f3985 The contribution aims to remove the hard limit of 50 unique ids as it

[Maria-developers] Invalid code in server_audit.c

Hi Alexei, While investigating community contributions from Daniel Black (MDEV-9433), I came across this comment: [image: danblack]Daniel Black added a comment - 2016-01-20 02:54 [plugin/server_audit/server_audit.c:402]: (erro

Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

. Vicentiu On Fri, 8 Jan 2016 at 09:36, Alexander Barkov wrote: > Hi Vicențiu, > > > On 01/08/2016 02:48 AM, Vicențiu Ciorbaru wrote: > > Hi Alexander, Sergei, > > > > On Fri, 8 Jan 2016 at 00:10 Alexander Barkov > <mailto:b...@mariadb.org>> wrote: &g

Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

Hi Alexander, Sergei, On Fri, 8 Jan 2016 at 00:10 Alexander Barkov wrote: > Hi Sergei, > > > On 01/07/2016 08:53 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > On Nov 27, Alexander Barkov wrote: > >> Hi Serg, > >> > >> Please review a patch for MDEV-8092. > > > > I didn't review a lo

Re: [Maria-developers] Use of std::string

On Wed, 6 Jan 2016 at 21:48 Sergei Golubchik wrote: > Hi, Vicențiu! > Hi Sergei! > On Jan 05, Vicențiu Ciorbaru wrote: > > > > Sample code where we can avoid ifs: > > > > case SSL_TYPE_SPECIFIED: > > table->field[nex

[Maria-developers] Use of std::string

Hi Sergei, I was doing some work within sql_acl.cc, having to refactor a bit of logic regarding USER_RESOURCES and SSL related stuff and I'm thinking of making use of std::string instead of const char* to remove the need for checking NULL pointers. I noticed that we generally do not make any use

Re: [Maria-developers] [Commits] 6414959: MDEV-7526: TokuDB doesn't build on OS X

On Sun, 20 Dec 2015 at 11:44 Sergei Golubchik wrote: > Hi, Vicentiu! > > On Dec 19, Vicentiu Ciorbaru wrote: > > revision-id: 64149590c47d1cf6b1b227d8c90bdc23d20a8956 > (mariadb-5.5.47-8-g6414959) > > parent(s): f89c9fc4b7b5d82c79775cb848225900b45a6b79 > > author: V

Re: [Maria-developers] [Commits] 9d8ad0d: Add --persistent option for mysqlcheck

Git log show his name, I think that the commit message generated by the hook is at fault. On Tue, 15 Dec 2015 at 16:20 Vicențiu Ciorbaru wrote: > Hi Sergey, > > The commit message still has his name on it. > > I've only added some code to it, but I've left his orig

Re: [Maria-developers] [Commits] 9d8ad0d: Add --persistent option for mysqlcheck

11:11:50AM +0200, Vicentiu Ciorbaru wrote: > > revision-id: 9d8ad0d79e3c3a1a9bf7c8cc6477ee4e69fba633 > (mariadb-10.0.22-63-g9d8ad0d) > > parent(s): e9b4a041af5122dffd59012493c565e6e3db2664 > > committer: Vicențiu Ciorbaru > > timestamp: 2015-12-15 11:11:28 +0200 > > message: > &g

Re: [Maria-developers] BUILD ERROR

Hi Laketra, As far as I know, MariaDB tokudb engine does not work on Mac OS. To not compile tokudb you can run during cmake Cmake. -DPLUGIN_TOKUDB=NO Then run make. Make sure to delete cmakecache.txt before running cmake again. Vicentiu On Fri, 11 Dec 2015 at 11:19, Laketra Musa wrote: > Hi, >

[Maria-developers] [MDEV-7122] Questions regarding code history

Hi Sergey! I've been investigating MDEV-7122. I'm still quite a ways to go before I can understand all the underlying bits of logic. I need a little help regarding a change that you've committed a while back. Do you know (remember) why you've placed DBUG_ASSERT(0) in the commit: a1b4eadf89a3940b8

[Maria-developers] Error Compiling MariaDB with clang on Mac Os X

Hi Sergei, While working on features for 10.2 I've encountered a problem when compiling MariaDB as a Debug build. According to your change on commit 29dd634a4c0b9c3579cf9d318ed64d748d848b1d dbug: correct trace for DBUG_RETURN(func()); This causes a small problem, in two places within the codebas

Re: [Maria-developers] MDEV-6877 - binlog_row_image implementation advice

Nielsen wrote: > Vicențiu Ciorbaru writes: > > > I've gotten to a "sort of" stable state with binlog_row_image. It's not > > 100% complete as I did not add any tests for the new use cases. > > Also there are a couple of changes that I am not 100% sure if

[Maria-developers] MDEV-7937: Enforce SSL when --ssl client option is used

Hi Sergei! I've done some work on this issue. I've read MySQL's implementation of this and have looked at our implementation. They have done a bit of refactoring, introducing an enforce_ssl flag, as well as changing the C interface a bit, to allow setting this flag programatically. I've created a

  1   2   >