Re: [Maria-developers] 6daf451415f: Let "FTWRL " use extra(HA_EXTRA_FLUSH)

2020-04-02 Thread Sergey Vojtovich
Sergei, On Thu, Apr 02, 2020 at 05:13:27PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Apr 02, Sergey Vojtovich wrote: > > On Thu, Apr 02, 2020 at 11:43:14AM +0200, Sergei Golubchik wrote: > > > Hi, Sergey! > > > > > > On Apr 01, Sergey Vojtovi

Re: [Maria-developers] eeba5b2b158: Fixed close_cached_connection_tables() flushing

2020-04-02 Thread Sergey Vojtovich
Sergei, On Thu, Apr 02, 2020 at 11:44:04AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Apr 02, Sergey Vojtovich wrote: > > revision-id: eeba5b2b158 (mariadb-10.5.0-72-geeba5b2b158) > > parent(s): a737b71295e > > author: Sergey Vojtovich > > committer

Re: [Maria-developers] 5c26e91f755: Cleanup close_all_tables_for_name()

2020-04-02 Thread Sergey Vojtovich
Sergei, On Thu, Apr 02, 2020 at 11:43:26AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Apr 01, Sergey Vojtovich wrote: > > revision-id: 5c26e91f755 (mariadb-10.5.0-70-g5c26e91f755) > > parent(s): 6daf451415f > > author: Sergey Vojtovich > > committer

Re: [Maria-developers] 6daf451415f: Let "FTWRL " use extra(HA_EXTRA_FLUSH)

2020-04-02 Thread Sergey Vojtovich
Sergei, On Thu, Apr 02, 2020 at 11:43:14AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Apr 01, Sergey Vojtovich wrote: > > revision-id: 6daf451415f (mariadb-10.5.0-69-g6daf451415f) > > parent(s): c24253d0fa3 > > author: Sergey Vojtovich > > committer

Re: [Maria-developers] 7740cb24572: Don't use plugin->data for storage engine plugins

2020-03-31 Thread Sergey Vojtovich
Hi Sergei, On Tue, Mar 31, 2020 at 02:15:34PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Mar 31, Sergey Vojtovich wrote: > > revision-id: 7740cb24572 (mariadb-10.4.4-472-g7740cb24572) > > parent(s): da6d7f72b0a > > author: Sergey Vojtovich > > committer

Re: [Maria-developers] [MariaDB/server] Proper locking for mysql.gtid_slave_pos truncation (84b437d)

2019-12-18 Thread Sergey Vojtovich
Kristian, Thanks for your prompt reply! On Wed, Dec 18, 2019 at 08:38:31AM +0100, Kristian Nielsen wrote: > Sergey Vojtovich writes: > > > ATTN @dr-m, @andrelkin, @SachinSetiya, @knielsen > > So IIUC, this is about incorrect usage of ha_truncate() in > rpl_slave_state:

Re: [Maria-developers] [Commits] b3473961810: MDEV-11094: Blackhole table updates on slave fail when row annotation is enabled

2019-05-29 Thread Sergey Vojtovich
Hi Sujatha, On Wed, May 29, 2019 at 04:37:27PM +0530, sujatha wrote: > revision-id: b347396181018cedc946450cb49891f1a0aa4575 > (mariadb-10.1.39-48-gb3473961810) > parent(s): 8358c6f03edb941be488f009c2bd0eb9df47e8c5 > author: Sujatha > committer: Sujatha > timestamp: 2019-05-29 15:18:52 +0530 > me

Re: [Maria-developers] cf9bafc: MDEV-14815 - Server crash or AddressSanitizer errors or valgrind warnings

2018-10-19 Thread Sergey Vojtovich
Hi Sergei, On Fri, Oct 19, 2018 at 04:13:16PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Oct 19, Sergey Vojtovich wrote: > > revision-id: cf9bafc8cb0943c914d118525888140ea15e6b55 > > (mariadb-10.0.36-50-gcf9bafc) > > parent(s): 8e716138cef2d9be603cdf71

Re: [Maria-developers] e11e0e6c8b9: MDEV-17167 - InnoDB: Failing assertion: table->get_ref_count() == 0 upon

2018-09-24 Thread Sergey Vojtovich
Hi Sergei, On Mon, Sep 24, 2018 at 03:02:40PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Sep 12, Sergey Vojtovich wrote: > > revision-id: e11e0e6c8b9a85ca7f16c6b9b28fb505d464a96e > > (mariadb-10.3.7-186-ge11e0e6c8b9) > > parent(s): f2f661b848c02ebd7c444ba6

Re: [Maria-developers] b88e98df9da: C++11 experiment: check if all builders support it

2018-07-03 Thread Sergey Vojtovich
irst release) so that we're more or less certain we won't have to revert it. > > > revision-id: b88e98df9daa586bd6ed1f5908ededaa65a6e464 > > (mariadb-10.3.6-16-gb88e98df9da) > > parent(s): 9988a423d229730b252942b7fa066d1591b7eca9 > > author: Sergey Vojtovi

Re: [Maria-developers] innobase/sync0policy.h converts opaque pthread_t to ULINT

2018-04-16 Thread Sergey Vojtovich
Hi Sergei, If you disable just DebugMutex but leave UNIV_DEBUG enabled, how do you make assertions like this work properly: `ut_ad(mutex_own(&mutex))`? Regards, Sergey On Mon, Apr 16, 2018 at 01:30:33PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Apr 16, Sergey Vo

Re: [Maria-developers] innobase/sync0policy.h converts opaque pthread_t to ULINT

2018-04-16 Thread Sergey Vojtovich
Hi! Something similar (HAVE_IB_ATOMIC_PTHREAD_T_GCC) was removed in 2b47f8ff03845f7ffe2fa3bd583dd4123dae2b61. IIRC the reason was: relevant code didn't follow this macro properly and this code was still functional. You may use os_thread_pf(os_thread_get_curr_id()) to cast it to ulint. Yes, it is

Re: [Maria-developers] MDEV-14929 - AddressSanitizer: memcpy-param-overlap in Field_longstr::compress

2018-03-31 Thread Sergey Vojtovich
Sergei, On Sat, Mar 31, 2018 at 01:15:02PM +0200, Sergei Golubchik wrote: > Hi, Sergey, > > > From 6de643a580b4e706e0201927e43a033f5cb98970 Mon Sep 17 00:00:00 2001 > > From: Sergey Vojtovich > > Date: Wed, 21 Mar 2018 13:54:15 +0400 > > Subject: [PATCH] MDEV-14

Re: [Maria-developers] 665402a: MDEV-14265 - RPMLint warning: shared-lib-calls-exit

2017-12-18 Thread Sergey Vojtovich
Hi Sergei, Thanks for looking into this patch! On Mon, Dec 18, 2017 at 09:34:30PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 18, Sergey Vojtovich wrote: > > revision-id: 665402aa9b83565c1cef3caa06cd998d3808f0d7 > > (mariadb-10.1.29-31-g

Re: [Maria-developers] 9145b7d: MDEV-11153 - Introduce status variables for table cache monitoring and tuning

2017-10-26 Thread Sergey Vojtovich
wrote: > Hi, Sergey! > > Looks ok, thanks. Just one question: > > On Aug 10, Sergey Vojtovich wrote: > > revision-id: 9145b7dd11a0e95016304e53acf306daac323580 > > (mariadb-10.3.0-49-g9145b7d) > > parent(s): 63ad4fe5bbe77fe17ab441fcce0106bdee9b618d > > commit

Re: [Maria-developers] [Commits] 62021f3: MDEV-12070 - Introduce thd_query_safe() from MySQL 5.7

2017-06-23 Thread Sergey Vojtovich
Hi Sergei, On Fri, Jun 23, 2017 at 12:47:46PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 22, Sergey Vojtovich wrote: > > revision-id: 62021f391a42c5577190aa43cb8ad91e56235b46 > > (mariadb-10.2.6-57-g62021f3) > > parent(s): 557e1bd472612848a42e772c1fb

Re: [Maria-developers] [Commits] 922f970: MDEV-12882 - Assertion failed in MDL_context::upgrade_shared_lock

2017-06-22 Thread Sergey Vojtovich
Sergei, On Thu, Jun 22, 2017 at 07:57:21PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 22, Sergey Vojtovich wrote: > > revision-id: 922f9700a7fb084e3f7d6cff56e27e24fc603ed7 > > (mariadb-10.2.6-58-g922f970) > > parent(s): 62021f391a42c5577190aa43cb8ad91e562

Re: [Maria-developers] MDEV-12620 - set lock_wait_timeout = 1; flush tables with read lock;

2017-06-16 Thread Sergey Vojtovich
Hi Sergei, On Fri, Jun 16, 2017 at 02:28:55PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 16, Sergey Vojtovich wrote: > > revision-id: 056bab0880544d91ea67d18fe8db65b4f6625482 > > (mariadb-10.1.24-22-g056bab0) > > parent(s): 58f87a41bd8de7370cc05c41977

Re: [Maria-developers] compilation failure: my_atomic.h

2017-04-07 Thread Sergey Vojtovich
Hi Alexander, Marko, It was agreed to drop support for x86 asm based atomic operations in 10.3, which broke builds on this host. CentOS 5 is currently discontinued. We just need to remove it from our 10.3 builds. We're heading towards C11 atomic operations in a sense that we mimic it's API. But w

Re: [Maria-developers] [Commits] 00c30e5: MDEV-11645: archive.archive fails in buildbot with valgrind (Use of uninitialised value)

2017-03-03 Thread Sergey Vojtovich
Hi Varun, On Wed, Mar 01, 2017 at 07:50:01AM +0530, Varun wrote: > revision-id: 00c30e5a234fbd01484cd069c01e97c075025323 > (mariadb-10.2.3-283-g00c30e5) > parent(s): b13cee83f9cfcffa98d227c492411a9acec85f42 > author: Varun Gupta > committer: Varun Gupta > timestamp: 2017-03-01 07:46:26 +0530 > me

Re: [Maria-developers] [Commits] 5f02c66: MDEV-11227 - mysqlimport -l doesn't issue UNLOCK TABLES

2016-12-15 Thread Sergey Vojtovich
Hi Sergei, On Thu, Dec 15, 2016 at 04:38:04PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 15, Sergey Vojtovich wrote: > > > > + /* > > > > An upgradable shared metadata lock which blocks all attempts to > > > > update > >

Re: [Maria-developers] [Commits] 5f02c66: MDEV-11227 - mysqlimport -l doesn't issue UNLOCK TABLES

2016-12-15 Thread Sergey Vojtovich
Hi Sergei, Thanks for your feedback. Answers inline. On Thu, Dec 15, 2016 at 02:23:03PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 13, Sergey Vojtovich wrote: > > revision-id: 5f02c661f3d30baf08071acad29cef40fad0739c > > (mariadb-10.2.2-225-g

Re: [Maria-developers] Deleting unused branches on github

2016-11-07 Thread Sergey Vojtovich
re's no action, we may consider we did our best and aren't obligated to keep these branches anymore. > > > At least the following branches may have valuable revisions: > >> origin/10.1-spider 1 year, 1 month ago Michael Widenius > >> > >> origin/10.0-p

Re: [Maria-developers] Deleting unused branches on github

2016-11-07 Thread Sergey Vojtovich
t the following branches don't seem to exist anymore: > origin/bb-10.1-systemd1 year ago Sergey > Vojtovich > origin/bb-svoj1 year, 1 month ago Sergey > Vojtovich > origin/bb-10.1-atomics

Re: [Maria-developers] new PLUGIN API.

2016-10-23 Thread Sergey Vojtovich
Hi Alexey, Just soem thought from my side... > +const char *ap_get_database(MYSQL_THD thd) > +{ > + if (!thd) > +return ""; > + > + return thd->db; > +} I think this should be benchmarked with perf. Things like this ain't good performance wise (we already fixed a bunch of those). That is wh

Re: [Maria-developers] MDEV-7660 MySQL WL#6671 "Improve scalability by not using thr_lock.c locks for InnoDB tables"

2016-10-18 Thread Sergey Vojtovich
Hi Sergei! On Sat, Oct 15, 2016 at 11:13:24AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Oct 15, Sergey Vojtovich wrote: > > Hi Sergei, > > > > Sorry to say this, but you reviewed outdated commits. There's just one in > > bb-10.2-mdev7660 now. Si

Re: [Maria-developers] MDEV-7660 MySQL WL#6671 "Improve scalability by not using thr_lock.c locks for InnoDB tables"

2016-10-14 Thread Sergey Vojtovich
Hi Sergei, Sorry to say this, but you reviewed outdated commits. There's just one in bb-10.2-mdev7660 now. Since value of those cleanups was rather questionable and I got conflicts on rebase I discarded them. Still some answers inline. On Fri, Oct 14, 2016 at 08:12:52PM +0200, Sergei Golubchik w

Re: [Maria-developers] [Commits] 9f7e77b: MDEV-10296 - Multi-instance table cache

2016-09-09 Thread Sergey Vojtovich
Hi Sergei, On Fri, Sep 09, 2016 at 09:03:23AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Sep 07, Sergey Vojtovich wrote: > > revision-id: 9f7e77b5414b5b2ef9b5f50f131966821fefb9c7 > > (mariadb-10.1.8-229-g9f7e77b) > > parent(s): 58634f6e50b40b28533a03a1afc

Re: [Maria-developers] [Commits] 97d212a: MDEV-10545: Server crashed in my_copy_fix_mb on querying I_S and P_S tables

2016-09-02 Thread Sergey Vojtovich
Hi Nirbhay, On Fri, Sep 02, 2016 at 09:00:27AM -0400, Nirbhay Choubey wrote: > > > diff --git a/sql/log_event.cc b/sql/log_event.cc > > > index afa58af..66e7c60 100644 > > > --- a/sql/log_event.cc > > > +++ b/sql/log_event.cc > > > @@ -6022,7 +6022,7 @@ int Load_log_event::do_apply_event(NET* net,

Re: [Maria-developers] 48d1ba6: MDEV-10296 - Multi-instance table cache

2016-08-31 Thread Sergey Vojtovich
Hi Sergei, On Wed, Aug 31, 2016 at 04:47:09PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Aug 03, Sergey Vojtovich wrote: > > > On Jun 29, Sergey Vojtovich wrote: > > > > revision-id: 48d1ba6097939efe5efd28dd3ed9d281cc2bc2f4 > > > > (ma

[Maria-developers] Commit emails reply-to maria-developers@lists.launchpad.net

2016-08-24 Thread Sergey Vojtovich
Hi! Why do commit emails have "Reply-To: maria-developers@lists.launchpad.net"? I believe it is wrong at least for the following reasons: - I must be careful if I want to reply privately, e.g. something like "hold on, I'll review it in a few hours" doesn't deserve to hit maria-developers@ - I w

Re: [Maria-developers] [Commits] 294961c: MDEV-10538: MariaDB fails to start without galera_recovery in systemd mode

2016-08-24 Thread Sergey Vojtovich
Hi Nirbhay, Ok to push. I suggest that we avoid such overcomplicated constructs in our default systemd configuration. Consider integrating recovery into the server (I know it's not trivial) or creating "included" config for galera. Thanks, Sergey On Mon, Aug 22, 2016 at 06:38:07PM -0400, Nirbhay

Re: [Maria-developers] Please review MDEV-10604 Disable unstable MTR tests by default

2016-08-24 Thread Sergey Vojtovich
2016 at 03:04:26PM +0300, Elena Stepanova wrote: > Hi Sergey (Vojtovich), > > Please review the patch that we've discussed at length. > Serg, FYI. > > The length of the "unstable" list shouldn't scare anyone. At the end, this > task should cause no

Re: [Maria-developers] 48d1ba6: MDEV-10296 - Multi-instance table cache

2016-08-03 Thread Sergey Vojtovich
other cases too? Aim of this patch is to improve scalability when single table is being accessed by multiple threads. > And what is the effect of the more expensive tc_remove_all_unused_tables() ? Not sure I understand this question, could you elaborate? > > On Jun 29, Sergey Vo

Re: [Maria-developers] e252dae: MDEV-9872 - Add common optimized CRC32 function interface

2016-08-02 Thread Sergey Vojtovich
ors. I can see only one ifdef that can be avoided (mysys/checksum.c). InnoDB never calls crc32(), so it has to have this mess. I can change it, but my preference is to keep it and make my_checksum() static inline instead. > > On Jul 05, Sergey Vojtovich wrote: > > revision-id: e252dae

Re: [Maria-developers] [Commits] 5486f34: MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func

2016-08-02 Thread Sergey Vojtovich
Hi Vicentiu, Ok to push. This patch is against 10.2, do you plan to fix previous versions separately? On Mon, Aug 01, 2016 at 02:46:03PM +0300, vicentiu wrote: > revision-id: 5486f3458859fa4bd161150b9ac0e9c0f633a0e3 > (mariadb-10.2.1-9-g5486f34) > parent(s): 08683a726773f8cdf16a4a3dfb3920e5f7842

Re: [Maria-developers] [Commits] 5486f34: MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func

2016-08-01 Thread Sergey Vojtovich
Hi Vicentiu, I'm back from vacation, but quite busy with paperwork etc. I'll review your patch tomorrow. Regards, Sergey On Mon, Aug 01, 2016 at 02:46:03PM +0300, vicentiu wrote: > revision-id: 5486f3458859fa4bd161150b9ac0e9c0f633a0e3 > (mariadb-10.2.1-9-g5486f34) > parent(s): 08683a726773f8cdf

Re: [Maria-developers] [Commits] 3bbf3d2: MDEV-10216: Assertion `strcmp(share->unique_file_name, filename) ||

2016-07-05 Thread Sergey Vojtovich
Hi Nirbhay, Looks good, thanks! On Fri, Jul 01, 2016 at 02:47:29PM -0400, Nirbhay Choubey wrote: > revision-id: 3bbf3d2e246da1a2fd458b634f30cbe35afb5668 > (mariadb-10.2.0-142-g3bbf3d2) > parent(s): 76f492e26d8d45c678c570be2cf4ca5d238edceb > author: Nirbhay Choubey > committer: Nirbhay Choubey >

Re: [Maria-developers] [MariaDB/server] MDEV-10298: Systemd hardening (#195)

2016-06-29 Thread Sergey Vojtovich
e? Thanks, Sergey On Wed, Jun 29, 2016 at 02:19:00PM +0200, Kristian Nielsen wrote: > Sergey Vojtovich writes: > > > Similar to other open source projects, the MariaDB Foundation needs to > > have shared ownership of all code that is included in the MariaDB > > distri

Re: [Maria-developers] [Commits] d1de640: MDEV-10216: Assertion `strcmp(share->unique_file_name, filename) ||

2016-06-23 Thread Sergey Vojtovich
Hi Nirbhay, This solution looks better than MyISAM/Aria based one. Still a few doubts inline. I still suggest someone should do second review. On Tue, Jun 21, 2016 at 01:47:15PM -0400, Nirbhay Choubey wrote: > revision-id: d1de6402c8734e9a1929c2384c0cfc07c2ec48c0 > (mariadb-10.2.0-83-gd1de640)

Re: [Maria-developers] [Commits] 511bd2c: MDEV-10216: Assertion `strcmp(share->unique_file_name, filename) ||

2016-06-16 Thread Sergey Vojtovich
Hi Nirbhay, last_version of MyISAM is used for debugging only and has no functional effect. last_version of Aria has some functional effect. Effect of HA_EXTRA_PREPARE_FOR_RENAME for MyISAM is flush key blocks and reset last_version. Effect of HA_EXTRA_PREPARE_FOR_RENAME for Aria is more complex.

Re: [Maria-developers] MDEV-7660 MySQL WL#6671 "Improve scalability by not using thr_lock.c locks for InnoDB tables"

2016-06-01 Thread Sergey Vojtovich
Hi Sergei, On Wed, Jun 01, 2016 at 08:39:36AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 01, Sergey Vojtovich wrote: > > On Tue, May 31, 2016 at 06:48:31PM +0200, Sergei Golubchik wrote: > > > > > > I think it's fine. I had a few questions thou

Re: [Maria-developers] MDEV-7660 MySQL WL#6671 "Improve scalability by not using thr_lock.c locks for InnoDB tables"

2016-05-31 Thread Sergey Vojtovich
I can try to make a list if you like. > > > commit 47aa5f9 > > Author: Sergey Vojtovich > > Date: Fri May 6 13:44:07 2016 +0400 > > > > MDEV-7660 - MySQL WL#6671 "Improve scalability by not using thr_lock.c > > locks > > for

Re: [Maria-developers] [Commits] 53696a6: MDEV-10004: Galera's pc.recovery process fails in 10.1 with systemd

2016-05-27 Thread Sergey Vojtovich
Hi Nirbhay, Looks good to push. On Thu, May 26, 2016 at 11:52:04PM -0400, Nirbhay Choubey wrote: > revision-id: 53696a63a2a517e04bf27382184162da50994ecb > (mariadb-10.1.14-4-g53696a6) > parent(s): 9a1c4e900b98fdb9940aab57c895753f175c2bd8 > author: Nirbhay Choubey > committer: Nirbhay Choubey > t

Re: [Maria-developers] [Commits] 454a9dc: MDEV-10004: Galera's pc.recovery process fails in 10.1 with systemd

2016-05-25 Thread Sergey Vojtovich
Hi Nirbhay, I believe this patch is acceptable. Still I didn't completely understand the need for all this complexity and your answer to Daniel's question. Some minor comments inline. On Fri, May 20, 2016 at 11:04:24PM -0400, Nirbhay Choubey wrote: > revision-id: 454a9dc53a5b02af316dd713c577082e

[Maria-developers] Effect of gcc optimization levels

2016-05-17 Thread Sergey Vojtovich
Hi Wlad, Last week I promised to benchmark effect of various gcc optimization levels. Here're results: -O0 418TPS -Os 663TPS -O1 759TPS -O2 807TPS -O3 812TPS -O3 -unroll2 -ip 812TPS (default) -Ofast 819TPS Benchmark was done on a Sandy Bridge system running Ubuntu 12.10. Single thread OLTP RO, p

Re: [Maria-developers] Joinable threads

2016-05-06 Thread Sergey Vojtovich
Hi Monty, On Fri, May 06, 2016 at 12:52:02PM +0300, Michael Widenius wrote: > Hi! > > On 5 May 2016 17:42, "Sergey Vojtovich" wrote: > > > > Hi Monty, > > > > Thanks for you reply. Please allow me to disagree with some points. :) > > > > At

Re: [Maria-developers] Joinable threads

2016-05-05 Thread Sergey Vojtovich
> On Wed, May 4, 2016 at 11:13 AM, Sergey Vojtovich wrote: > > Hi Monty, > > > > I vaguely recall you told me once that you like detached threads more than > > joinable, specifically for service threads. Could you remind me what were > > the reasons behi

[Maria-developers] Joinable threads

2016-05-04 Thread Sergey Vojtovich
Hi Monty, I vaguely recall you told me once that you like detached threads more than joinable, specifically for service threads. Could you remind me what were the reasons behind it? I need this to fix https://jira.mariadb.org/browse/MDEV-9994 properly. Thanks, Sergey ___

Re: [Maria-developers] 745b522: MDEV-8889 - Assertion `next_insert_id == 0' failed in handler::ha_external_lock

2016-04-22 Thread Sergey Vojtovich
Hi Sergei, Thanks for you review! On Fri, Apr 22, 2016 at 06:07:19PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > I believe this fix is ok... > > On Apr 21, Sergey Vojtovich wrote: > > revision-id: 745b5226e68d376eed709d930f72c3fbc7f07d2a > > (mariadb-10.0.2

Re: [Maria-developers] 21265d5: MDEV-9943 - TokuDB fails to compile with gcc 5.2.1

2016-04-19 Thread Sergey Vojtovich
Hi Sergei, I don't mind, but it needs to be tested. It have to wait till tomorrow. Regards, Sergey On Tue, Apr 19, 2016 at 06:30:43PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Apr 19, Sergey Vojtovich wrote: > > revision-id: 21265d58c1ea65f5c21a56cf669321f390

Re: [Maria-developers] MTR related community contribution

2016-02-07 Thread Sergey Vojtovich
Hi! IIUC one of limitations might be caused by mtr reserving 20 TCP ports per instance, first reserved port is 16000. This leaves (65535 - 16000) / 20= 2476.75 max possible mysqld instances. Regards, Sergey On Sun, Feb 07, 2016 at 12:52:01PM +0100, Vladislav Vaintroub wrote: > > > On 2/6/2016

Re: [Maria-developers] [Commits] b904ca0: MDEV-9297 - mysql_install_db launches mysqld 3x

2015-12-29 Thread Sergey Vojtovich
Hi Sergei, On Tue, Dec 29, 2015 at 01:51:02PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 23, Sergey Vojtovich wrote: > > revision-id: b904ca0c2e9e35ffecb314f1082e45bfb42038f3 > > (mariadb-10.1.8-99-gb904ca0) > > parent(s): 29290a3d53a05bd7177bcf7de05

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-12-28 Thread Sergey Vojtovich
Hi Sergei, On Wed, Nov 25, 2015 at 02:11:21PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 25, Sergey Vojtovich wrote: > > On Mon, Nov 23, 2015 at 10:44:39AM +0100, Sergei Golubchik wrote: > > > On Nov 23, Sergey Vojtovich wrote: > > > > On M

Re: [Maria-developers] [Commits] 2b3bffb: MDEV-8491 - On shutdown, report the user and the host executed that.

2015-12-24 Thread Sergey Vojtovich
Hi Sergei, On Thu, Nov 26, 2015 at 02:55:49PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 26, Sergey Vojtovich wrote: > > > > + > > > > + if ((user= my_strdup(user_host_buff, MYF(0))) && > > > &

Re: [Maria-developers] [Commits] ed5ec30: MDEV-7780 - Support for faking server version

2015-12-24 Thread Sergey Vojtovich
Hi Sergei, On Thu, Dec 24, 2015 at 01:24:09PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 24, Sergey Vojtovich wrote: > > revision-id: ed5ec30f9ca448086db5acbfd5f484a534119810 > > (mariadb-10.1.8-101-ged5ec30) > > parent(s): 1f19c6aa93de730cd10c9fcbb33

Re: [Maria-developers] [Commits] 370ab48: MDEV-9209 - [PATCH] scripts: Do not prepend the prefix to absolute paths

2015-12-22 Thread Sergey Vojtovich
Hi Sergei, On Tue, Dec 22, 2015 at 01:27:48PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 18, Sergey Vojtovich wrote: > > revision-id: 370ab48e9fcf4bc15ffa5e313fc34aa97981a832 > > (mariadb-10.1.9-24-g370ab48) > > parent(s): 428e09a789a17211de9b4f0a2c4

Re: [Maria-developers] [Commits] 063967b: MDEV-9081 - Debian: insecure debian-sys-maint password handling

2015-12-21 Thread Sergey Vojtovich
Hi Sergei, On Mon, Dec 21, 2015 at 08:22:51PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 21, Sergey Vojtovich wrote: > > On Mon, Dec 21, 2015 at 01:45:27PM +0100, Sergei Golubchik wrote: > > > > > > > besides, what the plan for moving to unix_so

Re: [Maria-developers] [Commits] 063967b: MDEV-9081 - Debian: insecure debian-sys-maint password handling

2015-12-21 Thread Sergey Vojtovich
Hi Sergei, On Mon, Dec 21, 2015 at 01:45:27PM +0100, Sergei Golubchik wrote: ...skip... > > > besides, what the plan for moving to unix_socket auth? > > Strictly speaking there is no plan. If you're asking for my opinion: I like > > it. > > I'd avoid such massive changes to not very well tested

Re: [Maria-developers] [Commits] 063967b: MDEV-9081 - Debian: insecure debian-sys-maint password handling

2015-12-21 Thread Sergey Vojtovich
Hi Sergei, On Mon, Dec 21, 2015 at 12:50:05PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 21, Sergey Vojtovich wrote: > > revision-id: 063967b1e447f0fc908a1ec0224fd7c1d268bf17 > > (mariadb-10.1.9-25-g063967b) > > parent(s): 370ab48e9fcf4bc15ffa5e313fc

Re: [Maria-developers] [Commits] 732d45e: MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many

2015-12-16 Thread Sergey Vojtovich
Hi Sergei, On Tue, Dec 15, 2015 at 10:49:37PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Dec 14, Sergey Vojtovich wrote: > > revision-id: 732d45e93b81a104e3f3931e4908e22167a54622 > > (mariadb-10.0.22-57-g732d45e) > > parent(s): 3e206a518dec400e084451165f6

Re: [Maria-developers] [Commits] 9d8ad0d: Add --persistent option for mysqlcheck

2015-12-15 Thread Sergey Vojtovich
Hi Vicentu, this is contribution by Daniel. He should get some credit for this. Assuming you didn't change this code much, this should be committed on Daniel's behalf, so that he gets credit on github. Or at the very least mention in a comment contribution author. Thanks, Sergey On Tue, Dec 15,

[Maria-developers] PR#129 - 'truncate table' make server crash in sharding&ha configuration when wrapper is oracle

2015-12-09 Thread Sergey Vojtovich
Hi Kentoku, we got new pull request for Spider. Could you suggest what should we do about it? What license should be requested for Spider contributions? PR: https://github.com/MariaDB/server/pull/129 MDEV: https://mariadb.atlassian.net/browse/MDEV-9254 Thanks, Sergey ___

Re: [Maria-developers] [Commits] 6c19f0b: MDEV-9172 - Analyze patches for IBM System z

2015-12-09 Thread Sergey Vojtovich
Hi Sergei, On Wed, Dec 09, 2015 at 01:17:31PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 27, Sergey Vojtovich wrote: > > revision-id: 6c19f0b0eb0600c276f8681673dc768d542d3bd3 > > (mariadb-10.1.9-8-g6c19f0b) > > parent(s): 3c0e9d31b3e6494931deb09f5c9

Re: [Maria-developers] The compile errors on Linux on Power

2015-12-01 Thread Sergey Vojtovich
Hi Lixun, you likely have quite outdated compiler on that host. Anyway, there is a patch for similar issue on IBM Z, which should solve this problem: http://lists.askmonty.org/pipermail/commits/2015-November/008648.html Regards, Segrey On Tue, Dec 01, 2015 at 09:14:55PM +0800, Lixun Peng wrote:

Re: [Maria-developers] [Commits] 9f3eab9: MDEV-7780 - Support for faking server version

2015-11-26 Thread Sergey Vojtovich
Hi Sergei, we have 2 "exec perl" and many pipes. Not much, so I can change as you suggest. Thanks, Sergey On Thu, Nov 26, 2015 at 10:32:52AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 26, Sergey Vojtovich wrote: > > revision-id: 9f3eab98b93ae28

Re: [Maria-developers] [Commits] 2b3bffb: MDEV-8491 - On shutdown, report the user and the host executed that.

2015-11-26 Thread Sergey Vojtovich
Hi Sergei, On Thu, Nov 26, 2015 at 10:09:19AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 25, Sergey Vojtovich wrote: > > revision-id: 2b3bffb42cc4adbec2d91c1b9c4028374b63a51a > > (mariadb-10.1.8-75-g2b3bffb) > > parent(s): 6019fee7d84e8ec7d64337ad080

Re: [Maria-developers] [Commits] 6019fee: MDEV-7780 - Support for faking server version

2015-11-25 Thread Sergey Vojtovich
Hi Sergei, On Wed, Nov 25, 2015 at 02:35:59PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 25, Sergey Vojtovich wrote: > > revision-id: 6019fee7d84e8ec7d64337ad080a04f9c106bb68 > > (mariadb-10.1.8-74-g6019fee) > > parent(s): 2c29e85eafbf5bafe9c431accea

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-25 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 10:44:39AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 23, Sergey Vojtovich wrote: > > On Mon, Nov 23, 2015 at 10:00:33AM +0100, Sergei Golubchik wrote: > > > On Nov 23, Sergey Vojtovich wrote: > > > > >

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 10:00:33AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 23, Sergey Vojtovich wrote: > > > > > > > > So I didn't break it, it was broken even prior to this patch. In > > > > 5.7 all these options are

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 09:21:44AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 23, Sergey Vojtovich wrote: > > On Mon, Nov 23, 2015 at 08:39:23AM +0100, Sergei Golubchik wrote: > > > On Nov 20, Sergey Vojtovich wr

Re: [Maria-developers] [Commits] 334323b: MDEV-8542 - The "aria_recover" variable should be renamed "aria_recover_options"

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 09:00:45AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 20, Sergey Vojtovich wrote: > > revision-id: 334323bb3e5ca973cf239dce21a7d5510407f230 > > (mariadb-10.1.8-59-g334323b) > > parent(s): a1ab4314d1f88fa954a774c3227

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 08:39:23AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 20, Sergey Vojtovich wrote: > > revision-id: a1ab4314d1f88fa954a774c322709822d7b95344 > > (mariadb-10.1.8-58-ga1ab431) > > parent(s): cfc135b645db5fa78b9f63b1959

Re: [Maria-developers] [Commits] 2709165: MDEV-9128 - Compiling on IBM System Z fails

2015-11-18 Thread Sergey Vojtovich
Hi Jan, yes, for some reason XtraDB doesn't have this code and compiles well on Z. Regards, Sergey On Wed, Nov 18, 2015 at 02:57:19PM +0200, Jan Lindström wrote: > Hi Sergey, > > Is this true only for innodb_plugin ? > > R: Jan > > On Wed, Nov 18, 2015 at 2:07 P

Re: [Maria-developers] [Commits] f21705d: MDEV-7806 - thread_pool_size is not auto-sized

2015-11-17 Thread Sergey Vojtovich
Hi Sergei, On Tue, Nov 17, 2015 at 03:22:23PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 17, Sergey Vojtovich wrote: > > On Tue, Nov 17, 2015 at 02:23:56PM +0100, Sergei Golubchik wrote: > > > On Nov 17, Sergey Vojtovich wr

Re: [Maria-developers] [Commits] f21705d: MDEV-7806 - thread_pool_size is not auto-sized

2015-11-17 Thread Sergey Vojtovich
Hi Sergei, On Tue, Nov 17, 2015 at 02:23:56PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 17, Sergey Vojtovich wrote: > > revision-id: f21705dfbfcd87e46937222eb860727beb21a89b > > (mariadb-10.1.8-66-gf21705d) > > parent(s): c0216f1d02e63686f986fa8f352

Re: [Maria-developers] Please review MDEV-8140 patch

2015-11-10 Thread Sergey Vojtovich
; This patch looks good. Kentoku, will you take care of it and apply to your > > tree? > > Or should we apply it directly to 10.0? > > Please apply it directly to 10.0 this time. > > Thanks, > Kentoku > > > 2015-11-09 19:15 GMT+09:00 Sergey Vojtovich : > &g

Re: [Maria-developers] Please review MDEV-8140 patch

2015-11-09 Thread Sergey Vojtovich
Hi Kentoku, Cheng! This patch looks good. Kentoku, will you take care of it and apply to your tree? Or should we apply it directly to 10.0? Thanks, Sergey On Sun, Nov 08, 2015 at 07:58:41PM +0800, chengxiaoz wrote: > Hi kentoku and Sergey, > > Please review mypatch for MDEV-8140. https://github

Re: [Maria-developers] [Commits] 01bd373: MDEV-8437 - plugin variables conflict with bootstrap

2015-11-05 Thread Sergey Vojtovich
Hi Sergei, On Thu, Nov 05, 2015 at 03:49:08PM +0100, Sergei Golubchik wrote: > > > On Nov 03, Sergey Vojtovich wrote: > > > > revision-id: 01bd373f8f0cf2e1737d01a48033a7615b2a > > > > (mariadb-10.1.8-23-g01bd373) > > > > parent(s): dc40d737d4af3

Re: [Maria-developers] [Commits] 01bd373: MDEV-8437 - plugin variables conflict with bootstrap

2015-11-05 Thread Sergey Vojtovich
Hi Sergei, On Thu, Nov 05, 2015 at 03:30:53PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 03, Sergey Vojtovich wrote: > > revision-id: 01bd373f8f0cf2e1737d01a48033a7615b2a > > (mariadb-10.1.8-23-g01bd373) > > parent(s): dc40d737d4af3cb0e272c58507a

Re: [Maria-developers] [Commits] dc40d73: MDEV-8437 - plugin variables conflict with bootstrap

2015-11-05 Thread Sergey Vojtovich
Hi Sergei, On Thu, Nov 05, 2015 at 03:23:30PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 03, Sergey Vojtovich wrote: > > revision-id: dc40d737d4af3cb0e272c58507ad54e4eb24be28 > > (mariadb-10.1.8-22-gdc40d73) > > parent(s): a574407444fc3ea93ca88afa93d

Re: [Maria-developers] [Commits] 4685c90: mari...@.service.in should be configured for all systemd platforms.

2015-11-04 Thread Sergey Vojtovich
Hi Nirbhay, On Wed, Nov 04, 2015 at 09:52:15PM -0500, Nirbhay Choubey wrote: > Hi Svoj! > > On Wed, Nov 4, 2015 at 1:54 AM, Sergey Vojtovich wrote: > > > Hi Nirbhay, > > > > taking into account that CPackRPM won't be able to install it, > > > I

Re: [Maria-developers] [Commits] 4685c90: mari...@.service.in should be configured for all systemd platforms.

2015-11-03 Thread Sergey Vojtovich
Hi Nirbhay, taking into account that CPackRPM won't be able to install it, what's the purpose of having this configured for all systemd platforms? Regards, Sergey On Tue, Nov 03, 2015 at 05:38:12PM -0500, Nirbhay Choubey wrote: > revision-id: 4685c903bc822596bcf12cbfdb5bcc4460ed0105 > parent(s):

Re: [Maria-developers] [Commits] 0a1b60a: MDEV-8450: PATCH] Wrong macro expansion in Query_cache::send_result_to_client()

2015-09-04 Thread Sergey Vojtovich
Hi Sanja, ok to push, a few minor notes JFYI inline. I found only one real bug, but generally I agree that we should fix these fragile macros. On Tue, Sep 01, 2015 at 11:47:09AM +0200, sa...@mariadb.com wrote: > revision-id: 0a1b60a8aee4bce3235fd5a1d8cb2231b51ff5cc > (mariadb-10.0.21-7-g0a1b60a)

Re: [Maria-developers] 4728581: MDEV-7652 - More explanatory ERROR and WARNING messages when loading plugins

2015-07-29 Thread Sergey Vojtovich
Hi Sergei, thanks for your review. Answers inline. On Tue, Jul 28, 2015 at 07:36:29PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > Looks ok, just a couple of comments about the messages. > If you're agree - please, fix and push. > > On Jul 28, Sergey Vojtovich

Re: [Maria-developers] mariadb 10.1.5 crash

2015-06-19 Thread Sergey Vojtovich
eithout problemns > >It's mariadb 10.1.5 glibc>2.14 > >The serve load was low i was testing only, near to 5 active connections, > >others was connections not running anything just connections waiting > >queries > > > > > >Em quinta-feira, 18 de junho de

Re: [Maria-developers] [Commits] 2e08ec2: MDEV-7956 - handler::rebind_psi() takes 0.07% in OLTP RO

2015-06-18 Thread Sergey Vojtovich
Hi Sergei, On Thu, Jun 18, 2015 at 12:06:30PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 17, s...@mariadb.org wrote: > > revision-id: 2e08ec24623e0b3d3db02333e16658dcfaa0535c > > parent(s): b776f8d3a8afff55d5f8208da7bdfce9aa33eb39 > > committer: Serge

Re: [Maria-developers] [Commits] 3f0b023: MDEV-7952 - clock_gettime() takes 0.24% in OLTP RO

2015-06-18 Thread Sergey Vojtovich
Hi Sergei, On Thu, Jun 18, 2015 at 11:04:15AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 17, s...@mariadb.org wrote: > > revision-id: 3f0b02351a53e0fcaee8554c2c852fb3da8fe7da > > parent(s): 5d03dd20a4abbfd9777b619dfd51a6927323955a > > committer: Serge

Re: [Maria-developers] [Commits] 2e08ec2: MDEV-7956 - handler::rebind_psi() takes 0.07% in OLTP RO

2015-06-18 Thread Sergey Vojtovich
Hi Sergei, On Thu, Jun 18, 2015 at 08:44:46AM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 17, s...@mariadb.org wrote: > > revision-id: 2e08ec24623e0b3d3db02333e16658dcfaa0535c > > parent(s): b776f8d3a8afff55d5f8208da7bdfce9aa33eb39 > > committer: Serge

Re: [Maria-developers] mariadb 10.1.5 crash

2015-06-17 Thread Sergey Vojtovich
Hi Roberto, according to this trace server crashed while evicting an object from table cache (happens when we run out of table_open_cache). Likely because per-share free tables list was broken. The rest is quite moot yet: e.g. it may (or may not) also involve table definition cache eviction. Will

Re: [Maria-developers] 8456b23: MDEV-5309 - RENAME TABLE does not check for existence of the table's engine

2015-06-15 Thread Sergey Vojtovich
Hi Sergei, On Mon, Jun 15, 2015 at 04:01:55PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 15, s...@mariadb.org wrote: > > revision-id: 8456b231e9079be26c77da2a294ea1dac64d9d76 > > parent(s): aad8667f8a4e2a26652494b29ee6c12824865ac8 > > committer: Serge

Re: [Maria-developers] 91259f9: MDEV-7505 - Too large scale in DECIMAL dynamic column getter crashes mysqld

2015-06-04 Thread Sergey Vojtovich
f6b63dd > > committer: Sergey Vojtovich > > branch nick: mariadb > > timestamp: 2015-06-04 16:04:05 +0400 > > message: > > > > MDEV-7505 - Too large scale in DECIMAL dynamic column getter crashes mysqld > > > > Server may crash if sanity checks of C

Re: [Maria-developers] [Commits] 9bb9bde: MDEV-6236 - [PATCH] mysql_tzinfo_to_sql may produce invalid SQL

2015-06-03 Thread Sergey Vojtovich
; > revision-id: 9bb9bde42dbf6f936faadeaa34cde838bf6b63dd > > parent(s): 54977bee6705b9f3ebe2e534245defdb18ac31be > > committer: Sergey Vojtovich > > branch nick: mariadb > > timestamp: 2015-06-03 14:30:09 +0400 > > message: > > > > MDEV-6236 - [PATCH] mysq

Re: [Maria-developers] [Commits] 68b5057: always use my_b_pread() instead of mysql_file_pread()

2015-06-02 Thread Sergey Vojtovich
Hi Sergei, ok to push. Regards, Sergey On Tue, May 26, 2015 at 03:38:11PM +0200, s...@mariadb.org wrote: > revision-id: 68b5057695165b88db38d5090f45ebe3a5149995 > parent(s): ab7640f4d30f5a160d3a1c77efe9d2c459a3bda6 > committer: Sergei Golubchik > branch nick: maria > timestamp: 2015-05-26 15:28:

Re: [Maria-developers] [Commits] ab7640f: my_b_fill, inline my_b_* functions instead of hairy macros

2015-06-02 Thread Sergey Vojtovich
Hi Sergei, ok to push. Should we always prefer "static inline" over macroses? Regards, Sergey On Tue, May 26, 2015 at 03:38:02PM +0200, s...@mariadb.org wrote: > revision-id: ab7640f4d30f5a160d3a1c77efe9d2c459a3bda6 > parent(s): d916a1dc7705ae29a916e7ec91f0c76bceab708c > committer: Sergei Golubc

Re: [Maria-developers] [Commits] 7819ddb: MDEV-8192 - THD::set_command() takes 0.05% in OLTP RO

2015-05-28 Thread Sergey Vojtovich
Hi Sergei, On Thu, May 28, 2015 at 06:06:45PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On May 20, s...@mariadb.org wrote: > > revision-id: 7819ddb99be5dff26c8a2109ba70a54289a950ad > > parent(s): fcb48ee418959ea2c05d528266bb2dcad5bce46b > > committer: Serge

Re: [Maria-developers] MDEV-7950 Item_func::type() takes 0.26% in OLTP RO

2015-05-28 Thread Sergey Vojtovich
Hi Alexander, what if we do something like this: static SEL_TREE *get_mm_tree_XXX(Item *arg1, Item *arg2) { return !arg1->real_item()->type() == Item::FIELD_ITEM || arg1->real_item()->const_item() || arg2->is_expensive() ? 0 : get_full_func_mm_tree(param, this, (Item_f

Re: [Maria-developers] [Commits] 8a595a9: cleanup: LOAD DATA replication support in IO_CACHE

2015-05-28 Thread Sergey Vojtovich
Hi Sergei, ok to push. On Wed, May 27, 2015 at 08:14:59PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On May 27, Sergey Vojtovich wrote: > > On Tue, May 26, 2015 at 03:37:36PM +0200, s...@mariadb.org wrote: > > > revision-id: 8a595a9825de286ad073f6f043db4c0

Re: [Maria-developers] [Commits] 1cd9319: myisam/aria: don't mess with IO_CACHE::file

2015-05-28 Thread Sergey Vojtovich
y On Wed, May 27, 2015 at 10:07:07PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On May 27, Sergey Vojtovich wrote: > > Hi Sergei, > > > > I'm lost now. In Aria you did change very similar code and kept > > init_io_cache(-1) while init_io_cache(in

Re: [Maria-developers] [Commits] 1cd9319: myisam/aria: don't mess with IO_CACHE::file

2015-05-27 Thread Sergey Vojtovich
Hi Sergei, my concern was that we do if (!rep_quick) twice in a very short distance. Anyway, this was just a minor wish. Final decision is up to you. Regards, Sergey On Wed, May 27, 2015 at 09:02:03PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On May 27, Sergey Vojtovich wrot

  1   2   3   >