[Maria-developers] Coverity

2013-12-08 Thread Christian Convey
Hi guys, I'm afraid I won't have the time available that I'd hope to, for analyzing MariaDB with Coverity Prevent. Would anyone like to take over from me the Coverity MariaDB account? Thanks, Christian ___ Mailing list: https://launchpad.net/~maria-dev

Re: [Maria-developers] Determining to which project a patch should be sent.

2013-02-20 Thread Christian Convey
Hi Sergei, Thanks, I'll do that. - Christian On Wed, Feb 20, 2013 at 2:50 AM, Sergei Golubchik wrote: > Hi, Christian! > > On Feb 19, Christian Convey wrote: >> Hi guys, >> >> As I work through the Coverity Scan results of MariaDB's trunk, I find &

Re: [Maria-developers] Determining to which project a patch should be sent.

2013-02-19 Thread Christian Convey
/19/2013 04:59 PM, Christian Convey wrote: >> Hi guys, >> >> As I work through the Coverity Scan results of MariaDB's trunk, I find >> myself having to research what some functions do, and the meanings of >> their parameters and return values. Rather than just re

[Maria-developers] Determining to which project a patch should be sent.

2013-02-19 Thread Christian Convey
Hi guys, As I work through the Coverity Scan results of MariaDB's trunk, I find myself having to research what some functions do, and the meanings of their parameters and return values. Rather than just recording what I learn on a piece of paper, I thought it might be nice to write Doxygen commen

Re: [Maria-developers] Using C++ features in MariaDB

2013-02-19 Thread Christian Convey
Thanks Sergei, I'll keep that in mind. On Tue, Feb 19, 2013 at 12:49 AM, Sergei Golubchik wrote: > Hi, Christian! > > On Feb 18, Christian Convey wrote: >> >> The reason I'm asking is that, while I'm generally cautious about new >> C++ features, there a

Re: [Maria-developers] Using C++ features in MariaDB

2013-02-18 Thread Christian Convey
ss.html ). I'm trying to anticipate whether or not a patch would be rejected if it contained those constructs. - Christian On Mon, Feb 18, 2013 at 4:08 PM, Sergei Golubchik wrote: > Hi, Christian! > > On Feb 18, Christian Convey wrote: >> While we're on the topic, how does M

Re: [Maria-developers] Using C++ features in MariaDB

2013-02-18 Thread Christian Convey
guage feature well enough? On Mon, Feb 18, 2013 at 12:47 PM, Sergei Golubchik wrote: > Hi, Christian! > > On Feb 18, Christian Convey wrote: >> Thanks Sergei. So why is it used in some places, but not in the >> server code? > > STL is pretty much ok starting from 10.0. >

Re: [Maria-developers] Using C++ features in MariaDB

2013-02-18 Thread Christian Convey
Thanks Sergei. So why is it used in some places, but not in the server code? On Mon, Feb 18, 2013 at 3:00 AM, Sergei Golubchik wrote: > Hi, Christian! > > On Feb 17, Christian Convey wrote: >> I just read in Pachev's "MySQL Internals" book that C++ STL and >&

[Maria-developers] Using C++ features in MariaDB

2013-02-17 Thread Christian Convey
I just read in Pachev's "MySQL Internals" book that C++ STL and exceptions aren't allowed in the MySQL code. Are those restrictions also in effect for MariaDB? If so, can anyone explain the reason for them? Thanks, Christian ___ Mailing list: https://

Re: [Maria-developers] No Doxygen?

2013-02-11 Thread Christian Convey
Hi Monty, Thanks. As long as there's something other than a community-wide disinterest in my doing it, I'll keep it on my personal TO DO list. - Christian On Mon, Feb 11, 2013 at 1:30 PM, Michael Widenius wrote: > > Hi! > >>>>>> "Christian" ==

Re: [Maria-developers] No Doxygen?

2013-02-11 Thread Christian Convey
Thanks Sergei. Once I'm done with the Coverity Scan results, maybe I'll look into adding Doxygen. On the other hand, if no one else really wants it, I might not bother. - Christian On Mon, Feb 11, 2013 at 3:57 AM, Sergei Golubchik wrote: > Hi, Christian! > > On Feb 10, Chr

[Maria-developers] No Doxygen?

2013-02-10 Thread Christian Convey
I was kind of surprised to not find anything in MariaDB's build system for using Doxygen to create HTML docs. Have people decided this isn't a worthwhile thing to do? Or has just no one gotten around to it yet? - Christian ___ Mailing list: https://la

Re: [Maria-developers] Coverity scan results

2013-02-07 Thread Christian Convey
No problem. I'm happy to go through the Coverity reports. Hopefully I can at least do some research on Coverity's output by the time you guys are ready to look at it. - C On Thu, Feb 7, 2013 at 2:35 PM, Sergei Golubchik wrote: > Hi, Christian! > > On Feb 07, Chr

Re: [Maria-developers] Coverity scan results

2013-02-07 Thread Christian Convey
Hi Giacomo, > Perhaps you can create a list of those minor issues and in the list we can > take advantage of more developer, I'd like to fix some of them in next days. Sure, no problem. I just added you as a user to that project. You should get an email for completing your registration very soo

Re: [Maria-developers] Coverity scan results

2013-02-07 Thread Christian Convey
Hi Sergei, > I'd suggest you to start looking at the issues and fix those that are > simple, like, those you can fix in a few minutes. They should be in a > majority anyway. > > For example, there were issues where va_end() was forgotten. > Or where memcmp return value was casted to char. > This i

Re: [Maria-developers] Coverity scan results

2013-02-07 Thread Christian Convey
On Feb 07, Christian Convey wrote: >> Hi Sergei >> >> > Usually there's a pattern, and many false positives fall under it. >> > Please create an account for me, and I'll see if we could quickly >> > discard many false positives. >> >> Done. If

Re: [Maria-developers] Coverity scan results

2013-02-07 Thread Christian Convey
Hi Sergei > Usually there's a pattern, and many false positives fall under it. > Please create an account for me, and I'll see if we could quickly > discard many false positives. Done. If you don't receive an email from the Scan project soon, let me know. > > No, I didn't mean that you need to

Re: [Maria-developers] Coverity scan results

2013-02-07 Thread Christian Convey
Hi Sergei, > MySQL was under the Coverity Scan twice (at least twice - that's what > I've personally was involved in). The first report found about 300 > defects, and about 200 of them were false positives, 50 of them were > real, and others were not in the MySQL code. The second has found only >

[Maria-developers] Coverity scan results

2013-02-06 Thread Christian Convey
Hey guys, For those of you who missed it, I volunteered to try gettin MariaDB scanned as part of the Coverity Scan service. I just got the trunk scanned for the first time, and a lot of potential-problem reports came up. I did a spot check on one of them, and the report looks like a true-positiv

Re: [Maria-developers] Coverity scans of MariaDB source

2013-02-04 Thread Christian Convey
Hi Colin, Okay, thanks. I'll get on it. - Christian On Mon, Feb 4, 2013 at 11:00 AM, Colin Charles wrote: > Hi! > > On Mon Feb 04 2013, at 11:58, Christian Convey wrote: >> Coverity has a deal called Coverity Scan, where they offer free static >> analyses of

[Maria-developers] Coverity scans of MariaDB source

2013-02-04 Thread Christian Convey
Coverity has a deal called Coverity Scan, where they offer free static analyses of open-source programs (http://scan.coverity.com/). I've used Coverity Prevent at work, and I was pretty happy with the analyses it performed. Is it an intentional choice that MariaDB isn't making use of Coverity Sca

Re: [Maria-developers] CMake vs. autotools on Linux?

2013-02-03 Thread Christian Convey
page? On Sun, Feb 3, 2013 at 3:42 PM, Kristian Nielsen wrote: > Christian Convey writes: > >> I noticed that MariaDB is built (indirectly) with CMake on Windows, >> and with autotools on Linux. >> >> Why are both systems used? I would have assumed that beca

[Maria-developers] CMake vs. autotools on Linux?

2013-02-03 Thread Christian Convey
Hi guys, I noticed that MariaDB is built (indirectly) with CMake on Windows, and with autotools on Linux. Why are both systems used? I would have assumed that because CMake is pretty good at generating Makefiles on Linux and OS X, there would be little reason to continue using autotools. Thanks