[Maria-developers] Handling size_t -> int conversions

2010-08-18 Thread Bo Thorsen
see patches on this - one big patch, or several smaller patches? Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible. ___ Mailing list: https://launchpad.net/~maria-developers Post

[Maria-developers] Get rid of all 32 bit Visual Studio compiler warnings

2010-08-18 Thread Bo Thorsen
" warnings. C4334 gives a warning if you make a 1u << 10 and store that in a 64 bit variable, because you could have meant 1i64 << 10. Can I push this to 5.1? Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible. =

[Maria-developers] Patch: Separate builddir from src dir with cmake

2010-08-18 Thread Bo Thorsen
: Bo Thorsen Organization: Monty Program AB To: maria-developers@lists.launchpad.net Hi people, Our cmake scripts weren't able to build outside the source dir. This is bad for 3 reasons: - it's supposed to work - cmake recommends building outside the src dir - on Windows, cmake can'

Re: [Maria-developers] Federated vs. FederatedX in Windows

2010-08-16 Thread Bo Thorsen
be correct. Confirmed :( I have added a bug report on this: https://bugs.launchpad.net/maria/+bug/618608 Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible. ___ Mailing list: https

[Maria-developers] Separate builddir from src dir with cmake

2010-07-12 Thread Bo Thorsen
the Oracle as well to minimize the drift between the cmake files? Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible. === modified file 'CMakeLists.txt' --- CMakeLists.txt 2010-07-01 13:50:54 + +++ CMakeLists

[Maria-developers] Get rid of all 32 bit Visual Studio compiler warnings

2010-07-08 Thread Bo Thorsen
.) Any comments on these? My comments on the other parts of the patch, as I wrote in the last mail: Den 07-07-2010 17:45, Bo Thorsen skrev: The attached patch reduces the warnings in a 32 bit build with Visual Studio 2008 to a set in the flex/bison generated code. I'll handle those later.

[Maria-developers] Get rid of most 32 bit Visual Studio compiler warnings

2010-07-07 Thread Bo Thorsen
ssion from this patch, though, and submit a bug report on the innodb code on mysql. I assume there will be something here I should change, but if parts of the patch are ready for pushing, let me know that. Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Featu

Re: [Maria-developers] Compile for 64 bit

2010-07-07 Thread Bo Thorsen
Den 02-07-2010 15:38, Kristian Nielsen skrev: Bo Thorsen writes: The attached patch adds a -64 keyword to the script make_mariadb_win_dist. With this patch, the script produces both 32 bit zip files (without any arguments) and 64 bit zip files (with -64). I also expanded it so it's pos

Re: [Maria-developers] Compile for 64 bit

2010-07-02 Thread Bo Thorsen
Den 02-07-2010 15:38, Kristian Nielsen skrev: Bo Thorsen writes: The attached patch adds a -64 keyword to the script make_mariadb_win_dist. With this patch, the script produces both 32 bit zip files (without any arguments) and 64 bit zip files (with -64). I also expanded it so it's pos

[Maria-developers] Compile for 64 bit

2010-07-02 Thread Bo Thorsen
in64 instead of -win32. Ok to push this to 5.1? Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible. === modified file 'win/make_mariadb_win_dist' --- win/make_mariadb_win_dist 2010-05-26 08:40:01 + +++ win/make_mari

[Maria-developers] Install MariaDB as a Windows service in the installer

2010-06-30 Thread Bo Thorsen
s the diff with the code I have added. Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible. === modified file 'CMakeLists.txt' --- CMakeLists.txt 2010-06-29 09:26:10 + +++ CMakeLists.txt 2010-06-29 10:45:37

Re: [Maria-developers] Install remaining files with CPack+NSIS

2010-06-29 Thread Bo Thorsen
Den 29-06-2010 12:26, Kristian Nielsen skrev: Bo Thorsen writes: This patch installs all the files that were missing from the installer package. Now, the installer has the same set of files as the zip file. Diff'ed against the current 5.1 tree. I looked through the patch. I didn&

[Maria-developers] Install remaining files with CPack+NSIS

2010-06-29 Thread Bo Thorsen
This patch installs all the files that were missing from the installer package. Now, the installer has the same set of files as the zip file. Diff'ed against the current 5.1 tree. Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Bac

[Maria-developers] Patch to add a Windows NSIS based installer

2010-06-25 Thread Bo Thorsen
e solution that doesn't involve patching CMake or some other evil scheme I've been considering. To generate an installer: Run cmake as usual, build in visual studio, and call "cpack" when the build is done. That's about as simple as possible :) Can I check this

[Maria-developers] XtraDB and FederatedX in the Windows zip file

2010-06-24 Thread Bo Thorsen
evant. Because a standard build of the zip file now actually has FederatedX and XtraDB in it. So the Windows code is good to go :-) Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compa

Re: [Maria-developers] Windows installer, NSIS version

2010-06-18 Thread Bo Thorsen
Den 18-06-2010 08:44, Bo Thorsen skrev: and the workaround makes it simple Yes and no. I've been working on this workaround, and it's quite difficult to implement. Plus it means forking the NSIS implementation in CMake to a local version :( It's possible I can do this workarou

Re: [Maria-developers] Windows installer, NSIS version

2010-06-17 Thread Bo Thorsen
Den 18-06-2010 08:05, Colin Charles skrev: Hi! On 17 Jun 2010, at 16:20, Bo Thorsen wrote: There is no support for setting up the database in the installer, or setting up MariaDB as a service. CMake+NSIS is just a dumb file copy system. MySQL works around this by running another executable at

[Maria-developers] Windows installer, WiX version

2010-06-17 Thread Bo Thorsen
eatures in the installer will be a lot simpler with WiX, because the system is designed to be powerful. I would like to hear some discussion about this. Should I start spending the longer time on this, or go with the simple NSIS solution for now? Bo Thorsen. Monty Program AB. -- MariaDB:

[Maria-developers] Windows installer, NSIS version

2010-06-17 Thread Bo Thorsen
ler system. NSIS would be my choice for an installer right now. But because of the limitations, I'd consider this a temporary solution until we have a better one. See my next mail for a better but much more complex system. Comments, please. Bo Thorsen. Monty Program AB. -- Maria

Re: [Maria-developers] Patch to build xtradb and federatedx statically on Windows

2010-06-09 Thread Bo Thorsen
Den 09-06-2010 10:42, Sergei Golubchik skrev: Hi, Bo! On Jun 09, Bo Thorsen wrote: Hi everyone, Recently, we found out that xtradb and federatedx were compiled as plugins on Windows. This is not correct because they are core storage engines and should be linked statically instead. Heh

[Maria-developers] Patch to build xtradb and federatedx statically on Windows

2010-06-09 Thread Bo Thorsen
With this patch, the Windows zip file release build should work correctly and produce a MariaDB with both XtraDB and FederatedX in it. Should I check this into ~maria-captains/maria/5.1, or is there a branch more suitable at the moment? Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replaceme

Re: [Maria-developers] Windows zip file

2010-05-14 Thread Bo Thorsen
Den 14-05-2010 10:01, Henrik Ingo skrev: (Adding maria-developers) On Wednesday 12 May 2010 16:10:36 Bo Thorsen wrote: Den 12-05-2010 15:04, Henrik Ingo skrev: On Wednesday 12 May 2010 13:44:18 Michael Widenius wrote: Hi! "Bo" == Bo Thorsen writes: Bo> Hi Daniel (and d

Re: [Maria-developers] Summary of discussion about MariaDB future and release plans

2010-05-13 Thread Bo Thorsen
Den 12-05-2010 21:04, Michael Widenius skrev: > "Peter" == Peter Zaitsev writes: Peter> Henrik, Peter> 5.2.47 is a lot more clear for me though it relays on the fact MySQL chose Peter> not to release 5.2 themselves Yes. Peter> What are you going to do with 5.5 as it comes out ? Cr

[Maria-developers] Patch to generate perl scripts in the right place

2010-05-12 Thread Bo Thorsen
As discussed with Kristian Nielsen on IRC. Bo. === modified file 'scripts/CMakeLists.txt' --- scripts/CMakeLists.txt 2008-03-11 14:46:07 + +++ scripts/CMakeLists.txt 2010-05-12 12:13:40 + @@ -56,22 +56,22 @@ SET(localstatedir ${prefix}/data) CONFIGURE_FILE(mysql_config

Re: [Maria-developers] Windows installer

2010-05-10 Thread Bo Thorsen
Hi Sergei, Den 10-05-2010 11:24, Sergei Golubchik skrev: You're the windows developer, so it's up to you. Not really. I want to build a good package on Windows. For that, I need input from others. However, it does look like I'm on track for now. If you can make a nicely and professionally

Re: [Maria-developers] Windows installer

2010-05-10 Thread Bo Thorsen
I know you did a lot of work on an installer as well. How did you do it, and how far did you get? It might be that I'd continue with your work instead of this. Bo. On Mon, May 10, 2010 at 12:55, Bo Thorsen mailto:b...@askmonty.org> <mailto:b...@askmont

Re: [Maria-developers] Windows installer

2010-05-10 Thread Bo Thorsen
nstead of this. Bo. On Mon, May 10, 2010 at 12:55, Bo Thorsen mailto:b...@askmonty.org>> wrote: Hi everyone, I have been looking at getting our binary windows distribution back on track. One of the options would be to create the zip file like we did earlier. Anothe

[Maria-developers] Windows installer

2010-05-10 Thread Bo Thorsen
ller yet is to set up MariaDB as a service. I'm going to focus on getting Windows running in KVM for our buildbot system now. And then I'll get back to this later. Cheers, Bo Thorsen. === modified file 'CMakeLists.txt' --- CMakeLists.txt 2010-03-04 08:03:07 + +++

Re: [Maria-developers] Windows test platforms

2010-04-26 Thread Bo Thorsen
Monday 26 April 2010 11:04:50 Sergey Petrunya wrote: > On Mon, Apr 26, 2010 at 07:52:55AM +0200, Bo Thorsen wrote: > > The buildbot system will work in three parts. One will build a set of > > installable packages - for now probably just a zip file. Another will > > install th

Re: [Maria-developers] Windows test platforms

2010-04-26 Thread Bo Thorsen
Monday 26 April 2010 11:25:53 Michael Widenius wrote: > Hi! > > >>>>> "Bo" == Bo Thorsen writes: > > > > Bo> For building the installable packages, I intend to use XP and Visual > Studio Bo> 2008. > > We should look at using Vis

[Maria-developers] Windows test platforms

2010-04-25 Thread Bo Thorsen
f the 64 bit systems. This is four systems that does a very thin span of the incredible amount of systems done by MS. (And people say there are a lot of Linux distributions.) Does this make sense to you? Please let me know what you think. Kind reg

Re: [Maria-developers] Summary of discussion about MariaDB future and release plans

2010-04-20 Thread Bo Thorsen
Den 21-04-2010 00:29, Kristian Nielsen skrev: 2. On a note related to stability, I think we need to carefully avoid the mistakes from the MySQL release model. Basically, we need to have regular releases (6-12 month cycles). This is all-important! Much more important than any single feature, howev

[Maria-developers] Review request: Remove a bunch of Windows warnings

2010-04-20 Thread Bo Thorsen
Hi everyone, This patch removes most of the Windows build warnings on Windows Vista 32 bit with Visual Studio 2005. I have only built with debug info using the configuration in win\configure-mariadb.sh. I added "namespace { char dummy; };" to empty files, because the VC++ linker gives a warn

Re: [Maria-developers] Fix windows compiler errors

2010-04-09 Thread Bo Thorsen
Den 09-04-2010 11:58, Michael Widenius skrev: Hi! "Bo" == Bo Thorsen writes: Bo> Hi all, Bo> When compiling lp:maria on windows, there are a couple of errors. The Bo> attached patch fixes those. Bo> Part of this patch fixes https://bugs.launchpad.net/maria/+bug

Re: [Maria-developers] Removing a bunch of windows compilation warnings

2010-04-09 Thread Bo Thorsen
Den 09-04-2010 12:24, Sergei Golubchik skrev: Hi, Bo! On Apr 09, Bo Thorsen wrote: Hi everyone, I have been working on getting rid of the compiler warnings on Windows. I'm not sure if I have the proper fix for this one, so I separated it from the others. TAILQ_EMPTY(head) is defin

[Maria-developers] Removing a bunch of windows compilation warnings

2010-04-09 Thread Bo Thorsen
Hi everyone, I have been working on getting rid of the compiler warnings on Windows. I'm not sure if I have the proper fix for this one, so I separated it from the others. TAILQ_EMPTY(head) is defined in extra\libevent\event-internal.h as this: #define TAILQ_EMPTY(head)((head)->tqh_f

Re: [Maria-developers] Fix windows compiler errors

2010-04-08 Thread Bo Thorsen
Den 07-04-2010 16:24, Bo Thorsen skrev: Hi all, When compiling lp:maria on windows, there are a couple of errors. The attached patch fixes those. Part of this patch fixes https://bugs.launchpad.net/maria/+bug/550974, and it's done the way Sanja suggested. Can I check this patch

[Maria-developers] Fix windows compiler errors

2010-04-07 Thread Bo Thorsen
Hi all, When compiling lp:maria on windows, there are a couple of errors. The attached patch fixes those. Part of this patch fixes https://bugs.launchpad.net/maria/+bug/550974, and it's done the way Sanja suggested. Bo. === modified file sql/mysqld.cc --- sql/mysqld.cc 2010-04-06 22:4

Re: [Maria-developers] WL enhancements

2010-03-17 Thread Bo Thorsen
anonical would switch to git and keep the rest of launchpad running, that would be fantastic. Kind regards, Bo Thorsen, Monty Program AB. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Uns

Re: [Maria-developers] WL enhancements

2010-03-17 Thread Bo Thorsen
d > show the audit trail of all changes to hours. I like this idea, if it's this simple. It would solve the problem, and, as Henrik says, remember who did it and why. Kind regards, Bo Thorsen, Monty Program AB. ___ Mailing list: https://la

Re: [Maria-developers] WL enhancements

2010-03-04 Thread Bo Thorsen
Thursday 04 March 2010 10:42:09 Oleksandr Byelkin wrote: > Hi! > > 3 марта 2010, в 18:07, Sergei Golubchik написал(а): > [skip] > > > ability to remove hours > >Somebody mentioned that a number of hours could be > >increased by mistake, and there should be a way to decrease > >is bac

Re: [Maria-developers] WL enhancements

2010-03-04 Thread Bo Thorsen
n't assume that people don't make mistakes. Even simple typos are currently impossible to fix unless they happen to be less than the intended hours. Kind regards, Bo Thorsen, Monty Program AB. ___ Mailing list: https://launchpad.net/~mari

Re: [Maria-developers] [Maria-discuss] [All] askmonty.org moving to a new server this Thursday (25 Feb)

2010-02-23 Thread Bo Thorsen
Tuesday 23 February 2010 09:54:53 Oleksandr Byelkin wrote: > Hi! > > 22 февр. 2010, в 21:50, Daniel Bartholomew написал(а): > [skip] > > > askmonty.org is the only domain/website that will be impacted by this > > move, websites on any other domain (such as buildbot.askmonty.org) > > are not part

Re: [Maria-developers] Windows installer, part 2

2009-10-19 Thread Bo Thorsen
Hi, I tried to send this from my askmonty.org address, so it might come twice. Fredag 16 oktober 2009 23:18:23 Sergey Petrunya wrote: > Thanks everyone for input on the input so far! I believe I've collected it > all and put into the WL entry: > http://askmonty.org/worklog/Server-RawIdeaBin/?tid=

Re: [Maria-developers] Rev 2779: Add win/make_mariadb_win_dist which is to be used to make windows in file:///home/psergey/bzr-new/maria-5.1-build1/

2009-10-11 Thread Bo Thorsen
Sergey Petrunya skrev: At file:///home/psergey/bzr-new/maria-5.1-build1/ [...] +win/configure-mariadb.sh + +cmake -G "Visual Studio 9 2008" + +devenv MySQL.sln /build RelWithDebInfo +devenv MySQL.sln /build Debug Just a small note: You need the commercial Visual C++ for this. devenv is not pa

Re: [Maria-developers] Buildbot and compiler warnings

2009-08-12 Thread Bo Thorsen
On Wednesday 12 August 2009 07:26:18 Sergei Golubchik wrote: > [...] > There are certain warnings and classes of warnings that I don't want to > see in the code, right. But there are many others - fixing them only > obfuscates the code, adds ugly hacks (and long comments /* we have to do > it this

Re: [Maria-developers] compile issue and the -lz flag

2009-05-04 Thread Bo Thorsen
On Monday 04 May 2009 17:22:57 Don Kehn wrote: > Yes the the libraries are installed, and I believe that the > --with-zlib-dir=bundled has gotten me on to a difference error, my yum list > shown below. > > [r...@m1330 etc] > yum list|grep libz > libzip.x86_64 0.8-5.fc9

Re: [Maria-developers] compile issue and the -lz flag

2009-05-04 Thread Bo Thorsen
On Monday 04 May 2009 16:57:42 Kristian Nielsen wrote: > Don Kehn writes: > > when compiling on x64 systems (i.e. CentOS & Fedora core 10) and using > > the BUILD/compile-pentium64-max, I'm getting the -lz error "/usr/bin/ld: > > cannot find -lz" and when I simplify the ./comfigure line to a > > -