Hello Sergei,
On 5/4/23 4:20 PM, Alexander Barkov wrote:
eh, not quite. I can define a function with the same name as a native
function in any db. E.g.
create test.replace(a int) returns int
and it'll be callable as test.replace(1)
So ER_FUNCTION_NOT_DEFINED is wrong here.
But
parse mariadb_schema.
Now that we have a customer bug "MDEV-29095 REGEXP_REPLACE ...",
I think it's better not to minimize the patch to MDEV-27744.
This symmetric solution is more reliable for my opinion.
More comments below
On Apr 27, Alexander Barkov wrote:
revision-id: d67c3
Hello Sergei,
Please review a new patch version:
https://github.com/MariaDB/server/commit/8d51c6d234b1730d4ff3b2c1fe7828eeca81998b
Comments go inline:
As we discussed on slack, my plan was not to change the hard-coded
default collations in the collation library.
So in the library it will al
8mb4_general_ci as a default
collation for utf8mb4. And the server default collations will be
handled by this new variable character_set_collations.
I did not mean this variable to be something fringe or temporary.
On Mar 07, Alexander Barkov wrote:
revision-id: 940d028521f (mariadb-10.11.1
Hello Sergei,
On 1/16/23 1:58 AM, Sergei Golubchik wrote:
Hi, Alexander,
On Jan 15, Alexander Barkov wrote:
revision-id: 06ce67c644b (mariadb-10.4.27-41-g06ce67c644b)
parent(s): 6cb84346e1b
author: Alexander Barkov
committer: Alexander Barkov
timestamp: 2023-01-10 18:27:16 +0400
message
e codepage, unless there is an actual
console output.
Thank for the explanation. I still have some questions. Let's
talk on slack.
Best regards,
Wlad
*From: *Alexander Barkov <mailto:b...@mariadb.com>
*Sent: *Friday, 10 December 2021 14:40
*To: *maria-developers <mailto:maria-de
Hi Wlad,
You've done a great piece of work. Thanks and congrats.
I generally like all the changes.
Have a few comments only, please see below.
commit 1411d5f40ceaf2eecabbcf68588743439003f4a2
Author: Vladislav Vaintroub
Date: Fri Nov 19 11:42:46 2021 +0100
Windows : incorrect handlin
Hi Wlad,
You've done a great piece of work. Thanks and congrats.
I generally like all the changes.
Have a few comments only, please see below.
commit 1411d5f40ceaf2eecabbcf68588743439003f4a2
Author: Vladislav Vaintroub
Date: Fri Nov 19 11:42:46 2021 +0100
Windows : incorrect handlin
Hi Sergei,
On 10/26/21 11:54 AM, Sergei Golubchik wrote:
Hi, Alexander!
On Oct 26, Alexander Barkov wrote:
Fix:
- Adding a new class Item_copy_inet6, which implements val_native().
- Fixing Type_handler::create_item_copy() to make Item_copy_inet6
instead of Item_copy_string.
Could there
Hello Sergei,
On 10/25/21 11:03 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Oct 25, Alexander Barkov wrote:
MDEV-26732 Assertion `0' failed in Item::val_native
Also fixes MDEV-24619 Wrong result or Assertion `0' in Item::val_native /
Type_handler_inet6::Item_val_native_with_
Hello Sergei,
On 10/25/21 7:28 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Oct 25, Alexander Barkov wrote:
revision-id: d1ec0231553 (mariadb-10.5.4-550-gd1ec0231553)
parent(s): 8b115503563
author: Alexander Barkov
committer: Alexander Barkov
timestamp: 2021-10-07 20:58:18 +0400
message
Hello Sergei,
Thanks, please find an updated patch version in:
https://github.com/MariaDB/server/commits/bb-10.7-bar-uuid
See comments inline:
On 10/21/21 7:47 PM, Sergei Golubchik wrote:
diff --git a/plugin/type_uuid/mysql-test/type_uuid/type_uuid_memory.result
b/plugin/type_uuid/mysql-te
Hello Sergei,
Thanks for your review.
I've pushed a new patch version to bb-10.7-bar-uuid.
Please see comments inline:
On 10/20/21 2:48 AM, Sergei Golubchik wrote:
2000----0002
+1000----0003
2000----0003
please, ad
On 10/12/21 8:46 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Oct 12, Alexander Barkov wrote:
diff --git a/sql/field.cc b/sql/field.cc
index 46a3a1deea3..fc3456e2ccb 100644
--- a/sql/field.cc
+++ b/sql/field.cc
@@ -7368,7 +7368,9 @@ bool
Field_longstr::cmp_to_string_with_same_collation
Hello Sergei,
Thanks for the review. An updated patch is attached.
See comments below:
On 10/11/21 8:44 PM, Sergei Golubchik wrote:
Hi, Alexander!
See comments below
diff --git a/plugin/type_inet/mysql-test/type_inet/type_inet6_innodb.test
b/plugin/type_inet/mysql-test/type_inet/type_ine
Hello Sergei,
Thanks for the review.
A new patch is here:
https://github.com/MariaDB/server/commit/0629711db43ec489a360d8f689b72fac66a2470b
See also comments below:
On 9/11/21 5:46 PM, Sergei Golubchik wrote:
Hi, Alexander!
please add more benchmark results to the MDEV, all the variants tha
k_start + 1
Other scan_ident_xxx() require m_ptr == m_tok_start
So some additional changes will be needed, and it will be more complex
at the end. I suggest to keep it as is.
Thanks.
On 7/31/20 1:38 AM, Sergei Golubchik wrote:
Hi, Alexander!
On Jul 29, Alexander Barkov wrote:
On Jul 28, Alexa
Hi Sergei,
Thanks for review. Please find comments inline:
On 7/28/20 6:02 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jul 28, Alexander Barkov wrote:
revision-id: ca7e6f8d572 (mariadb-10.3.21-178-gca7e6f8d572)
parent(s): f3f23b5c4bd
author: Alexander Barkov
committer: Alexander Barkov
Hi Sergei,
Thanks for your review. Comments follow:
On 6/7/20 9:59 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 07, Alexander Barkov wrote:
revision-id: 06942363ebc (mariadb-10.5.2-311-g06942363ebc)
parent(s): 0d6d63e1505
author: Alexander Barkov
committer: Alexander Barkov
timestamp
the idea of adding a new List_iterator_fast constructor to
with a cast inside.
Also, please discuss with Georg the exact API of the new library functions.
Thanks!
commit 4da75d8ed70a7814a60b66e985bc42068ff90f50
Author: Alexander Barkov
Date: Tue Feb 25 16:09:42 2020 +0400
MDEV-17832 Protocol:
;,
while mariadb_get_field_info() will return strings
as MARIADB_CSTRING?
Also the function needs to be added to the MARIADB_SYMBOLS in
libmariadb/CMakeLists.txt
Thanks. Will do.
Otherwise it looks ok!
/Georg
On Wed, Feb 26, 2020 at 3:40 PM Alexander Barkov <mailto:b...@mariadb.com>> wrot
d as:
a. chunk type (1 byte)
b. chunk data length (1 byte)
c. chunk data (according to #b)
For now, two chunk types are implemented:
- data type name (used for GEOMETRY sub-types, and for INET6)
- format name (for JSON)
Thanks!
commit 833aefd138d78c036aa4dafc52f62186c8531361
Author: Alexander
Hi Georg,
Can you please review this cleanup patch?
It's a prerequisite for:
MDEV-17832 Protocol: extensions for Pluggable types and JSON, GEOMETRY
The idea is that this patch introduces a new file
libmariadb/mariadb_priv.h and adds prototypes of these functions:
void free_rows(MYSQL_DATA *c
Hi Georg,
Can you please review this cleanup patch?
It's a prerequisite for:
MDEV-17832 Protocol: extensions for Pluggable types and JSON, GEOMETRY
The idea is that this patch introduces a new file
libmariadb/mariadb_priv.h and adds prototypes of these functions:
void free_rows(MYSQL_DATA *c
Hi Sergei,
On 9/17/19 10:59 AM, Alexander Barkov wrote:
Hi Sergei,
Thank you for your review!
I've fixed some of your suggestions.
For other suggestions I have questions and comments. See below.
A new patch is here:
https://github.com/MariaDB/server/c
Hi Igor,
We discussed the problem with error messages with Sergei and both
agreed that a new error message like:
Subquery is not allowed in '%s'
will be more informative, and it's easy to do.
Why not replace:
bool expr_allows_subselect;
to
const char *clause_that_disallows_subselect;
Hi Igor,
I have the following suggestions so far.
Can you please fix them and replace the commit in bb-10.4-igor?
1. In statements where subquery is not allowed, the error message become
confusing:
EXECUTE stmt USING (SELECT 1);
< ERROR 1064 (42000): ... syntax to use near 'SELECT 1)' at
wrote:
Hi, Alexander!
On Sep 16, Alexander Barkov wrote:
revision-id: 3f38da9145c (mariadb-10.4.4-251-g3f38da9145c)
parent(s): e6ff3f9d1c8
author: Alexander Barkov
committer: Alexander Barkov
timestamp: 2019-07-12 07:53:55 +0400
message:
MDEV-20016 Add MariaDB_DATA_TYPE_PLUGIN
diff --git a/in
Hi Sergei,
Thanks for your review. I've addressed your suggestions.
Please find a newer version here:
https://github.com/MariaDB/server/commit/e4415549e5374f6fcb5d317a7078ead610adfa6c
Thanks.
On 8/28/19 4:47 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Aug 28, Alexander Barkov
Hi Sachin,
I've reviewed the code in bb-10.5-19708.
It looks good.
I suggest some cleanups.
- Remove Field::binlog_type_info_slave, it's not used.
- Remove Field::binlog_type_info_master.
Please don't cache Binlog_type_info inside the Field itself.
Let the caller code cache it in an arra
loop should be implemented in sql_yacc_ora.yy,
using Oracle style syntax:
FOR GROUP ROWS
LOOP statements
END LOOP;
instead of SQL/PSM syntax:
FOR GROUP ROWS
DO statements
END FOR;
Thanks.
On 6/20/19 11:30 AM, Alexander Barkov wrote:
Hi Varun,
I was recently assigned as a reviewer for this
Hi Varun,
I was recently assigned as a reviewer for this patch:
http://lists.askmonty.org/pipermail/commits/2017-December/011777.html
I have some suggestions.
1. The MDEV says the proposed syntax is:
FOR GROUP ROWS DO
and you implemented:
FOR GROUP NEXT ROW DO
I think the syntax on MDEV lo
able->file->ha_table_flags() &
HA_EXTENDED_TYPES_CONVERSION) is a bit ugly and could be replaced with
something more descriptive.
I agree. Let's do it in a separate commit as well.
Thanks.
Marko
On Fri, Apr 19, 2019 at 2:24 PM Alexander Barkov wrote:
Hi Marko, Eugene,
Thanks fo
conversion of CHAR columns in InnoDB.
I agree that the (table->file->ha_table_flags() &
HA_EXTENDED_TYPES_CONVERSION) is a bit ugly and could be replaced with
something more descriptive.
Marko
On Fri, Apr 19, 2019 at 2:24 PM Alexander Barkov wrote:
Hi Marko, Eugene,
Thanks for good
Hi Kenneth,
I just closed this issue as "not a bug":
MDEV-13361 Regression: LOAD DATA INFILE utf8 enconding issues
Can you please document that when doing "SELECT INTO OUTFILE" followed
by "LOAD DATA INFILE" for a mixture of text and binary data, one should
use "CHARACTER SET binary" in both sta
.
I will review the code and tests in detail next week. I hope that
Eugene can review it as well.
Best regards,
Marko
commit 11c50465849eac35a490c638bd13678f92438a69
Author: Alexander Barkov
Date: Fri Apr 19 15:18:38 2019 +0400
A joint patch for MDEV-19284 and MDEV-19285 (INSTANT ALTER)
Hi Marko and Eugene,
please review a patch fixing:
- MDEV-19284 INSTANT ALTER with ucs2-to-utf16 conversion produces bad data
- MDEV-19285 INSTANT ALTER from ascii_general_ci to latin1_general_ci
produces currupt data
Thanks!
commit 8ac8df9685bb0ee591602e4ca76a45725fa364de
Author: Alexander
Hi Sergei,
Please review a patch for MDEV-18319
https://github.com/MariaDB/server/commit/8a990ad17746927c6d395ec755a262eda59191fb
Thanks
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsub
Hi Eric,
On 02/24/2019 07:55 PM, Eric Herman wrote:
> Hello Bar,
>
> As you have done the work on store_native and val_native, I would
> especially like to know your thoughts with regards to how to expose
> these to the SQL layer.
>
> In my particular case, I'd like to re-work the "Add FLOAT an
Hi Sanja,
Please review a patch for MDEV-18195.
Thanks.
commit 1afccf570dcf6a0f274aab375380efd26a706cdf
Author: Alexander Barkov
Date: Thu Jan 17 16:37:57 2019 +0400
MDEV-18195 ASAN use-after-poison in my_strcasecmp_utf8 / Item::eq upon prepared statement with ORDER BY NAME_CONST
> Thanks,
> Anel
>
> On Mon, Dec 31, 2018 at 7:02 AM Alexander Barkov <mailto:b...@mariadb.com>> wrote:
>
> Hi Anel,
>
>
>
> On 12/28/2018 02:12 PM, Anel Husakovic wrote:
> > Hi Alexander,
> > my name is Anel, and I'm work
Hi Jan,
I checked changes to the /sql directory so far.
Sorry, I'm completely out of this topic.
So I have only general suggestions.
1. General code structure.
There are a lot of new
#ifdef WITH_WRESP
do_something_with_wresp();
#else
do_something_without_wresp();
#endif
This make the se
e are still numerous
> changes that are only picked up afterwards.
This is a very good idea.
Should developers create related documentation tasks to MDEVs
that need attention from the documentation team?
>
> On 2018/11/26 13:17, Alexander Barkov wrote:
>> Hi Kenneth, all,
>>
Hi Kenneth, all,
I've pushed MDEV-16991.
Can you please document this new feature.
Thanks!
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-develope
ngth_and_dec().
> Since it doesn't seem critical, i'm fine if you leave it as it is :)
Alas, fix_length_and_dec() does not get THD* as an argument.
Only fix_fields() does.
fix_length_and_dec() should also be fixed to get THD*.
Btw, perhaps 10.4 is a good timing for this.
>
&
Hi Alexey,
On 11/25/2018 09:05 AM, Alexander Barkov wrote:
>>
>> What do you think if we do this:
>> - add THD* memver to the MYSQL_TIME_STATUS structure,
>> so we can get rid of the THD * parameter to many functions?
>> - send one MYSQL_TIME_STATUS* to the
Hi Alexey,
On 11/25/2018 03:00 AM, Alexey Botchkov wrote:
> Hi, Alexander.
>
> First question about the sql/sql_basic_types.h.
> To me it looks overcomplicated. Do we really need classes over
> the simple enums?
> I attached my version of this file here. In my opinion it's shorter itself,
> and
copy_event_cache_to_file_and_reinit(head, file);
> + copy_event_cache_to_file_and_reinit(vcom, file);
>copy_event_cache_to_file_and_reinit(body, file);
>
> Sachin, regardless whether you like this elaboration,
> you got to check out bb-10.1-MDEV-10963 or the latest
> patch in t
en, should not we split such BINLOG statement with multiple
base64 chunks into individual BINLOG statements?
Thanks.
On 10/16/2018 04:03 PM, Sachin Setiya wrote:
> Hi Bar!
> On Tue, Oct 16, 2018 at 7:33 AM Alexander Barkov wrote:
>>
>> Hi Sachin,
>>
>>
>> On 10/16/2
Hi Sachin,
On 10/16/2018 03:49 AM, Sachin Setiya wrote:
> Hi Bar!
> On Tue, Sep 11, 2018 at 1:47 PM Alexander Barkov wrote:
>>
>> Hi Sachin,
>>
>>
>> On 09/10/2018 03:47 PM, Sachin Setia wrote:
>>> Hi Bar,
>>>
>>> Currently if we
as char) |
> +-+
> | 1. |
> +-+
So this looks like a problem in CAST, not in LIKE.
>
> Should we change the "like" operator behavior ? (in another patch ?)
Yes, we can fix CAST in another patch.
I reported t
INTERVAL
(this grammar will be gone soon).
Thanks!
>
> Regards.
>
>> -Message d'origine-
>> De : Alexander Barkov [mailto:b...@mariadb.com]
>> Envoyé : jeudi 4 octobre 2018 16:05
>> À : jerome brauge
>> Cc : MariaDB Developers (maria-develope
cedence
I'll have a patch soon, then will return to MDEV-17359.
Greetings.
On 10/04/2018 09:26 AM, Alexander Barkov wrote:
> Jerome,
>
> Can you please wait. I'll do some more analysis on the subject.
>
>
> On 10/04/2018 09:16 AM, Alexander Barkov wrote:
>>
Jerome,
Can you please wait. I'll do some more analysis on the subject.
On 10/04/2018 09:16 AM, Alexander Barkov wrote:
> Hello Jerome,
>
> On 10/03/2018 05:33 PM, jerome brauge wrote:
>> Hello Alexander,
>> Can you review this patch for MDEV-17359 ?
>>
>&g
Hello Jerome,
On 10/03/2018 05:33 PM, jerome brauge wrote:
> Hello Alexander,
> Can you review this patch for MDEV-17359 ?
>
> Best regards.
>
Thanks for you contribution!
I noticed that Oracle also supports concatenation in the ESCAPE clause:
SELECT 'x' FROM DUAL WHERE 'a' LIKE 'b' ESCAPE
Hi Sachin,
On 09/10/2018 03:47 PM, Sachin Setia wrote:
> Hi Bar,
>
> Currently if we have generated the sql file using mysqlbinlog -v and
> if we have big statement binlog
> , then mysqlbinlog add comment in between of Binlog 'XXX' statement ,
> but unfortunately base64_decode
> does not underst
ent I remember or understood everything.
> For the scope of this review, I was satisfied with what I could figure out.
>
> Thanks for your patience in receiving this review.
Thanks!
Both MDEV-15759 and MDEV-15758 are now pushed to 10.4.
> Vicențiu
>
> On Mon, 9 Jul 2018 at 11:0
Hi Vicențiu,
Sending the patch adjusted to the latest 10.4.
Thanks.
On 04/03/2018 12:57 PM, Alexander Barkov wrote:
> Hello Vicentiu,
>
> Please review my patch for MDEV-15758.
>
> It also fixes this bug:
>
> MDEV-15759 Expect "Impossible WHERE
Hi Sergei,
Please review a patch for MDEV-13995.
Thanks!
diff --git a/mysql-test/main/timezone2.result b/mysql-test/main/timezone2.result
index 096e996..7b14990 100644
--- a/mysql-test/main/timezone2.result
+++ b/mysql-test/main/timezone2.result
@@ -332,3 +332,198 @@ NULL
#
# End of 5.3 tests
Hi Ian,
can you please document the FOR loop?
I've created an MDEV for it:
MDEV-16674 Document FOR loop
with links to all relevant tasks.
Thanks!
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchp
Hello Sanja,
Please review a patch for MDEV-16584.
Thanks!
commit 23d4d40f156f1c1300015cfa91603447dff0399e
Author: Alexander Barkov
Date: Tue Jun 26 14:43:45 2018 +0400
MDEV-16584 SP with a cursor inside a loop wastes THD memory aggressively
Problem:
push_cursor
Hi Aleksey,
I found some dead code in sp_head that seem to have appeared
in your patch for "IB: 0.2 part IV".
If you don't mind, I'll remove it.
Please have a look into the attached patch.
Thanks.
diff --git a/sql/sp_head.cc b/sql/sp_head.cc
index 3a9e83d..b0586ed 100644
--- a/sql/sp_head.cc
++
Hi Sergei,
Please review a patch for MDEV-12574.
I suggest we push it into 10.2 (not into 10.3).
Thanks!
diff --git a/mysql-test/r/type_decimal.result b/mysql-test/r/type_decimal.result
index d5232ff..b858d1e 100644
--- a/mysql-test/r/type_decimal.result
+++ b/mysql-test/r/type_decimal.result
here copy_with_sum_func is used
> need to be analysed throughly to make sure.
My task was to do an equivalent code change that does not change the
execution flow.
I can add comments near all calls for copy_with_sum_func(),
and one can study separately if they are really necessary.
>
Hello Sanja,
I recently worked on MDEV-16309 and had hard time to find
which Item classes in the hierarchy:
- have always with_sum_func==true
- have always with_sum_func==false
- have variable with_sum_func
To make it sure, before actually working on MDEV-16309,
I had to create a separate working
Hi Sergei,
On 05/14/2018 05:44 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> Looks ok. A couple minor comments:
Thanks for the review. Please find answers to your comments below:
>
> On May 07, Alexander Barkov wrote:
>
>> commit fa6cf08ad1c01e990cd6a497a0
Hi Sergey,
Please review a patch for MDEV-16134.
Thanks!
diff --git a/mysql-test/main/column_compression.result b/mysql-test/main/column_compression.result
index c521a20..f4eb046 100644
--- a/mysql-test/main/column_compression.result
+++ b/mysql-test/main/column_compression.result
@@ -1403,3 +140
Hi Sergei,
Please review a patch for MDEV-16094.
Thanks!
commit fa6cf08ad1c01e990cd6a497a0403c1bbfe0b27e
Author: Alexander Barkov
Date: Mon May 7 16:59:34 2018 +0400
MDEV-16094 Crash when using AS OF with a stored function
MDEV-16100 FOR SYSTEM_TIME erroneously resolves string user
Hello Igor and Sanja,
In your branch you stopped to use the global function check_simple_select().
It's not used any more.
Please remove it from sql_parse.h and sql_parse.cc.
Thanks.
___
Mailing list: https://launchpad.net/~maria-developers
Post to
Hello,
We have an optional length for integer data types:
TINYINT(N)
SMALLINT(N)
MEDIUMINT(N)
INT(N)
BIGINT(N)
The number given in the parentheses imposes no any limits on the
supported range. So for example BIGINT(1) is still a full-featured
data type that can store and retrieve any 64-bit num
Hi Sanja,
the patch is OK to push. Thanks.
On 04/23/2018 12:37 PM, Oleksandr Byelkin wrote:
> revision-id: a20e1ce85ec56616fa048e9ba39c25c65b098fce
> (mariadb-10.3.6-36-ga20e1ce85ec)
> parent(s): c6ba758d1d41c11466b8f9b61b4546efc95aa689
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
Hello Andrei,
In LOGGER::slow_log_print() there is a piece of this code:
query_utime= (current_utime - thd->start_utime);
lock_utime= (thd->utime_after_lock - thd->start_utime);
my_hrtime_t current_time= { hrtime_from_time(thd->start_time) +
thd->s
Hi Aleksey, Sergei,
On 04/11/2018 01:34 AM, Aleksey Midenkov wrote:
> Hi Alexander!
>
> On Tue, Apr 10, 2018 at 12:15 PM, Alexander Barkov wrote:
>> Hi Aleksey,
>>
>> You added Type_handler_hybrid_field_type::m_vers_trx_id.
>>
>> Is it really needed? It
On 04/16/2018 10:38 AM, Alexander Barkov wrote:
> - Adds a function relink_hack() to properly bind st_select_lex containing
> an IN/EXISTS subselect to thd->lex->builtin_select. This is needed for
> the cases when the statement does not do main_select_push().
> I does
On 04/12/2018 09:11 AM, Alexander Barkov wrote:
>>
>>>
>>> Anyway you can't use anymore:
>>> SELECT c FROM t1 ORDER BY a
>>> UNION
>>> SELECT c FROM t2 ORDER BY b
>>> ORDER BY c.
>>>
>>> You have to put
Hi,
On 04/12/2018 07:59 AM, Alexander Barkov wrote:
> Hi Igor,
>
> Please do "reply all" when replying.
>
> On 04/12/2018 01:28 AM, Igor Babaev wrote:
>> Alexander,
>>
>> If you have the same behaviour you have to use
>>
>> SELECT * FROM t1
gt; (SELECT c FROM t1 ORDER BY a)
> UNION
> (SELECT c FROM t2 ORDER BY b)
> ORDER BY c.
>
> (see the standard).
I like this change.
>
> It means that the ORDER BY clause followed a union relates to the union.
> The same is true for 'FOR UPDATE' because it follows opt
Hi Sanja and Igor,
In 10.3-MDEV-11953 you're adding a number of main_select_push() /
pop_select() around "expr" and other rules that contain "expr".
How do you decide when push/pop is needed.
Why, for example, LIMIT and ORDER clause don't have
their own push/pop. They do create some expressions
Hi Sanja, and Igor,
(resending with Igor on CC)
I noticed a FOR UPDATE behavior change in 10.3-MDEV-11953
In 10.3 I run this script in a client session:
CREATE OR REPLACE TABLE t1 (a INT NOT NULL PRIMARY KEY);
CREATE OR REPLACE TABLE t2 (a INT NOT NULL PRIMARY KEY);
INSERT INTO t1 VALUES (1);
Hi Sanja,
I noticed a FOR UPDATE behavior change in 10.3-MDEV-11953
In 10.3 I run this script in a client session:
CREATE OR REPLACE TABLE t1 (a INT NOT NULL PRIMARY KEY);
CREATE OR REPLACE TABLE t2 (a INT NOT NULL PRIMARY KEY);
INSERT INTO t1 VALUES (1);
INSERT INTO t2 VALUES (2);
BEGIN;
SELEC
Hello Sanja,
On 04/10/2018 03:37 PM, Oleksandr Byelkin wrote:
> Am 10.04.2018 um 10:58 schrieb Alexander Barkov:
>>Hello Sanja,
>>
>>
>> I reviewed your recent changes in "10.3-MDEV-11953"
>> (and the attached additional patch for sql_yacc_ora.yy)
Hi Aleksey,
You added Type_handler_hybrid_field_type::m_vers_trx_id.
Is it really needed? It seems to be always "false".
So this code in aggregate_for_comparison() seems to be a dead code:
if (m_vers_trx_id && (a == STRING_RESULT || b == STRING_RESULT))
m_type_handler= &type_handler_date
Hello Sanja,
I reviewed your recent changes in "10.3-MDEV-11953"
(and the attached additional patch for sql_yacc_ora.yy)
I have some proposals:
1. Can you please move huge pieces of the code from sql_yacc.yy to LEX
or other relevant classes?
It makes the grammar much more readable (patches
Hello Sergei,
On 04/09/2018 01:09 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Apr 09, Alexander Barkov wrote:
>> Hi Sergei,
>>
>> I'm looking at this use rule in sql_yacc.yy:
>>
>> history_point:
>> temporal_literal
>&g
Hi Sergei,
I'm looking at this use rule in sql_yacc.yy:
history_point:
temporal_literal
{
$$= Vers_history_point(VERS_TIMESTAMP, $1);
}
| function_call_keyword_timestamp
{
$$= Vers_history_point(VERS_TIMESTAMP, $1);
Hello Jerome,
On 03/30/2018 06:52 PM, jerome brauge wrote:
> Hello Alexander,
> I've found one another difference between Mariadb and Oracle : oracle always
> rollback the active transaction if an error is raised, Maria leave the
> transaction active.
> Possible workaround in stored procedure:
Hello Vicentiu,
Please review my patch for MDEV-15758.
It also fixes this bug:
MDEV-15759 Expect "Impossible WHERE" for
indexed_int_column=out_of_range_int_constant
Thanks!
diff --git a/mysql-test/main/type_bit.result b/mysql-test/main/type_bit.result
index 30cd94c..c9796c8 100644
--- a/mysql-t
Hello Jerome,
On 03/29/2018 08:05 PM, jerome brauge wrote:
> Hello Alexander,
> Can you open an MDEV for rpad/lpad (return NULL instead of empty string when
> sql_mode=oracle) and review this patch ?
The patch looks fine.
This is a new MDEV:
MDEV-15739 sql_mode=ORACLE: Make LPAD and RPLAD r
Forgot to mention,
To track changes easier, I made a separate MDEV for this:
MDEV-15664 sql_mode=ORACLE: Make TRIM return NULL instead of empty string
Greetings.
On 03/26/2018 04:21 PM, Alexander Barkov wrote:
> Hello Jerome,
>
>
> Thank you for the contribution.
>
>
Hello Jerome,
Thank you for the contribution.
The patch looks fine. I have only some proposals.
1. We don't use bb-10.2-ext any more. Please use 10.3 instead.
2. You mapped "TRIM_ORACLE" to SYM(TRIM).
I guess you wanted to avoid grammar duplication
for "TRIM" and "TRIM_ORACLE".
It's good t
Hello Sanja,
Please review a patch for MDEV-15620.
Thanks!
commit 8306aaec113a061e5e1a576ff9f932f9cac1850a
Author: Alexander Barkov
Date: Fri Mar 23 14:23:48 2018 +0400
MDEV-15620 Crash when using "SET @@NEW.a=expr" inside a trigger
The problem resided in this bra
Hi Sergei,
Thanks for review. Comments follow inline:
On 01/28/2018 07:22 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Nov 03, Alexander Barkov wrote:
Hello Sergei,
Please review a patch for MDEV-13790.
It removes the attempt to search the best suitable buffer
and just returns the result
d thd->mem_root to be always
saved/restored in sync. That is, as an arena.
As agreed on slack, let's return to the first version of the patch.
I only added a helper class Item_change_list_savepoint,
to avoid duplicate code.
Thanks!
On Jan 18, Alexander Barkov wrote:
On 12/27/2017 08:
Hi Sergei,
On 12/27/2017 08:33 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Dec 26, Alexander Barkov wrote:
Hi Sergei,
can you please review a patch for MDEV-14603?
I agree with the fix.
But I don't like that there are many things to backup/restore
(Statement, arena, free_list, an
Hi Sergei,
can you please review a patch for MDEV-14603?
Thanks!
diff --git a/mysql-test/r/ps.result b/mysql-test/r/ps.result
index 6857ebc..a56920d 100644
--- a/mysql-test/r/ps.result
+++ b/mysql-test/r/ps.result
@@ -5074,3 +5074,45 @@ t1 CREATE TABLE `t1` (
) ENGINE=MyISAM DEFAULT CHARSET=lati
Hello Ian,
Can you please document the difference between functions HOUR() and
EXTRACT(HOUR)?
Please see details here:
https://jira.mariadb.org/browse/MDEV-14731
Thanks!
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria
Hi Sergei,
Please review a patch for MDEV-14031.
Thanks!
diff --git a/mysql-test/suite/plugins/r/binlog-simple_plugin_check.result b/mysql-test/suite/plugins/r/binlog-simple_plugin_check.result
new file mode 100644
index 000..0094c37
--- /dev/null
+++ b/mysql-test/suite/plugins/r/binlog-simpl
can add this flag there , to
> MY_MAINTAINER_CXX_WARNINGS.
Thanks! This helps.
I have added the flag to MY_MAINTAINER_CXX_WARNINGS.
https://github.com/MariaDB/server/commit/a61fbf87ed9f6bb68332b81bc1024d1ded944d3d
Greetings.
>
>
>
> Wlad
>
>
>
> *From:
Hello Vlad,
Are we still supposed to use these scripts in the BUILD directory:
compile-pentium64-debug
compile-pentium64-debug-all
compile-pentium64-debug-max
compile-pentium64-gcov
compile-pentium64-gprof
compile-pentium64-max
compile-pentium64-valgrind-max
I stopped using them long time ago.
B
Hi Sergei,
Please review a patch for MDEV-13995.
Thanks!
commit 3eb1d600701b743f7b3238e6393436d6b917ad40
Author: Alexander Barkov
Date: Mon Dec 4 21:41:28 2017 +0400
MDEV-13995 MAX(timestamp) returns a wrong result near DST change
The problem happened because timestamp values
1 - 100 of 634 matches
Mail list logo
