Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

2019-12-18 Thread Aleksey Midenkov
Sergei, On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Dec 18, Aleksey Midenkov wrote: > > Sergei, > > > > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik > wrote: > > > > > Hi, Aleksey! > > > > > > On Dec 18, Aleksey Midenkov wrote: > > > > On Wed, Dec 4, 2019 a

Re: [Maria-developers] [MariaDB/server] Proper locking for mysql.gtid_slave_pos truncation (84b437d)

2019-12-18 Thread Kristian Nielsen
Sergey Vojtovich writes: >> when all slave threads are stopped and nothing else is accessing the >> gtid_pos table. > It is a table, so any client connection can be accessing it any time? Yes. What I meant is that - mysql.gtid_slave_pos is a system table, it is not supposed to be modified from u

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

2019-12-18 Thread Sergei Golubchik
Hi, Aleksey! On Dec 18, Aleksey Midenkov wrote: > Sergei, > > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik wrote: > > > Hi, Aleksey! > > > > On Dec 18, Aleksey Midenkov wrote: > > > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > > > > > > But it's better to be from the other side

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

2019-12-18 Thread Aleksey Midenkov
Sergei, On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Dec 18, Aleksey Midenkov wrote: > > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > > > > But it's better to be from the other side: > > > > bool Lex_cstring::strdup(MEM_ROOT *mem_root, const Lex_cstr

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

2019-12-18 Thread Sergei Golubchik
Hi, Aleksey! On Dec 18, Aleksey Midenkov wrote: > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > > But it's better to be from the other side: > > bool Lex_cstring::strdup(MEM_ROOT *mem_root, const Lex_cstring &src) > { > // allocate and deep-copy from src to this > } > > I'd really

Re: [Maria-developers] [MariaDB/server] Proper locking for mysql.gtid_slave_pos truncation (84b437d)

2019-12-18 Thread Sergey Vojtovich
Kristian, Thanks for your prompt reply! On Wed, Dec 18, 2019 at 08:38:31AM +0100, Kristian Nielsen wrote: > Sergey Vojtovich writes: > > > ATTN @dr-m, @andrelkin, @SachinSetiya, @knielsen > > So IIUC, this is about incorrect usage of ha_truncate() in > rpl_slave_state::truncate_state_table().