Re: [Maria-developers] 9145b7d: MDEV-11153 - Introduce status variables for table cache monitoring and tuning

2017-10-26 Thread Sergey Vojtovich
Hi Sergei, The only reason is there were minor requests to make it tunable. It is easier to convert read-only var to command line option. If we know for sure that we won't do it, I can make it status var instead. Thanks, Sergey On Thu, Oct 26, 2017 at 07:15:42PM +0200, Sergei Golubchik wrote: >

Re: [Maria-developers] 9145b7d: MDEV-11153 - Introduce status variables for table cache monitoring and tuning

2017-10-26 Thread Sergei Golubchik
Hi, Sergey! Looks ok, thanks. Just one question: On Aug 10, Sergey Vojtovich wrote: > revision-id: 9145b7dd11a0e95016304e53acf306daac323580 > (mariadb-10.3.0-49-g9145b7d) > parent(s): 63ad4fe5bbe77fe17ab441fcce0106bdee9b618d > committer: Sergey Vojtovich > timestamp: 2017-08-10 15:45:03 +0400 >

Re: [Maria-developers] MDEV-13997 Change Item_bool_rowready_func2 to cache const items at fix time rather than evaluation time

2017-10-26 Thread Sergei Golubchik
Hi, Alexander! On Oct 04, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-13997. > > It's needed for: > MDEV-13995 MAX(timestamp) returns a wrong result near DST change > and for: > MDEV-4912 Add a plugin to field types (column types) > > Thanks! See some questions b