[Maria-developers] Add hidden level 2/3 (PSEDUO_HIDDEN_COLUMN / COMPLETELY_HIDDEN_COLUMN) to mariadb

2017-06-16 Thread Sachin Setiya
Hello Everyone! Currently I am implementing 10177. But I have one doubt I am not sure how to implement a function which will create hidden level 2/3 field for server. Suppose we create a function (say add_hidden_field(.)) which will add the field to table T. But the issue is where should we

Re: [Maria-developers] MDEV-12620 - set lock_wait_timeout = 1; flush tables with read lock;

2017-06-16 Thread Sergey Vojtovich
Hi Sergei, On Fri, Jun 16, 2017 at 02:28:55PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Jun 16, Sergey Vojtovich wrote: > > revision-id: 056bab0880544d91ea67d18fe8db65b4f6625482 > > (mariadb-10.1.24-22-g056bab0) > > parent(s): 58f87a41bd8de7370cc05c41977fadc685826c9e > > committer: Ser

Re: [Maria-developers] MDEV-12620 - set lock_wait_timeout = 1; flush tables with read lock;

2017-06-16 Thread Sergei Golubchik
Hi, Sergey! On Jun 16, Sergey Vojtovich wrote: > revision-id: 056bab0880544d91ea67d18fe8db65b4f6625482 > (mariadb-10.1.24-22-g056bab0) > parent(s): 58f87a41bd8de7370cc05c41977fadc685826c9e > committer: Sergey Vojtovich > timestamp: 2017-06-16 15:47:46 +0400 > message: > > MDEV-12620 - set lock_w

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-06-16 Thread Sergei Golubchik
Hi, Alexander! On Jun 16, Alexander Barkov wrote: > > Agreed. This version fixes around 16 classes that had the same problem, > and which only needed to swap "str" and "tmp_value" in their val_str() > implementations. > > As agreed on slack, the following three classes: > - Item_str_conv > - Ite

Re: [Maria-developers] [Commits] 01b2bb79bb78e42108e32af02f1418a660ca861d Fixed the bug mdev-13064.

2017-06-16 Thread Oleksandr Byelkin
Hi, Igor! Am 15.06.2017 um 23:43 schrieb Igor Babaev: commit 01b2bb79bb78e42108e32af02f1418a660ca861d Author: Igor Babaev Commit: Igor Babaev Fixed the bug mdev-13064. This is another attempt to fix the bug mdev-12992. This patch introduces st_select_lex::context_analysi

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-06-16 Thread Alexander Barkov
Hello Sergei, Thanks for your review. Here's a new version of the patch. Please see comments below: On 03/06/2017 10:50 AM, Sergei Golubchik wrote: > Hi, Alexander! > > On Mar 06, Alexander Barkov wrote: @@ -3378,16 +3379,16 @@ String *Item_func_conv_charset::val_str(String *str)