Re: [Maria-developers] Please review MDEV-10386 Assertion `fixed == 1' failed in virtual String* Item_func_conv_charset::val_str(String*)

2016-12-20 Thread Alexander Barkov
Hello Sergei, On 12/21/2016 12:48 AM, Sergei Golubchik wrote: > Hi, Alexander! > > On Dec 19, Alexander Barkov wrote: >> Hello Sergei, >> >> Please review a patch for MDEV-10386. >> >> Thanks! > >> diff --git a/sql/item.cc b/sql/item.cc >> index 53666aa..44bd620 100644 >> --- a/sql/item.cc >> +

Re: [Maria-developers] Please review MDEV-10386 Assertion `fixed == 1' failed in virtual String* Item_func_conv_charset::val_str(String*)

2016-12-20 Thread Sergei Golubchik
Hi, Alexander! On Dec 19, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-10386. > > Thanks! > diff --git a/sql/item.cc b/sql/item.cc > index 53666aa..44bd620 100644 > --- a/sql/item.cc > +++ b/sql/item.cc > @@ -1164,7 +1164,9 @@ Item *Item_cache::safe_charset_convert

Re: [Maria-developers] 0310b44: MDEV-10418 Assertion `m_extra_cache' failed in ha_partition::late_extra_cache(uint)

2016-12-20 Thread Sergei Golubchik
Hi, Alexey! On Dec 20, Alexey Botchkov wrote: > revision-id: 0310b444dba1b9cbd6921963dd3bff689ca23a24 > (mariadb-5.5.53-34-g0310b44) > parent(s): f23b41b9b8a30e0e54a1ec7a8923057b0e57e0f5 > committer: Alexey Botchkov > timestamp: 2016-12-20 00:24:20 +0400 > message: > > MDEV-10418 Assertion `m_ex

[Maria-developers] mysql_secure_installation documentation

2016-12-20 Thread Michal Schorm
Hello all, I took care about bug against "mysql_secure_installation" script. [1] The problem is pretty simple. When you use "mysql_secure_installation" script, it will ingore all of yours current configuration. However, there are some options, that can be used. One of them is used to add your c

[Maria-developers] Please review MDEV-11615 Split Item_hybrid_func::fix_attributes into virtual methods in Type_handler

2016-12-20 Thread Alexander Barkov
Hello Sanja, Please review a patch for MDEV-11615. Thanks! commit 0fc326434740e8beb411ef5c71ee615581b91c77 Author: Alexander Barkov Date: Tue Dec 20 18:19:47 2016 +0400 MDEV-11615 Split Item_hybrid_func::fix_attributes into virtual methods in Type_handler diff --git a/sql/item_cmpfunc.cc

Re: [Maria-developers] MDEV-10142 - bb-10.2-compatibility

2016-12-20 Thread Alexander Barkov
On 12/20/2016 02:25 PM, Vladislav Vaintroub wrote: > > > On 12/20/2016 3:40 AM, Alexander Barkov wrote: >> Hello Jerome, >> >> On 12/19/2016 05:16 PM, jerome brauge wrote: >>> Hello, >>> To build this branch on windows (Visual Studio Express 2015), I have to add >>> "#pragma warning( disable :

Re: [Maria-developers] MDEV-10142 - bb-10.2-compatibility

2016-12-20 Thread Vladislav Vaintroub
On 12/20/2016 3:40 AM, Alexander Barkov wrote: Hello Jerome, On 12/19/2016 05:16 PM, jerome brauge wrote: Hello, To build this branch on windows (Visual Studio Express 2015), I have to add "#pragma warning( disable : 4099 )" in sql_lex.h. But I don't know if it's the right solution. What ha

Re: [Maria-developers] MDEV-10142 - bb-10.2-compatibility

2016-12-20 Thread jerome brauge
Hello Alexander, Thank for these news. 1) without pragma, lots of sql_lex.h(732): error C4099: 'LEX': type name first seen using 'struct' now seen using 'class' 2) Transform select : I' m new on Mariadb, but doing this kind of transformation on other sgbd that I know (oracle, sqlserver, Sybase