Re: [Maria-developers] Sachin weekly report

2016-08-24 Thread Sergei Golubchik
Hi, Sachin! On Aug 23, Sachin Setia wrote: > > > > Looks simpler, agree. The length of the keypart should not matter, > > because it should never be used. May be it would be good to set it to -1 > > as it might help to catch errors (where it is erroneously used). > > I think it should , because w

Re: [Maria-developers] [Maria-discuss] Known limitation with TokuDB in Read Free Replication & parallel replication ?

2016-08-24 Thread Kristian Nielsen
Rich Prohaska writes: > On Tue, Aug 23, 2016 at 1:45 PM, Kristian Nielsen > wrote: >> In the original parallel replication patch, thd_report_wait_for() did not >> call back directly into tokudb_kill_query(). The kill happened >> asynchronously, in a separate background thread. Then there is no

[Maria-developers] Commit emails reply-to maria-developers@lists.launchpad.net

2016-08-24 Thread Sergey Vojtovich
Hi! Why do commit emails have "Reply-To: maria-developers@lists.launchpad.net"? I believe it is wrong at least for the following reasons: - I must be careful if I want to reply privately, e.g. something like "hold on, I'll review it in a few hours" doesn't deserve to hit maria-developers@ - I w

Re: [Maria-developers] [Commits] 294961c: MDEV-10538: MariaDB fails to start without galera_recovery in systemd mode

2016-08-24 Thread Sergey Vojtovich
Hi Nirbhay, Ok to push. I suggest that we avoid such overcomplicated constructs in our default systemd configuration. Consider integrating recovery into the server (I know it's not trivial) or creating "included" config for galera. Thanks, Sergey On Mon, Aug 22, 2016 at 06:38:07PM -0400, Nirbhay

Re: [Maria-developers] Please review MDEV-10604 Disable unstable MTR tests by default

2016-08-24 Thread Sergey Vojtovich
Hi Elene, In another thread you mentioned that there's alternative solution used by Otto to maintain this list. I'm generally fine with either solution. This patch as such looks Ok. How do we qualify tests unstable? Failed since the beginning of the year, modified in last version, failed in Debi