Re: [Maria-developers] e252dae: MDEV-9872 - Add common optimized CRC32 function interface

2016-08-02 Thread Sergey Vojtovich
Hi Sergei, On Tue, Aug 02, 2016 at 07:22:14PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > So, what did you do here? Did you change InnoDB's version of crc32 or > just moved it to extra/ ? Just moved it to extra, no changes to crc32-vpmsum code. Also let server use it on PPC64LE. > > You re

Re: [Maria-developers] f89d1f5: MDEV-10421 duplicate CHECK CONSTRAINTs.

2016-08-02 Thread Sergei Golubchik
Hi, Alexey! Thanks! See below On Jul 31, Alexey Botchkov wrote: > revision-id: f89d1f55576136fb229392cb9a2997b9c0131241 > (mariadb-10.2.1-9-gf89d1f5) > parent(s): 08683a726773f8cdf16a4a3dfb3920e5f7842481 > committer: Alexey Botchkov > timestamp: 2016-07-31 14:04:52 +0400 > message: > > MDEV-104

Re: [Maria-developers] e252dae: MDEV-9872 - Add common optimized CRC32 function interface

2016-08-02 Thread Sergei Golubchik
Hi, Sergey! So, what did you do here? Did you change InnoDB's version of crc32 or just moved it to extra/ ? You removed mysys/my_crc32.c - where will crc32 come from on x86? Why did you name new function crc32_vpmsum instead of just naming it crc32 and avoding #ifdef's elsewhere? On Jul 05, Ser

Re: [Maria-developers] 48d1ba6: MDEV-10296 - Multi-instance table cache

2016-08-02 Thread Sergei Golubchik
Hi, Sergey! Ok, see comments below. But why is this supposed to improve scalability? Are you talking about the use case of one table being access by multiple threads? Or this helps in other cases too? And what is the effect of the more expensive tc_remove_all_unused_tables() ? On Jun 29, Sergey

Re: [Maria-developers] [Commits] 5486f34: MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func

2016-08-02 Thread Vicențiu Ciorbaru
Hi Sergey, Thanks for the review. I would push the fix into 5.5 if there are no buildbot failures. There seems to be something wrong with solaris though. Need to #ifdef the __sync_synchronize() there. The patch generally applies to 5.5 as well. Since we're having a 5.5 week next, I'll test it for

Re: [Maria-developers] [Commits] 5486f34: MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func

2016-08-02 Thread Sergey Vojtovich
Hi Vicentiu, Ok to push. This patch is against 10.2, do you plan to fix previous versions separately? On Mon, Aug 01, 2016 at 02:46:03PM +0300, vicentiu wrote: > revision-id: 5486f3458859fa4bd161150b9ac0e9c0f633a0e3 > (mariadb-10.2.1-9-g5486f34) > parent(s): 08683a726773f8cdf16a4a3dfb3920e5f7842

Re: [Maria-developers] Sachin weekly report

2016-08-02 Thread Sergei Golubchik
Hi, Sachin! On Aug 02, Sachin Setia wrote: > Hello Sergei! > > Sir I am stuck at one problem. > Consider the case > create table t1 (abc blob unique, xyz int unique); > /* Insert data */ > update t1 set abc = 33 where xyz =23; > This is not working because xyz = 23 will require index scan and at