Re: [Maria-developers] [Commits] 475cab8: MDEV-10050: Crash in subselect

2016-06-23 Thread Sergey Petrunia
Hi Sanja, On Wed, Jun 22, 2016 at 02:17:06PM +0200, Oleksandr Byelkin wrote: > revision-id: 475cab835fb48c91d5cca649ab93917ec1718d75 > (mariadb-5.5.50-6-g475cab8) > parent(s): a482e76e65a4fee70479e877929381c86b1ec62f > committer: Oleksandr Byelkin > timestamp: 2016-06-22 14:17:06 +0200 > message:

Re: [Maria-developers] [Commits] d1de640: MDEV-10216: Assertion `strcmp(share->unique_file_name, filename) ||

2016-06-23 Thread Sergey Vojtovich
Hi Nirbhay, This solution looks better than MyISAM/Aria based one. Still a few doubts inline. I still suggest someone should do second review. On Tue, Jun 21, 2016 at 01:47:15PM -0400, Nirbhay Choubey wrote: > revision-id: d1de6402c8734e9a1929c2384c0cfc07c2ec48c0 > (mariadb-10.2.0-83-gd1de640)

Re: [Maria-developers] [MariaDB/server] MDEV-10271: Log stop of slave SQL thread on errors, too (#188)

2016-06-23 Thread Kristian Nielsen
Hartmut Holzgraefe writes: > there is an according internal escalation request to engineering > @mariadb.com ... as this is a customer request a launchpad list > is not really the right point to discuss this at this point ... Well, since you are asking to get changes in stable 10.0 and 10.1 rele

Re: [Maria-developers] [MariaDB/server] MDEV-10271: Log stop of slave SQL thread on errors, too (#188)

2016-06-23 Thread Kristian Nielsen
Hartmut Holzgraefe writes: > -- Commit Summary -- > > * MDEV-10271: Log stop of slave SQL thread on errors, too > * MDEV-10272: add master host/port info to slave thread exit messages So one comment. With the first patch, there are two cases where the error message "Slave SQL thread exit

Re: [Maria-developers] MDEV-9423: FTWRL and Binlog checkpoint

2016-06-23 Thread Kristian Nielsen
Nirbhay Choubey writes: > While copying the last 2 binlog files would have solved this, I have worked > out > a solution where the donor node waits for binlog checkpoint event for last > binlog > file to get logged before proceeding with file transfer. > > http://lists.askmonty.org/pipermail/comm