Re: [Maria-developers] 1e883e9: MDEV-5535: Cannot reopen temporary table

2016-05-17 Thread Sergei Golubchik
Hi, Nirbhay! On May 16, Nirbhay Choubey wrote: > Hi Serg, > > On Wed, Mar 30, 2016 at 7:12 AM, Sergei Golubchik wrote: > > > Hi, Nirbhay! > > > > Here's a review of MDEV-5535. > > Sorry, it took a while - this was a big patch. > > > > The approach is fine, my comments are mostly about details.

[Maria-developers] Effect of gcc optimization levels

2016-05-17 Thread Sergey Vojtovich
Hi Wlad, Last week I promised to benchmark effect of various gcc optimization levels. Here're results: -O0 418TPS -Os 663TPS -O1 759TPS -O2 807TPS -O3 812TPS -O3 -unroll2 -ip 812TPS (default) -Ofast 819TPS Benchmark was done on a Sandy Bridge system running Ubuntu 12.10. Single thread OLTP RO, p

Re: [Maria-developers] Please review MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring

2016-05-17 Thread Alexander Barkov
Hi Sergei, Thanks for review. On 05/09/2016 10:30 PM, Sergei Golubchik wrote: Hi, Alexander! TL;DR: looks fine. Few minor comments, see below. On Apr 08, Alexander Barkov wrote: diff --git a/include/m_ctype.h b/include/m_ctype.h index c892d576..bb633f8 100644 --- a/include/m_ctype.h +++ b/