Re: [Maria-developers] Introduction - GSOF16

2016-03-19 Thread Sergei Golubchik
Hi, Chandu! On Mar 16, Chandu Maddila wrote: > Hi Team, > > I'm Chandra Sekhar Maddila from India and currently masters student of > BITS-Pilani. > > I'm pretty interested in working with MariaDB team as part of GSOF. Some of > the items that I'm interested in are MXS-1, MDEV-8100, MDEV-5662, MD

Re: [Maria-developers] Please review MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool)

2016-03-19 Thread Alexander Barkov
Hi Sergei, It appeared to be very easy to fix all hybrid functions to use the same attribute aggregation code, and therefore get rid of duplicate implementations for Item_func_case_abbreviation2 and Item_func_case. This patch fixes: - The original problem reported in MDEV-9653 - An additional

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-19 Thread Shubham Barai
Hi Sergei, Sorry! I made a mistake. Actually, when I changed my storage engine to MyISAM and executed create table statement(with unique blobs and no prefix length),mysqld crashed. After reconnecting to the server, the storage engine got changed to default (InnoDB).I didn't know about t

Re: [Maria-developers] NO PAD Collation for MariaDB

2016-03-19 Thread Melissa Rose
Thanks for the kind response Alexander Barkov: I have already build the Server from source and I am looking at some character sets in string/*.c files and how they are implemented. I have also written and submitted a draft proposal on the summerofcode website. Please I would appreciate if anyon

Re: [Maria-developers] 72b709a: MDEV-9701: CREATE VIEW with GROUP BY or ORDER BY and constant produces invalid definition

2016-03-19 Thread Sergei Golubchik
Hi, Oleksandr! On Mar 16, Oleksandr Byelkin wrote: > > On Mar 16, OleksandrByelkin wrote: > >> revision-id: 72b709ac7503ae6dd2b5e9049322fefb90b0ebbe > >> (mariadb-10.1.12-16-g72b709a) > >> parent(s): 9b53d84d14a9b031d193f6beae382a232aa738e3 > >> committer: Oleksandr Byelkin > >> timestamp: 2016-0

Re: [Maria-developers] [Maria-discuss] Collations, trailing spaces and unique indexes

2016-03-19 Thread Binarus
Alexander, I'd like to continue our conversation from Maria-discuss. >> - I have found my_strnxfrm_unicode in the same file and will need more time >> to make my opinion of how difficult it will be >> (I don't know what a weight is, so I currently try to understand what the >> function does at

Re: [Maria-developers] Please review MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool)

2016-03-19 Thread Sergei Golubchik
Hi, Alexander! Looks very good! Just one comment - instead of a special treatment for MYSQL_TYPE_NULL, I would try to set decimal=0 in Item_null. It already sets max_length=0, and I cannot think of any reason why we might want decimal to be 31 for it. On Mar 17, Alexander Barkov wrote: > Hi Serg

Re: [Maria-developers] Please review MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool)

2016-03-19 Thread Sergei Golubchik
Hi, Alexander! On Mar 17, Alexander Barkov wrote: > > > > why is it NOT_FIXED_DEC? it seems to me that it has to be 0 here. > > Perhaps my example in the comments made you think that > it happens in a very special case with CAST AS UNSIGNED. > It also happens in simpler cases: > > SELECT CASE W

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-19 Thread Sergei Golubchik
Hi, Shubham! On Mar 16, Shubham Barai wrote: > Hello, Sergie! > I tried to explore the source code from > mi_create.c,ha_myisam.cc,sql/sql_table.cc,include/myisam.h,.and some other > files. > The main task is to create MI_UNIQUEDEF "uniques" for long unique > constraints. > We have to consider

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-19 Thread Sergei Golubchik
Hi, Sachin! On Mar 16, Sachin Setia wrote: > Thanks sir for your reply > I have done two thing > 1. First commenting some code to remove the error we get when we try to > create unique blob > file=sql/sql_table.cc > line no=3877 It'd be easier to read, if you'd sent a patch instead. > /* > * Gso

Re: [Maria-developers] b1a1e5b: MDEV-6058 MySQL Bug #11766693: LOG-SLOW-ADMIN-STATEMENTS AND LOG-SLOW-SLAVE-STATEMENTS NOT DISPLAYED.

2016-03-19 Thread Sergei Golubchik
Hi, Alexey! On Mar 18, Alexey Botchkov wrote: > revision-id: b1a1e5b3d3d5ab95c596580de07daf38a3efa039 > (mariadb-10.1.12-19-gb1a1e5b) > parent(s): 4aac51db9a55a11574cbfa60484d4329d35b6f2c > committer: Alexey Botchkov > timestamp: 2016-03-18 11:47:05 +0400 > message: > > MDEV-6058 MySQL Bug #1176

Re: [Maria-developers] bf2eaa7: MDEV-9382: After updating mariadb server apt-configure fails

2016-03-19 Thread Jean Weisbuch
I forgot to create the PR for upstream as i did for Otto's repo : https://github.com/ottok/mariadb-10.0/pull/26 and https://github.com/ottok/mariadb-10.0/pull/27 These changes are already in Debian testing packages, should i create the PR or you will handle it on your side? Le 16/03/2016 20:02

Re: [Maria-developers] Please review MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool)

2016-03-19 Thread Alexander Barkov
Hi Sergei, On 03/17/2016 01:16 AM, Sergei Golubchik wrote: > Hi, Alexander! > > On Mar 16, Alexander Barkov wrote: >> Hello Sergei, >> >> Please review a patch for: >> >> MDEV-9653 Assertion `length || !scale' failed in uint >> my_decimal_length_to_precision(uint, uint, bool) >> >> Thanks! > >>

[Maria-developers] [GSoC 2016] NO PAD Collations

2016-03-19 Thread Даниил Медведев
Hi, I am Daniil Medvedev from Lomonosov Moscow State University, a 3rd year student, pursuing my bachelor’s degree in Computer Science. I was interested in project idea NO PAD Collations, and I wish to contribute to MariaDB using my skills and ideas. Technologies that i know: C/C++, git, linux, sh

Re: [Maria-developers] bf2eaa7: MDEV-9382: After updating mariadb server apt-configure fails

2016-03-19 Thread Nirbhay Choubey
Hi Serg, On Wed, Mar 16, 2016 at 3:02 PM, Sergei Golubchik wrote: .. cut.. > diff --git a/debian/mariadb-server-10.1.mysql.init > b/debian/mariadb-server-10.1.mysql.init > > index 9e098b4..005d0e8 100644 > > --- a/debian/mariadb-server-10.1.mysql.init > > +++ b/debian/mariadb-server-10.1.mysql.i

Re: [Maria-developers] 72b709a: MDEV-9701: CREATE VIEW with GROUP BY or ORDER BY and constant produces invalid definition

2016-03-19 Thread Oleksandr Byelkin
On 17.03.2016 10:21, Sergei Golubchik wrote: Hi, Oleksandr! On Mar 16, Oleksandr Byelkin wrote: On Mar 16, OleksandrByelkin wrote: revision-id: 72b709ac7503ae6dd2b5e9049322fefb90b0ebbe (mariadb-10.1.12-16-g72b709a) parent(s): 9b53d84d14a9b031d193f6beae382a232aa738e3 committer: Oleksandr Byelk

Re: [Maria-developers] bf2eaa7: MDEV-9382: After updating mariadb server apt-configure fails

2016-03-19 Thread Sergei Golubchik
Hi, Nirbhay! On Mar 02, Nirbhay Choubey wrote: > revision-id: bf2eaa7c1548f07ce5de13a406ff9183f082b8b3 > (mariadb-10.1.12-4-gbf2eaa7) > parent(s): fd741c1a12e78035dcef9a5684b530fe09cbfdde > author: Nirbhay Choubey > committer: Nirbhay Choubey > timestamp: 2016-03-02 09:41:03 -0500 > message: > >

Re: [Maria-developers] failing tests

2016-03-19 Thread Elena Stepanova
Hi Alexander, It's https://jira.mariadb.org/browse/MDEV-9739 Regards, Elena On 18.03.2016 15:46, Alexander Barkov wrote: Hello Olivier, a few tests are failing in the main 10.1 tree on Linux: connect.xml connect.xml_grant connect.xml_html connect.xml_mdev5261 connect.xml_mult Can you please

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-19 Thread Sergei Golubchik
Hi, Sachin! On Mar 18, Sachin Setia wrote: > > ERROR 1030 (HY000): Got error 190 "Incompatible key or row definition > between the MariaDB .frm file and the information in the storage engine. > You have to dump an" from storage engine MyISAM > > We are getting this becuase in mi_create for each

Re: [Maria-developers] MDEV-9369 IN operator with ( num, NULL ) gives inconsistent result

2016-03-19 Thread Sergei Golubchik
Hi, Alexander! On Feb 08, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-9369. > > Briefly, it fixes cmp_item::cmp() to return three possible values: > FALSE, TRUE, UNKNOWN. These values are then recursively pulled to > the very top level, to the owner Item_xxx. > >

[Maria-developers] failing tests

2016-03-19 Thread Alexander Barkov
Hello Olivier, a few tests are failing in the main 10.1 tree on Linux: connect.xml connect.xml_grant connect.xml_html connect.xml_mdev5261 connect.xml_mult Can you please have a look? Thanks! ___ Mailing list: https://launchpad.net/~maria-developers

Re: [Maria-developers] Please review MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool)

2016-03-19 Thread Alexander Barkov
Hi Sergei, On 03/17/2016 01:14 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Mar 17, Alexander Barkov wrote: >>> >>> why is it NOT_FIXED_DEC? it seems to me that it has to be 0 here. >> >> Perhaps my example in the comments made you think that >> it happens in a very special case with CAST

Re: [Maria-developers] GSoC 2016 CONC-125

2016-03-19 Thread Christian Massey
Hi Oleksandr, MariaDB Mentors, I have submitted a draft proposal for this project on the summer of code website. Please kindly review it and leave comments so I can make any necessary corrections. Cheers, Christian 2016-03-06 15:53 GMT+01:00 Oleksandr Byelkin : > Hi, Christian! > > On 06.03.201

Re: [Maria-developers] [GSoC 2016] NO PAD Collations

2016-03-19 Thread Sergei Golubchik
Hi, Daniil! On Mar 16, Даниил Медведев wrote: > Hi, I am Daniil Medvedev from Lomonosov Moscow State University, a 3rd year > student, pursuing my bachelor’s degree in Computer Science. > I was interested in project idea NO PAD Collations, and I wish to > contribute to MariaDB using my skills and

Re: [Maria-developers] [Commits] 1e542ec: MDEV-9382: After updating mariadb server apt-configure fails

2016-03-19 Thread Sergei Golubchik
Hi, Nirbhay! Ok to push. And, please, check whether /etc/default/mariadb needs to be mentioned in the corresponding (mariadb on debian/ubuntu) knowledgebase pages. On Mar 16, Nirbhay Choubey wrote: > revision-id: 1e542ecd8af6f78db767a9b3da016b38d1ec3970 > (mariadb-10.1.12-6-g1e542ec) > parent(s)

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-19 Thread Shubham Barai
Hello Sergei, As you suggested, I tried to develop a prototype just for blobs. So far it is working fine but I am still verifying it for different cases. I will provide you the link to my Github repository shortly. Thanks, Shubham On 16 March 2016 at 17:55, Sergei Golubchik wrot

[Maria-developers] Randomness in TokuDB builds

2016-03-19 Thread Otto Kekäläinen
Hello TokuDB experts! There is some randomness, maybe some unique build id in every TokuDB build that breaks the reproducable builds of it in Debian. Check out: https://tests.reproducible-builds.org/dbd/unstable/amd64/mariadb-10.0_10.0.24-5.diffoscope.html I can't find any mentions of a build id

[Maria-developers] Please review MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool)

2016-03-19 Thread Alexander Barkov
Hello Sergei, Please review a patch for: MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool) Thanks! diff --git a/mysql-test/r/func_hybrid_type.result b/mysql-test/r/func_hybrid_type.result index 95a8a82..29f9f46 100644 --- a/mysql-test/r/func_h

Re: [Maria-developers] [Maria-discuss] Collations, trailing spaces and unique indexes

2016-03-19 Thread Alexander Barkov
Hi Binarus, On 03/16/2016 07:02 PM, Binarus wrote: > Alexander, > > I'd like to continue our conversation from Maria-discuss. Sure. > >>> - I have found my_strnxfrm_unicode in the same file and will need more time >>> to make my opinion of how difficult it will be >>> (I don't know what a we

Re: [Maria-developers] [Maria-discuss] Collations, trailing spaces and unique indexes

2016-03-19 Thread Alexander Barkov
Hi Binarus, On 03/16/2016 06:13 PM, Binarus wrote: >> I just wanted to split the task into these steps: >> >> 1. Default and _bin collations. >>This is what MDEV-9711 is about. >> >> 2. Unicode Collation Algorithm (UCA) based collations >>(e.g. utf8_unicode_nopad_ci) >> >> >> 3. The rest (

Re: [Maria-developers] Aggregate stored functions [MDEV-7773]

2016-03-19 Thread Sergei Golubchik
Hi, Varun! On Mar 19, Varun Gupta wrote: > Hi Sergei, > I have gone through the code you suggested. I have got a good understanding > of what the code actually does. So now I wanted to start writing the > proposal for the idea. Can you tell me what all is needed to written in the > proposal. I am