Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

2015-11-23 Thread Oleksandr Byelkin
Hi, Sergei! On 23.11.15 16:01, Sergei Golubchik wrote: Hi, Sanja! On Nov 20, sa...@mariadb.com wrote: revision-id: 2606b8744404f352b44c85ee23d41b12cddc3470 (mariadb-10.1.8-51-g2606b87) parent(s): 81e4ce5e31ba0753d7acfab28bc6c3d83bfad1c6 committer: Oleksandr Byelkin timestamp: 2015-11-20 18:23

Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

2015-11-23 Thread Sergei Golubchik
Hi, Sanja! On Nov 20, sa...@mariadb.com wrote: > revision-id: 2606b8744404f352b44c85ee23d41b12cddc3470 > (mariadb-10.1.8-51-g2606b87) > parent(s): 81e4ce5e31ba0753d7acfab28bc6c3d83bfad1c6 > committer: Oleksandr Byelkin > timestamp: 2015-11-20 18:23:52 +0100 > message: > > MDEV-9117: Client Serve

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergei Golubchik
Hi, Sergey! On Nov 23, Sergey Vojtovich wrote: > On Mon, Nov 23, 2015 at 10:00:33AM +0100, Sergei Golubchik wrote: > > On Nov 23, Sergey Vojtovich wrote: > > > > Could there be any other fix for P_S autosizing besides moving all its > > dependencies to early options? > No simple solution on my mi

Re: [Maria-developers] Please review a simple patch changing shift/reduce conflicts from 160 to 121

2015-11-23 Thread Sergei Golubchik
Hi, Alexander! On Nov 21, Alexander Barkov wrote: > diff --git a/sql/sql_yacc.yy b/sql/sql_yacc.yy > index bd2adc3..18980b3 100644 > --- a/sql/sql_yacc.yy > +++ b/sql/sql_yacc.yy > @@ -2062,10 +2063,18 @@ opt_end_of_input: > | END_OF_INPUT > ; > > +/* > + binlog_base64_event

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 10:00:33AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 23, Sergey Vojtovich wrote: > > > > > > > > So I didn't break it, it was broken even prior to this patch. In > > > > 5.7 all these options are marked EARLY and are autosized before > > > > PFS a

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergei Golubchik
Hi, Sergey! On Nov 23, Sergey Vojtovich wrote: > > > > > > So I didn't break it, it was broken even prior to this patch. In > > > 5.7 all these options are marked EARLY and are autosized before > > > PFS autosizing. > > > > That's what I was getting at, yes :) > > > > Perhaps you fix should've

Re: [Maria-developers] [Commits] 334323b: MDEV-8542 - The "aria_recover" variable should be renamed "aria_recover_options"

2015-11-23 Thread Sergei Golubchik
Hi, Sergey! On Nov 23, Sergey Vojtovich wrote: > > > diff --git a/storage/maria/ha_maria.cc b/storage/maria/ha_maria.cc > > > index 2e2aa71..064d759 100644 > > > --- a/storage/maria/ha_maria.cc > > > +++ b/storage/maria/ha_maria.cc > > > @@ -256,6 +256,11 @@ static MYSQL_SYSVAR_ULONG(pagecache_fi

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 09:21:44AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 23, Sergey Vojtovich wrote: > > On Mon, Nov 23, 2015 at 08:39:23AM +0100, Sergei Golubchik wrote: > > > On Nov 20, Sergey Vojtovich wrote: > > > > revision-id: a1ab4314d1f88fa954a774c322709822d7b

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergei Golubchik
Hi, Sergey! On Nov 23, Sergey Vojtovich wrote: > On Mon, Nov 23, 2015 at 08:39:23AM +0100, Sergei Golubchik wrote: > > On Nov 20, Sergey Vojtovich wrote: > > > revision-id: a1ab4314d1f88fa954a774c322709822d7b95344 > > > (mariadb-10.1.8-58-ga1ab431) > > > parent(s): cfc135b645db5fa78b9f63b1959ea3f

Re: [Maria-developers] [Commits] 334323b: MDEV-8542 - The "aria_recover" variable should be renamed "aria_recover_options"

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 09:00:45AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 20, Sergey Vojtovich wrote: > > revision-id: 334323bb3e5ca973cf239dce21a7d5510407f230 > > (mariadb-10.1.8-59-g334323b) > > parent(s): a1ab4314d1f88fa954a774c322709822d7b95344 > > committer: Serg

Re: [Maria-developers] [Commits] a1ab431: MDEV-7261 - Backport the default autosized value of

2015-11-23 Thread Sergey Vojtovich
Hi Sergei, On Mon, Nov 23, 2015 at 08:39:23AM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 20, Sergey Vojtovich wrote: > > revision-id: a1ab4314d1f88fa954a774c322709822d7b95344 > > (mariadb-10.1.8-58-ga1ab431) > > parent(s): cfc135b645db5fa78b9f63b1959ea3f2be137a26 > > committer: Serg

Re: [Maria-developers] [Commits] 334323b: MDEV-8542 - The "aria_recover" variable should be renamed "aria_recover_options"

2015-11-23 Thread Sergei Golubchik
Hi, Sergey! On Nov 20, Sergey Vojtovich wrote: > revision-id: 334323bb3e5ca973cf239dce21a7d5510407f230 > (mariadb-10.1.8-59-g334323b) > parent(s): a1ab4314d1f88fa954a774c322709822d7b95344 > committer: Sergey Vojtovich > timestamp: 2015-11-20 17:36:23 +0400 > message: > > MDEV-8542 - The "aria_re