[Maria-developers] MDEV-7950 Item_func::type() takes 0.26% in OLTP RO

Hello Sergey, Please review the next step for MDEV-7950. It does the following: - Adds specific implementations of virtual method get_mm_tree() into Item_func_like, Item_bool_rowready_func2, Item_func_spatial_rel - Gets rid of two virtual calls: select_optimize() and have_rev_func(). - Remo

Re: [Maria-developers] [Commits] 1cd9319: myisam/aria: don't mess with IO_CACHE::file

Hi, Sergey! On May 27, Sergey Vojtovich wrote: > Hi Sergei, > > I'm lost now. In Aria you did change very similar code and kept > init_io_cache(-1) while init_io_cache(info->dfile) was moved down > and replaced with init_io_cache(new_file). This sounds reasonable. > FWICS MyISAM has very same co

Re: [Maria-developers] [Commits] 1cd9319: myisam/aria: don't mess with IO_CACHE::file

Hi, Sergey! On May 27, Sergey Vojtovich wrote: > Hi Sergei, > > my concern was that we do if (!rep_quick) twice in a very short distance. > Anyway, this was just a minor wish. Final decision is up to you. I've already fixed it. Regards, Sergei > > > Why not to move new_data_cache initializatio

Re: [Maria-developers] [Commits] 1cd9319: myisam/aria: don't mess with IO_CACHE::file

Hi Sergei, my concern was that we do if (!rep_quick) twice in a very short distance. Anyway, this was just a minor wish. Final decision is up to you. Regards, Sergey On Wed, May 27, 2015 at 09:02:03PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On May 27, Sergey Vojtovich wrote: > > Hi Ser

Re: [Maria-developers] [Commits] 1cd9319: myisam/aria: don't mess with IO_CACHE::file

Hi, Sergey! On May 27, Sergey Vojtovich wrote: > Hi Sergei, > > looks good. Ok to push, a few minor suggestions inline. > > > diff --git a/storage/maria/ma_check.c b/storage/maria/ma_check.c > > index 8c012d2..d50528e 100644 > > --- a/storage/maria/ma_check.c > > +++ b/storage/maria/ma_check.c >

Re: [Maria-developers] [Commits] 8a595a9: cleanup: LOAD DATA replication support in IO_CACHE

Hi, Sergey! On May 27, Sergey Vojtovich wrote: > On Tue, May 26, 2015 at 03:37:36PM +0200, s...@mariadb.org wrote: > > revision-id: 8a595a9825de286ad073f6f043db4c0dce88a2ea > > parent(s): 3e55ef26d49a900782d2c2bb2c03470faed6ec9d > > committer: Sergei Golubchik > > branch nick: maria > > timestamp:

Re: [Maria-developers] step7 (cleanup) MDEV-7950 Item_func::type() takes 0.26% in OLTP RO

Hi Alexander, ok to push. Thanks, Sergey On Wed, May 27, 2015 at 02:15:06PM +0400, Alexander Barkov wrote: > Hi Sergey, > > On 05/27/2015 11:23 AM, Sergey Vojtovich wrote: > >Hi Alexander, > > > >ok to push. I just wish to study this code a bit before we continue. > > > > Thanks! > > I'm send

Re: [Maria-developers] step7 (cleanup) MDEV-7950 Item_func::type() takes 0.26% in OLTP RO

Hi Sergey, On 05/27/2015 11:23 AM, Sergey Vojtovich wrote: Hi Alexander, ok to push. I just wish to study this code a bit before we continue. Thanks! I'm sending the next step, as agreed on IRC. Thanks, Sergey On Wed, May 27, 2015 at 08:03:57AM +0400, Alexander Barkov wrote: Hi Ser

Re: [Maria-developers] [Commits] 8a595a9: cleanup: LOAD DATA replication support in IO_CACHE

Hi Sergei, a few thoughts/questions inline. On Tue, May 26, 2015 at 03:37:36PM +0200, s...@mariadb.org wrote: > revision-id: 8a595a9825de286ad073f6f043db4c0dce88a2ea > parent(s): 3e55ef26d49a900782d2c2bb2c03470faed6ec9d > committer: Sergei Golubchik > branch nick: maria > timestamp: 2015-05-26 15

Re: [Maria-developers] step7 (cleanup) MDEV-7950 Item_func::type() takes 0.26% in OLTP RO

Hi Alexander, ok to push. I just wish to study this code a bit before we continue. Thanks, Sergey On Wed, May 27, 2015 at 08:03:57AM +0400, Alexander Barkov wrote: > Hi Sergey, > > please review the next step for MDEV-7950. > > It breaks get_mm_parts() into a virtual method in Item, so > - r