Re: [Maria-developers] MDEV-4511 Assertion `scale <= precision' fails on GROUP BY TIMEDIFF with incorrect types

2014-07-23 Thread Alexander Barkov
Hello Sergei, On 07/23/2014 08:50 PM, Sergei Golubchik wrote: Hi, Alexander! I removed find_num_type() and fix_num_length_and_dec() which were hard to track, and for some Items these methods were erroneously called twice. fix_num_length_and_dec() now only exists as a non-virtual method in It

Re: [Maria-developers] MDEV-4511 Assertion `scale <= precision' fails on GROUP BY TIMEDIFF with incorrect types

2014-07-23 Thread Sergei Golubchik
Hi, Alexander! > I removed find_num_type() and fix_num_length_and_dec() which > were hard to track, and for some Items these methods were > erroneously called twice. > > fix_num_length_and_dec() now only exists as a non-virtual method in > Item_sum and Item_udf_func. Why did you keep them? > ==

[Maria-developers] please review mdev-5745 analyze MySQL fix for bug#12368495

2014-07-23 Thread Alexander Barkov
Hi Serg, please review a patch for mdev-5745. Thanks. === modified file 'mysql-test/r/ctype_ucs.result' --- mysql-test/r/ctype_ucs.result 2014-04-28 11:56:31 + +++ mysql-test/r/ctype_ucs.result 2014-07-23 15:08:56 + @@ -4277,5 +4277,38 @@ COALESCE(c1) DROP TABLE t1; # +# MDEV-5745 an

Re: [Maria-developers] [GSoC] Optimize mysql-test-runs - Results of new strategy

2014-07-23 Thread Elena Stepanova
Hi Pablo, On 23.07.2014 15:51, Pablo Estrada wrote: Hi Elena, It's hard to make suggestions without seeing what you currently have, please let me know when you have pushed the code. I just finished cleaning up the code with the new implementation, but in any case, the strategy is exactly th

Re: [Maria-developers] [GSoC] Optimize mysql-test-runs - Results of new strategy

2014-07-23 Thread Pablo Estrada
Hi Elena, It's hard to make suggestions without seeing what you currently have, > please let me know when you have pushed the code. > I just finished cleaning up the code with the new implementation, but in any case, the strategy is exactly the same. I have been looking for advice with the strate