Re: [Maria-developers] Doubt in bin logging for CREATE VIEW - MDEV-6365

2014-06-19 Thread James Briggs
Hi folks. I created this MDEV based on the "bad news" in my previous comment about create view (actually things are worse than I thought, since implementing the missing options will break user applications and affect replication backward compatibility): (MDEV-6365) CREATE VIEW Ignores RESTRICT/

Re: [Maria-developers] Doubt in bin logging for CREATE VIEW

2014-06-19 Thread James Briggs
Hi Sriram. To clarify, the missing view features (union, restrict/cascade, subquery) are major projects outside the scope of your GSoC project, so don't bother spending time on it. It would take months just to test changes that large. Just admire how much is not done even after 20 years. :) Tha

Re: [Maria-developers] Doubt in bin logging for CREATE VIEW

2014-06-19 Thread sriram patil
Hi James, Well, I liked the good news part. :) I will share the test results with you too. And yeah, will look into the create view comments. Thanks, Sriram On Thu, Jun 19, 2014 at 2:48 PM, James Briggs wrote: > Hi Sriram. > > The good news ... nice catch, you earned your GSoC salary! > > Th

Re: [Maria-developers] Doubt in bin logging for CREATE VIEW

2014-06-19 Thread sriram patil
Hi Kristian, I have not yet tried setting up the replication and writing the tests for it. I am reading about it. I will look into setting up the replication and writing test cases for it. Will get back to you when I have the test results ready. Thanks, Sriram On Thu, Jun 19, 2014 at 2:15 PM,

Re: [Maria-developers] Doubt in bin logging for CREATE VIEW

2014-06-19 Thread James Briggs
Hi Sriram. The good news ... nice catch, you earned your GSoC salary! The mysql_register_view() has a dozen different ways to fail: - RAM: my_error(ER_OUT_OF_RESOURCES, MYF(0)); - disk: sql_create_definition_file() - name collision - etc. So the create view statement can definitely fail on the

Re: [Maria-developers] Doubt in bin logging for CREATE VIEW

2014-06-19 Thread Kristian Nielsen
sriram patil writes: > In case of CREATE VIEW (method: mysql_create_view file: sql/sql_view.cc), > while the bin logging is skipped for most of the errors by jumping to "err" > label, it is not skipped in following code snippet (line number: 616) > > res= mysql_register_view(thd, view, mode); >

Re: [Maria-developers] [GSoC] Optimize mysql-test-runs - Setback

2014-06-19 Thread Elena Stepanova
Hi Pablo, I'll send a more detailed reply later, just a couple of quick comments/questions now. To your question I'm just not quite sure what you mean with this example: mysql-test/plugin/example/mtr/t In this example, what is the test name? And what is exactly the path? (./mysql-test/...)

[Maria-developers] Doubt in bin logging for CREATE VIEW

2014-06-19 Thread sriram patil
Hi All, I was checking the behavior of bin logging in various methods. I found out CREATE VIEW differs a little bit than others in bin logging. The query is written into bin log if query is executed successfully. If there is any error the query is not logged. This behavior is observed across all