Re: [Maria-developers] Extra copying in debian/rules causes troubles

2014-02-03 Thread Elena Stepanova
Hi, On 1/31/2014 11:49 AM, Kristian Nielsen wrote: Elena Stepanova writes: ifeq ($(findstring nocheck,$(DEB_BUILD_OPTIONS)),) # Don't know why the following is necessary... cp unittest/unit.pl $(builddir)/unittest/ cp -r mysql-test/* $(builddir)/mysql-test/

Re: [Maria-developers] Rev 3967: MDEV-5597 - Reduce usage of LOCK_open: LOCK_flush

2014-02-03 Thread Sergey Vojtovich
Hi Sergei, On Mon, Feb 03, 2014 at 05:22:50PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Jan 31, Sergey Vojtovich wrote: > > > > > > I'm sorry, I don't understand that at all. > > > > > > Why my_refs is only incremented in debug builds? In non-debug builds you > > > wait until all tabl

Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Alexander Barkov
On 02/03/2014 07:51 PM, Alexander Barkov wrote: Hi Sergei, On 02/03/2014 07:44 PM, Sergei Golubchik wrote: Hi, Alexander! Ah, so at the end you've decided to fix the type, not the assert. Fine. Ok to push. There were two problems actually: - the type - the assert I fixed both. Sorry,

Re: [Maria-developers] MariaDB 5.5.35

2014-02-03 Thread Reindl Harald
Am 03.02.2014 18:08, schrieb ImperialNetwork: > I started to notice this on my error log since i upgraded from 5.5.34 to > 5.5.35: > > 140203 5:26:25 InnoDB: Failed to set O_DIRECT on file > /dev/shm/#sql7e8f6_1a94bc_10.ibd: CREATE: Invalid argument, > continuing anyway > 140203 5:26:25 In

[Maria-developers] MariaDB 5.5.35

2014-02-03 Thread ImperialNetwork
Hi, I started to notice this on my error log since i upgraded from 5.5.34 to 5.5.35: 140203 5:26:25 InnoDB: Failed to set O_DIRECT on file /dev/shm/#sql7e8f6_1a94bc_10.ibd: CREATE: Invalid argument, continuing anyway 140203 5:26:25 InnoDB: O_DIRECT is known to result in 'Invalid argumen

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

2014-02-03 Thread Sergei Golubchik
Hi, Holyfoot! On Jan 31, holyf...@askmonty.org wrote: > revno: 4029 > revision-id: holyf...@askmonty.org-20140131103303-1rx7ielo83f8iahe > parent: holyf...@askmonty.org-20140124020722-dd5twtwlcc8o1xiy > committer: Alexey Botchkov > branch nick: mdev-4856 > timestamp: Fri 2014-01-31 14:33:03 +0400

Re: [Maria-developers] Rev 3967: MDEV-5597 - Reduce usage of LOCK_open: LOCK_flush

2014-02-03 Thread Sergei Golubchik
Hi, Sergey! On Jan 31, Sergey Vojtovich wrote: > > > > I'm sorry, I don't understand that at all. > > > > Why my_refs is only incremented in debug builds? In non-debug builds you > > wait until all tables but one are closed, in debug builds you may keep > > more than one table opened. > See abov

Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Alexander Barkov
Hi Sergei, On 02/03/2014 07:44 PM, Sergei Golubchik wrote: Hi, Alexander! Ah, so at the end you've decided to fix the type, not the assert. Fine. Ok to push. There were two problems actually: - the type - the assert I fixed both. Thanks for review! Btw, the problem with type can be back

Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Sergei Golubchik
Hi, Alexander! Ah, so at the end you've decided to fix the type, not the assert. Fine. Ok to push. On Jan 31, Alexander Barkov wrote: > Hi Sergei, > > Please review a patch for mdev-5450. > > Thanks. > === modified file 'sql/item_timefunc.cc' > --- sql/item_timefunc.cc 2013-12-16 12:02:2

Re: [Maria-developers] MariaDB build dependencies

2014-02-03 Thread Otto Kekäläinen
Thanks Kristian and Colin for quick replies and confirming that dependencies are now optimal. 2014-02-03 Kristian Nielsen : > - procps | hurd > > Seems debian/rules uses /proc to guess a good make -j value, and jemalloc > config.guess tries to guess the CPU from it. Neither is a good argument to

Re: [Maria-developers] MariaDB build dependencies

2014-02-03 Thread Kristian Nielsen
Otto Kekäläinen writes: > Can anybody tell me how in particular these are supposed to affect the > build process? > - libevent-dev I think libevent was at some point used for the thread pool. But that the current thread pool implementation does not use libevent due to performance reason. So it s

Re: [Maria-developers] MariaDB build dependencies

2014-02-03 Thread Colin Charles
On 3 Feb 2014, at 19:39, Otto Kekäläinen wrote: > Can anybody tell me how in particular these are supposed to affect the > build process? > - libevent-dev Old threadpool needed this, so this is an old dependency for MariaDB 5.1-5.3. The 5.5 threadpool doesn't use libevent, so can be safely rem

Re: [Maria-developers] [Commits] Rev 3966: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-03 Thread Jan Lindström
Hi, Hi, Jan! Good point! On Feb 02, Jan Lindström wrote: Hi, In my opinion the test case is not complete, you are missing e.g. ALTER TABLE t2 ADD FOREIGN KEY IF NOT EXISTS (id) REFERENCES t1(id); -- should fail on warning ALTER TABLE t2 ADD FOREIGN KEY

Re: [Maria-developers] [Commits] Rev 3966: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-03 Thread Sergei Golubchik
Hi, Jan! Good point! On Feb 02, Jan Lindström wrote: > Hi, > > In my opinion the test case is not complete, you are missing e.g. > > ALTER TABLE t2 ADD FOREIGN KEY IF NOT EXISTS (id) REFERENCES t1(id); > -- should fail on warning > ALTER TABLE t2 ADD FOREIGN KEY IF NOT EXISTS (id) REFERENCES t1

[Maria-developers] MariaDB build dependencies

2014-02-03 Thread Otto Kekäläinen
Hello, The original MariaDB debian/control in bzr/mariadb-5.5 lists many more dependencies than what are likely to be needed: Build-Depends: libtool (>= 1.4.2-7), procps | hurd, debhelper, file (>= 3.28), libncurses5-dev (>= 5.0-6), perl (>= 5.6.0), libwrap0-dev (>= 7.6-8.3), zlib1g-dev (>= 1:1.