Re: [Maria-developers] Extra copying in debian/rules causes troubles

2014-01-30 Thread Kristian Nielsen
Elena Stepanova writes: > ifeq ($(findstring nocheck,$(DEB_BUILD_OPTIONS)),) > # Don't know why the following is necessary... > cp unittest/unit.pl $(builddir)/unittest/ > cp -r mysql-test/* $(builddir)/mysql-test/ > cp -r sql/share/* $(builddir)/sql/share/ >

Re: [Maria-developers] MariaDB

2014-01-30 Thread Kristian Nielsen
Otto Kekäläinen writes: > 2013-10-01 Otto Kekäläinen : >> 2013/10/1 Ondřej Surý : >>> - it would be better to repack the tarball and kill the upstream debian/ >>> directory to not mess with our packaging >> >> I hope to merge my work upstream and that is easier if my changes are >> a made on top

Re: [Maria-developers] buildbot for non ~maria-captains branches on launchpad

2014-01-30 Thread Kristian Nielsen
Daniel Bartholomew writes: > On Wed, Jan 29, 2014 at 4:01 AM, Alexander Barkov wrote: >> Would it be possible to have buildbot watch branches >> which are on Launchpad, but which are outside of >> the /~maria-captains/ directory? > Sure. It can be configured to do so. Branches are defined using

Re: [Maria-developers] buildbot for non ~maria-captains branches on launchpad

2014-01-30 Thread Daniel Bartholomew
On Wed, Jan 29, 2014 at 4:01 AM, Alexander Barkov wrote: > Would it be possible to have buildbot watch branches > which are on Launchpad, but which are outside of > the /~maria-captains/ directory? > > For example: > > bzr+ssh://bazaar.launchpad.net/~mroonga/maria/mroonga/ > Sure. It can be confi

[Maria-developers] Extra copying in debian/rules causes troubles

2014-01-30 Thread Elena Stepanova
Hi all. There is a fragment in MariaDB debian/dist/*/rules files: ... ifeq ($(findstring nocheck,$(DEB_BUILD_OPTIONS)),) # Don't know why the following is necessary... cp unittest/unit.pl $(builddir)/unittest/ cp -r mysql-test/* $(builddir)/mysql-test/ cp -r sql/s

Re: [Maria-developers] Rev 3966: MDEV-5492 - Reduce usage of LOCK_open: TABLE::in_use

2014-01-30 Thread Sergei Golubchik
Hi, Sergey! On Jan 30, Sergey Vojtovich wrote: > > The assumption above looks a bit risky without any way to enforce it. > > > > Perhaps you could make in_use private (renaming to, say, m_in_use) > > and add an inline getter method TABLE::in_use() that in debug builds > > will assert that your as