Re: [Maria-developers] review of mdev-5095 (executing triggers on slave)

2013-12-03 Thread Oleksandr Byelkin
Hi! 03.12.2013 14:09, Michael Widenius пишет: Hi! Here is the review of mdev-5095 I got the diff from: bzr diff -r3942.. [skip] === modified file 'sql/log_event.cc' -#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION) +#if defined(MYSQL_SERVER) && defined(HAVE_REPLICATION) Was the

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES and INSTALL PLUGIN

2013-12-03 Thread Sergey Vojtovich
Hi Sergei, thanks for your feedback. Comments/questions inline. On Fri, Nov 29, 2013 at 01:57:13PM +0100, Sergei Golubchik wrote: > Hi, Sergey! > > On Nov 27, Sergey Vojtovich wrote: > > Hi Sergei, > > > > I'm afraid I couldn't find easy fix for this deadlock. The question is if it > > is worth

Re: [Maria-developers] Build fail of MariaDB10 with TokuDB enabled

2013-12-03 Thread Leif Walsh
That's a good solution, but I'd still be wary of messing around too much with cmake's RPATH handling. I'll do this in ft-index soon though. Sent from my iPhone > On Dec 3, 2013, at 4:09, Sergei Golubchik wrote: > > Hi, Leif! > >> On Dec 02, Leif Walsh wrote: >> Yep, CMAKE_SKIP_BUILD_RPATH=0

[Maria-developers] review of mdev-5095 (executing triggers on slave)

2013-12-03 Thread Michael Widenius
Hi! Here is the review of mdev-5095 I got the diff from: bzr diff -r3942.. > === modified file 'mysql-test/r/mysqld--help.result' > --- mysql-test/r/mysqld--help.result 2012-10-18 21:33:06 + > +++ mysql-test/r/mysqld--help.result 2013-12-03 10:53:01 + > @@ -747,6 +747,14 @@ > --slav

Re: [Maria-developers] Build fail of MariaDB10 with TokuDB enabled

2013-12-03 Thread Sergei Golubchik
Hi, Leif! On Dec 02, Leif Walsh wrote: > Yep, CMAKE_SKIP_BUILD_RPATH=0 would cause this exact problem. We > should add something to our cmake to warn if that is set to 0. I'd suggest this change: --- storage/tokudb/ft-index/ft/CMakeLists.txt 2013-11-19 14:35:31 + +++ storage/tokudb/ft-ind

[Maria-developers] The "Monty Program AB" vendor check (rpm)

2013-12-03 Thread Oden Eriksson
Hello, I got assigned to look at the rpm packaging and fixed some stuff there, but got stuck at the "Monty Program AB" vendor check in support-files/rpm/server- prein.sh when I wanted to replace the fedora packages with in this case mariadb galera packages. Is this check absolutely nessesary?