Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread Jan Lindström
On 08/19/2013 07:43 PM, MARK CALLAGHAN wrote: Welcome back to the MySQL community Jan. It is good to see SkySQL/MariaDB get more InnoDB expertise. Thanks, I have really enjoyed back on MySQL community. Many things are changed but many are as they were when I was moved to develop other databa

Re: [Maria-developers] [Otto Kekäläinen] Fwd: initial feedback on mar iadb

2013-08-19 Thread Otto Kekäläinen
Hello, 2013/8/20 Michael Widenius : > Otto> plugin/handler_socket/libhsclient/auto_addrinfo.hpp: UNKNOWN > Otto> [Copyright: 2010 DeNA Co.,Ltd.. All rights reserved] > > Otto> => Some files have copyright, but no license info in the header. > > This is the original external files we are using. >

Re: [Maria-developers] MDEV-4911 - KILL command with query id

2013-08-19 Thread Roberto Spadim
maybe we could use (a bit complex, but nice): KILL QUERY_ID IN (SELECT QUERY_ID FROM information_schema.PROCESSLIST WHERE ...) or KILL THREAD_ID IN (SELECT id FROM information_schema.PROCESSLIST WHERE ...) or KILL USER IN (SELECT user FROM information_schema.PROCESSLIST WHERE ...) __

Re: [Maria-developers] More Secure Kill Command

2013-08-19 Thread Roberto Spadim
some things that must be done: 1) the KILL QUERY_ID 1,2,3,4,5 don't work, that's my first patch with sql_yacc.yy maybe i done something wrong since %expect changed +8 numbers 2) the QUERY_ID isn't what i want but well worked hehehehe, maybe change the syntax and make it more beautiful 3) there's

Re: [Maria-developers] [Otto Kekäläinen] Fwd: initial feedback on mar iadb

2013-08-19 Thread Michael Widenius
Hi! > "Otto" == Otto Kekäläinen writes: Otto> 2013/8/18 Sergei Golubchik : >> I'd say, let us treat the copyright headers in source files as the >> authoritative source. Then the debian copyright file should simply say >> exactly what copyright comments do. And there will be no mismatch >>

[Maria-developers] Master slave

2013-08-19 Thread Richard Couture
Is it possible to set up replication in such a manner as to permit writing records to either a master or a slave replica? We want to set up a fail safe replica that can easily take over when our connection to the main replica fails, which, unfortunately, is fairly often. I read a document, some

Re: [Maria-developers] [Otto Kekäläinen] Fwd: initial feedback on mariadb

2013-08-19 Thread Otto Kekäläinen
2013/8/18 Sergei Golubchik : > I'd say, let us treat the copyright headers in source files as the > authoritative source. Then the debian copyright file should simply say > exactly what copyright comments do. And there will be no mismatch > between them. And Monty Program AB and MariaDB Foundation

Re: [Maria-developers] linking an external library

2013-08-19 Thread Vladislav Vaintroub
For embedded, "libsql.a" is not used. Instead, there is libsql_embedded.a, and it is built in libmysqld/CMakeLists.txt So, - If you want your static library to be "merged" into one big libmysqld.a , you need to add it into the LIBS list (see SET(LIBS.) in the CMakeLists.txt). -

Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread Leif Walsh
Hi Mark, TokuMX is a quite different beast than TokuDB. First of all, we already had the experience of integrating our engine into one database product before we started. So many kinks in the TokuKV layer had already been worked out. But more importantly, TokuMX/MongoDB doesn't have a storage e

Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread Peter Laursen
I think PBXT is the best example till now that the SE API actually works. Paul, who created it, also was not grown in MySQL but he managed to figure out good enough to write a complete transactional general-purpose storage engine. It did not quite reach GA level. But I don't think the API is to b

Re: [Maria-developers] linking an external library

2013-08-19 Thread rg
thanks for the tips so far and I can link external libs with e.g. libsql.a but the problem seems to go deeper and the core issue appears to be - linking a static library to say libsql.a breaks generation of libmysqld.a as Linux ar/ranlib can not strip out nested linked libraries. This is somewhat

Re: [Maria-developers] MDEV-4911 - KILL command with query id

2013-08-19 Thread Roberto Spadim
uhmmm i didn't think about the if_idle, it was a mail at maria-discuss that send the patch of google mysql (must check if i'm wrong), and i ported the patch to mariadb code the state='' could be really nice, an very good idea =] 2013/8/19 Eric Bergen : > If you're going to add support for kil

Re: [Maria-developers] MariaDB mutex contention

2013-08-19 Thread Roberto Spadim
hummm some doubts since i never used/write an audit plugin... the lock_plugin of query response time, is a audit plugin + a information schema plugin right? he audit plugin is 'called' at query start and query end? or there's more locks used? when used the locked is used in what case? to lock the U

Re: [Maria-developers] linking an external library

2013-08-19 Thread Vladislav Vaintroub
TARGET_LINK_LIBRARIES({$LIBNAME}) is not a correct syntax It does need target (you link your library to some other library or executable, and this library or executable is called target) TARGET_LINK_LIBRARIES( "${LIBNAME}") should work For example, if you want to link something with mysqld, y

Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread MARK CALLAGHAN
Welcome back to the MySQL community Jan. It is good to see SkySQL/MariaDB get more InnoDB expertise. On Mon, Aug 19, 2013 at 9:32 AM, Jan Lindström wrote: > Hi, > > From experience working on two storage engines on MySQL and being main > developer for the second one, and one "storage engine" o

Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread Jan Lindström
Hi, From experience working on two storage engines on MySQL and being main developer for the second one, and one "storage engine" on big company, I would say MySQL storage engine API has some legacy problems and clearly some missing functionality. e.g. - Some part of the storage engines are

Re: [Maria-developers] linking an external library

2013-08-19 Thread Stewart Smith
rg writes: > I want to link an external library for a language extension. After several > hours of trying to tell cmake (^%$@*&) to pick it up for linking the > library would still not be built with. did you remove the CMakeCache.txt file? CMake is garbage like that. -- Stewart Smith pgpfNIe

Re: [Maria-developers] Can there be a better storage engine API?

2013-08-19 Thread MARK CALLAGHAN
Thanks for your response. On Fri, Aug 16, 2013 at 11:23 AM, Zardosht Kasheff wrote: > I've worked on the TokuDB storage engine for quite a while now. I have > had many experiences over the years, so I guess it's hard to know > where to begin. I guess I will start small, and if the conversation >

Re: [Maria-developers] MariaDB mutex contention

2013-08-19 Thread MARK CALLAGHAN
Is it reasonable for semi-sync to need to lock/unlock LOCK_plugin that frequently? The plugin architecture, like most of the rest of MySQL, wasn't described to people on the outside (like me). On Mon, Aug 19, 2013 at 6:32 AM, Pavel Ivanov wrote: > On Mon, Aug 19, 2013 at 5:17 AM, Roberto Spadim

Re: [Maria-developers] MDEV-4911 - KILL command with query id

2013-08-19 Thread Eric Bergen
If you're going to add support for killing queries in a specific state then why not just add the ability to pass in a state? I can see some use cases for killing queries in a specific state that are more useful than sleep. Off the top of my head: Killing a query while it is waiting for table lock.

Re: [Maria-developers] MariaDB mutex contention

2013-08-19 Thread Roberto Spadim
hi! > Another plugin that should be disabled is QUERY_RESPONSE_TIME. It has quite > some impact on LOCK_plugin: > > -DWITH_QUERY_RESPONSE_TIME=1 > > +-++-+ > | event_name | count_star | sum_timer_wait

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-19 Thread Kristian Nielsen
Pavel Ivanov writes: > I think to fix this bug we should stop using gtid_slave_pos as > indication of the current db state. We should make it possible to Agree. > change gtid_binlog_pos when there's no events in binlogs. And when Ok. Actually, I think we should expose the real binlog state (wh

Re: [Maria-developers] MariaDB mutex contention

2013-08-19 Thread Axel Schwenke
Hi Pavel, Pavel Ivanov wrote: >> From the above I'd say: >> 911 928 - number of executed queries (1x LOCK_tdc per query) >> 1 835 243 / 911 928= ~2 - LOCK_open was acquired 2x per query >> 4 194 896 / 911 928= ~4 - LOCK_plugin was acquired 4x per query > > I wonder how the MariaDB under test was